* [PATCHv2] mv643xx_eth: fix NAPI weight being > 64
@ 2013-05-14 9:54 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2013-05-14 9:54 UTC (permalink / raw)
To: davem, Jason Cooper, buytenh; +Cc: linux ARM, netdev, Andrew Lunn
3.10-rc1 issues the following warning:
netif_napi_add() called with weight 128 on device eth%d
This patch reduce the weight to 64, using NAPI_POLL_WEIGHT.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
v1->v2: Use NAPI_POLL_WEIGHT.
drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index d0afeea..8f63c36 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2745,7 +2745,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
INIT_WORK(&mp->tx_timeout_task, tx_timeout_task);
- netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, 128);
+ netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, NAPI_POLL_WEIGHT);
init_timer(&mp->rx_oom);
mp->rx_oom.data = (unsigned long)mp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCHv2] mv643xx_eth: fix NAPI weight being > 64
@ 2013-05-14 9:54 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2013-05-14 9:54 UTC (permalink / raw)
To: linux-arm-kernel
3.10-rc1 issues the following warning:
netif_napi_add() called with weight 128 on device eth%d
This patch reduce the weight to 64, using NAPI_POLL_WEIGHT.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
v1->v2: Use NAPI_POLL_WEIGHT.
drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index d0afeea..8f63c36 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2745,7 +2745,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
INIT_WORK(&mp->tx_timeout_task, tx_timeout_task);
- netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, 128);
+ netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, NAPI_POLL_WEIGHT);
init_timer(&mp->rx_oom);
mp->rx_oom.data = (unsigned long)mp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCHv2] mv643xx_eth: fix NAPI weight being > 64
2013-05-14 9:54 ` Andrew Lunn
@ 2013-05-14 13:10 ` Eric Dumazet
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2013-05-14 13:10 UTC (permalink / raw)
To: Andrew Lunn; +Cc: davem, Jason Cooper, buytenh, linux ARM, netdev
On Tue, 2013-05-14 at 11:54 +0200, Andrew Lunn wrote:
> 3.10-rc1 issues the following warning:
>
> netif_napi_add() called with weight 128 on device eth%d
>
> This patch reduce the weight to 64, using NAPI_POLL_WEIGHT.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v1->v2: Use NAPI_POLL_WEIGHT.
>
> drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index d0afeea..8f63c36 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -2745,7 +2745,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
>
> INIT_WORK(&mp->tx_timeout_task, tx_timeout_task);
>
> - netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, 128);
> + netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, NAPI_POLL_WEIGHT);
>
> init_timer(&mp->rx_oom);
> mp->rx_oom.data = (unsigned long)mp;
Thanks Andrew.
Note that some other drivers need same change, would you mind sending a
patch for them as well ?
Acked-by: Eric Dumazet <edumazet@google.com>
drivers/s390/net/qeth_core.h:741:#define QETH_NAPI_WEIGHT 128
drivers/infiniband/hw/nes/nes_nic.c:1682: netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
drivers/infiniband/ulp/ipoib/ipoib_main.c:1356: netif_napi_add(dev, &priv->napi, ipoib_poll, 100);
drivers/net/can/janz-ican3.c:1794: netif_napi_add(ndev, &mod->napi, ican3_napi, ICAN3_RX_BUFFERS);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCHv2] mv643xx_eth: fix NAPI weight being > 64
@ 2013-05-14 13:10 ` Eric Dumazet
0 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2013-05-14 13:10 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2013-05-14 at 11:54 +0200, Andrew Lunn wrote:
> 3.10-rc1 issues the following warning:
>
> netif_napi_add() called with weight 128 on device eth%d
>
> This patch reduce the weight to 64, using NAPI_POLL_WEIGHT.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v1->v2: Use NAPI_POLL_WEIGHT.
>
> drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index d0afeea..8f63c36 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -2745,7 +2745,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
>
> INIT_WORK(&mp->tx_timeout_task, tx_timeout_task);
>
> - netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, 128);
> + netif_napi_add(dev, &mp->napi, mv643xx_eth_poll, NAPI_POLL_WEIGHT);
>
> init_timer(&mp->rx_oom);
> mp->rx_oom.data = (unsigned long)mp;
Thanks Andrew.
Note that some other drivers need same change, would you mind sending a
patch for them as well ?
Acked-by: Eric Dumazet <edumazet@google.com>
drivers/s390/net/qeth_core.h:741:#define QETH_NAPI_WEIGHT 128
drivers/infiniband/hw/nes/nes_nic.c:1682: netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
drivers/infiniband/ulp/ipoib/ipoib_main.c:1356: netif_napi_add(dev, &priv->napi, ipoib_poll, 100);
drivers/net/can/janz-ican3.c:1794: netif_napi_add(ndev, &mod->napi, ican3_napi, ICAN3_RX_BUFFERS);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2] mv643xx_eth: fix NAPI weight being > 64
2013-05-14 9:54 ` Andrew Lunn
@ 2013-05-14 18:33 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-05-14 18:33 UTC (permalink / raw)
To: andrew; +Cc: jason, buytenh, linux-arm-kernel, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 14 May 2013 11:54:20 +0200
> 3.10-rc1 issues the following warning:
>
> netif_napi_add() called with weight 128 on device eth%d
>
> This patch reduce the weight to 64, using NAPI_POLL_WEIGHT.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCHv2] mv643xx_eth: fix NAPI weight being > 64
@ 2013-05-14 18:33 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-05-14 18:33 UTC (permalink / raw)
To: linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 14 May 2013 11:54:20 +0200
> 3.10-rc1 issues the following warning:
>
> netif_napi_add() called with weight 128 on device eth%d
>
> This patch reduce the weight to 64, using NAPI_POLL_WEIGHT.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-14 18:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-14 9:54 [PATCHv2] mv643xx_eth: fix NAPI weight being > 64 Andrew Lunn
2013-05-14 9:54 ` Andrew Lunn
2013-05-14 13:10 ` Eric Dumazet
2013-05-14 13:10 ` Eric Dumazet
2013-05-14 18:33 ` David Miller
2013-05-14 18:33 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.