All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: David Teigland <teigland@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	cluster-devel@redhat.com
Subject: Re: [PATCH -next] gfs2: fix DLM depends to fix build errors
Date: Wed, 15 May 2013 11:05:06 +0100	[thread overview]
Message-ID: <1368612306.2732.16.camel@menhir> (raw)
In-Reply-To: <51926E38.7090801@infradead.org>

Hi,

Now in the -nmw tree. Will push to -fixes once it has had a few days to
sit in -nmw/-next. Thanks,

Steve.

On Tue, 2013-05-14 at 10:02 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors by correcting DLM dependencies in GFS2.
> Build errors happen when CONFIG_GFS2_FS_LOCKING_DLM=y and CONFIG_DLM=m:
> 
> fs/built-in.o: In function `gfs2_lock':
> file.c:(.text+0xc7abd): undefined reference to `dlm_posix_get'
> file.c:(.text+0xc7ad0): undefined reference to `dlm_posix_unlock'
> file.c:(.text+0xc7ad9): undefined reference to `dlm_posix_lock'
> fs/built-in.o: In function `gdlm_unmount':
> lock_dlm.c:(.text+0xd6e5b): undefined reference to `dlm_release_lockspace'
> fs/built-in.o: In function `sync_unlock':
> lock_dlm.c:(.text+0xd6e9e): undefined reference to `dlm_unlock'
> fs/built-in.o: In function `sync_lock':
> lock_dlm.c:(.text+0xd6fb6): undefined reference to `dlm_lock'
> fs/built-in.o: In function `gdlm_put_lock':
> lock_dlm.c:(.text+0xd7238): undefined reference to `dlm_unlock'
> fs/built-in.o: In function `gdlm_mount':
> lock_dlm.c:(.text+0xd753e): undefined reference to `dlm_new_lockspace'
> lock_dlm.c:(.text+0xd79d3): undefined reference to `dlm_release_lockspace'
> fs/built-in.o: In function `gdlm_lock':
> lock_dlm.c:(.text+0xd8179): undefined reference to `dlm_lock'
> fs/built-in.o: In function `gdlm_cancel':
> lock_dlm.c:(.text+0xd6b22): undefined reference to `dlm_unlock'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  fs/gfs2/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20130513.orig/fs/gfs2/Kconfig
> +++ linux-next-20130513/fs/gfs2/Kconfig
> @@ -26,7 +26,7 @@ config GFS2_FS
>  config GFS2_FS_LOCKING_DLM
>  	bool "GFS2 DLM locking"
>  	depends on (GFS2_FS!=n) && NET && INET && (IPV6 || IPV6=n) && \
> -		HOTPLUG && DLM && CONFIGFS_FS && SYSFS
> +		HOTPLUG && CONFIGFS_FS && SYSFS && (DLM=y || DLM=GFS2_FS)
>  	help
>  	  Multiple node locking module for GFS2
>  



WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH -next] gfs2: fix DLM depends to fix build errors
Date: Wed, 15 May 2013 11:05:06 +0100	[thread overview]
Message-ID: <1368612306.2732.16.camel@menhir> (raw)
In-Reply-To: <51926E38.7090801@infradead.org>

Hi,

Now in the -nmw tree. Will push to -fixes once it has had a few days to
sit in -nmw/-next. Thanks,

Steve.

On Tue, 2013-05-14 at 10:02 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors by correcting DLM dependencies in GFS2.
> Build errors happen when CONFIG_GFS2_FS_LOCKING_DLM=y and CONFIG_DLM=m:
> 
> fs/built-in.o: In function `gfs2_lock':
> file.c:(.text+0xc7abd): undefined reference to `dlm_posix_get'
> file.c:(.text+0xc7ad0): undefined reference to `dlm_posix_unlock'
> file.c:(.text+0xc7ad9): undefined reference to `dlm_posix_lock'
> fs/built-in.o: In function `gdlm_unmount':
> lock_dlm.c:(.text+0xd6e5b): undefined reference to `dlm_release_lockspace'
> fs/built-in.o: In function `sync_unlock':
> lock_dlm.c:(.text+0xd6e9e): undefined reference to `dlm_unlock'
> fs/built-in.o: In function `sync_lock':
> lock_dlm.c:(.text+0xd6fb6): undefined reference to `dlm_lock'
> fs/built-in.o: In function `gdlm_put_lock':
> lock_dlm.c:(.text+0xd7238): undefined reference to `dlm_unlock'
> fs/built-in.o: In function `gdlm_mount':
> lock_dlm.c:(.text+0xd753e): undefined reference to `dlm_new_lockspace'
> lock_dlm.c:(.text+0xd79d3): undefined reference to `dlm_release_lockspace'
> fs/built-in.o: In function `gdlm_lock':
> lock_dlm.c:(.text+0xd8179): undefined reference to `dlm_lock'
> fs/built-in.o: In function `gdlm_cancel':
> lock_dlm.c:(.text+0xd6b22): undefined reference to `dlm_unlock'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  fs/gfs2/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20130513.orig/fs/gfs2/Kconfig
> +++ linux-next-20130513/fs/gfs2/Kconfig
> @@ -26,7 +26,7 @@ config GFS2_FS
>  config GFS2_FS_LOCKING_DLM
>  	bool "GFS2 DLM locking"
>  	depends on (GFS2_FS!=n) && NET && INET && (IPV6 || IPV6=n) && \
> -		HOTPLUG && DLM && CONFIGFS_FS && SYSFS
> +		HOTPLUG && CONFIGFS_FS && SYSFS && (DLM=y || DLM=GFS2_FS)
>  	help
>  	  Multiple node locking module for GFS2
>  




  reply	other threads:[~2013-05-15 10:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  4:01 linux-next: Tree for May 8 Stephen Rothwell
2013-05-08  4:01 ` Stephen Rothwell
2013-05-08 17:57 ` linux-next: Tree for May 8 (gpio-mcp23s08) Randy Dunlap
2013-05-08 18:04 ` linux-next: Tree for May 8 (dlm) Randy Dunlap
2013-05-08 18:04   ` [Cluster-devel] " Randy Dunlap
2013-05-08 23:47   ` Stephen Rothwell
2013-05-08 23:47     ` [Cluster-devel] " Stephen Rothwell
2013-05-09 16:50     ` David Teigland
2013-05-09 16:50       ` [Cluster-devel] " David Teigland
2013-05-09 17:08       ` Randy Dunlap
2013-05-09 17:08         ` [Cluster-devel] " Randy Dunlap
2013-05-13  9:18         ` Steven Whitehouse
2013-05-13  9:18           ` [Cluster-devel] " Steven Whitehouse
2013-05-13 16:30           ` Randy Dunlap
2013-05-13 16:30             ` [Cluster-devel] " Randy Dunlap
     [not found]             ` <51913F8B.7080201@infradead.org>
     [not found]               ` <51914045.1060900@infradead.org>
2013-05-13 19:45                 ` Randy Dunlap
2013-05-13 19:45                   ` [Cluster-devel] " Randy Dunlap
2013-05-14  8:51                   ` Steven Whitehouse
2013-05-14  8:51                     ` [Cluster-devel] " Steven Whitehouse
2013-05-14 17:02                     ` [PATCH -next] gfs2: fix DLM depends to fix build errors Randy Dunlap
2013-05-14 17:02                       ` [Cluster-devel] " Randy Dunlap
2013-05-15 10:05                       ` Steven Whitehouse [this message]
2013-05-15 10:05                         ` Steven Whitehouse
2013-05-08 18:26 ` [PATCH -next] media/usb: fix kconfig dependencies (aka bool depending on tristate considered harmful) Randy Dunlap
2013-05-08 21:18   ` Yann E. MORIN
2013-05-08 21:28     ` [PATCH -next v2] " Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368612306.2732.16.camel@menhir \
    --to=swhiteho@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.