* [PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()
@ 2013-05-20 17:32 Lars-Peter Clausen
2013-05-21 3:53 ` 김승우
2013-05-21 4:12 ` Inki Dae
0 siblings, 2 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2013-05-20 17:32 UTC (permalink / raw)
To: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie
Cc: dri-devel, linux-kernel, Lars-Peter Clausen
free_irq() expects the same pointer that was passed to request_threaded_irq(),
otherwise the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl>
@r1@
type T;
T devid;
@@
request_threaded_irq(..., devid)
@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)
@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index bbfc384..7e99853 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev)
pm_runtime_disable(dev);
- free_irq(hdata->irq, hdata);
+ free_irq(hdata->irq, ctx);
/* hdmiphy i2c driver */
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()
2013-05-20 17:32 [PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq() Lars-Peter Clausen
@ 2013-05-21 3:53 ` 김승우
2013-05-21 4:12 ` Inki Dae
1 sibling, 0 replies; 3+ messages in thread
From: 김승우 @ 2013-05-21 3:53 UTC (permalink / raw)
To: Lars-Peter Clausen, Inki Dae
Cc: Joonyoung Shim, Kyungmin Park, David Airlie, linux-kernel,
dri-devel, Seung-Woo Kim
Good point,
On 2013년 05월 21일 02:32, Lars-Peter Clausen wrote:
> free_irq() expects the same pointer that was passed to request_threaded_irq(),
> otherwise the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
>
> <smpl>
> @r1@
> type T;
> T devid;
> @@
> request_threaded_irq(..., devid)
>
> @r2@
> type r1.T;
> T devid;
> position p;
> @@
> free_irq@p(..., devid)
>
> @@
> position p != r2.p;
> @@
> *free_irq@p(...)
> </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index bbfc384..7e99853 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev)
>
> pm_runtime_disable(dev);
>
> - free_irq(hdata->irq, hdata);
> + free_irq(hdata->irq, ctx);
>
>
> /* hdmiphy i2c driver */
>
--
Seung-Woo Kim
Samsung Software R&D Center
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()
2013-05-20 17:32 [PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq() Lars-Peter Clausen
2013-05-21 3:53 ` 김승우
@ 2013-05-21 4:12 ` Inki Dae
1 sibling, 0 replies; 3+ messages in thread
From: Inki Dae @ 2013-05-21 4:12 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Seung-Woo Kim, linux-kernel, DRI mailing list, Kyungmin Park
[-- Attachment #1.1: Type: text/plain, Size: 1336 bytes --]
2013/5/21 Lars-Peter Clausen <lars@metafoo.de>
> free_irq() expects the same pointer that was passed to
> request_threaded_irq(),
> otherwise the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
>
> <smpl>
> @r1@
> type T;
> T devid;
> @@
> request_threaded_irq(..., devid)
>
> @r2@
> type r1.T;
> T devid;
> position p;
> @@
> free_irq@p(..., devid)
>
> @@
> position p != r2.p;
> @@
> *free_irq@p(...)
> </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index bbfc384..7e99853 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev)
>
> pm_runtime_disable(dev);
>
> - free_irq(hdata->irq, hdata);
> + free_irq(hdata->irq, ctx);
>
>
It's better to use devm_reqeust_irq instead. Anyway that was a bug. Applied.
Thanks,
Inki Dae
>
> /* hdmiphy i2c driver */
> --
> 1.8.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[-- Attachment #1.2: Type: text/html, Size: 2249 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-21 4:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-20 17:32 [PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq() Lars-Peter Clausen
2013-05-21 3:53 ` 김승우
2013-05-21 4:12 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.