* [U-Boot] [PATCH] cmd_mem: fix cp command
@ 2013-05-21 7:08 Masahiro Yamada
2013-05-24 14:38 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2013-05-21 7:08 UTC (permalink / raw)
To: u-boot
The "cp" command has not worked since
commit 0628ab8ec59834f98ede267edd21ddb8ba0bb57b,
because of the following lines, which set the destination
and the source to the same address.
buf = map_sysmem(addr, bytes);
src = map_sysmem(addr, bytes);
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
common/cmd_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index 64dd76a..6df00b1 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -445,7 +445,7 @@ static int do_mem_cp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#endif
bytes = size * count;
- buf = map_sysmem(addr, bytes);
+ buf = map_sysmem(dest, bytes);
src = map_sysmem(addr, bytes);
while (count-- > 0) {
if (size == 4)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] cmd_mem: fix cp command
2013-05-21 7:08 [U-Boot] [PATCH] cmd_mem: fix cp command Masahiro Yamada
@ 2013-05-24 14:38 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2013-05-24 14:38 UTC (permalink / raw)
To: u-boot
On Tue, May 21, 2013 at 04:08:08PM +0900, Masahiro Yamada wrote:
> The "cp" command has not worked since
> commit 0628ab8ec59834f98ede267edd21ddb8ba0bb57b,
> because of the following lines, which set the destination
> and the source to the same address.
>
> buf = map_sysmem(addr, bytes);
> src = map_sysmem(addr, bytes);
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Tested-by: Tom Rini <trini@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130524/a4fe0e43/attachment.pgp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-24 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-21 7:08 [U-Boot] [PATCH] cmd_mem: fix cp command Masahiro Yamada
2013-05-24 14:38 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.