All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: s390: Module autoloading.
@ 2013-05-27 16:42 Cornelia Huck
  2013-05-27 16:42 ` [PATCH] KVM: s390: Add "devname:kvm" alias Cornelia Huck
  0 siblings, 1 reply; 7+ messages in thread
From: Cornelia Huck @ 2013-05-27 16:42 UTC (permalink / raw)
  To: Marcelo Tossati, Gleb Natapov, Paolo Bonzini
  Cc: Christian Borntraeger, Heiko Carstens, Martin Schwidefsky, KVM,
	linux-s390

This patch enables automatically loading the kvm module when /dev/kvm
is opened, allowing distros to stop loading the module statically.

I think it is trivial enough for 3.10; otherwise, please queue this for 3.11.

Cornelia Huck (1):
  KVM: s390: Add "devname:kvm" alias.

 arch/s390/kvm/kvm-s390.c | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
1.8.1.6

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] KVM: s390: Add "devname:kvm" alias.
  2013-05-27 16:42 [PATCH] KVM: s390: Module autoloading Cornelia Huck
@ 2013-05-27 16:42 ` Cornelia Huck
  2013-05-28  9:00   ` Paolo Bonzini
  2013-05-28 10:44   ` Paolo Bonzini
  0 siblings, 2 replies; 7+ messages in thread
From: Cornelia Huck @ 2013-05-27 16:42 UTC (permalink / raw)
  To: Marcelo Tossati, Gleb Natapov, Paolo Bonzini
  Cc: Christian Borntraeger, Heiko Carstens, Martin Schwidefsky, KVM,
	linux-s390

Providing a "devname:kvm" module alias enables automatic loading of
the kvm module when /dev/kvm is opened.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 arch/s390/kvm/kvm-s390.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 93444c4..3b597e5 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
 
 module_init(kvm_s390_init);
 module_exit(kvm_s390_exit);
+
+/*
+ * Enable autoloading of the kvm module.
+ * Note that we add the module alias here instead of virt/kvm/kvm_main.c
+ * since x86 takes a different approach.
+ */
+#include <linux/miscdevice.h>
+MODULE_ALIAS_MISCDEV(KVM_MINOR);
+MODULE_ALIAS("devname:kvm");
-- 
1.8.1.6

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
  2013-05-27 16:42 ` [PATCH] KVM: s390: Add "devname:kvm" alias Cornelia Huck
@ 2013-05-28  9:00   ` Paolo Bonzini
  2013-05-28  9:07     ` Christian Borntraeger
  2013-05-28 10:44   ` Paolo Bonzini
  1 sibling, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2013-05-28  9:00 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Marcelo Tossati, Gleb Natapov, Christian Borntraeger,
	Heiko Carstens, Martin Schwidefsky, KVM, linux-s390

Il 27/05/2013 18:42, Cornelia Huck ha scritto:
> Providing a "devname:kvm" module alias enables automatic loading of
> the kvm module when /dev/kvm is opened.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 93444c4..3b597e5 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>  
>  module_init(kvm_s390_init);
>  module_exit(kvm_s390_exit);
> +
> +/*
> + * Enable autoloading of the kvm module.
> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
> + * since x86 takes a different approach.
> + */
> +#include <linux/miscdevice.h>
> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
> +MODULE_ALIAS("devname:kvm");
> 

Looks good for 3.10.  Should I take this since Alex is on holiday, or
should I wait for him to come back?

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
  2013-05-28  9:00   ` Paolo Bonzini
@ 2013-05-28  9:07     ` Christian Borntraeger
  0 siblings, 0 replies; 7+ messages in thread
From: Christian Borntraeger @ 2013-05-28  9:07 UTC (permalink / raw)
  To: Paolo Bonzini
  Cc: Cornelia Huck, Marcelo Tossati, Gleb Natapov, Heiko Carstens,
	Martin Schwidefsky, KVM, linux-s390

On 28/05/13 11:00, Paolo Bonzini wrote:

> Looks good for 3.10.  Should I take this since Alex is on holiday, or
> should I wait for him to come back?

let me refer to 
http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/104230
;-)


Christian 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
  2013-05-27 16:42 ` [PATCH] KVM: s390: Add "devname:kvm" alias Cornelia Huck
  2013-05-28  9:00   ` Paolo Bonzini
@ 2013-05-28 10:44   ` Paolo Bonzini
  2013-06-03  7:50       ` Paolo Bonzini
  1 sibling, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2013-05-28 10:44 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Marcelo Tossati, Gleb Natapov, Christian Borntraeger,
	Heiko Carstens, Martin Schwidefsky, KVM, linux-s390

Il 27/05/2013 18:42, Cornelia Huck ha scritto:
> Providing a "devname:kvm" module alias enables automatic loading of
> the kvm module when /dev/kvm is opened.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 93444c4..3b597e5 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>  
>  module_init(kvm_s390_init);
>  module_exit(kvm_s390_exit);
> +
> +/*
> + * Enable autoloading of the kvm module.
> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
> + * since x86 takes a different approach.
> + */
> +#include <linux/miscdevice.h>
> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
> +MODULE_ALIAS("devname:kvm");
> 

Applied, thanks.

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
  2013-05-28 10:44   ` Paolo Bonzini
@ 2013-06-03  7:50       ` Paolo Bonzini
  0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2013-06-03  7:50 UTC (permalink / raw)
  Cc: Cornelia Huck, Marcelo Tossati, Gleb Natapov,
	Christian Borntraeger, Heiko Carstens, Martin Schwidefsky, KVM,
	linux-s390

Il 28/05/2013 12:44, Paolo Bonzini ha scritto:
> Il 27/05/2013 18:42, Cornelia Huck ha scritto:
>> Providing a "devname:kvm" module alias enables automatic loading of
>> the kvm module when /dev/kvm is opened.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 93444c4..3b597e5 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>>  
>>  module_init(kvm_s390_init);
>>  module_exit(kvm_s390_exit);
>> +
>> +/*
>> + * Enable autoloading of the kvm module.
>> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
>> + * since x86 takes a different approach.
>> + */
>> +#include <linux/miscdevice.h>
>> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
>> +MODULE_ALIAS("devname:kvm");
>>
> 
> Applied, thanks.

After discussion with Gleb, we have decided to postpone this patch to
3.11.  Thanks for your understanding. :)

I'll push pending patches to master and queue soon.

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
@ 2013-06-03  7:50       ` Paolo Bonzini
  0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2013-06-03  7:50 UTC (permalink / raw)
  Cc: Cornelia Huck, Marcelo Tossati, Gleb Natapov,
	Christian Borntraeger, Heiko Carstens, Martin Schwidefsky, KVM,
	linux-s390

Il 28/05/2013 12:44, Paolo Bonzini ha scritto:
> Il 27/05/2013 18:42, Cornelia Huck ha scritto:
>> Providing a "devname:kvm" module alias enables automatic loading of
>> the kvm module when /dev/kvm is opened.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 93444c4..3b597e5 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>>  
>>  module_init(kvm_s390_init);
>>  module_exit(kvm_s390_exit);
>> +
>> +/*
>> + * Enable autoloading of the kvm module.
>> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
>> + * since x86 takes a different approach.
>> + */
>> +#include <linux/miscdevice.h>
>> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
>> +MODULE_ALIAS("devname:kvm");
>>
> 
> Applied, thanks.

After discussion with Gleb, we have decided to postpone this patch to
3.11.  Thanks for your understanding. :)

I'll push pending patches to master and queue soon.

Paolo


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-06-03  7:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-27 16:42 [PATCH] KVM: s390: Module autoloading Cornelia Huck
2013-05-27 16:42 ` [PATCH] KVM: s390: Add "devname:kvm" alias Cornelia Huck
2013-05-28  9:00   ` Paolo Bonzini
2013-05-28  9:07     ` Christian Borntraeger
2013-05-28 10:44   ` Paolo Bonzini
2013-06-03  7:50     ` Paolo Bonzini
2013-06-03  7:50       ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.