* [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
@ 2023-01-20 2:03 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-01-20 2:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kunihiko Hayashi, Masami Hiramatsu
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel
The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
socionext,uniphier-soc-glue binding are not patterns, but the full node
name, so move them to 'properties'. As patterns, they were missing start
and end anchors so any prefix or suffix was allowed.
Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
index 4b6852db4747..7845dcfca986 100644
--- a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
@@ -32,7 +32,6 @@ properties:
reg:
maxItems: 1
-patternProperties:
pinctrl:
$ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
@ 2023-01-20 2:03 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-01-20 2:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kunihiko Hayashi, Masami Hiramatsu
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel
The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
socionext,uniphier-soc-glue binding are not patterns, but the full node
name, so move them to 'properties'. As patterns, they were missing start
and end anchors so any prefix or suffix was allowed.
Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
index 4b6852db4747..7845dcfca986 100644
--- a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
@@ -32,7 +32,6 @@ properties:
reg:
maxItems: 1
-patternProperties:
pinctrl:
$ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
2023-01-20 2:03 ` Rob Herring
@ 2023-01-20 4:54 ` Kunihiko Hayashi
-1 siblings, 0 replies; 6+ messages in thread
From: Kunihiko Hayashi @ 2023-01-20 4:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Masami Hiramatsu
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel
Hi Rob,
On 2023/01/20 11:03, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
>
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue
> logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> index 4b6852db4747..7845dcfca986 100644
> ---
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> +++
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> @@ -32,7 +32,6 @@ properties:
> reg:
> maxItems: 1
>
> -patternProperties:
> pinctrl:
> $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
>
Thanks for pointing out.
This is because I forgot to remove it when I changed the child node,
and it should be removed.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
---
Best Regards
Kunihiko Hayashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
@ 2023-01-20 4:54 ` Kunihiko Hayashi
0 siblings, 0 replies; 6+ messages in thread
From: Kunihiko Hayashi @ 2023-01-20 4:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Masami Hiramatsu
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel
Hi Rob,
On 2023/01/20 11:03, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
>
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue
> logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> index 4b6852db4747..7845dcfca986 100644
> ---
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> +++
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> @@ -32,7 +32,6 @@ properties:
> reg:
> maxItems: 1
>
> -patternProperties:
> pinctrl:
> $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
>
Thanks for pointing out.
This is because I forgot to remove it when I changed the child node,
and it should be removed.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
2023-01-20 2:03 ` Rob Herring
@ 2023-01-23 21:24 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-01-23 21:24 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Krzysztof Kozlowski, linux-kernel,
Kunihiko Hayashi, Masami Hiramatsu, devicetree, linux-arm-kernel
On Thu, 19 Jan 2023 20:03:39 -0600, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
>
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
@ 2023-01-23 21:24 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-01-23 21:24 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Krzysztof Kozlowski, linux-kernel,
Kunihiko Hayashi, Masami Hiramatsu, devicetree, linux-arm-kernel
On Thu, 19 Jan 2023 20:03:39 -0600, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
>
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-23 21:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 2:03 [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names Rob Herring
2023-01-20 2:03 ` Rob Herring
2023-01-20 4:54 ` Kunihiko Hayashi
2023-01-20 4:54 ` Kunihiko Hayashi
2023-01-23 21:24 ` Rob Herring
2023-01-23 21:24 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.