* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-30 4:07 Stephen Warren
2013-06-01 6:43 ` Olof Johansson
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Warren @ 2013-05-30 4:07 UTC (permalink / raw)
To: linux-arm-kernel
From: Jongsung Kim <neidhard.kim@lge.com>
Stephen Warren reported the recent commit 78506f2 (add support for
extended FIFO-size of PL011-r1p5) breaks the serial port on the
BCM2835 ARM SoC.
A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
this compatibility issue, this patch overrides the HW UART periphid
register values with the actually compatible UART periphid 0x00241011
(r1p3 or r1p4).
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
This is a fix for v3.10-rc*.
arch/arm/boot/dts/bcm2835.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index f0052dc..1e12aef 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -44,6 +44,7 @@
reg = <0x7e201000 0x1000>;
interrupts = <2 25>;
clock-frequency = <3000000>;
+ arm,primecell-periphid = <0x00241011>;
};
gpio: gpio {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-30 4:07 [PATCH] ARM: bcm2835: override the HW UART periphid Stephen Warren
@ 2013-06-01 6:43 ` Olof Johansson
0 siblings, 0 replies; 17+ messages in thread
From: Olof Johansson @ 2013-06-01 6:43 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 29, 2013 at 10:07:39PM -0600, Stephen Warren wrote:
> From: Jongsung Kim <neidhard.kim@lge.com>
>
> Stephen Warren reported the recent commit 78506f2 (add support for
> extended FIFO-size of PL011-r1p5) breaks the serial port on the
> BCM2835 ARM SoC.
>
> A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
> The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
> FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
> this compatibility issue, this patch overrides the HW UART periphid
> register values with the actually compatible UART periphid 0x00241011
> (r1p3 or r1p4).
>
> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> This is a fix for v3.10-rc*.
Applied.
-Olof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5
@ 2013-05-21 2:12 Stephen Warren
2013-05-21 6:02 ` Jongsung Kim
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Warren @ 2013-05-21 2:12 UTC (permalink / raw)
To: Jongsung Kim
Cc: 'Russell King', 'Greg Kroah-Hartman',
jslaby, linux-serial, linux-kernel, linux-rpi-kernel,
linux-arm-kernel
On 05/20/2013 07:39 PM, Jongsung Kim wrote:
> Jongsung Kim <neidhard.kim@lge.com> :
>> Stephen Warren <swarren@wwwdotorg.org> :
>>>> All r1p5 have 32-byte FIFO depth and it's not configurable. From the
>>>> PL011
>>>> TRM:
>>>>
>>>> r1p4-r1p5 Contains the following differences in functionality:
>>>> * The receive and transmit FIFOs are increased to a depth of
> 32.
>>>> * The Revision field in the UARTPeriphID2 Register on page
> 3-24
>>>> bits [7:4] now reads back as 0x3.
>>>
>>> Well, that certainly isn't true in practice. I think we should revert
>>> this commit until we can determine what the problem is.
>>
>> I asked to the ARM support about this. Waiting for reply..
>
> ARM support said they doesn't have information about BCM2835 UART. Does
> anyone have a communication channel to Broadcom? It takes time for me to
> get contact point to Broadcom.. (I'm trying)
>
> However, ARM support also said:
>
> "If the Broadcom part definitely has 16-deep FIFOs, it cannot be based
> on a PL011 r1p5, so I might guess that Broadcom have just referenced
> the latest version of the documentation on our website, but have actually
> implemented an earlier version."
This all seems rather academic. Irrespective of what the cause of the
problem is, the commit actively breaks a previously working
configuration. I still believe we should revert it first, then find out
exactly what's going on later. Should I sent the revert commit?
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-21 2:12 [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5 Stephen Warren
@ 2013-05-21 6:02 ` Jongsung Kim
0 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-21 6:02 UTC (permalink / raw)
To: swarren, linux, gregkh, jslaby
Cc: linux-serial, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Jongsung Kim
Stephen Warren reported the recent commit 78506f2 (add support for
extended FIFO-size of PL011-r1p5) breaks the serial port on the
BCM2835 ARM SoC.
A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
this compatibility issue, this patch overrides the HW UART periphid
register values with the actually compatible UART periphid 0x00241011
(r1p3 or r1p4).
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
---
arch/arm/boot/dts/bcm2835.dtsi | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index f0052dc..1e12aef 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -44,6 +44,7 @@
reg = <0x7e201000 0x1000>;
interrupts = <2 25>;
clock-frequency = <3000000>;
+ arm,primecell-periphid = <0x00241011>;
};
gpio: gpio {
--
1.7.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-21 6:02 ` Jongsung Kim
0 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-21 6:02 UTC (permalink / raw)
To: linux-arm-kernel
Stephen Warren reported the recent commit 78506f2 (add support for
extended FIFO-size of PL011-r1p5) breaks the serial port on the
BCM2835 ARM SoC.
A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
this compatibility issue, this patch overrides the HW UART periphid
register values with the actually compatible UART periphid 0x00241011
(r1p3 or r1p4).
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
---
arch/arm/boot/dts/bcm2835.dtsi | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index f0052dc..1e12aef 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -44,6 +44,7 @@
reg = <0x7e201000 0x1000>;
interrupts = <2 25>;
clock-frequency = <3000000>;
+ arm,primecell-periphid = <0x00241011>;
};
gpio: gpio {
--
1.7.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* RE: [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-21 6:02 ` Jongsung Kim
(?)
@ 2013-05-21 6:07 ` Jongsung Kim
-1 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-21 6:07 UTC (permalink / raw)
To: swarren, linux, gregkh, jslaby
Cc: linux-serial, linux-rpi-kernel, linux-arm-kernel, linux-kernel
Jongsung Kim <neidhard.kim@lge.com> :
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
b/arch/arm/boot/dts/bcm2835.dtsi
> index f0052dc..1e12aef 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -44,6 +44,7 @@
> reg = <0x7e201000 0x1000>;
> interrupts = <2 25>;
> clock-frequency = <3000000>;
> + arm,primecell-periphid = <0x00241011>;
> };
>
> gpio: gpio {
Stephen, how do you think about this kind of approach instead?
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-21 6:07 ` Jongsung Kim
0 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-21 6:07 UTC (permalink / raw)
To: linux-arm-kernel
Jongsung Kim <neidhard.kim@lge.com> :
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
b/arch/arm/boot/dts/bcm2835.dtsi
> index f0052dc..1e12aef 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -44,6 +44,7 @@
> reg = <0x7e201000 0x1000>;
> interrupts = <2 25>;
> clock-frequency = <3000000>;
> + arm,primecell-periphid = <0x00241011>;
> };
>
> gpio: gpio {
Stephen, how do you think about this kind of approach instead?
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-21 6:07 ` Jongsung Kim
0 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-21 6:07 UTC (permalink / raw)
To: swarren, linux, gregkh, jslaby
Cc: linux-serial, linux-rpi-kernel, linux-arm-kernel, linux-kernel
Jongsung Kim <neidhard.kim@lge.com> :
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
b/arch/arm/boot/dts/bcm2835.dtsi
> index f0052dc..1e12aef 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -44,6 +44,7 @@
> reg = <0x7e201000 0x1000>;
> interrupts = <2 25>;
> clock-frequency = <3000000>;
> + arm,primecell-periphid = <0x00241011>;
> };
>
> gpio: gpio {
Stephen, how do you think about this kind of approach instead?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-21 6:07 ` Jongsung Kim
(?)
@ 2013-05-21 9:00 ` Gordon Hollingworth
-1 siblings, 0 replies; 17+ messages in thread
From: Gordon Hollingworth @ 2013-05-21 9:00 UTC (permalink / raw)
To: Jongsung Kim
Cc: Stephen Warren, Russell King, gregkh, jslaby, linux-arm-kernel,
linux-rpi-kernel, linux-serial, linux-kernel
Have checked with the designer of the UART block and he confirmed that
the 2835 PL011 contains a 16 deep fifo not 32 deep...
Hardware guys, they can never just leave it alone!!!
Gordon
On 21 May 2013 07:07, Jongsung Kim <neidhard.kim@lge.com> wrote:
> Jongsung Kim <neidhard.kim@lge.com> :
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
> b/arch/arm/boot/dts/bcm2835.dtsi
>> index f0052dc..1e12aef 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -44,6 +44,7 @@
>> reg = <0x7e201000 0x1000>;
>> interrupts = <2 25>;
>> clock-frequency = <3000000>;
>> + arm,primecell-periphid = <0x00241011>;
>> };
>>
>> gpio: gpio {
>
> Stephen, how do you think about this kind of approach instead?
>
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-21 9:00 ` Gordon Hollingworth
0 siblings, 0 replies; 17+ messages in thread
From: Gordon Hollingworth @ 2013-05-21 9:00 UTC (permalink / raw)
To: linux-arm-kernel
Have checked with the designer of the UART block and he confirmed that
the 2835 PL011 contains a 16 deep fifo not 32 deep...
Hardware guys, they can never just leave it alone!!!
Gordon
On 21 May 2013 07:07, Jongsung Kim <neidhard.kim@lge.com> wrote:
> Jongsung Kim <neidhard.kim@lge.com> :
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
> b/arch/arm/boot/dts/bcm2835.dtsi
>> index f0052dc..1e12aef 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -44,6 +44,7 @@
>> reg = <0x7e201000 0x1000>;
>> interrupts = <2 25>;
>> clock-frequency = <3000000>;
>> + arm,primecell-periphid = <0x00241011>;
>> };
>>
>> gpio: gpio {
>
> Stephen, how do you think about this kind of approach instead?
>
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-21 9:00 ` Gordon Hollingworth
0 siblings, 0 replies; 17+ messages in thread
From: Gordon Hollingworth @ 2013-05-21 9:00 UTC (permalink / raw)
To: Jongsung Kim
Cc: Stephen Warren, Russell King, gregkh, jslaby, linux-arm-kernel,
linux-rpi-kernel, linux-serial, linux-kernel
Have checked with the designer of the UART block and he confirmed that
the 2835 PL011 contains a 16 deep fifo not 32 deep...
Hardware guys, they can never just leave it alone!!!
Gordon
On 21 May 2013 07:07, Jongsung Kim <neidhard.kim@lge.com> wrote:
> Jongsung Kim <neidhard.kim@lge.com> :
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
> b/arch/arm/boot/dts/bcm2835.dtsi
>> index f0052dc..1e12aef 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -44,6 +44,7 @@
>> reg = <0x7e201000 0x1000>;
>> interrupts = <2 25>;
>> clock-frequency = <3000000>;
>> + arm,primecell-periphid = <0x00241011>;
>> };
>>
>> gpio: gpio {
>
> Stephen, how do you think about this kind of approach instead?
>
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-21 6:02 ` Jongsung Kim
@ 2013-05-21 16:34 ` Stephen Warren
-1 siblings, 0 replies; 17+ messages in thread
From: Stephen Warren @ 2013-05-21 16:34 UTC (permalink / raw)
To: Jongsung Kim
Cc: linux, gregkh, jslaby, linux-serial, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
On 05/21/2013 12:02 AM, Jongsung Kim wrote:
> Stephen Warren reported the recent commit 78506f2 (add support for
> extended FIFO-size of PL011-r1p5) breaks the serial port on the
> BCM2835 ARM SoC.
>
> A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
> The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
> FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
> this compatibility issue, this patch overrides the HW UART periphid
> register values with the actually compatible UART periphid 0x00241011
> (r1p3 or r1p4).
>
> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
I know this will work, because I tried out the same thing last week.
However, I'm not convinced that it's the correct approach. What other
changes exist between r1p4 and r1p5; can you check in the TRM? Faking
the periphid would prevent the driver from taking account of any other
changes. Should we instead add a DT property solely to override the FIFO
size, and then set that for bcm2835? I guess if there really aren't any
other SW-visible changes in r1p5, this approach is fine.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-21 16:34 ` Stephen Warren
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Warren @ 2013-05-21 16:34 UTC (permalink / raw)
To: linux-arm-kernel
On 05/21/2013 12:02 AM, Jongsung Kim wrote:
> Stephen Warren reported the recent commit 78506f2 (add support for
> extended FIFO-size of PL011-r1p5) breaks the serial port on the
> BCM2835 ARM SoC.
>
> A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
> The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
> FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
> this compatibility issue, this patch overrides the HW UART periphid
> register values with the actually compatible UART periphid 0x00241011
> (r1p3 or r1p4).
>
> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
I know this will work, because I tried out the same thing last week.
However, I'm not convinced that it's the correct approach. What other
changes exist between r1p4 and r1p5; can you check in the TRM? Faking
the periphid would prevent the driver from taking account of any other
changes. Should we instead add a DT property solely to override the FIFO
size, and then set that for bcm2835? I guess if there really aren't any
other SW-visible changes in r1p5, this approach is fine.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-21 16:34 ` Stephen Warren
@ 2013-05-22 1:43 ` Stephen Warren
-1 siblings, 0 replies; 17+ messages in thread
From: Stephen Warren @ 2013-05-22 1:43 UTC (permalink / raw)
To: Jongsung Kim
Cc: linux, gregkh, jslaby, linux-serial, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
On 05/21/2013 10:34 AM, Stephen Warren wrote:
> On 05/21/2013 12:02 AM, Jongsung Kim wrote:
>> Stephen Warren reported the recent commit 78506f2 (add support for
>> extended FIFO-size of PL011-r1p5) breaks the serial port on the
>> BCM2835 ARM SoC.
>>
>> A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
>> The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
>> FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
>> this compatibility issue, this patch overrides the HW UART periphid
>> register values with the actually compatible UART periphid 0x00241011
>> (r1p3 or r1p4).
>>
>> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
>> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
>
> I know this will work, because I tried out the same thing last week.
>
> However, I'm not convinced that it's the correct approach. What other
> changes exist between r1p4 and r1p5; can you check in the TRM?
Looking at the TRM, it seems this is really the only change, according
to the changelog in the documentation (although it's a little difficult
to tell since the document seems to have a bunch of changes that
presumably don't affect behaviour). So, faking the periphid seems OK.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Let's apply for 3.10.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-22 1:43 ` Stephen Warren
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Warren @ 2013-05-22 1:43 UTC (permalink / raw)
To: linux-arm-kernel
On 05/21/2013 10:34 AM, Stephen Warren wrote:
> On 05/21/2013 12:02 AM, Jongsung Kim wrote:
>> Stephen Warren reported the recent commit 78506f2 (add support for
>> extended FIFO-size of PL011-r1p5) breaks the serial port on the
>> BCM2835 ARM SoC.
>>
>> A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
>> The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
>> FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
>> this compatibility issue, this patch overrides the HW UART periphid
>> register values with the actually compatible UART periphid 0x00241011
>> (r1p3 or r1p4).
>>
>> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
>> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
>
> I know this will work, because I tried out the same thing last week.
>
> However, I'm not convinced that it's the correct approach. What other
> changes exist between r1p4 and r1p5; can you check in the TRM?
Looking at the TRM, it seems this is really the only change, according
to the changelog in the documentation (although it's a little difficult
to tell since the document seems to have a bunch of changes that
presumably don't affect behaviour). So, faking the periphid seems OK.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Let's apply for 3.10.
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH] ARM: bcm2835: override the HW UART periphid
2013-05-22 1:43 ` Stephen Warren
(?)
@ 2013-05-22 1:52 ` Jongsung Kim
-1 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-22 1:52 UTC (permalink / raw)
To: 'Stephen Warren'
Cc: linux, gregkh, jslaby, linux-serial, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Stephen Warren <swarren@wwwdotorg.org> :
> Looking at the TRM, it seems this is really the only change, according
> to the changelog in the documentation (although it's a little difficult
> to tell since the document seems to have a bunch of changes that
presumably
> don't affect behaviour). So, faking the periphid seems OK.
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>
> Let's apply for 3.10.
Thank you, Stephen.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-22 1:52 ` Jongsung Kim
0 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-22 1:52 UTC (permalink / raw)
To: linux-arm-kernel
Stephen Warren <swarren@wwwdotorg.org> :
> Looking at the TRM, it seems this is really the only change, according
> to the changelog in the documentation (although it's a little difficult
> to tell since the document seems to have a bunch of changes that
presumably
> don't affect behaviour). So, faking the periphid seems OK.
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>
> Let's apply for 3.10.
Thank you, Stephen.
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH] ARM: bcm2835: override the HW UART periphid
@ 2013-05-22 1:52 ` Jongsung Kim
0 siblings, 0 replies; 17+ messages in thread
From: Jongsung Kim @ 2013-05-22 1:52 UTC (permalink / raw)
To: 'Stephen Warren'
Cc: linux, gregkh, jslaby, linux-serial, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Stephen Warren <swarren@wwwdotorg.org> :
> Looking at the TRM, it seems this is really the only change, according
> to the changelog in the documentation (although it's a little difficult
> to tell since the document seems to have a bunch of changes that
presumably
> don't affect behaviour). So, faking the periphid seems OK.
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>
> Let's apply for 3.10.
Thank you, Stephen.
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2013-06-01 6:43 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-30 4:07 [PATCH] ARM: bcm2835: override the HW UART periphid Stephen Warren
2013-06-01 6:43 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2013-05-21 2:12 [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5 Stephen Warren
2013-05-21 6:02 ` [PATCH] ARM: bcm2835: override the HW UART periphid Jongsung Kim
2013-05-21 6:02 ` Jongsung Kim
2013-05-21 6:07 ` Jongsung Kim
2013-05-21 6:07 ` Jongsung Kim
2013-05-21 6:07 ` Jongsung Kim
2013-05-21 9:00 ` Gordon Hollingworth
2013-05-21 9:00 ` Gordon Hollingworth
2013-05-21 9:00 ` Gordon Hollingworth
2013-05-21 16:34 ` Stephen Warren
2013-05-21 16:34 ` Stephen Warren
2013-05-22 1:43 ` Stephen Warren
2013-05-22 1:43 ` Stephen Warren
2013-05-22 1:52 ` Jongsung Kim
2013-05-22 1:52 ` Jongsung Kim
2013-05-22 1:52 ` Jongsung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.