All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kbuild: make sure we clean up DTB temporary files
@ 2013-05-31 10:14 Ian Campbell
  2013-05-31 17:27 ` Stephen Warren
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2013-05-31 10:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ian Campbell, Michal Marek, Stephen Warren, Rob Herring,
	Grant Likely, linux-kbuild

Various temporary files used when building DTB files were not suffixed with
.tmp and therefore were not cleaned up by "make clean".

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Stephen Warren <swarren@nvidia.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 scripts/Makefile.lib |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 51bb3de..d7ec7cf 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -149,7 +149,7 @@ cpp_flags      = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE)     \
 
 ld_flags       = $(LDFLAGS) $(ldflags-y)
 
-dtc_cpp_flags  = -Wp,-MD,$(depfile).pre -nostdinc                        \
+dtc_cpp_flags  = -Wp,-MD,$(depfile).pre.tmp -nostdinc                    \
 		 -I$(srctree)/arch/$(SRCARCH)/boot/dts                   \
 		 -I$(srctree)/arch/$(SRCARCH)/boot/dts/include           \
 		 -undef -D__DTS__
@@ -265,13 +265,13 @@ quiet_cmd_dtc = DTC     $@
 cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
 	$(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 \
 		-i $(srctree)/arch/$(SRCARCH)/boot/dts $(DTC_FLAGS) \
-		-d $(depfile).dtc $(dtc-tmp) ; \
-	cat $(depfile).pre $(depfile).dtc > $(depfile)
+		-d $(depfile).dtc.tmp $(dtc-tmp) ; \
+	cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
 
 $(obj)/%.dtb: $(src)/%.dts FORCE
 	$(call if_changed_dep,dtc)
 
-dtc-tmp = $(subst $(comma),_,$(dot-target).dts)
+dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
 
 # Bzip2
 # ---------------------------------------------------------------------------
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: make sure we clean up DTB temporary files
  2013-05-31 10:14 [PATCH] kbuild: make sure we clean up DTB temporary files Ian Campbell
@ 2013-05-31 17:27 ` Stephen Warren
  2013-05-31 22:21   ` Grant Likely
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2013-05-31 17:27 UTC (permalink / raw)
  To: Ian Campbell
  Cc: linux-kernel, Michal Marek, Stephen Warren, Rob Herring,
	Grant Likely, linux-kbuild

On 05/31/2013 04:14 AM, Ian Campbell wrote:
> Various temporary files used when building DTB files were not suffixed with
> .tmp and therefore were not cleaned up by "make clean".

Reviewed-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: make sure we clean up DTB temporary files
  2013-05-31 17:27 ` Stephen Warren
@ 2013-05-31 22:21   ` Grant Likely
  0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2013-05-31 22:21 UTC (permalink / raw)
  To: Stephen Warren, Ian Campbell
  Cc: linux-kernel, Michal Marek, Stephen Warren, Rob Herring, linux-kbuild

On Fri, 31 May 2013 11:27:16 -0600, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 05/31/2013 04:14 AM, Ian Campbell wrote:
> > Various temporary files used when building DTB files were not suffixed with
> > .tmp and therefore were not cleaned up by "make clean".
> 
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>

Merged, thanks.

g.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-31 22:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-31 10:14 [PATCH] kbuild: make sure we clean up DTB temporary files Ian Campbell
2013-05-31 17:27 ` Stephen Warren
2013-05-31 22:21   ` Grant Likely

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.