Re: [layerindex-web][PATCH 1/2] views.py: Redirect to recipe details for single results

Re: [layerindex-web][PATCH 1/2] views.py: Redirect to recipe details for single results

[Jose Lamego]

[-- Attachment #1.1: Type: text/plain, Size: 1443 bytes --]

Ping.

On 01/18/2017 04:19 PM, Jose Lamego wrote:
> From: Alex Franco <alejandro.franco@linux.intel.com>
> 
> When a recipe search returns only one result, clicking the single
> result at the results view is still required to view further
> recipe detail.
> 
> This change automatically redirects to the recipe details view
> when the recipe search returns a single result.
> 
> [YOCTO #6618]
> 
> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> ---
>  layerindex/views.py | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/layerindex/views.py b/layerindex/views.py
> index 0f73e93..03fadbb 100644
> --- a/layerindex/views.py
> +++ b/layerindex/views.py
> @@ -372,6 +372,14 @@ class RecipeSearchView(ListView):
>      context_object_name = 'recipe_list'
>      paginate_by = 50
>  
> +    def render_to_response(self, context, **kwargs):
> +        if len(self.object_list) == 1:
> +            return HttpResponseRedirect("/layerindex/recipe/%s/"
> +                                        % self.object_list[0].id)
> +        else:
> +            return super(ListView, self).render_to_response(context,
> +                                                            **kwargs)
> +
>      def get_queryset(self):
>          _check_url_branch(self.kwargs)
>          query_string = self.request.GET.get('q', '')
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [layerindex-web][PATCH 2/2] views.py: Consider layer name in recipe search

[Jose Lamego]

[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]

Ping.

On 01/18/2017 04:19 PM, Jose Lamego wrote:
> From: Alex Franco <alejandro.franco@linux.intel.com>
> 
> Recipe search cannot be narrowed to a specific layer, producing
> unnecessary results.
> 
> This change allows including a layers name when searching for recipes to
> narrow the yielded results by adding a layer name to the simplesearch.getquery
> call in the recipe search view.
> 
> [YOCTO #6618]
> 
> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> ---
>  layerindex/views.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/layerindex/views.py b/layerindex/views.py
> index 03fadbb..5db6fbc 100644
> --- a/layerindex/views.py
> +++ b/layerindex/views.py
> @@ -406,7 +406,8 @@ class RecipeSearchView(ListView):
>              qs0 = init_qs.filter(pn=query_string).order_by(*order_by)
>              qs0 = recipes_preferred_count(qs0)
>  
> -            entry_query = simplesearch.get_query(query_string, ['pn'])
> +            entry_query = simplesearch.get_query(
> +                query_string, ['pn', 'layerbranch__layer__name'])
>              qs1 = init_qs.filter(entry_query).order_by(*order_by)
>              qs1 = recipes_preferred_count(qs1)
>  
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [layerindex-web][PATCH 2/2] views.py: Consider layer name in recipe search

[Paul Eggleton]

Hi Jose,

Sorry for the delay in responding to this.

I'd prefer if this were implemented like the recently added "inherits:" where 
we have a special prefix e.g. "layer:" in order to search for things in a 
particular layer. Then it's much clearer as to what's going on.

Cheers,
Paul

On Tuesday, 14 March 2017 9:35:34 AM NZDT Jose Lamego wrote:
> Ping.
> 
> On 01/18/2017 04:19 PM, Jose Lamego wrote:
> > From: Alex Franco <alejandro.franco@linux.intel.com>
> > 
> > Recipe search cannot be narrowed to a specific layer, producing
> > unnecessary results.
> > 
> > This change allows including a layers name when searching for recipes to
> > narrow the yielded results by adding a layer name to the
> > simplesearch.getquery call in the recipe search view.
> > 
> > [YOCTO #6618]
> > 
> > Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> > ---
> > 
> >  layerindex/views.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/layerindex/views.py b/layerindex/views.py
> > index 03fadbb..5db6fbc 100644
> > --- a/layerindex/views.py
> > +++ b/layerindex/views.py
> > 
> > @@ -406,7 +406,8 @@ class RecipeSearchView(ListView):
> >              qs0 = init_qs.filter(pn=query_string).order_by(*order_by)
> >              qs0 = recipes_preferred_count(qs0)
> > 
> > -            entry_query = simplesearch.get_query(query_string, ['pn'])
> > +            entry_query = simplesearch.get_query(
> > +                query_string, ['pn', 'layerbranch__layer__name'])
> > 
> >              qs1 = init_qs.filter(entry_query).order_by(*order_by)
> >              qs1 = recipes_preferred_count(qs1)


-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [layerindex-web][PATCH 1/2] views.py: Redirect to recipe details for single results

[Paul Eggleton]

This should be using a reverse() call instead of a hardcoded URL path suffix. 
However, since that was a trivial fix I've done that and merged it - it'll 
appear in the layer index once we do the next upgrade (fairly soon).

Cheers,
Paul

On Tuesday, 14 March 2017 9:35:16 AM NZDT Jose Lamego wrote:
> Ping.
> 
> On 01/18/2017 04:19 PM, Jose Lamego wrote:
> > From: Alex Franco <alejandro.franco@linux.intel.com>
> > 
> > When a recipe search returns only one result, clicking the single
> > result at the results view is still required to view further
> > recipe detail.
> > 
> > This change automatically redirects to the recipe details view
> > when the recipe search returns a single result.
> > 
> > [YOCTO #6618]
> > 
> > Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> > ---
> > 
> >  layerindex/views.py | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/layerindex/views.py b/layerindex/views.py
> > index 0f73e93..03fadbb 100644
> > --- a/layerindex/views.py
> > +++ b/layerindex/views.py
> > 
> > @@ -372,6 +372,14 @@ class RecipeSearchView(ListView):
> >      context_object_name = 'recipe_list'
> >      paginate_by = 50
> > 
> > +    def render_to_response(self, context, **kwargs):
> > +        if len(self.object_list) == 1:
> > +            return HttpResponseRedirect("/layerindex/recipe/%s/"
> > +                                        % self.object_list[0].id)
> > +        else:
> > +            return super(ListView, self).render_to_response(context,
> > +                                                            **kwargs)
> > +
> > 
> >      def get_queryset(self):
> >          _check_url_branch(self.kwargs)
> >          query_string = self.request.GET.get('q', '')


-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [layerindex-web][PATCH 2/2] views.py: Consider layer name in recipe search

[Jose Lamego]

[-- Attachment #1.1: Type: text/plain, Size: 1941 bytes --]



On 03/13/2017 08:01 PM, Paul Eggleton wrote:
> Hi Jose,
> 
> Sorry for the delay in responding to this.
> 
> I'd prefer if this were implemented like the recently added "inherits:" where 
> we have a special prefix e.g. "layer:" in order to search for things in a 
> particular layer. Then it's much clearer as to what's going on.
> 
I've submitted a new patch following this approach:
https://lists.yoctoproject.org/pipermail/yocto/2017-April/035451.html

> Cheers,
> Paul
> 
> On Tuesday, 14 March 2017 9:35:34 AM NZDT Jose Lamego wrote:
>> Ping.
>>
>> On 01/18/2017 04:19 PM, Jose Lamego wrote:
>>> From: Alex Franco <alejandro.franco@linux.intel.com>
>>>
>>> Recipe search cannot be narrowed to a specific layer, producing
>>> unnecessary results.
>>>
>>> This change allows including a layers name when searching for recipes to
>>> narrow the yielded results by adding a layer name to the
>>> simplesearch.getquery call in the recipe search view.
>>>
>>> [YOCTO #6618]
>>>
>>> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
>>> ---
>>>
>>>  layerindex/views.py | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/layerindex/views.py b/layerindex/views.py
>>> index 03fadbb..5db6fbc 100644
>>> --- a/layerindex/views.py
>>> +++ b/layerindex/views.py
>>>
>>> @@ -406,7 +406,8 @@ class RecipeSearchView(ListView):
>>>              qs0 = init_qs.filter(pn=query_string).order_by(*order_by)
>>>              qs0 = recipes_preferred_count(qs0)
>>>
>>> -            entry_query = simplesearch.get_query(query_string, ['pn'])
>>> +            entry_query = simplesearch.get_query(
>>> +                query_string, ['pn', 'layerbranch__layer__name'])
>>>
>>>              qs1 = init_qs.filter(entry_query).order_by(*order_by)
>>>              qs1 = recipes_preferred_count(qs1)
> 
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [layerindex-web][PATCH 2/2] views.py: Consider layer name in recipe search

[Jose Lamego]

ping

On 01/18/2017 04:31 PM, Jose Lamego wrote:
> From: Alex Franco <alejandro.franco@linux.intel.com>
> 
> Recipe search cannot be narrowed to a specific layer, producing
> unnecessary results.
> 
> This change allows including a layers name when searching for recipes to
> narrow the yielded results by adding a layer name to the simplesearch.getquery
> call in the recipe search view.
> 
> [YOCTO #6618]
> 
> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> ---
>  layerindex/views.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/layerindex/views.py b/layerindex/views.py
> index 03fadbb..5db6fbc 100644
> --- a/layerindex/views.py
> +++ b/layerindex/views.py
> @@ -406,7 +406,8 @@ class RecipeSearchView(ListView):
>              qs0 = init_qs.filter(pn=query_string).order_by(*order_by)
>              qs0 = recipes_preferred_count(qs0)
>  
> -            entry_query = simplesearch.get_query(query_string, ['pn'])
> +            entry_query = simplesearch.get_query(
> +                query_string, ['pn', 'layerbranch__layer__name'])
>              qs1 = init_qs.filter(entry_query).order_by(*order_by)
>              qs1 = recipes_preferred_count(qs1)
>  
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC

[layerindex-web][PATCH 2/2] views.py: Consider layer name in recipe search

[Jose Lamego]

From: Alex Franco <alejandro.franco@linux.intel.com>

Recipe search cannot be narrowed to a specific layer, producing
unnecessary results.

This change allows including a layers name when searching for recipes to
narrow the yielded results by adding a layer name to the simplesearch.getquery
call in the recipe search view.

[YOCTO #6618]

Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
---
 layerindex/views.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/layerindex/views.py b/layerindex/views.py
index 03fadbb..5db6fbc 100644
--- a/layerindex/views.py
+++ b/layerindex/views.py
@@ -406,7 +406,8 @@ class RecipeSearchView(ListView):
             qs0 = init_qs.filter(pn=query_string).order_by(*order_by)
             qs0 = recipes_preferred_count(qs0)
 
-            entry_query = simplesearch.get_query(query_string, ['pn'])
+            entry_query = simplesearch.get_query(
+                query_string, ['pn', 'layerbranch__layer__name'])
             qs1 = init_qs.filter(entry_query).order_by(*order_by)
             qs1 = recipes_preferred_count(qs1)
 
-- 
1.9.1