* [PATCH 5/17] lpfc 8.3.40: Fix inconsistent list removal causes crash.
@ 2013-05-31 21:04 James Smart
0 siblings, 0 replies; only message in thread
From: James Smart @ 2013-05-31 21:04 UTC (permalink / raw)
To: linux-scsi
Fix inconsistent list removal causes crash.
Signed-off-by: James Smart <james.smart@emulex.com>
---
lpfc_sli.c | 18 ------------------
1 file changed, 18 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
--- a/drivers/scsi/lpfc/lpfc_sli.c 2013-05-31 10:58:14.126057545 -0400
+++ b/drivers/scsi/lpfc/lpfc_sli.c 2013-05-31 10:58:16.738057604 -0400
@@ -1011,17 +1011,6 @@ __lpfc_sli_release_iocbq_s4(struct lpfc_
else
sglq = __lpfc_clear_active_sglq(phba, iocbq->sli4_lxritag);
- /*
- ** This should have been removed from the txcmplq before calling
- ** iocbq_release. The normal completion
- ** path should have already done the list_del_init.
- */
- if (unlikely(!list_empty(&iocbq->list))) {
- if (iocbq->iocb_flag & LPFC_IO_ON_TXCMPLQ)
- iocbq->iocb_flag &= ~LPFC_IO_ON_TXCMPLQ;
- list_del_init(&iocbq->list);
- }
-
if (sglq) {
if ((iocbq->iocb_flag & LPFC_EXCHANGE_BUSY) &&
@@ -1070,13 +1059,6 @@ __lpfc_sli_release_iocbq_s3(struct lpfc_
{
size_t start_clean = offsetof(struct lpfc_iocbq, iocb);
- /*
- ** This should have been removed from the txcmplq before calling
- ** iocbq_release. The normal completion
- ** path should have already done the list_del_init.
- */
- if (unlikely(!list_empty(&iocbq->list)))
- list_del_init(&iocbq->list);
/*
* Clean all volatile data fields, preserve iotag and node struct.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-05-31 21:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-31 21:04 [PATCH 5/17] lpfc 8.3.40: Fix inconsistent list removal causes crash James Smart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.