From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
"Jiri Benc" <jbenc@redhat.com>, "David Miller" <davem@redhat.com>,
j.vimal@gmail.com, "Michal Soltys" <soltys@ziu.info>,
"Mike Frysinger" <vapier@gentoo.org>,
"Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>,
"Patrick McHardy" <kaber@trash.net>,
"Jiri Pirko" <jpirko@redhat.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Dave Taht" <dave.taht@gmail.com>,
netdev@vger.kernel.org, bloat@lists.bufferbloat.net,
"Dan Siemon" <dan@coverfire.com>,
"Jim Gettys" <jg@freedesktop.org>,
"Steven Barth" <cyrus@openwrt.org>,
"Felix Fietkau" <nbd@nbd.name>
Subject: Re: Bad shaping at low rates, after commit 56b765b79 (htb: improved accuracy at high rates)
Date: Tue, 04 Jun 2013 09:02:07 -0700 [thread overview]
Message-ID: <1370361727.24311.215.camel@edumazet-glaptop> (raw)
In-Reply-To: <1370361306.24311.214.camel@edumazet-glaptop>
On Tue, 2013-06-04 at 08:55 -0700, Eric Dumazet wrote:
> On Tue, 2013-06-04 at 08:18 -0700, Eric Dumazet wrote:
>
> > I have a good idea of what's going on for htb at low rates, I am testing
> > a fix, thanks for the report !
> >
>
> Yes, we need to convert whole thing to use ns units, instead
> of a mix of 64ns and 1ns units.
>
> Please test the following patch :
Oh well, it works only on 64bit arches.
I'll send a more complete patch, but thats the idea
next prev parent reply other threads:[~2013-06-04 16:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:13 tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-05-29 15:52 ` Eric Dumazet
2013-05-29 22:50 ` Stephen Hemminger
2013-05-29 23:18 ` Eric Dumazet
2013-05-30 9:15 ` Jesper Dangaard Brouer
2013-05-30 9:52 ` [Bloat] " Steinar H. Gunderson
[not found] ` <20130529155034.334092c5-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2013-05-30 0:34 ` Dave Taht
2013-05-30 8:09 ` Jesper Dangaard Brouer
2013-05-30 7:51 ` Jesper Dangaard Brouer
2013-05-30 14:39 ` Eric Dumazet
2013-05-30 15:55 ` Jesper Dangaard Brouer
2013-05-30 16:29 ` Jussi Kivilinna
2013-06-02 21:15 ` Eric Dumazet
2013-06-02 21:33 ` [PATCH iproute2] htb: report overhead attribute Eric Dumazet
2013-06-03 15:45 ` Rick Jones
2013-06-03 15:56 ` Eric Dumazet
2013-06-04 11:11 ` Jesper Dangaard Brouer
2013-06-04 13:58 ` Eric Dumazet
2013-06-04 15:08 ` Jesper Dangaard Brouer
2013-06-03 19:50 ` Jussi Kivilinna
2013-06-07 15:56 ` Stephen Hemminger
2013-06-07 16:00 ` Eric Dumazet
2013-06-04 12:13 ` Bad shaping at low rates, after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-04 15:18 ` Eric Dumazet
2013-06-04 15:55 ` Eric Dumazet
2013-06-04 16:02 ` Eric Dumazet [this message]
2013-06-04 17:11 ` [PATCH] net_sched: htb: do not mix 1ns and 64ns time units Eric Dumazet
2013-06-04 20:21 ` Jesper Dangaard Brouer
[not found] ` <20130604222135.67eedab8-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-04 20:26 ` Dave Taht
2013-06-04 21:02 ` Eric Dumazet
2013-06-04 20:50 ` Eric Dumazet
2013-06-05 0:44 ` David Miller
2013-06-06 13:55 ` RFC: Proposed fix for tc linklayer calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-06 14:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370361727.24311.215.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bloat@lists.bufferbloat.net \
--cc=brouer@redhat.com \
--cc=cyrus@openwrt.org \
--cc=dan@coverfire.com \
--cc=dave.taht@gmail.com \
--cc=davem@redhat.com \
--cc=j.vimal@gmail.com \
--cc=jbenc@redhat.com \
--cc=jg@freedesktop.org \
--cc=jpirko@redhat.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=kaber@trash.net \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=soltys@ziu.info \
--cc=stephen@networkplumber.org \
--cc=toke@toke.dk \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.