All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Add support for ethernet point-to-point connections configured via DHCP
@ 2015-03-05 11:07 Gerd von Egidy
  2015-03-26 13:53 ` Gerd v. Egidy
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Gerd von Egidy @ 2015-03-05 11:07 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

When current dracut receives an ip with netmask of 255.255.255.255 via DHCP,
setting the also supplied default gateway fails (because it is obviously not
within the netmask).

The setup with a netmask of /32 is quite common in colocation datacenters
where you don't want the machines of two different customers to directly talk
to each other. At least two of the biggest colocation providers in Germany
(1&1 and Strato) do it that way. NetworkManager supports this kind of setup
and the dhclient-scripts of several distributions too.

In this patch I have implemented a simple approach very similar to what is
found in Debian. The dhclient-script from Fedora uses a more sophisticated
approach, but that relies on the ipcalc utility which would introduce a
dependency on Fedora-initscripts for dracut.

Signed-off-by: Gerd von Egidy <gerd.von.egidy-XXsH3GEs1jrby3iVrkZq2A@public.gmane.org>
---
 modules.d/40network/dhclient-script.sh | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/modules.d/40network/dhclient-script.sh b/modules.d/40network/dhclient-script.sh
index 50f1985..98352ec 100755
--- a/modules.d/40network/dhclient-script.sh
+++ b/modules.d/40network/dhclient-script.sh
@@ -43,7 +43,13 @@ setup_interface() {
         valid_lft ${lease_time} preferred_lft ${lease_time} \
         dev $netif
 
-    [ -n "$gw" ] && echo ip route replace default via $gw dev $netif > /tmp/net.$netif.gw
+    if [ -n "$gw" ] ; then
+        if [ "$mask" == "255.255.255.255" ] ; then
+            # point-to-point connection => set explicit route to gateway
+            echo ip route add $gw dev $netif > /tmp/net.$netif.gw
+        fi
+        echo ip route replace default via $gw dev $netif >> /tmp/net.$netif.gw
+    fi
 
     [ -n "${search}${domain}" ] && echo "search $search $domain" > /tmp/net.$netif.resolv.conf
     if  [ -n "$namesrv" ] ; then
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add support for ethernet point-to-point connections configured via DHCP
  2015-03-05 11:07 [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd von Egidy
@ 2015-03-26 13:53 ` Gerd v. Egidy
  2015-03-26 15:38 ` [Dracut GitHub] Patchset imported to github Dracut GitHub Import Bot
  2015-06-03  7:35 ` [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd v. Egidy
  2 siblings, 0 replies; 4+ messages in thread
From: Gerd v. Egidy @ 2015-03-26 13:53 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

On Thursday 05 March 2015 12:07:57 Gerd von Egidy wrote:
> When current dracut receives an ip with netmask of 255.255.255.255 via DHCP,
> setting the also supplied default gateway fails (because it is obviously
> not within the netmask).
> 
> The setup with a netmask of /32 is quite common in colocation datacenters
> where you don't want the machines of two different customers to directly
> talk to each other. At least two of the biggest colocation providers in
> Germany (1&1 and Strato) do it that way. NetworkManager supports this kind
> of setup and the dhclient-scripts of several distributions too.
> 
> In this patch I have implemented a simple approach very similar to what is
> found in Debian. The dhclient-script from Fedora uses a more sophisticated
> approach, but that relies on the ipcalc utility which would introduce a
> dependency on Fedora-initscripts for dracut.

any comments or questions about this one?

I'd prefer if this could be merged into dracut upstream.

Kind regards,

Gerd

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Dracut GitHub] Patchset imported to github
  2015-03-05 11:07 [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd von Egidy
  2015-03-26 13:53 ` Gerd v. Egidy
@ 2015-03-26 15:38 ` Dracut GitHub Import Bot
  2015-06-03  7:35 ` [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd v. Egidy
  2 siblings, 0 replies; 4+ messages in thread
From: Dracut GitHub Import Bot @ 2015-03-26 15:38 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

Patchset imported to github.
Pull request:
<https://github.com/haraldh/dracut/compare/master...dracut-mailing-devs:13711492.8HAMuGhYIN@thunder>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add support for ethernet point-to-point connections configured via DHCP
  2015-03-05 11:07 [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd von Egidy
  2015-03-26 13:53 ` Gerd v. Egidy
  2015-03-26 15:38 ` [Dracut GitHub] Patchset imported to github Dracut GitHub Import Bot
@ 2015-06-03  7:35 ` Gerd v. Egidy
  2 siblings, 0 replies; 4+ messages in thread
From: Gerd v. Egidy @ 2015-06-03  7:35 UTC (permalink / raw)
  To: Harald Hoyer; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

Hi Harald,

thank you for merging my patch into master.

Could you also merge it into the RHEL-7 branch so it will be released with 7.2 
or 7.3? Or do you prefer if I open a bug in Bugzilla for that?

It fixes a regression from RHEL 6 which could be network-installed with a dhcp 
configured point-to-point connection.

Thank you.

Kind regards,

Gerd

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-06-03  7:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 11:07 [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd von Egidy
2015-03-26 13:53 ` Gerd v. Egidy
2015-03-26 15:38 ` [Dracut GitHub] Patchset imported to github Dracut GitHub Import Bot
2015-06-03  7:35 ` [PATCH] Add support for ethernet point-to-point connections configured via DHCP Gerd v. Egidy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.