* [PATCH 1/3] ARM: dts: Add MFC clock entry for 5250
@ 2013-06-19 8:52 Arun Kumar K
2013-06-19 8:52 ` [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420 Arun Kumar K
2013-06-19 8:52 ` [PATCH 3/3] ARM: EXYNOS: Add mfc-v7 to memory reserve Arun Kumar K
0 siblings, 2 replies; 8+ messages in thread
From: Arun Kumar K @ 2013-06-19 8:52 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, k.debski, s.nawrocki, arunkk.samsung
The patch adds the MFC clock entry for the 5250 SoC
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d04ab0a..9c6cda6 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -168,6 +168,8 @@
reg = <0x11000000 0x10000>;
interrupts = <0 96 0>;
samsung,power-domain = <&pd_mfc>;
+ clocks = <&clock 266>;
+ clock-names = "mfc";
};
rtc {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420
2013-06-19 8:52 [PATCH 1/3] ARM: dts: Add MFC clock entry for 5250 Arun Kumar K
@ 2013-06-19 8:52 ` Arun Kumar K
2013-06-19 9:24 ` Sachin Kamat
2013-06-19 12:04 ` Chander Kashyap
2013-06-19 8:52 ` [PATCH 3/3] ARM: EXYNOS: Add mfc-v7 to memory reserve Arun Kumar K
1 sibling, 2 replies; 8+ messages in thread
From: Arun Kumar K @ 2013-06-19 8:52 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, k.debski, s.nawrocki, arunkk.samsung
The patch adds MFC nodes for exynos 5420 and for
smdk 5420 board.
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++
arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 08607df..682532c 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -30,4 +30,9 @@
clock-frequency = <24000000>;
};
};
+
+ codec@11000000 {
+ samsung,mfc-r = <0x43000000 0x800000>;
+ samsung,mfc-l = <0x51000000 0x800000>;
+ };
};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 8474d63..cb74356 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -100,4 +100,12 @@
clocks = <&clock 260>, <&clock 131>;
clock-names = "uart", "clk_uart_baud0";
};
+
+ codec@11000000 {
+ compatible = "samsung,mfc-v7";
+ reg = <0x11000000 0x10000>;
+ interrupts = <0 96 0>;
+ clocks = <&clock 401>;
+ clock-names = "mfc";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] ARM: EXYNOS: Add mfc-v7 to memory reserve
2013-06-19 8:52 [PATCH 1/3] ARM: dts: Add MFC clock entry for 5250 Arun Kumar K
2013-06-19 8:52 ` [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420 Arun Kumar K
@ 2013-06-19 8:52 ` Arun Kumar K
1 sibling, 0 replies; 8+ messages in thread
From: Arun Kumar K @ 2013-06-19 8:52 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, k.debski, s.nawrocki, arunkk.samsung
The patch updates the exynos5 memory reservation to reserve
memory for mfc-v7 also in addition to v6.
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
arch/arm/mach-exynos/mach-exynos5-dt.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index f874b77..fdb6181 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -60,13 +60,17 @@ static char const *exynos5_dt_compat[] __initdata = {
static void __init exynos5_reserve(void)
{
#ifdef CONFIG_S5P_DEV_MFC
- struct s5p_mfc_dt_meminfo mfc_mem;
+ int i;
+ struct s5p_mfc_dt_meminfo mfc_mem[] = {
+ {.compatible = "samsung,mfc-v6"},
+ {.compatible = "samsung,mfc-v7"},
+ };
/* Reserve memory for MFC only if it's available */
- mfc_mem.compatible = "samsung,mfc-v6";
- if (of_scan_flat_dt(s5p_fdt_find_mfc_mem, &mfc_mem))
- s5p_mfc_reserve_mem(mfc_mem.roff, mfc_mem.rsize, mfc_mem.loff,
- mfc_mem.lsize);
+ for (i = 0; i < ARRAY_SIZE(mfc_mem); i++)
+ if (of_scan_flat_dt(s5p_fdt_find_mfc_mem, &mfc_mem[i]))
+ s5p_mfc_reserve_mem(mfc_mem[i].roff, mfc_mem[i].rsize,
+ mfc_mem[i].loff, mfc_mem[i].lsize);
#endif
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420
2013-06-19 8:52 ` [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420 Arun Kumar K
@ 2013-06-19 9:24 ` Sachin Kamat
2013-06-19 9:50 ` Tomasz Figa
2013-06-19 10:19 ` Arun Kumar K
2013-06-19 12:04 ` Chander Kashyap
1 sibling, 2 replies; 8+ messages in thread
From: Sachin Kamat @ 2013-06-19 9:24 UTC (permalink / raw)
To: Arun Kumar K
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, k.debski,
s.nawrocki, arunkk.samsung
On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote:
> The patch adds MFC nodes for exynos 5420 and for
> smdk 5420 board.
>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++
> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 08607df..682532c 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -30,4 +30,9 @@
> clock-frequency = <24000000>;
> };
> };
> +
> + codec@11000000 {
> + samsung,mfc-r = <0x43000000 0x800000>;
> + samsung,mfc-l = <0x51000000 0x800000>;
> + };
> };
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 8474d63..cb74356 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -100,4 +100,12 @@
> clocks = <&clock 260>, <&clock 131>;
> clock-names = "uart", "clk_uart_baud0";
> };
> +
> + codec@11000000 {
> + compatible = "samsung,mfc-v7";
> + reg = <0x11000000 0x10000>;
> + interrupts = <0 96 0>;
> + clocks = <&clock 401>;
> + clock-names = "mfc";
> + };
I think it is better if we disable the IPs in dtsi file and enbale
them in respective board files as was followed for Exynos4.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420
2013-06-19 9:24 ` Sachin Kamat
@ 2013-06-19 9:50 ` Tomasz Figa
2013-06-19 10:19 ` Arun Kumar K
1 sibling, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2013-06-19 9:50 UTC (permalink / raw)
To: Sachin Kamat
Cc: Arun Kumar K, linux-samsung-soc, devicetree-discuss, kgene.kim,
k.debski, s.nawrocki, arunkk.samsung
Hi Arun, Sachin,
On Wednesday 19 of June 2013 14:54:01 Sachin Kamat wrote:
> On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote:
> > The patch adds MFC nodes for exynos 5420 and for
> > smdk 5420 board.
> >
> > Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> > ---
> >
> > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++
> > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> > b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 08607df..682532c 100644
> > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> > @@ -30,4 +30,9 @@
> >
> > clock-frequency = <24000000>;
> >
> > };
> >
> > };
> >
> > +
> > + codec@11000000 {
> > + samsung,mfc-r = <0x43000000 0x800000>;
> > + samsung,mfc-l = <0x51000000 0x800000>;
> > + };
> >
> > };
> >
> > diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> > b/arch/arm/boot/dts/exynos5420.dtsi index 8474d63..cb74356 100644
> > --- a/arch/arm/boot/dts/exynos5420.dtsi
> > +++ b/arch/arm/boot/dts/exynos5420.dtsi
> > @@ -100,4 +100,12 @@
> >
> > clocks = <&clock 260>, <&clock 131>;
> > clock-names = "uart", "clk_uart_baud0";
> >
> > };
> >
> > +
> > + codec@11000000 {
> > + compatible = "samsung,mfc-v7";
> > + reg = <0x11000000 0x10000>;
> > + interrupts = <0 96 0>;
> > + clocks = <&clock 401>;
> > + clock-names = "mfc";
> > + };
>
> I think it is better if we disable the IPs in dtsi file and enbale
> them in respective board files as was followed for Exynos4.
+1
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420
2013-06-19 9:24 ` Sachin Kamat
2013-06-19 9:50 ` Tomasz Figa
@ 2013-06-19 10:19 ` Arun Kumar K
1 sibling, 0 replies; 8+ messages in thread
From: Arun Kumar K @ 2013-06-19 10:19 UTC (permalink / raw)
To: Sachin Kamat
Cc: Arun Kumar K, linux-samsung-soc, devicetree-discuss, Kukjin Kim,
Kamil Debski, Sylwester Nawrocki
Hi Sachin,
On Wed, Jun 19, 2013 at 2:54 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote:
>> The patch adds MFC nodes for exynos 5420 and for
>> smdk 5420 board.
>>
>> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++
>> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 08607df..682532c 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -30,4 +30,9 @@
>> clock-frequency = <24000000>;
>> };
>> };
>> +
>> + codec@11000000 {
>> + samsung,mfc-r = <0x43000000 0x800000>;
>> + samsung,mfc-l = <0x51000000 0x800000>;
>> + };
>> };
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 8474d63..cb74356 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -100,4 +100,12 @@
>> clocks = <&clock 260>, <&clock 131>;
>> clock-names = "uart", "clk_uart_baud0";
>> };
>> +
>> + codec@11000000 {
>> + compatible = "samsung,mfc-v7";
>> + reg = <0x11000000 0x10000>;
>> + interrupts = <0 96 0>;
>> + clocks = <&clock 401>;
>> + clock-names = "mfc";
>> + };
>
> I think it is better if we disable the IPs in dtsi file and enbale
> them in respective board files as was followed for Exynos4.
>
Right. Will change it.
Regards
Arun
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420
2013-06-19 8:52 ` [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420 Arun Kumar K
2013-06-19 9:24 ` Sachin Kamat
@ 2013-06-19 12:04 ` Chander Kashyap
2013-06-20 4:30 ` Arun Kumar K
1 sibling, 1 reply; 8+ messages in thread
From: Chander Kashyap @ 2013-06-19 12:04 UTC (permalink / raw)
To: Arun Kumar K
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, k.debski,
s.nawrocki, arunkk.samsung
On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote:
> The patch adds MFC nodes for exynos 5420 and for
> smdk 5420 board.
>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++
> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 08607df..682532c 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -30,4 +30,9 @@
> clock-frequency = <24000000>;
> };
> };
> +
> + codec@11000000 {
> + samsung,mfc-r = <0x43000000 0x800000>;
> + samsung,mfc-l = <0x51000000 0x800000>;
> + };
> };
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 8474d63..cb74356 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -100,4 +100,12 @@
> clocks = <&clock 260>, <&clock 131>;
> clock-names = "uart", "clk_uart_baud0";
> };
> +
> + codec@11000000 {
> + compatible = "samsung,mfc-v7";
> + reg = <0x11000000 0x10000>;
> + interrupts = <0 96 0>;
> + clocks = <&clock 401>;
> + clock-names = "mfc";
> + };
Is it not possible to move the common part of this node to common
exynos5.dtsi? As exynos5250 is using same property values.
> };
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
with warm regards,
Chander Kashyap
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420
2013-06-19 12:04 ` Chander Kashyap
@ 2013-06-20 4:30 ` Arun Kumar K
0 siblings, 0 replies; 8+ messages in thread
From: Arun Kumar K @ 2013-06-20 4:30 UTC (permalink / raw)
To: Chander Kashyap
Cc: Arun Kumar K, linux-samsung-soc, devicetree-discuss, kgene.kim,
Kamil Debski, s.nawrocki
Hi Chander,
On Wed, Jun 19, 2013 at 5:34 PM, Chander Kashyap
<chander.kashyap@linaro.org> wrote:
> On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote:
>> The patch adds MFC nodes for exynos 5420 and for
>> smdk 5420 board.
>>
>> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++
>> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 08607df..682532c 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -30,4 +30,9 @@
>> clock-frequency = <24000000>;
>> };
>> };
>> +
>> + codec@11000000 {
>> + samsung,mfc-r = <0x43000000 0x800000>;
>> + samsung,mfc-l = <0x51000000 0x800000>;
>> + };
>> };
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 8474d63..cb74356 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -100,4 +100,12 @@
>> clocks = <&clock 260>, <&clock 131>;
>> clock-names = "uart", "clk_uart_baud0";
>> };
>> +
>> + codec@11000000 {
>> + compatible = "samsung,mfc-v7";
>> + reg = <0x11000000 0x10000>;
>> + interrupts = <0 96 0>;
>> + clocks = <&clock 401>;
>> + clock-names = "mfc";
>> + };
> Is it not possible to move the common part of this node to common
> exynos5.dtsi? As exynos5250 is using same property values.
Yes that can be done. I have kept it separate as the IP is different
and compatible is also changing. But the reg and interrupt remains same
and hopefully that can be moved to common exynos5.dtsi.
Regards
Arun
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-06-20 4:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-19 8:52 [PATCH 1/3] ARM: dts: Add MFC clock entry for 5250 Arun Kumar K
2013-06-19 8:52 ` [PATCH 2/3] ARM: dts: Add MFC node for exynos 5420 Arun Kumar K
2013-06-19 9:24 ` Sachin Kamat
2013-06-19 9:50 ` Tomasz Figa
2013-06-19 10:19 ` Arun Kumar K
2013-06-19 12:04 ` Chander Kashyap
2013-06-20 4:30 ` Arun Kumar K
2013-06-19 8:52 ` [PATCH 3/3] ARM: EXYNOS: Add mfc-v7 to memory reserve Arun Kumar K
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.