* [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages.
@ 2013-06-20 8:27 Sona Sarmadi
2013-06-20 8:45 ` Richard Purdie
2013-06-24 7:45 ` [PATCH v2] " Sona Sarmadi
0 siblings, 2 replies; 3+ messages in thread
From: Sona Sarmadi @ 2013-06-20 8:27 UTC (permalink / raw)
To: openembedded-core
From: Björn Stenberg <bjst@enea.com>
Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
---
meta/recipes-extended/bash/bash-4.2/run-ptest | 2 +-
meta/recipes-extended/bash/bash.inc | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/bash/bash-4.2/run-ptest b/meta/recipes-extended/bash/bash-4.2/run-ptest
index 66f1eee..8dd3b99 100644
--- a/meta/recipes-extended/bash/bash-4.2/run-ptest
+++ b/meta/recipes-extended/bash/bash-4.2/run-ptest
@@ -1,2 +1,2 @@
#!/bin/sh
-echo Makefile: | make -f Makefile -f - -k THIS_SH=/bin/bash BUILD_DIR=. runtest
+make -k THIS_SH=/bin/bash BUILD_DIR=. runtest
diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
index c619f82..2f4519c 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -40,6 +40,7 @@ do_install_append () {
do_install_ptest () {
make INSTALL_TEST_DIR=${D}${PTEST_PATH}/tests install-test
cp ${B}/Makefile ${D}${PTEST_PATH}
+ sed -i 's/^Makefile/_Makefile/' ${D}${PTEST_PATH}/Makefile
}
pkg_postinst_${PN} () {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages.
2013-06-20 8:27 [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages Sona Sarmadi
@ 2013-06-20 8:45 ` Richard Purdie
2013-06-24 7:45 ` [PATCH v2] " Sona Sarmadi
1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2013-06-20 8:45 UTC (permalink / raw)
To: Sona Sarmadi; +Cc: openembedded-core
On Thu, 2013-06-20 at 10:27 +0200, Sona Sarmadi wrote:
> From: Björn Stenberg <bjst@enea.com>
>
> Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
> ---
> meta/recipes-extended/bash/bash-4.2/run-ptest | 2 +-
> meta/recipes-extended/bash/bash.inc | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
I'm sure this is a good change but could you expand a little on what it
does and why? Which error message is getting fixed? As well as the
summary, commit messages should have a description.
Cheers,
Richard
> diff --git a/meta/recipes-extended/bash/bash-4.2/run-ptest b/meta/recipes-extended/bash/bash-4.2/run-ptest
> index 66f1eee..8dd3b99 100644
> --- a/meta/recipes-extended/bash/bash-4.2/run-ptest
> +++ b/meta/recipes-extended/bash/bash-4.2/run-ptest
> @@ -1,2 +1,2 @@
> #!/bin/sh
> -echo Makefile: | make -f Makefile -f - -k THIS_SH=/bin/bash BUILD_DIR=. runtest
> +make -k THIS_SH=/bin/bash BUILD_DIR=. runtest
> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
> index c619f82..2f4519c 100644
> --- a/meta/recipes-extended/bash/bash.inc
> +++ b/meta/recipes-extended/bash/bash.inc
> @@ -40,6 +40,7 @@ do_install_append () {
> do_install_ptest () {
> make INSTALL_TEST_DIR=${D}${PTEST_PATH}/tests install-test
> cp ${B}/Makefile ${D}${PTEST_PATH}
> + sed -i 's/^Makefile/_Makefile/' ${D}${PTEST_PATH}/Makefile
> }
>
> pkg_postinst_${PN} () {
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] bash ptest: Sed away the Makefile dependency to remove error messages.
2013-06-20 8:27 [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages Sona Sarmadi
2013-06-20 8:45 ` Richard Purdie
@ 2013-06-24 7:45 ` Sona Sarmadi
1 sibling, 0 replies; 3+ messages in thread
From: Sona Sarmadi @ 2013-06-24 7:45 UTC (permalink / raw)
To: openembedded-core
From: Björn Stenberg <bjst@enea.com>
The bash Makefile defines a dependency on itself and tries to run configure,
causing error messages when running ptest on target:
make: *** No rule to make target `configure.in', needed by `configure'.
make: *** No rule to make target `aclocal.m4', needed by `configure'.
make: *** No rule to make target `config.h.in', needed by `configure'.
make: *** No rule to make target `Makefile.in', needed by `Makefile'.
make: Failed to remake makefile `Makefile'.
This patch edits out this dependency in the Makefile installed for ptest,
to get rid of these messages.
Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
---
meta/recipes-extended/bash/bash-4.2/run-ptest | 2 +-
meta/recipes-extended/bash/bash.inc | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/bash/bash-4.2/run-ptest b/meta/recipes-extended/bash/bash-4.2/run-ptest
index 66f1eee..8dd3b99 100644
--- a/meta/recipes-extended/bash/bash-4.2/run-ptest
+++ b/meta/recipes-extended/bash/bash-4.2/run-ptest
@@ -1,2 +1,2 @@
#!/bin/sh
-echo Makefile: | make -f Makefile -f - -k THIS_SH=/bin/bash BUILD_DIR=. runtest
+make -k THIS_SH=/bin/bash BUILD_DIR=. runtest
diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
index c619f82..2f4519c 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -40,6 +40,7 @@ do_install_append () {
do_install_ptest () {
make INSTALL_TEST_DIR=${D}${PTEST_PATH}/tests install-test
cp ${B}/Makefile ${D}${PTEST_PATH}
+ sed -i 's/^Makefile/_Makefile/' ${D}${PTEST_PATH}/Makefile
}
pkg_postinst_${PN} () {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-24 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-20 8:27 [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages Sona Sarmadi
2013-06-20 8:45 ` Richard Purdie
2013-06-24 7:45 ` [PATCH v2] " Sona Sarmadi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.