[PATCH 1/5] iio: fix typos in dac Kconfig

[PATCH 1/5] iio: fix typos in dac Kconfig

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/iio/dac/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index c9c33ce..b9fd4c7 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -15,7 +15,7 @@ config AD5064
 	  module will be called ad5064.
 
 config AD5360
-	tristate "Analog Devices Analog Devices AD5360/61/62/63/70/71/73 DAC driver"
+	tristate "Analog Devices AD5360/61/62/63/70/71/73 DAC driver"
 	depends on SPI
 	help
 	  Say yes here to build support for Analog Devices AD5360, AD5361,
@@ -68,7 +68,7 @@ config AD5446
 	  module will be called ad5446.
 
 config AD5449
-	tristate "Analog Device AD5449 and similar DACs driver"
+	tristate "Analog Devices AD5449 and similar DACs driver"
 	depends on SPI_MASTER
 	help
 	  Say yes here to build support for Analog Devices AD5415, AD5426, AD5429,
@@ -131,7 +131,7 @@ config AD5686
 	  module will be called ad5686.
 
 config AD7303
-	tristate "Analog Devices Analog Devices AD7303 DAC driver"
+	tristate "Analog Devices AD7303 DAC driver"
 	depends on SPI
 	help
 	  Say yes here to build support for Analog Devices AD7303 Digital to Analog
-- 
1.8.3.1

[PATCH 2/5] iio: use I2C_FUNC_SMBUS_I2C_BLOCK macro

[Peter Meerwald]

I do not see why the driver requires I2C_FUNC_SMBUS_I2C_BLOCK,
actually only single bytes or words are transferred

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Ge Gao <ggao@invensense.com>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index fe4c61e..6a1ff80 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -663,8 +663,8 @@ static int inv_mpu_probe(struct i2c_client *client,
 	int result;
 
 	if (!i2c_check_functionality(client->adapter,
-					I2C_FUNC_SMBUS_READ_I2C_BLOCK |
-					I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
+		I2C_FUNC_SMBUS_I2C_BLOCK)) {
+
 		result = -ENOSYS;
 		goto out_no_free;
 	}
-- 
1.8.3.1

[PATCH 3/5] iio: fix Kconfig typos

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/iio/Kconfig          | 2 +-
 drivers/iio/pressure/Kconfig | 8 ++++----
 drivers/iio/trigger/Kconfig  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
index 9af763a..be8e303 100644
--- a/drivers/iio/Kconfig
+++ b/drivers/iio/Kconfig
@@ -23,7 +23,7 @@ if IIO_BUFFER
 config IIO_BUFFER_CB
 boolean "IIO callback buffer used for push in-kernel interfaces"
 	help
-	  Should be selected by any drivers that do-inkernel push
+	  Should be selected by any drivers that do in-kernel push
 	  usage.  That is, those where the data is pushed to the consumer.
 
 config IIO_KFIFO_BUF
diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
index 9427f01..3cba7f5 100644
--- a/drivers/iio/pressure/Kconfig
+++ b/drivers/iio/pressure/Kconfig
@@ -1,18 +1,18 @@
 #
 # Pressure drivers
 #
-menu "Pressure Sensors"
+menu "Pressure sensors"
 
 config IIO_ST_PRESS
-	tristate "STMicroelectronics pressures Driver"
+	tristate "STMicroelectronics pressure sensor Driver"
 	depends on (I2C || SPI_MASTER) && SYSFS
 	select IIO_ST_SENSORS_CORE
 	select IIO_ST_PRESS_I2C if (I2C)
 	select IIO_ST_PRESS_SPI if (SPI_MASTER)
 	select IIO_TRIGGERED_BUFFER if (IIO_BUFFER)
 	help
-	  Say yes here to build support for STMicroelectronics pressures:
-	  LPS331AP.
+	  Say yes here to build support for STMicroelectronics pressure
+	  sensors: LPS331AP.
 
 	  This driver can also be built as a module. If so, will be created
 	  these modules:
diff --git a/drivers/iio/trigger/Kconfig b/drivers/iio/trigger/Kconfig
index 360fd50..0a4a516 100644
--- a/drivers/iio/trigger/Kconfig
+++ b/drivers/iio/trigger/Kconfig
@@ -17,7 +17,7 @@ config IIO_SYSFS_TRIGGER
 	depends on SYSFS
 	select IRQ_WORK
 	help
-	  Provides support for using SYSFS entry as IIO triggers.
+	  Provides support for using SYSFS entries as IIO triggers.
 	  If unsure, say N (but it's safe to say "Y").
 
 	  To compile this driver as a module, choose M here: the
-- 
1.8.3.1

[PATCH 4/5] iio: remove mention of ring buffer from CONFIG_IIO_KFIFO_BUF, CONFIG_IIO_TRIGGER description

[Peter Meerwald]

ring buffers are only in staging, don't mention them here

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/iio/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
index be8e303..524380c 100644
--- a/drivers/iio/Kconfig
+++ b/drivers/iio/Kconfig
@@ -30,8 +30,7 @@ config IIO_KFIFO_BUF
 	select IIO_TRIGGER
 	tristate "Industrial I/O buffering based on kfifo"
 	help
-	  A simple fifo based on kfifo.  Use this if you want a fifo
-	  rather than a ring buffer. Note that this currently provides
+	  A simple fifo based on kfifo.  Note that this currently provides
 	  no buffer events so it is up to userspace to work out how
 	  often to read from the buffer.
 
@@ -49,7 +48,7 @@ config IIO_TRIGGER
 	help
 	  Provides IIO core support for triggers.  Currently these
 	  are used to initialize capture of samples to push into
-	  ring buffers.  The triggers are effectively a 'capture
+	  buffers.  The triggers are effectively a 'capture
 	  data now' interrupt.
 
 config IIO_CONSUMERS_PER_TRIGGER
-- 
1.8.3.1

[PATCH 5/5] iio: reword help text of several IIO_ST drivers

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Denis Ciocca <denis.ciocca@st.com>
---
 drivers/iio/accel/Kconfig        | 4 ++--
 drivers/iio/gyro/Kconfig         | 4 ++--
 drivers/iio/magnetometer/Kconfig | 4 ++--
 drivers/iio/pressure/Kconfig     | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
index 719d83f..a002675 100644
--- a/drivers/iio/accel/Kconfig
+++ b/drivers/iio/accel/Kconfig
@@ -33,8 +33,8 @@ config IIO_ST_ACCEL_3AXIS
 	  LSM303DLH, LSM303DLHC, LIS3DH, LSM330D, LSM330DL, LSM330DLC,
 	  LIS331DLH, LSM303DL, LSM303DLM, LSM330.
 
-	  This driver can also be built as a module. If so, will be created
-	  these modules:
+	  This driver can also be built as a module. If so, these modules
+	  will be created:
 	  - st_accel (core functions for the driver [it is mandatory]);
 	  - st_accel_i2c (necessary for the I2C devices [optional*]);
 	  - st_accel_spi (necessary for the SPI devices [optional*]);
diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
index 8498e9d..1fdcc84 100644
--- a/drivers/iio/gyro/Kconfig
+++ b/drivers/iio/gyro/Kconfig
@@ -58,8 +58,8 @@ config IIO_ST_GYRO_3AXIS
 	  Say yes here to build support for STMicroelectronics gyroscopes:
 	  L3G4200D, LSM330DL, L3GD20, L3GD20H, LSM330DLC, L3G4IS, LSM330.
 
-	  This driver can also be built as a module. If so, will be created
-	  these modules:
+	  This driver can also be built as a module. If so, these modules
+	  will be created:
 	  - st_gyro (core functions for the driver [it is mandatory]);
 	  - st_gyro_i2c (necessary for the I2C devices [optional*]);
 	  - st_gyro_spi (necessary for the SPI devices [optional*]);
diff --git a/drivers/iio/magnetometer/Kconfig b/drivers/iio/magnetometer/Kconfig
index c332b0a..4d55b1b 100644
--- a/drivers/iio/magnetometer/Kconfig
+++ b/drivers/iio/magnetometer/Kconfig
@@ -36,8 +36,8 @@ config IIO_ST_MAGN_3AXIS
 	  Say yes here to build support for STMicroelectronics magnetometers:
 	  LSM303DLHC, LSM303DLM, LIS3MDL.
 
-	  This driver can also be built as a module. If so, will be created
-	  these modules:
+	  This driver can also be built as a module. If so, these modules
+	  will be created:
 	  - st_magn (core functions for the driver [it is mandatory]);
 	  - st_magn_i2c (necessary for the I2C devices [optional*]);
 	  - st_magn_spi (necessary for the SPI devices [optional*]);
diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
index 3cba7f5..56ae890 100644
--- a/drivers/iio/pressure/Kconfig
+++ b/drivers/iio/pressure/Kconfig
@@ -14,8 +14,8 @@ config IIO_ST_PRESS
 	  Say yes here to build support for STMicroelectronics pressure
 	  sensors: LPS331AP.
 
-	  This driver can also be built as a module. If so, will be created
-	  these modules:
+	  This driver can also be built as a module. If so, these modules
+	  will be created:
 	  - st_pressure (core functions for the driver [it is mandatory]);
 	  - st_pressure_i2c (necessary for the I2C devices [optional*]);
 	  - st_pressure_spi (necessary for the SPI devices [optional*]);
-- 
1.8.3.1

Re: [PATCH 1/5] iio: fix typos in dac Kconfig

[Lars-Peter Clausen]

On 06/23/2013 11:28 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Lars-Peter Clausen <lars@metafoo.de>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks

> ---
>  drivers/iio/dac/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index c9c33ce..b9fd4c7 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -15,7 +15,7 @@ config AD5064
>  	  module will be called ad5064.
>  
>  config AD5360
> -	tristate "Analog Devices Analog Devices AD5360/61/62/63/70/71/73 DAC driver"
> +	tristate "Analog Devices AD5360/61/62/63/70/71/73 DAC driver"
>  	depends on SPI
>  	help
>  	  Say yes here to build support for Analog Devices AD5360, AD5361,
> @@ -68,7 +68,7 @@ config AD5446
>  	  module will be called ad5446.
>  
>  config AD5449
> -	tristate "Analog Device AD5449 and similar DACs driver"
> +	tristate "Analog Devices AD5449 and similar DACs driver"
>  	depends on SPI_MASTER
>  	help
>  	  Say yes here to build support for Analog Devices AD5415, AD5426, AD5429,
> @@ -131,7 +131,7 @@ config AD5686
>  	  module will be called ad5686.
>  
>  config AD7303
> -	tristate "Analog Devices Analog Devices AD7303 DAC driver"
> +	tristate "Analog Devices AD7303 DAC driver"
>  	depends on SPI
>  	help
>  	  Say yes here to build support for Analog Devices AD7303 Digital to Analog

Re: [PATCH 5/5] iio: reword help text of several IIO_ST drivers

[Denis CIOCCA]

Acked-by: "Denis Ciocca" <denis.ciocca@st.com>

On Sunday, June 23, 2013 11:28:20 PM Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Denis Ciocca <denis.ciocca@st.com>
> ---
>  drivers/iio/accel/Kconfig        | 4 ++--
>  drivers/iio/gyro/Kconfig         | 4 ++--
>  drivers/iio/magnetometer/Kconfig | 4 ++--
>  drivers/iio/pressure/Kconfig     | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 719d83f..a002675 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -33,8 +33,8 @@ config IIO_ST_ACCEL_3AXIS
>  	  LSM303DLH, LSM303DLHC, LIS3DH, LSM330D, LSM330DL, LSM330DLC,
>  	  LIS331DLH, LSM303DL, LSM303DLM, LSM330.
> 
> -	  This driver can also be built as a module. If so, will be created
> -	  these modules:
> +	  This driver can also be built as a module. If so, these modules
> +	  will be created:
>  	  - st_accel (core functions for the driver [it is mandatory]);
>  	  - st_accel_i2c (necessary for the I2C devices [optional*]);
>  	  - st_accel_spi (necessary for the SPI devices [optional*]);
> diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
> index 8498e9d..1fdcc84 100644
> --- a/drivers/iio/gyro/Kconfig
> +++ b/drivers/iio/gyro/Kconfig
> @@ -58,8 +58,8 @@ config IIO_ST_GYRO_3AXIS
>  	  Say yes here to build support for STMicroelectronics gyroscopes:
>  	  L3G4200D, LSM330DL, L3GD20, L3GD20H, LSM330DLC, L3G4IS, LSM330.
> 
> -	  This driver can also be built as a module. If so, will be created
> -	  these modules:
> +	  This driver can also be built as a module. If so, these modules
> +	  will be created:
>  	  - st_gyro (core functions for the driver [it is mandatory]);
>  	  - st_gyro_i2c (necessary for the I2C devices [optional*]);
>  	  - st_gyro_spi (necessary for the SPI devices [optional*]);
> diff --git a/drivers/iio/magnetometer/Kconfig
> b/drivers/iio/magnetometer/Kconfig index c332b0a..4d55b1b 100644
> --- a/drivers/iio/magnetometer/Kconfig
> +++ b/drivers/iio/magnetometer/Kconfig
> @@ -36,8 +36,8 @@ config IIO_ST_MAGN_3AXIS
>  	  Say yes here to build support for STMicroelectronics magnetometers:
>  	  LSM303DLHC, LSM303DLM, LIS3MDL.
> 
> -	  This driver can also be built as a module. If so, will be created
> -	  these modules:
> +	  This driver can also be built as a module. If so, these modules
> +	  will be created:
>  	  - st_magn (core functions for the driver [it is mandatory]);
>  	  - st_magn_i2c (necessary for the I2C devices [optional*]);
>  	  - st_magn_spi (necessary for the SPI devices [optional*]);
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index 3cba7f5..56ae890 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -14,8 +14,8 @@ config IIO_ST_PRESS
>  	  Say yes here to build support for STMicroelectronics pressure
>  	  sensors: LPS331AP.
> 
> -	  This driver can also be built as a module. If so, will be created
> -	  these modules:
> +	  This driver can also be built as a module. If so, these modules
> +	  will be created:
>  	  - st_pressure (core functions for the driver [it is mandatory]);
>  	  - st_pressure_i2c (necessary for the I2C devices [optional*]);
>  	  - st_pressure_spi (necessary for the SPI devices [optional*]);

Re: [PATCH 1/5] iio: fix typos in dac Kconfig

[Jonathan Cameron]

On 06/24/2013 07:18 AM, Lars-Peter Clausen wrote:
> On 06/23/2013 11:28 PM, Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>> Cc: Lars-Peter Clausen <lars@metafoo.de>
> 
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git

Thanks,
> 
> Thanks
> 
>> ---
>>  drivers/iio/dac/Kconfig | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
>> index c9c33ce..b9fd4c7 100644
>> --- a/drivers/iio/dac/Kconfig
>> +++ b/drivers/iio/dac/Kconfig
>> @@ -15,7 +15,7 @@ config AD5064
>>  	  module will be called ad5064.
>>  
>>  config AD5360
>> -	tristate "Analog Devices Analog Devices AD5360/61/62/63/70/71/73 DAC driver"
>> +	tristate "Analog Devices AD5360/61/62/63/70/71/73 DAC driver"
>>  	depends on SPI
>>  	help
>>  	  Say yes here to build support for Analog Devices AD5360, AD5361,
>> @@ -68,7 +68,7 @@ config AD5446
>>  	  module will be called ad5446.
>>  
>>  config AD5449
>> -	tristate "Analog Device AD5449 and similar DACs driver"
>> +	tristate "Analog Devices AD5449 and similar DACs driver"
>>  	depends on SPI_MASTER
>>  	help
>>  	  Say yes here to build support for Analog Devices AD5415, AD5426, AD5429,
>> @@ -131,7 +131,7 @@ config AD5686
>>  	  module will be called ad5686.
>>  
>>  config AD7303
>> -	tristate "Analog Devices Analog Devices AD7303 DAC driver"
>> +	tristate "Analog Devices AD7303 DAC driver"
>>  	depends on SPI
>>  	help
>>  	  Say yes here to build support for Analog Devices AD7303 Digital to Analog
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 2/5] iio: use I2C_FUNC_SMBUS_I2C_BLOCK macro

[Jonathan Cameron]

On 06/23/2013 10:28 PM, Peter Meerwald wrote:
> I do not see why the driver requires I2C_FUNC_SMBUS_I2C_BLOCK,
> actually only single bytes or words are transferred
Applied as is, but Ge, I would like you to answer Peter's question
about whether this is actually needed at all.

> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Ge Gao <ggao@invensense.com>
> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index fe4c61e..6a1ff80 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -663,8 +663,8 @@ static int inv_mpu_probe(struct i2c_client *client,
>  	int result;
>  
>  	if (!i2c_check_functionality(client->adapter,
> -					I2C_FUNC_SMBUS_READ_I2C_BLOCK |
> -					I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
> +		I2C_FUNC_SMBUS_I2C_BLOCK)) {
> +
>  		result = -ENOSYS;
>  		goto out_no_free;
>  	}
> 

Re: [PATCH 3/5] iio: fix Kconfig typos

[Jonathan Cameron]

On 06/23/2013 10:28 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
applied to togreg branch of iio.git. Thanks!
> ---
>  drivers/iio/Kconfig          | 2 +-
>  drivers/iio/pressure/Kconfig | 8 ++++----
>  drivers/iio/trigger/Kconfig  | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
> index 9af763a..be8e303 100644
> --- a/drivers/iio/Kconfig
> +++ b/drivers/iio/Kconfig
> @@ -23,7 +23,7 @@ if IIO_BUFFER
>  config IIO_BUFFER_CB
>  boolean "IIO callback buffer used for push in-kernel interfaces"
>  	help
> -	  Should be selected by any drivers that do-inkernel push
> +	  Should be selected by any drivers that do in-kernel push
>  	  usage.  That is, those where the data is pushed to the consumer.
>  
>  config IIO_KFIFO_BUF
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index 9427f01..3cba7f5 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -1,18 +1,18 @@
>  #
>  # Pressure drivers
>  #
> -menu "Pressure Sensors"
> +menu "Pressure sensors"
>  
>  config IIO_ST_PRESS
> -	tristate "STMicroelectronics pressures Driver"
> +	tristate "STMicroelectronics pressure sensor Driver"
>  	depends on (I2C || SPI_MASTER) && SYSFS
>  	select IIO_ST_SENSORS_CORE
>  	select IIO_ST_PRESS_I2C if (I2C)
>  	select IIO_ST_PRESS_SPI if (SPI_MASTER)
>  	select IIO_TRIGGERED_BUFFER if (IIO_BUFFER)
>  	help
> -	  Say yes here to build support for STMicroelectronics pressures:
> -	  LPS331AP.
> +	  Say yes here to build support for STMicroelectronics pressure
> +	  sensors: LPS331AP.
>  
>  	  This driver can also be built as a module. If so, will be created
>  	  these modules:
> diff --git a/drivers/iio/trigger/Kconfig b/drivers/iio/trigger/Kconfig
> index 360fd50..0a4a516 100644
> --- a/drivers/iio/trigger/Kconfig
> +++ b/drivers/iio/trigger/Kconfig
> @@ -17,7 +17,7 @@ config IIO_SYSFS_TRIGGER
>  	depends on SYSFS
>  	select IRQ_WORK
>  	help
> -	  Provides support for using SYSFS entry as IIO triggers.
> +	  Provides support for using SYSFS entries as IIO triggers.
>  	  If unsure, say N (but it's safe to say "Y").
>  
>  	  To compile this driver as a module, choose M here: the
> 

Re: [PATCH 4/5] iio: remove mention of ring buffer from CONFIG_IIO_KFIFO_BUF, CONFIG_IIO_TRIGGER description

[Jonathan Cameron]

On 06/23/2013 10:28 PM, Peter Meerwald wrote:
> ring buffers are only in staging, don't mention them here
Actually they aren't there either any more.  Long killed off.

> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Applied to the togreg branch of iio.git

Thanks
> ---
>  drivers/iio/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
> index be8e303..524380c 100644
> --- a/drivers/iio/Kconfig
> +++ b/drivers/iio/Kconfig
> @@ -30,8 +30,7 @@ config IIO_KFIFO_BUF
>  	select IIO_TRIGGER
>  	tristate "Industrial I/O buffering based on kfifo"
>  	help
> -	  A simple fifo based on kfifo.  Use this if you want a fifo
> -	  rather than a ring buffer. Note that this currently provides
> +	  A simple fifo based on kfifo.  Note that this currently provides
>  	  no buffer events so it is up to userspace to work out how
>  	  often to read from the buffer.
>  
> @@ -49,7 +48,7 @@ config IIO_TRIGGER
>  	help
>  	  Provides IIO core support for triggers.  Currently these
>  	  are used to initialize capture of samples to push into
> -	  ring buffers.  The triggers are effectively a 'capture
> +	  buffers.  The triggers are effectively a 'capture
>  	  data now' interrupt.
>  
>  config IIO_CONSUMERS_PER_TRIGGER
> 

Re: [PATCH 5/5] iio: reword help text of several IIO_ST drivers

[Jonathan Cameron]

On 06/24/2013 07:30 AM, Denis CIOCCA wrote:
> Acked-by: "Denis Ciocca" <denis.ciocca@st.com>
Applied to the togreg branch of iio.git

Thanks
> 
> On Sunday, June 23, 2013 11:28:20 PM Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>> Cc: Denis Ciocca <denis.ciocca@st.com>
>> ---
>>  drivers/iio/accel/Kconfig        | 4 ++--
>>  drivers/iio/gyro/Kconfig         | 4 ++--
>>  drivers/iio/magnetometer/Kconfig | 4 ++--
>>  drivers/iio/pressure/Kconfig     | 4 ++--
>>  4 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
>> index 719d83f..a002675 100644
>> --- a/drivers/iio/accel/Kconfig
>> +++ b/drivers/iio/accel/Kconfig
>> @@ -33,8 +33,8 @@ config IIO_ST_ACCEL_3AXIS
>>  	  LSM303DLH, LSM303DLHC, LIS3DH, LSM330D, LSM330DL, LSM330DLC,
>>  	  LIS331DLH, LSM303DL, LSM303DLM, LSM330.
>>
>> -	  This driver can also be built as a module. If so, will be created
>> -	  these modules:
>> +	  This driver can also be built as a module. If so, these modules
>> +	  will be created:
>>  	  - st_accel (core functions for the driver [it is mandatory]);
>>  	  - st_accel_i2c (necessary for the I2C devices [optional*]);
>>  	  - st_accel_spi (necessary for the SPI devices [optional*]);
>> diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
>> index 8498e9d..1fdcc84 100644
>> --- a/drivers/iio/gyro/Kconfig
>> +++ b/drivers/iio/gyro/Kconfig
>> @@ -58,8 +58,8 @@ config IIO_ST_GYRO_3AXIS
>>  	  Say yes here to build support for STMicroelectronics gyroscopes:
>>  	  L3G4200D, LSM330DL, L3GD20, L3GD20H, LSM330DLC, L3G4IS, LSM330.
>>
>> -	  This driver can also be built as a module. If so, will be created
>> -	  these modules:
>> +	  This driver can also be built as a module. If so, these modules
>> +	  will be created:
>>  	  - st_gyro (core functions for the driver [it is mandatory]);
>>  	  - st_gyro_i2c (necessary for the I2C devices [optional*]);
>>  	  - st_gyro_spi (necessary for the SPI devices [optional*]);
>> diff --git a/drivers/iio/magnetometer/Kconfig
>> b/drivers/iio/magnetometer/Kconfig index c332b0a..4d55b1b 100644
>> --- a/drivers/iio/magnetometer/Kconfig
>> +++ b/drivers/iio/magnetometer/Kconfig
>> @@ -36,8 +36,8 @@ config IIO_ST_MAGN_3AXIS
>>  	  Say yes here to build support for STMicroelectronics magnetometers:
>>  	  LSM303DLHC, LSM303DLM, LIS3MDL.
>>
>> -	  This driver can also be built as a module. If so, will be created
>> -	  these modules:
>> +	  This driver can also be built as a module. If so, these modules
>> +	  will be created:
>>  	  - st_magn (core functions for the driver [it is mandatory]);
>>  	  - st_magn_i2c (necessary for the I2C devices [optional*]);
>>  	  - st_magn_spi (necessary for the SPI devices [optional*]);
>> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
>> index 3cba7f5..56ae890 100644
>> --- a/drivers/iio/pressure/Kconfig
>> +++ b/drivers/iio/pressure/Kconfig
>> @@ -14,8 +14,8 @@ config IIO_ST_PRESS
>>  	  Say yes here to build support for STMicroelectronics pressure
>>  	  sensors: LPS331AP.
>>
>> -	  This driver can also be built as a module. If so, will be created
>> -	  these modules:
>> +	  This driver can also be built as a module. If so, these modules
>> +	  will be created:
>>  	  - st_pressure (core functions for the driver [it is mandatory]);
>>  	  - st_pressure_i2c (necessary for the I2C devices [optional*]);
>>  	  - st_pressure_spi (necessary for the SPI devices [optional*]);--
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 2/5] iio: use I2C_FUNC_SMBUS_I2C_BLOCK macro

[Ge Gao]

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

It is not needed now. But it is actually needed in my "full" version of
drivers, which involves of using DMP.  But I think it can be removed now.
Do you need a patch for this? Thank you very much.

Ge

On Saturday, June 29, 2013, Jonathan Cameron wrote:

> On 06/23/2013 10:28 PM, Peter Meerwald wrote:
> > I do not see why the driver requires I2C_FUNC_SMBUS_I2C_BLOCK,
> > actually only single bytes or words are transferred
> Applied as is, but Ge, I would like you to answer Peter's question
> about whether this is actually needed at all.
>
> >
> > Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> > Cc: Ge Gao <ggao@invensense.com>
> > ---
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > index fe4c61e..6a1ff80 100644
> > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > @@ -663,8 +663,8 @@ static int inv_mpu_probe(struct i2c_client *client,
> >       int result;
> >
> >       if (!i2c_check_functionality(client->adapter,
> > -                                     I2C_FUNC_SMBUS_READ_I2C_BLOCK |
> > -                                     I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
> > +             I2C_FUNC_SMBUS_I2C_BLOCK)) {
> > +
> >               result = -ENOSYS;
> >               goto out_no_free;
> >       }
> >
>

[-- Attachment #2: Type: text/html, Size: 1919 bytes --]