All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Add GLSDK Branding
@ 2013-06-26 11:03 Siddharth Heroor
  2013-06-26 11:03 ` [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info Siddharth Heroor
  2013-06-26 11:03 ` [PATCH 2/2] glsdk: add the initial GLSDK branding policy Siddharth Heroor
  0 siblings, 2 replies; 12+ messages in thread
From: Siddharth Heroor @ 2013-06-26 11:03 UTC (permalink / raw)
  To: meta-arago

* Create a GLSDK Branding configuration.
* Overlay arago information for the GLSDK kernel

Siddharth Heroor (2):
  meta-arago-distro: recipes-kernel - Overlay Arago info
  glsdk: add the initial GLSDK branding policy

 .../conf/distro/include/branding-glsdk.inc         |    4 ++++
 .../linux/linux-ti-glsdk_3.8.bbappend              |   17 +++++++++++++++++
 2 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-distro/conf/distro/include/branding-glsdk.inc
 create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-glsdk_3.8.bbappend

cc: Mrinmayee Hingolikar <mrinmayee@ti.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info
  2013-06-26 11:03 [PATCH 0/2] Add GLSDK Branding Siddharth Heroor
@ 2013-06-26 11:03 ` Siddharth Heroor
  2013-06-26 12:53   ` Maupin, Chase
  2013-06-26 11:03 ` [PATCH 2/2] glsdk: add the initial GLSDK branding policy Siddharth Heroor
  1 sibling, 1 reply; 12+ messages in thread
From: Siddharth Heroor @ 2013-06-26 11:03 UTC (permalink / raw)
  To: meta-arago

* Based of linux-ti-staging_3.8.bbappend

Signed-off-by: Siddharth Heroor <heroor@ti.com>
cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
---
 .../linux/linux-ti-glsdk_3.8.bbappend              |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-glsdk_3.8.bbappend

diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-glsdk_3.8.bbappend b/meta-arago-distro/recipes-kernel/linux/linux-ti-glsdk_3.8.bbappend
new file mode 100644
index 0000000..b20c63a
--- /dev/null
+++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-glsdk_3.8.bbappend
@@ -0,0 +1,17 @@
+MACHINE_KERNEL_PR_append = "-arago6"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
+
+require copy-defconfig.inc
+
+KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV', True).partition('+')[2][0:7]}"
+
+# The below lines are overlayed until the LOCALVERSION change is merged into
+# the oe-core danny branch. Update: not coming to danny, keep until dylan.
+kernel_do_configure_prepend() {
+    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
+    then
+        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
+        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
+    fi
+}
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 11:03 [PATCH 0/2] Add GLSDK Branding Siddharth Heroor
  2013-06-26 11:03 ` [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info Siddharth Heroor
@ 2013-06-26 11:03 ` Siddharth Heroor
  2013-06-26 15:31   ` Cooper Jr., Franklin
  1 sibling, 1 reply; 12+ messages in thread
From: Siddharth Heroor @ 2013-06-26 11:03 UTC (permalink / raw)
  To: meta-arago

* Choose ti-linux-glsdk as the preferred provider

Signed-off-by: Siddharth Heroor <heroor@ti.com>
cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
---
 .../conf/distro/include/branding-glsdk.inc         |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-distro/conf/distro/include/branding-glsdk.inc

diff --git a/meta-arago-distro/conf/distro/include/branding-glsdk.inc b/meta-arago-distro/conf/distro/include/branding-glsdk.inc
new file mode 100644
index 0000000..d1c30f3
--- /dev/null
+++ b/meta-arago-distro/conf/distro/include/branding-glsdk.inc
@@ -0,0 +1,4 @@
+# GLSDK branding configuration
+
+# Use the SDK supported kernel and kernel version
+PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info
  2013-06-26 11:03 ` [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info Siddharth Heroor
@ 2013-06-26 12:53   ` Maupin, Chase
  2013-06-26 13:48     ` Denys Dmytriyenko
  0 siblings, 1 reply; 12+ messages in thread
From: Maupin, Chase @ 2013-06-26 12:53 UTC (permalink / raw)
  To: Heroor, Siddharth, meta-arago

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Heroor, Siddharth
>Sent: Wednesday, June 26, 2013 6:03 AM
>To: meta-arago@arago-project.org
>Subject: [meta-arago] [PATCH 1/2] meta-arago-distro: recipes-
>kernel - Overlay Arago info
>
>* Based of linux-ti-staging_3.8.bbappend
>
>Signed-off-by: Siddharth Heroor <heroor@ti.com>
>cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
>---
> .../linux/linux-ti-glsdk_3.8.bbappend              |   17
>+++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
> create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-
>ti-glsdk_3.8.bbappend
>
>diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-
>glsdk_3.8.bbappend b/meta-arago-distro/recipes-kernel/linux/linux-
>ti-glsdk_3.8.bbappend
>new file mode 100644
>index 0000000..b20c63a
>--- /dev/null
>+++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-
>glsdk_3.8.bbappend
>@@ -0,0 +1,17 @@
>+MACHINE_KERNEL_PR_append = "-arago6"

Maybe I'm missing something, but I didn't remember seeing the patch that added linux-ti-glsdk recipe to be appended in the first place.

Also, why start with arago6?

>+
>+FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
>+
>+require copy-defconfig.inc
>+
>+KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
>True).partition('+')[2][0:7]}"
>+
>+# The below lines are overlayed until the LOCALVERSION change is
>merged into
>+# the oe-core danny branch. Update: not coming to danny, keep
>until dylan.
>+kernel_do_configure_prepend() {
>+    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
>+    then
>+        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
>+        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
>+    fi
>+}
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info
  2013-06-26 12:53   ` Maupin, Chase
@ 2013-06-26 13:48     ` Denys Dmytriyenko
  2013-06-26 13:56       ` Denys Dmytriyenko
  0 siblings, 1 reply; 12+ messages in thread
From: Denys Dmytriyenko @ 2013-06-26 13:48 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-arago

On Wed, Jun 26, 2013 at 12:53:51PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> >Sent: Wednesday, June 26, 2013 6:03 AM
> >To: meta-arago@arago-project.org
> >Subject: [meta-arago] [PATCH 1/2] meta-arago-distro: recipes-
> >kernel - Overlay Arago info
> >
> >* Based of linux-ti-staging_3.8.bbappend
> >
> >Signed-off-by: Siddharth Heroor <heroor@ti.com>
> >cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
> >---
> > .../linux/linux-ti-glsdk_3.8.bbappend              |   17
> >+++++++++++++++++
> > 1 files changed, 17 insertions(+), 0 deletions(-)
> > create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-
> >ti-glsdk_3.8.bbappend
> >
> >diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-
> >glsdk_3.8.bbappend b/meta-arago-distro/recipes-kernel/linux/linux-
> >ti-glsdk_3.8.bbappend
> >new file mode 100644
> >index 0000000..b20c63a
> >--- /dev/null
> >+++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-
> >glsdk_3.8.bbappend
> >@@ -0,0 +1,17 @@
> >+MACHINE_KERNEL_PR_append = "-arago6"
> 
> Maybe I'm missing something, but I didn't remember seeing the patch that 
> added linux-ti-glsdk recipe to be appended in the first place.

Correct, a dangling bbappend will break the build.


> Also, why start with arago6?
> 
> >+
> >+FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> >+
> >+require copy-defconfig.inc
> >+
> >+KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> >True).partition('+')[2][0:7]}"
> >+
> >+# The below lines are overlayed until the LOCALVERSION change is
> >merged into
> >+# the oe-core danny branch. Update: not coming to danny, keep
> >until dylan.
> >+kernel_do_configure_prepend() {
> >+    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> >+    then
> >+        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> >+        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> >+    fi
> >+}
> >--
> >1.7.0.4
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info
  2013-06-26 13:48     ` Denys Dmytriyenko
@ 2013-06-26 13:56       ` Denys Dmytriyenko
  0 siblings, 0 replies; 12+ messages in thread
From: Denys Dmytriyenko @ 2013-06-26 13:56 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-arago

On Wed, Jun 26, 2013 at 09:48:08AM -0400, Denys Dmytriyenko wrote:
> On Wed, Jun 26, 2013 at 12:53:51PM +0000, Maupin, Chase wrote:
> > >-----Original Message-----
> > >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > >bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> > >Sent: Wednesday, June 26, 2013 6:03 AM
> > >To: meta-arago@arago-project.org
> > >Subject: [meta-arago] [PATCH 1/2] meta-arago-distro: recipes-
> > >kernel - Overlay Arago info
> > >
> > >* Based of linux-ti-staging_3.8.bbappend

Now, reading this comment also makes me think that it could be the case of 
mis-understanding how bbappend works...

The name of bbappend should match the name of the recipe that is being 
altered. You cannot have a linux-ti-glsdk.bbappend trying to amend 
linux-ti-staging.bb and you would have to provide your own linux-ti-glsdk.bb 
recipe.


> > >Signed-off-by: Siddharth Heroor <heroor@ti.com>
> > >cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
> > >---
> > > .../linux/linux-ti-glsdk_3.8.bbappend              |   17
> > >+++++++++++++++++
> > > 1 files changed, 17 insertions(+), 0 deletions(-)
> > > create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-
> > >ti-glsdk_3.8.bbappend
> > >
> > >diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-
> > >glsdk_3.8.bbappend b/meta-arago-distro/recipes-kernel/linux/linux-
> > >ti-glsdk_3.8.bbappend
> > >new file mode 100644
> > >index 0000000..b20c63a
> > >--- /dev/null
> > >+++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-
> > >glsdk_3.8.bbappend
> > >@@ -0,0 +1,17 @@
> > >+MACHINE_KERNEL_PR_append = "-arago6"
> > 
> > Maybe I'm missing something, but I didn't remember seeing the patch that 
> > added linux-ti-glsdk recipe to be appended in the first place.
> 
> Correct, a dangling bbappend will break the build.
> 
> 
> > Also, why start with arago6?
> > 
> > >+
> > >+FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> > >+
> > >+require copy-defconfig.inc
> > >+
> > >+KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > >True).partition('+')[2][0:7]}"
> > >+
> > >+# The below lines are overlayed until the LOCALVERSION change is
> > >merged into
> > >+# the oe-core danny branch. Update: not coming to danny, keep
> > >until dylan.
> > >+kernel_do_configure_prepend() {
> > >+    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> > >+    then
> > >+        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> > >+        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> > >+    fi
> > >+}
> > >--
> > >1.7.0.4
> > >
> > >_______________________________________________
> > >meta-arago mailing list
> > >meta-arago@arago-project.org
> > >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 11:03 ` [PATCH 2/2] glsdk: add the initial GLSDK branding policy Siddharth Heroor
@ 2013-06-26 15:31   ` Cooper Jr., Franklin
  2013-06-26 16:11     ` Maupin, Chase
  0 siblings, 1 reply; 12+ messages in thread
From: Cooper Jr., Franklin @ 2013-06-26 15:31 UTC (permalink / raw)
  To: Heroor, Siddharth, meta-arago

> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> Sent: Wednesday, June 26, 2013 6:03 AM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK branding policy
> 
> * Choose ti-linux-glsdk as the preferred provider
> 
> Signed-off-by: Siddharth Heroor <heroor@ti.com>
> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
> ---
>  .../conf/distro/include/branding-glsdk.inc         |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)  create mode 100644 meta-
> arago-distro/conf/distro/include/branding-glsdk.inc
> 
> diff --git a/meta-arago-distro/conf/distro/include/branding-glsdk.inc b/meta-
> arago-distro/conf/distro/include/branding-glsdk.inc
> new file mode 100644
> index 0000000..d1c30f3
> --- /dev/null
> +++ b/meta-arago-distro/conf/distro/include/branding-glsdk.inc
> @@ -0,0 +1,4 @@
> +# GLSDK branding configuration
> +
> +# Use the SDK supported kernel and kernel version
> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"

I am not familiar with the GLSDK but I am not sure why you need your own branding include file. This patch shows you want to change the kernel but this really should be done in meta-ti within each of the machine configuration files. I will let Denys comment but if you really can't put this within meta-ti then you should at least make this statement machine or at least SOC specific.

Branding-amsdk.inc only exist due to the mainline effort for am335x. Currently the Sitara team supports am335x on the 3.2 kernel while the kernel team is working on getting am335x in mainline. So satisfy both kernels the branding include file was created.

Unless your team's work falls in a similar situation there isn't a need to create this file. I personally don't like the branding include file and plan on getting rid of the amsdk file once we release a mainline am335x SDK.

Also I don't see a recipe for linux-ti-glsdk within meta-ti.

> --
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 15:31   ` Cooper Jr., Franklin
@ 2013-06-26 16:11     ` Maupin, Chase
  2013-06-26 16:16       ` Denys Dmytriyenko
  0 siblings, 1 reply; 12+ messages in thread
From: Maupin, Chase @ 2013-06-26 16:11 UTC (permalink / raw)
  To: Cooper Jr., Franklin, Heroor, Siddharth, meta-arago

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Wednesday, June 26, 2013 10:31 AM
>To: Heroor, Siddharth; meta-arago@arago-project.org
>Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
>branding policy
>
>> -----Original Message-----
>> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
>> Sent: Wednesday, June 26, 2013 6:03 AM
>> To: meta-arago@arago-project.org
>> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
>branding policy
>>
>> * Choose ti-linux-glsdk as the preferred provider
>>
>> Signed-off-by: Siddharth Heroor <heroor@ti.com>
>> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
>> ---
>>  .../conf/distro/include/branding-glsdk.inc         |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)  create mode
>100644 meta-
>> arago-distro/conf/distro/include/branding-glsdk.inc
>>
>> diff --git a/meta-arago-distro/conf/distro/include/branding-
>glsdk.inc b/meta-
>> arago-distro/conf/distro/include/branding-glsdk.inc
>> new file mode 100644
>> index 0000000..d1c30f3
>> --- /dev/null
>> +++ b/meta-arago-distro/conf/distro/include/branding-glsdk.inc
>> @@ -0,0 +1,4 @@
>> +# GLSDK branding configuration
>> +
>> +# Use the SDK supported kernel and kernel version
>> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
>
>I am not familiar with the GLSDK but I am not sure why you need
>your own branding include file. This patch shows you want to
>change the kernel but this really should be done in meta-ti within
>each of the machine configuration files. I will let Denys comment
>but if you really can't put this within meta-ti then you should at
>least make this statement machine or at least SOC specific.
>
>Branding-amsdk.inc only exist due to the mainline effort for
>am335x. Currently the Sitara team supports am335x on the 3.2
>kernel while the kernel team is working on getting am335x in
>mainline. So satisfy both kernels the branding include file was
>created.

Another example would be if you want to use QT5 instead of QT4 to set preferred versions and providers for your SDK.

>
>Unless your team's work falls in a similar situation there isn't a
>need to create this file. I personally don't like the branding
>include file and plan on getting rid of the amsdk file once we
>release a mainline am335x SDK.
>
>Also I don't see a recipe for linux-ti-glsdk within meta-ti.
>
>> --
>> 1.7.0.4
>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 16:11     ` Maupin, Chase
@ 2013-06-26 16:16       ` Denys Dmytriyenko
  2013-06-26 16:20         ` Maupin, Chase
  0 siblings, 1 reply; 12+ messages in thread
From: Denys Dmytriyenko @ 2013-06-26 16:16 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-arago, Cooper Jr., Franklin

On Wed, Jun 26, 2013 at 04:11:52PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> >Sent: Wednesday, June 26, 2013 10:31 AM
> >To: Heroor, Siddharth; meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
> >branding policy
> >
> >> -----Original Message-----
> >> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> >> Sent: Wednesday, June 26, 2013 6:03 AM
> >> To: meta-arago@arago-project.org
> >> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
> >branding policy
> >>
> >> * Choose ti-linux-glsdk as the preferred provider
> >>
> >> Signed-off-by: Siddharth Heroor <heroor@ti.com>
> >> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
> >> ---
> >>  .../conf/distro/include/branding-glsdk.inc         |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)  create mode
> >100644 meta-
> >> arago-distro/conf/distro/include/branding-glsdk.inc
> >>
> >> diff --git a/meta-arago-distro/conf/distro/include/branding-
> >glsdk.inc b/meta-
> >> arago-distro/conf/distro/include/branding-glsdk.inc
> >> new file mode 100644
> >> index 0000000..d1c30f3
> >> --- /dev/null
> >> +++ b/meta-arago-distro/conf/distro/include/branding-glsdk.inc
> >> @@ -0,0 +1,4 @@
> >> +# GLSDK branding configuration
> >> +
> >> +# Use the SDK supported kernel and kernel version
> >> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
> >
> >I am not familiar with the GLSDK but I am not sure why you need
> >your own branding include file. This patch shows you want to
> >change the kernel but this really should be done in meta-ti within
> >each of the machine configuration files. I will let Denys comment
> >but if you really can't put this within meta-ti then you should at
> >least make this statement machine or at least SOC specific.
> >
> >Branding-amsdk.inc only exist due to the mainline effort for
> >am335x. Currently the Sitara team supports am335x on the 3.2
> >kernel while the kernel team is working on getting am335x in
> >mainline. So satisfy both kernels the branding include file was
> >created.
> 
> Another example would be if you want to use QT5 instead of QT4 to set 
> preferred versions and providers for your SDK.

So, how this is different? Until we see the actual kernel recipe, I'm inclined 
to believe this patch is valid and correct. Especially if it's altering one of 
our existing machines and kernel recipes specifically for GLSDK. That is what 
branding was created for in the first place.


> >Unless your team's work falls in a similar situation there isn't a
> >need to create this file. I personally don't like the branding
> >include file and plan on getting rid of the amsdk file once we
> >release a mainline am335x SDK.
> >
> >Also I don't see a recipe for linux-ti-glsdk within meta-ti.
> >
> >> --
> >> 1.7.0.4
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 16:16       ` Denys Dmytriyenko
@ 2013-06-26 16:20         ` Maupin, Chase
  2013-06-26 18:04           ` Cooper Jr., Franklin
  0 siblings, 1 reply; 12+ messages in thread
From: Maupin, Chase @ 2013-06-26 16:20 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago, Cooper Jr., Franklin

>-----Original Message-----
>From: Dmytriyenko, Denys
>Sent: Wednesday, June 26, 2013 11:17 AM
>To: Maupin, Chase
>Cc: Cooper Jr., Franklin; Heroor, Siddharth; meta-arago@arago-
>project.org
>Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
>branding policy
>
>On Wed, Jun 26, 2013 at 04:11:52PM +0000, Maupin, Chase wrote:
>> >-----Original Message-----
>> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>> >Sent: Wednesday, June 26, 2013 10:31 AM
>> >To: Heroor, Siddharth; meta-arago@arago-project.org
>> >Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial
>GLSDK
>> >branding policy
>> >
>> >> -----Original Message-----
>> >> From: meta-arago-bounces@arago-project.org [mailto:meta-
>arago-
>> >> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
>> >> Sent: Wednesday, June 26, 2013 6:03 AM
>> >> To: meta-arago@arago-project.org
>> >> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial
>GLSDK
>> >branding policy
>> >>
>> >> * Choose ti-linux-glsdk as the preferred provider
>> >>
>> >> Signed-off-by: Siddharth Heroor <heroor@ti.com>
>> >> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
>> >> ---
>> >>  .../conf/distro/include/branding-glsdk.inc         |    4
>++++
>> >>  1 files changed, 4 insertions(+), 0 deletions(-)  create
>mode
>> >100644 meta-
>> >> arago-distro/conf/distro/include/branding-glsdk.inc
>> >>
>> >> diff --git a/meta-arago-distro/conf/distro/include/branding-
>> >glsdk.inc b/meta-
>> >> arago-distro/conf/distro/include/branding-glsdk.inc
>> >> new file mode 100644
>> >> index 0000000..d1c30f3
>> >> --- /dev/null
>> >> +++ b/meta-arago-distro/conf/distro/include/branding-
>glsdk.inc
>> >> @@ -0,0 +1,4 @@
>> >> +# GLSDK branding configuration
>> >> +
>> >> +# Use the SDK supported kernel and kernel version
>> >> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
>> >
>> >I am not familiar with the GLSDK but I am not sure why you need
>> >your own branding include file. This patch shows you want to
>> >change the kernel but this really should be done in meta-ti
>within
>> >each of the machine configuration files. I will let Denys
>comment
>> >but if you really can't put this within meta-ti then you should
>at
>> >least make this statement machine or at least SOC specific.
>> >
>> >Branding-amsdk.inc only exist due to the mainline effort for
>> >am335x. Currently the Sitara team supports am335x on the 3.2
>> >kernel while the kernel team is working on getting am335x in
>> >mainline. So satisfy both kernels the branding include file was
>> >created.
>>
>> Another example would be if you want to use QT5 instead of QT4
>to set
>> preferred versions and providers for your SDK.
>
>So, how this is different? Until we see the actual kernel recipe,
>I'm inclined
>to believe this patch is valid and correct. Especially if it's
>altering one of
>our existing machines and kernel recipes specifically for GLSDK.
>That is what
>branding was created for in the first place.
>

+1

>
>> >Unless your team's work falls in a similar situation there
>isn't a
>> >need to create this file. I personally don't like the branding
>> >include file and plan on getting rid of the amsdk file once we
>> >release a mainline am335x SDK.
>> >
>> >Also I don't see a recipe for linux-ti-glsdk within meta-ti.
>> >
>> >> --
>> >> 1.7.0.4
>> >>
>> >> _______________________________________________
>> >> meta-arago mailing list
>> >> meta-arago@arago-project.org
>> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> >_______________________________________________
>> >meta-arago mailing list
>> >meta-arago@arago-project.org
>> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 16:20         ` Maupin, Chase
@ 2013-06-26 18:04           ` Cooper Jr., Franklin
  2013-06-27  3:31             ` Siddharth Heroor
  0 siblings, 1 reply; 12+ messages in thread
From: Cooper Jr., Franklin @ 2013-06-26 18:04 UTC (permalink / raw)
  To: Maupin, Chase, Dmytriyenko, Denys; +Cc: meta-arago



> -----Original Message-----
> From: Maupin, Chase
> Sent: Wednesday, June 26, 2013 11:21 AM
> To: Dmytriyenko, Denys
> Cc: Cooper Jr., Franklin; Heroor, Siddharth; meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK branding
> policy
> 
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Wednesday, June 26, 2013 11:17 AM
> >To: Maupin, Chase
> >Cc: Cooper Jr., Franklin; Heroor, Siddharth; meta-arago@arago-
> >project.org
> >Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
> >branding policy
> >
> >On Wed, Jun 26, 2013 at 04:11:52PM +0000, Maupin, Chase wrote:
> >> >-----Original Message-----
> >> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> >> >Sent: Wednesday, June 26, 2013 10:31 AM
> >> >To: Heroor, Siddharth; meta-arago@arago-project.org
> >> >Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial
> >GLSDK
> >> >branding policy
> >> >
> >> >> -----Original Message-----
> >> >> From: meta-arago-bounces@arago-project.org [mailto:meta-
> >arago-
> >> >> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> >> >> Sent: Wednesday, June 26, 2013 6:03 AM
> >> >> To: meta-arago@arago-project.org
> >> >> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial
> >GLSDK
> >> >branding policy
> >> >>
> >> >> * Choose ti-linux-glsdk as the preferred provider
> >> >>
> >> >> Signed-off-by: Siddharth Heroor <heroor@ti.com>
> >> >> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
> >> >> ---
> >> >>  .../conf/distro/include/branding-glsdk.inc         |    4
> >++++
> >> >>  1 files changed, 4 insertions(+), 0 deletions(-)  create
> >mode
> >> >100644 meta-
> >> >> arago-distro/conf/distro/include/branding-glsdk.inc
> >> >>
> >> >> diff --git a/meta-arago-distro/conf/distro/include/branding-
> >> >glsdk.inc b/meta-
> >> >> arago-distro/conf/distro/include/branding-glsdk.inc
> >> >> new file mode 100644
> >> >> index 0000000..d1c30f3
> >> >> --- /dev/null
> >> >> +++ b/meta-arago-distro/conf/distro/include/branding-
> >glsdk.inc
> >> >> @@ -0,0 +1,4 @@
> >> >> +# GLSDK branding configuration
> >> >> +
> >> >> +# Use the SDK supported kernel and kernel version
> >> >> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
> >> >
> >> >I am not familiar with the GLSDK but I am not sure why you need your
> >> >own branding include file. This patch shows you want to change the
> >> >kernel but this really should be done in meta-ti
> >within
> >> >each of the machine configuration files. I will let Denys
> >comment
> >> >but if you really can't put this within meta-ti then you should
> >at
> >> >least make this statement machine or at least SOC specific.
> >> >
> >> >Branding-amsdk.inc only exist due to the mainline effort for am335x.
> >> >Currently the Sitara team supports am335x on the 3.2 kernel while
> >> >the kernel team is working on getting am335x in mainline. So satisfy
> >> >both kernels the branding include file was created.
> >>
> >> Another example would be if you want to use QT5 instead of QT4
> >to set
> >> preferred versions and providers for your SDK.
> >
> >So, how this is different? Until we see the actual kernel recipe, I'm
> >inclined to believe this patch is valid and correct. Especially if it's
> >altering one of our existing machines and kernel recipes specifically
> >for GLSDK.
> >That is what
> >branding was created for in the first place.
> >
> 
> +1
I'll wait to see what this kernel recipe is since that is the biggest point of confusion.

> 
> >
> >> >Unless your team's work falls in a similar situation there
> >isn't a
> >> >need to create this file. I personally don't like the branding
> >> >include file and plan on getting rid of the amsdk file once we
> >> >release a mainline am335x SDK.
> >> >
> >> >Also I don't see a recipe for linux-ti-glsdk within meta-ti.
> >> >
> >> >> --
> >> >> 1.7.0.4
> >> >>
> >> >> _______________________________________________
> >> >> meta-arago mailing list
> >> >> meta-arago@arago-project.org
> >> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >> >_______________________________________________
> >> >meta-arago mailing list
> >> >meta-arago@arago-project.org
> >> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy
  2013-06-26 18:04           ` Cooper Jr., Franklin
@ 2013-06-27  3:31             ` Siddharth Heroor
  0 siblings, 0 replies; 12+ messages in thread
From: Siddharth Heroor @ 2013-06-27  3:31 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On 6/26/2013 11:34 PM, Cooper Jr., Franklin wrote:
> 
> 
>> -----Original Message-----
>> From: Maupin, Chase
>> Sent: Wednesday, June 26, 2013 11:21 AM
>> To: Dmytriyenko, Denys
>> Cc: Cooper Jr., Franklin; Heroor, Siddharth; meta-arago@arago-project.org
>> Subject: RE: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK branding
>> policy
>>
>>> -----Original Message-----
>>> From: Dmytriyenko, Denys
>>> Sent: Wednesday, June 26, 2013 11:17 AM
>>> To: Maupin, Chase
>>> Cc: Cooper Jr., Franklin; Heroor, Siddharth; meta-arago@arago-
>>> project.org
>>> Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
>>> branding policy
>>>
>>> On Wed, Jun 26, 2013 at 04:11:52PM +0000, Maupin, Chase wrote:
>>>>> -----Original Message-----
>>>>> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>>>>> bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>>>>> Sent: Wednesday, June 26, 2013 10:31 AM
>>>>> To: Heroor, Siddharth; meta-arago@arago-project.org
>>>>> Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial
>>> GLSDK
>>>>> branding policy
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: meta-arago-bounces@arago-project.org [mailto:meta-
>>> arago-
>>>>>> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
>>>>>> Sent: Wednesday, June 26, 2013 6:03 AM
>>>>>> To: meta-arago@arago-project.org
>>>>>> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial
>>> GLSDK
>>>>> branding policy
>>>>>>
>>>>>> * Choose ti-linux-glsdk as the preferred provider
>>>>>>
>>>>>> Signed-off-by: Siddharth Heroor <heroor@ti.com>
>>>>>> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
>>>>>> ---
>>>>>>  .../conf/distro/include/branding-glsdk.inc         |    4
>>> ++++
>>>>>>  1 files changed, 4 insertions(+), 0 deletions(-)  create
>>> mode
>>>>> 100644 meta-
>>>>>> arago-distro/conf/distro/include/branding-glsdk.inc
>>>>>>
>>>>>> diff --git a/meta-arago-distro/conf/distro/include/branding-
>>>>> glsdk.inc b/meta-
>>>>>> arago-distro/conf/distro/include/branding-glsdk.inc
>>>>>> new file mode 100644
>>>>>> index 0000000..d1c30f3
>>>>>> --- /dev/null
>>>>>> +++ b/meta-arago-distro/conf/distro/include/branding-
>>> glsdk.inc
>>>>>> @@ -0,0 +1,4 @@
>>>>>> +# GLSDK branding configuration
>>>>>> +
>>>>>> +# Use the SDK supported kernel and kernel version
>>>>>> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
>>>>>
>>>>> I am not familiar with the GLSDK but I am not sure why you need your
>>>>> own branding include file. This patch shows you want to change the
>>>>> kernel but this really should be done in meta-ti
>>> within
>>>>> each of the machine configuration files. I will let Denys
>>> comment
>>>>> but if you really can't put this within meta-ti then you should
>>> at
>>>>> least make this statement machine or at least SOC specific.
>>>>>
>>>>> Branding-amsdk.inc only exist due to the mainline effort for am335x.
>>>>> Currently the Sitara team supports am335x on the 3.2 kernel while
>>>>> the kernel team is working on getting am335x in mainline. So satisfy
>>>>> both kernels the branding include file was created.
>>>>
>>>> Another example would be if you want to use QT5 instead of QT4
>>> to set
>>>> preferred versions and providers for your SDK.
>>>
>>> So, how this is different? Until we see the actual kernel recipe, I'm
>>> inclined to believe this patch is valid and correct. Especially if it's
>>> altering one of our existing machines and kernel recipes specifically
>>> for GLSDK.
>>> That is what
>>> branding was created for in the first place.
>>>
>>
>> +1
> I'll wait to see what this kernel recipe is since that is the biggest point of confusion.

I actually sent the kernel recipe to meta-ti up ahead, but it seems to
have been "lost" i.e never delivered. Looks like meta-ti or TI's SMTP
server doesn't like me sending patches to meta-ti :-).

I'm working to get that sorted out and I agree we need to get the
meta-ti kernel patch in place first.

> 
>>
>>>
>>>>> Unless your team's work falls in a similar situation there
>>> isn't a
>>>>> need to create this file. I personally don't like the branding
>>>>> include file and plan on getting rid of the amsdk file once we
>>>>> release a mainline am335x SDK.
>>>>>
>>>>> Also I don't see a recipe for linux-ti-glsdk within meta-ti.
>>>>>
>>>>>> --
>>>>>> 1.7.0.4
>>>>>>
>>>>>> _______________________________________________
>>>>>> meta-arago mailing list
>>>>>> meta-arago@arago-project.org
>>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>>>>> _______________________________________________
>>>>> meta-arago mailing list
>>>>> meta-arago@arago-project.org
>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>>>> _______________________________________________
>>>> meta-arago mailing list
>>>> meta-arago@arago-project.org
>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2013-06-27  3:31 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-26 11:03 [PATCH 0/2] Add GLSDK Branding Siddharth Heroor
2013-06-26 11:03 ` [PATCH 1/2] meta-arago-distro: recipes-kernel - Overlay Arago info Siddharth Heroor
2013-06-26 12:53   ` Maupin, Chase
2013-06-26 13:48     ` Denys Dmytriyenko
2013-06-26 13:56       ` Denys Dmytriyenko
2013-06-26 11:03 ` [PATCH 2/2] glsdk: add the initial GLSDK branding policy Siddharth Heroor
2013-06-26 15:31   ` Cooper Jr., Franklin
2013-06-26 16:11     ` Maupin, Chase
2013-06-26 16:16       ` Denys Dmytriyenko
2013-06-26 16:20         ` Maupin, Chase
2013-06-26 18:04           ` Cooper Jr., Franklin
2013-06-27  3:31             ` Siddharth Heroor

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.