* [PATCHv2 0/3] ARM: mxs: Various Crystalfontz DT additions
@ 2013-06-26 15:40 ` Alexandre Belloni
0 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: Shawn Guo
Cc: Russell King, Maxime Ripard, jimwall, brian, linux-arm-kernel,
linux-kernel, Alexandre Belloni
Hi,
This patch series add DT for the Crystalfontz CFA-10056 and Crystalfontz
CFA-10058.
The first patch simplifies board detection in mach-mxs.c as suggested by Thomas
Petazzoni in his review of the precedent DT additions.
The next patches are ading the DTs.
Changes in v2:
- took into account the review from Maxime Ripard
Thanks,
Alexandre
Alexandre Belloni (1):
ARM: mxs: Simplify detection of CrystalFontz boards
Brian Lilly (2):
ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree
ARM: mxs: dt: Add Crystalfontz CFA-10058 device tree
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/imx28-cfa10056.dts | 171 +++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/imx28-cfa10058.dts | 158 ++++++++++++++++++++++++++++++++
arch/arm/mach-mxs/mach-mxs.c | 5 +-
4 files changed, 332 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
create mode 100644 arch/arm/boot/dts/imx28-cfa10058.dts
--
1.8.1.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCHv2 0/3] ARM: mxs: Various Crystalfontz DT additions
@ 2013-06-26 15:40 ` Alexandre Belloni
0 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
This patch series add DT for the Crystalfontz CFA-10056 and Crystalfontz
CFA-10058.
The first patch simplifies board detection in mach-mxs.c as suggested by Thomas
Petazzoni in his review of the precedent DT additions.
The next patches are ading the DTs.
Changes in v2:
- took into account the review from Maxime Ripard
Thanks,
Alexandre
Alexandre Belloni (1):
ARM: mxs: Simplify detection of CrystalFontz boards
Brian Lilly (2):
ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree
ARM: mxs: dt: Add Crystalfontz CFA-10058 device tree
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/imx28-cfa10056.dts | 171 +++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/imx28-cfa10058.dts | 158 ++++++++++++++++++++++++++++++++
arch/arm/mach-mxs/mach-mxs.c | 5 +-
4 files changed, 332 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
create mode 100644 arch/arm/boot/dts/imx28-cfa10058.dts
--
1.8.1.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCHv2 1/3] ARM: mxs: Simplify detection of CrystalFontz boards
2013-06-26 15:40 ` Alexandre Belloni
@ 2013-06-26 15:40 ` Alexandre Belloni
-1 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: Shawn Guo
Cc: Russell King, Maxime Ripard, jimwall, brian, linux-arm-kernel,
linux-kernel, Alexandre Belloni
As all CrystalFontz boards are compatible with "crystalfontz,cfa10036", make it
easier to add future boards.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/mach-mxs/mach-mxs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 77280c6..8be23cb 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -363,10 +363,7 @@ static void __init mxs_machine_init(void)
imx28_evk_init();
else if (of_machine_is_compatible("bluegiga,apx4devkit"))
apx4devkit_init();
- else if (of_machine_is_compatible("crystalfontz,cfa10037") ||
- of_machine_is_compatible("crystalfontz,cfa10049") ||
- of_machine_is_compatible("crystalfontz,cfa10055") ||
- of_machine_is_compatible("crystalfontz,cfa10057"))
+ else if (of_machine_is_compatible("crystalfontz,cfa10036"))
crystalfontz_init();
of_platform_populate(NULL, of_default_bus_match_table,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv2 1/3] ARM: mxs: Simplify detection of CrystalFontz boards
@ 2013-06-26 15:40 ` Alexandre Belloni
0 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: linux-arm-kernel
As all CrystalFontz boards are compatible with "crystalfontz,cfa10036", make it
easier to add future boards.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/mach-mxs/mach-mxs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 77280c6..8be23cb 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -363,10 +363,7 @@ static void __init mxs_machine_init(void)
imx28_evk_init();
else if (of_machine_is_compatible("bluegiga,apx4devkit"))
apx4devkit_init();
- else if (of_machine_is_compatible("crystalfontz,cfa10037") ||
- of_machine_is_compatible("crystalfontz,cfa10049") ||
- of_machine_is_compatible("crystalfontz,cfa10055") ||
- of_machine_is_compatible("crystalfontz,cfa10057"))
+ else if (of_machine_is_compatible("crystalfontz,cfa10036"))
crystalfontz_init();
of_platform_populate(NULL, of_default_bus_match_table,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv2 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree
2013-06-26 15:40 ` Alexandre Belloni
@ 2013-06-26 15:40 ` Alexandre Belloni
-1 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: Shawn Guo
Cc: Russell King, Maxime Ripard, jimwall, brian, linux-arm-kernel,
linux-kernel, Alexandre Belloni
From: Brian Lilly <brian@crystalfontz.com>
The CFA-10056 is a breakout board for the CFA-10036, and is
basically a CFA-10037, with a 4.3" screen.
Signed-off-by: Brian Lilly <brian@crystalfontz.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx28-cfa10056.dts | 171 +++++++++++++++++++++++++++++++++++
2 files changed, 172 insertions(+)
create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 225d939..d494f37 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-cfa10037.dtb \
imx28-cfa10049.dtb \
imx28-cfa10055.dtb \
+ imx28-cfa10056.dtb \
imx28-cfa10057.dtb \
imx28-evk.dtb \
imx28-m28evk.dtb \
diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts b/arch/arm/boot/dts/imx28-cfa10056.dts
new file mode 100644
index 0000000..dd6d217
--- /dev/null
+++ b/arch/arm/boot/dts/imx28-cfa10056.dts
@@ -0,0 +1,171 @@
+/*
+ * Copyright 2013 Free Electrons
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/*
+ * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
+ * need to include the CFA-10036 DTS.
+ */
+/include/ "imx28-cfa10036.dts"
+
+/ {
+ model = "Crystalfontz CFA-10056 Board";
+ compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10036", "fsl,imx28";
+
+ apb@80000000 {
+ apbh@80000000 {
+ pinctrl@80018000 {
+ pinctrl-names = "default", "default";
+ pinctrl-1 = <&hog_pins_cfa10056
+ &hog_pins_cfa10056_pullup>;
+
+ hog_pins_cfa10056: hog-10056@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
+ 0x2153 /* MX28_PAD_SSP2_D5__GPIO_2_21 */
+ 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ hog_pins_cfa10056_pullup: hog-10056-pullup@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x31e3 /* MX28_PAD_LCD_RESET__GPIO_3_30 */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <1>;
+ };
+
+ spi2_pins_cfa10056: spi2-cfa10056@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x2103 /* MX28_PAD_SSP2_SCK__GPIO_2_16 */
+ 0x2113 /* MX28_PAD_SSP2_CMD__GPIO_2_17 */
+ 0x2123 /* MX28_PAD_SSP2_D0__GPIO_2_18 */
+ >;
+ fsl,drive-strength = <1>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <1>;
+ };
+
+ lcdif_pins_cfa10056: lcdif-evk@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */
+ 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */
+ 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */
+ 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+ };
+
+ lcdif@80030000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcdif_24bit_pins_a
+ &lcdif_pins_cfa10056>;
+ display = <&display>;
+ status = "okay";
+
+ display: display {
+ bits-per-pixel = <32>;
+ bus-width = <24>;
+
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing0 {
+ clock-frequency = <32000000>;
+ hactive = <480>;
+ vactive = <800>;
+ hback-porch = <2>;
+ hfront-porch = <2>;
+ vback-porch = <2>;
+ vfront-porch = <2>;
+ hsync-len = <5>;
+ vsync-len = <5>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ de-active = <1>;
+ pixelclk-active = <1>;
+ };
+ };
+ };
+ };
+ };
+
+ apbx@80040000 {
+ usbphy1: usbphy@8007e000 {
+ status = "okay";
+ };
+ };
+ };
+
+ ahb@80080000 {
+ usb1: usb@80090000 {
+ vbus-supply = <®_usb1_vbus>;
+ pinctrl-0 = <&usbphy1_pins_a>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+
+ reg_usb1_vbus: usb1_vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb1_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio0 7 1>;
+ };
+ };
+
+ ahb@80080000 {
+ mac0: ethernet@800f0000 {
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mac0_pins_a>;
+ phy-reset-gpios = <&gpio2 21 0>;
+ phy-reset-duration = <100>;
+ status = "okay";
+ };
+ };
+
+ spi2 {
+ compatible = "spi-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&spi2_pins_cfa10056>;
+ status = "okay";
+ gpio-sck = <&gpio2 16 0>;
+ gpio-mosi = <&gpio2 17 0>;
+ gpio-miso = <&gpio2 18 0>;
+ cs-gpios = <&gpio3 5 0>;
+ num-chipselects = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hx8369: hx8369@0 {
+ compatible = "himax,hx8369a", "himax,hx8369";
+ reg = <0>;
+ spi-max-frequency = <100000>;
+ spi-cpol;
+ spi-cpha;
+ gpios-reset = <&gpio3 30 0>;
+ };
+ };
+};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv2 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree
@ 2013-06-26 15:40 ` Alexandre Belloni
0 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Brian Lilly <brian@crystalfontz.com>
The CFA-10056 is a breakout board for the CFA-10036, and is
basically a CFA-10037, with a 4.3" screen.
Signed-off-by: Brian Lilly <brian@crystalfontz.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx28-cfa10056.dts | 171 +++++++++++++++++++++++++++++++++++
2 files changed, 172 insertions(+)
create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 225d939..d494f37 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-cfa10037.dtb \
imx28-cfa10049.dtb \
imx28-cfa10055.dtb \
+ imx28-cfa10056.dtb \
imx28-cfa10057.dtb \
imx28-evk.dtb \
imx28-m28evk.dtb \
diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts b/arch/arm/boot/dts/imx28-cfa10056.dts
new file mode 100644
index 0000000..dd6d217
--- /dev/null
+++ b/arch/arm/boot/dts/imx28-cfa10056.dts
@@ -0,0 +1,171 @@
+/*
+ * Copyright 2013 Free Electrons
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/*
+ * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
+ * need to include the CFA-10036 DTS.
+ */
+/include/ "imx28-cfa10036.dts"
+
+/ {
+ model = "Crystalfontz CFA-10056 Board";
+ compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10036", "fsl,imx28";
+
+ apb at 80000000 {
+ apbh at 80000000 {
+ pinctrl at 80018000 {
+ pinctrl-names = "default", "default";
+ pinctrl-1 = <&hog_pins_cfa10056
+ &hog_pins_cfa10056_pullup>;
+
+ hog_pins_cfa10056: hog-10056 at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
+ 0x2153 /* MX28_PAD_SSP2_D5__GPIO_2_21 */
+ 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ hog_pins_cfa10056_pullup: hog-10056-pullup at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x31e3 /* MX28_PAD_LCD_RESET__GPIO_3_30 */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <1>;
+ };
+
+ spi2_pins_cfa10056: spi2-cfa10056 at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x2103 /* MX28_PAD_SSP2_SCK__GPIO_2_16 */
+ 0x2113 /* MX28_PAD_SSP2_CMD__GPIO_2_17 */
+ 0x2123 /* MX28_PAD_SSP2_D0__GPIO_2_18 */
+ >;
+ fsl,drive-strength = <1>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <1>;
+ };
+
+ lcdif_pins_cfa10056: lcdif-evk at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */
+ 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */
+ 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */
+ 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+ };
+
+ lcdif at 80030000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcdif_24bit_pins_a
+ &lcdif_pins_cfa10056>;
+ display = <&display>;
+ status = "okay";
+
+ display: display {
+ bits-per-pixel = <32>;
+ bus-width = <24>;
+
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing0 {
+ clock-frequency = <32000000>;
+ hactive = <480>;
+ vactive = <800>;
+ hback-porch = <2>;
+ hfront-porch = <2>;
+ vback-porch = <2>;
+ vfront-porch = <2>;
+ hsync-len = <5>;
+ vsync-len = <5>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ de-active = <1>;
+ pixelclk-active = <1>;
+ };
+ };
+ };
+ };
+ };
+
+ apbx at 80040000 {
+ usbphy1: usbphy at 8007e000 {
+ status = "okay";
+ };
+ };
+ };
+
+ ahb at 80080000 {
+ usb1: usb at 80090000 {
+ vbus-supply = <®_usb1_vbus>;
+ pinctrl-0 = <&usbphy1_pins_a>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+
+ reg_usb1_vbus: usb1_vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb1_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio0 7 1>;
+ };
+ };
+
+ ahb at 80080000 {
+ mac0: ethernet at 800f0000 {
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mac0_pins_a>;
+ phy-reset-gpios = <&gpio2 21 0>;
+ phy-reset-duration = <100>;
+ status = "okay";
+ };
+ };
+
+ spi2 {
+ compatible = "spi-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&spi2_pins_cfa10056>;
+ status = "okay";
+ gpio-sck = <&gpio2 16 0>;
+ gpio-mosi = <&gpio2 17 0>;
+ gpio-miso = <&gpio2 18 0>;
+ cs-gpios = <&gpio3 5 0>;
+ num-chipselects = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hx8369: hx8369 at 0 {
+ compatible = "himax,hx8369a", "himax,hx8369";
+ reg = <0>;
+ spi-max-frequency = <100000>;
+ spi-cpol;
+ spi-cpha;
+ gpios-reset = <&gpio3 30 0>;
+ };
+ };
+};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv2 3/3] ARM: mxs: dt: Add Crystalfontz CFA-10058 device tree
2013-06-26 15:40 ` Alexandre Belloni
@ 2013-06-26 15:40 ` Alexandre Belloni
-1 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: Shawn Guo
Cc: Russell King, Maxime Ripard, jimwall, brian, linux-arm-kernel,
linux-kernel, Alexandre Belloni
From: Brian Lilly <brian@crystalfontz.com>
The CFA-10057 is a breakout board for the CFA-10036 that has Ethernet, USB and a
5" LCD screen on it.
Signed-off-by: Brian Lilly <brian@crystalfontz.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx28-cfa10058.dts | 158 +++++++++++++++++++++++++++++++++++
2 files changed, 159 insertions(+)
create mode 100644 arch/arm/boot/dts/imx28-cfa10058.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d494f37..ddd6f32 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -133,6 +133,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-cfa10055.dtb \
imx28-cfa10056.dtb \
imx28-cfa10057.dtb \
+ imx28-cfa10058.dtb \
imx28-evk.dtb \
imx28-m28evk.dtb \
imx28-sps1.dtb \
diff --git a/arch/arm/boot/dts/imx28-cfa10058.dts b/arch/arm/boot/dts/imx28-cfa10058.dts
new file mode 100644
index 0000000..99a21ac
--- /dev/null
+++ b/arch/arm/boot/dts/imx28-cfa10058.dts
@@ -0,0 +1,158 @@
+/*
+ * Copyright 2013 Crystalfontz America, Inc.
+ * Copyright 2013 Free Electrons
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/*
+ * The CFA-10058 is an expansion board for the CFA-10036 module, thus we
+ * need to include the CFA-10036 DTS.
+ */
+/include/ "imx28-cfa10036.dts"
+
+/ {
+ model = "Crystalfontz CFA-10058 Board";
+ compatible = "crystalfontz,cfa10058", "crystalfontz,cfa10036", "fsl,imx28";
+
+ apb@80000000 {
+ apbh@80000000 {
+ pinctrl@80018000 {
+ pinctrl-names = "default", "default";
+ pinctrl-1 = <&hog_pins_cfa10058
+ &hog_pins_cfa10058_pullup>;
+
+ hog_pins_cfa10058: hog-10058@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
+ 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ spi3_pins_cfa10058: spi3-cfa10058@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x0183 /* MX28_PAD_GPMI_RDN__GPIO_0_24 */
+ 0x01c3 /* MX28_PAD_GPMI_RESETN__GPIO_0_28 */
+ 0x0113 /* MX28_PAD_GPMI_CE1N__GPIO_0_17 */
+ 0x01a3 /* MX28_PAD_GPMI_ALE__GPIO_0_26 */
+ 0x01b3 /* MX28_PAD_GPMI_CLE__GPIO_0_27 */
+ >;
+ fsl,drive-strength = <1>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <1>;
+ };
+
+ lcdif_pins_cfa10058: lcdif-evk@0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */
+ 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */
+ 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */
+ 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+ };
+
+ lcdif@80030000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcdif_24bit_pins_a
+ &lcdif_pins_cfa10058>;
+ display = <&display>;
+ status = "okay";
+
+ display: display {
+ bits-per-pixel = <32>;
+ bus-width = <24>;
+
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing0 {
+ clock-frequency = <30000000>;
+ hactive = <800>;
+ vactive = <480>;
+ hback-porch = <40>;
+ hfront-porch = <40>;
+ vback-porch = <13>;
+ vfront-porch = <29>;
+ hsync-len = <8>;
+ vsync-len = <8>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ de-active = <1>;
+ pixelclk-active = <1>;
+ };
+ };
+ };
+ };
+ };
+
+ apbx@80040000 {
+ lradc@80050000 {
+ fsl,lradc-touchscreen-wires = <4>;
+ status = "okay";
+ };
+
+ pwm: pwm@80064000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm3_pins_b>;
+ status = "okay";
+ };
+
+ usbphy1: usbphy@8007e000 {
+ status = "okay";
+ };
+ };
+ };
+
+ ahb@80080000 {
+ usb1: usb@80090000 {
+ vbus-supply = <®_usb1_vbus>;
+ pinctrl-0 = <&usbphy1_pins_a>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+
+ reg_usb1_vbus: usb1_vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb1_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio0 7 1>;
+ };
+ };
+
+ ahb@80080000 {
+ mac0: ethernet@800f0000 {
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mac0_pins_a>;
+ phy-reset-gpios = <&gpio2 21 0>;
+ phy-reset-duration = <100>;
+ status = "okay";
+ };
+ };
+
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 3 5000000>;
+ brightness-levels = <0 4 8 16 32 64 128 255>;
+ default-brightness-level = <6>;
+ };
+};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv2 3/3] ARM: mxs: dt: Add Crystalfontz CFA-10058 device tree
@ 2013-06-26 15:40 ` Alexandre Belloni
0 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2013-06-26 15:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Brian Lilly <brian@crystalfontz.com>
The CFA-10057 is a breakout board for the CFA-10036 that has Ethernet, USB and a
5" LCD screen on it.
Signed-off-by: Brian Lilly <brian@crystalfontz.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx28-cfa10058.dts | 158 +++++++++++++++++++++++++++++++++++
2 files changed, 159 insertions(+)
create mode 100644 arch/arm/boot/dts/imx28-cfa10058.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d494f37..ddd6f32 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -133,6 +133,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-cfa10055.dtb \
imx28-cfa10056.dtb \
imx28-cfa10057.dtb \
+ imx28-cfa10058.dtb \
imx28-evk.dtb \
imx28-m28evk.dtb \
imx28-sps1.dtb \
diff --git a/arch/arm/boot/dts/imx28-cfa10058.dts b/arch/arm/boot/dts/imx28-cfa10058.dts
new file mode 100644
index 0000000..99a21ac
--- /dev/null
+++ b/arch/arm/boot/dts/imx28-cfa10058.dts
@@ -0,0 +1,158 @@
+/*
+ * Copyright 2013 Crystalfontz America, Inc.
+ * Copyright 2013 Free Electrons
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/*
+ * The CFA-10058 is an expansion board for the CFA-10036 module, thus we
+ * need to include the CFA-10036 DTS.
+ */
+/include/ "imx28-cfa10036.dts"
+
+/ {
+ model = "Crystalfontz CFA-10058 Board";
+ compatible = "crystalfontz,cfa10058", "crystalfontz,cfa10036", "fsl,imx28";
+
+ apb at 80000000 {
+ apbh at 80000000 {
+ pinctrl at 80018000 {
+ pinctrl-names = "default", "default";
+ pinctrl-1 = <&hog_pins_cfa10058
+ &hog_pins_cfa10058_pullup>;
+
+ hog_pins_cfa10058: hog-10058 at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
+ 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ spi3_pins_cfa10058: spi3-cfa10058 at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x0183 /* MX28_PAD_GPMI_RDN__GPIO_0_24 */
+ 0x01c3 /* MX28_PAD_GPMI_RESETN__GPIO_0_28 */
+ 0x0113 /* MX28_PAD_GPMI_CE1N__GPIO_0_17 */
+ 0x01a3 /* MX28_PAD_GPMI_ALE__GPIO_0_26 */
+ 0x01b3 /* MX28_PAD_GPMI_CLE__GPIO_0_27 */
+ >;
+ fsl,drive-strength = <1>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <1>;
+ };
+
+ lcdif_pins_cfa10058: lcdif-evk at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */
+ 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */
+ 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */
+ 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+ };
+
+ lcdif at 80030000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcdif_24bit_pins_a
+ &lcdif_pins_cfa10058>;
+ display = <&display>;
+ status = "okay";
+
+ display: display {
+ bits-per-pixel = <32>;
+ bus-width = <24>;
+
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing0 {
+ clock-frequency = <30000000>;
+ hactive = <800>;
+ vactive = <480>;
+ hback-porch = <40>;
+ hfront-porch = <40>;
+ vback-porch = <13>;
+ vfront-porch = <29>;
+ hsync-len = <8>;
+ vsync-len = <8>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ de-active = <1>;
+ pixelclk-active = <1>;
+ };
+ };
+ };
+ };
+ };
+
+ apbx at 80040000 {
+ lradc at 80050000 {
+ fsl,lradc-touchscreen-wires = <4>;
+ status = "okay";
+ };
+
+ pwm: pwm at 80064000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm3_pins_b>;
+ status = "okay";
+ };
+
+ usbphy1: usbphy at 8007e000 {
+ status = "okay";
+ };
+ };
+ };
+
+ ahb at 80080000 {
+ usb1: usb at 80090000 {
+ vbus-supply = <®_usb1_vbus>;
+ pinctrl-0 = <&usbphy1_pins_a>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+
+ reg_usb1_vbus: usb1_vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb1_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio0 7 1>;
+ };
+ };
+
+ ahb at 80080000 {
+ mac0: ethernet at 800f0000 {
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mac0_pins_a>;
+ phy-reset-gpios = <&gpio2 21 0>;
+ phy-reset-duration = <100>;
+ status = "okay";
+ };
+ };
+
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 3 5000000>;
+ brightness-levels = <0 4 8 16 32 64 128 255>;
+ default-brightness-level = <6>;
+ };
+};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCHv2 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree
2013-06-26 15:40 ` Alexandre Belloni
@ 2013-06-26 15:57 ` Maxime Ripard
-1 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2013-06-26 15:57 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Shawn Guo, Russell King, jimwall, brian, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 6324 bytes --]
On Wed, Jun 26, 2013 at 05:40:31PM +0200, Alexandre Belloni wrote:
> From: Brian Lilly <brian@crystalfontz.com>
>
> The CFA-10056 is a breakout board for the CFA-10036, and is
> basically a CFA-10037, with a 4.3" screen.
>
> Signed-off-by: Brian Lilly <brian@crystalfontz.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx28-cfa10056.dts | 171 +++++++++++++++++++++++++++++++++++
> 2 files changed, 172 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 225d939..d494f37 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
> imx28-cfa10037.dtb \
> imx28-cfa10049.dtb \
> imx28-cfa10055.dtb \
> + imx28-cfa10056.dtb \
> imx28-cfa10057.dtb \
> imx28-evk.dtb \
> imx28-m28evk.dtb \
> diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts b/arch/arm/boot/dts/imx28-cfa10056.dts
> new file mode 100644
> index 0000000..dd6d217
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx28-cfa10056.dts
> @@ -0,0 +1,171 @@
> +/*
> + * Copyright 2013 Free Electrons
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/*
> + * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
> + * need to include the CFA-10036 DTS.
> + */
> +/include/ "imx28-cfa10036.dts"
> +
> +/ {
> + model = "Crystalfontz CFA-10056 Board";
> + compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10036", "fsl,imx28";
> +
> + apb@80000000 {
> + apbh@80000000 {
> + pinctrl@80018000 {
> + pinctrl-names = "default", "default";
> + pinctrl-1 = <&hog_pins_cfa10056
> + &hog_pins_cfa10056_pullup>;
> +
> + hog_pins_cfa10056: hog-10056@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
> + 0x2153 /* MX28_PAD_SSP2_D5__GPIO_2_21 */
> + 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
These hogs pins don't have much sense anymore.
Maybe you should split out the three pins in:
- usb_pins_cfa10056
- mac0_pins_cfa10056
- move the last one in spi2_pins_cfa10056
> +
> + hog_pins_cfa10056_pullup: hog-10056-pullup@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x31e3 /* MX28_PAD_LCD_RESET__GPIO_3_30 */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <1>;
> + };
You could probably rename it to lcdif_pins_cfa10056_pullups or something
then, and make the lcdif driver grab these pins.
> +
> + spi2_pins_cfa10056: spi2-cfa10056@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x2103 /* MX28_PAD_SSP2_SCK__GPIO_2_16 */
> + 0x2113 /* MX28_PAD_SSP2_CMD__GPIO_2_17 */
> + 0x2123 /* MX28_PAD_SSP2_D0__GPIO_2_18 */
> + >;
> + fsl,drive-strength = <1>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <1>;
> + };
> +
> + lcdif_pins_cfa10056: lcdif-evk@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */
> + 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */
> + 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */
> + 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> + };
> +
> + lcdif@80030000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcdif_24bit_pins_a
> + &lcdif_pins_cfa10056>;
> + display = <&display>;
> + status = "okay";
> +
> + display: display {
> + bits-per-pixel = <32>;
> + bus-width = <24>;
> +
> + display-timings {
> + native-mode = <&timing0>;
> + timing0: timing0 {
> + clock-frequency = <32000000>;
> + hactive = <480>;
> + vactive = <800>;
> + hback-porch = <2>;
> + hfront-porch = <2>;
> + vback-porch = <2>;
> + vfront-porch = <2>;
> + hsync-len = <5>;
> + vsync-len = <5>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + de-active = <1>;
> + pixelclk-active = <1>;
> + };
> + };
> + };
> + };
> + };
> +
> + apbx@80040000 {
> + usbphy1: usbphy@8007e000 {
> + status = "okay";
> + };
> + };
> + };
> +
> + ahb@80080000 {
> + usb1: usb@80090000 {
> + vbus-supply = <®_usb1_vbus>;
> + pinctrl-0 = <&usbphy1_pins_a>;
> + pinctrl-names = "default";
> + status = "okay";
> + };
> + };
> +
> + regulators {
> + compatible = "simple-bus";
> +
> + reg_usb1_vbus: usb1_vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio0 7 1>;
> + };
> + };
> +
> + ahb@80080000 {
> + mac0: ethernet@800f0000 {
> + phy-mode = "rmii";
> + pinctrl-names = "default";
> + pinctrl-0 = <&mac0_pins_a>;
> + phy-reset-gpios = <&gpio2 21 0>;
> + phy-reset-duration = <100>;
> + status = "okay";
> + };
> + };
> +
> + spi2 {
> + compatible = "spi-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi2_pins_cfa10056>;
> + status = "okay";
> + gpio-sck = <&gpio2 16 0>;
> + gpio-mosi = <&gpio2 17 0>;
> + gpio-miso = <&gpio2 18 0>;
> + cs-gpios = <&gpio3 5 0>;
> + num-chipselects = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hx8369: hx8369@0 {
> + compatible = "himax,hx8369a", "himax,hx8369";
> + reg = <0>;
> + spi-max-frequency = <100000>;
> + spi-cpol;
> + spi-cpha;
> + gpios-reset = <&gpio3 30 0>;
> + };
> + };
> +};
> --
> 1.8.1.2
>
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCHv2 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree
@ 2013-06-26 15:57 ` Maxime Ripard
0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2013-06-26 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 26, 2013 at 05:40:31PM +0200, Alexandre Belloni wrote:
> From: Brian Lilly <brian@crystalfontz.com>
>
> The CFA-10056 is a breakout board for the CFA-10036, and is
> basically a CFA-10037, with a 4.3" screen.
>
> Signed-off-by: Brian Lilly <brian@crystalfontz.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx28-cfa10056.dts | 171 +++++++++++++++++++++++++++++++++++
> 2 files changed, 172 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 225d939..d494f37 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
> imx28-cfa10037.dtb \
> imx28-cfa10049.dtb \
> imx28-cfa10055.dtb \
> + imx28-cfa10056.dtb \
> imx28-cfa10057.dtb \
> imx28-evk.dtb \
> imx28-m28evk.dtb \
> diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts b/arch/arm/boot/dts/imx28-cfa10056.dts
> new file mode 100644
> index 0000000..dd6d217
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx28-cfa10056.dts
> @@ -0,0 +1,171 @@
> +/*
> + * Copyright 2013 Free Electrons
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/*
> + * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
> + * need to include the CFA-10036 DTS.
> + */
> +/include/ "imx28-cfa10036.dts"
> +
> +/ {
> + model = "Crystalfontz CFA-10056 Board";
> + compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10036", "fsl,imx28";
> +
> + apb at 80000000 {
> + apbh at 80000000 {
> + pinctrl at 80018000 {
> + pinctrl-names = "default", "default";
> + pinctrl-1 = <&hog_pins_cfa10056
> + &hog_pins_cfa10056_pullup>;
> +
> + hog_pins_cfa10056: hog-10056 at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
> + 0x2153 /* MX28_PAD_SSP2_D5__GPIO_2_21 */
> + 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
These hogs pins don't have much sense anymore.
Maybe you should split out the three pins in:
- usb_pins_cfa10056
- mac0_pins_cfa10056
- move the last one in spi2_pins_cfa10056
> +
> + hog_pins_cfa10056_pullup: hog-10056-pullup at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x31e3 /* MX28_PAD_LCD_RESET__GPIO_3_30 */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <1>;
> + };
You could probably rename it to lcdif_pins_cfa10056_pullups or something
then, and make the lcdif driver grab these pins.
> +
> + spi2_pins_cfa10056: spi2-cfa10056 at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x2103 /* MX28_PAD_SSP2_SCK__GPIO_2_16 */
> + 0x2113 /* MX28_PAD_SSP2_CMD__GPIO_2_17 */
> + 0x2123 /* MX28_PAD_SSP2_D0__GPIO_2_18 */
> + >;
> + fsl,drive-strength = <1>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <1>;
> + };
> +
> + lcdif_pins_cfa10056: lcdif-evk at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */
> + 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */
> + 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */
> + 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> + };
> +
> + lcdif at 80030000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcdif_24bit_pins_a
> + &lcdif_pins_cfa10056>;
> + display = <&display>;
> + status = "okay";
> +
> + display: display {
> + bits-per-pixel = <32>;
> + bus-width = <24>;
> +
> + display-timings {
> + native-mode = <&timing0>;
> + timing0: timing0 {
> + clock-frequency = <32000000>;
> + hactive = <480>;
> + vactive = <800>;
> + hback-porch = <2>;
> + hfront-porch = <2>;
> + vback-porch = <2>;
> + vfront-porch = <2>;
> + hsync-len = <5>;
> + vsync-len = <5>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + de-active = <1>;
> + pixelclk-active = <1>;
> + };
> + };
> + };
> + };
> + };
> +
> + apbx at 80040000 {
> + usbphy1: usbphy at 8007e000 {
> + status = "okay";
> + };
> + };
> + };
> +
> + ahb at 80080000 {
> + usb1: usb at 80090000 {
> + vbus-supply = <®_usb1_vbus>;
> + pinctrl-0 = <&usbphy1_pins_a>;
> + pinctrl-names = "default";
> + status = "okay";
> + };
> + };
> +
> + regulators {
> + compatible = "simple-bus";
> +
> + reg_usb1_vbus: usb1_vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio0 7 1>;
> + };
> + };
> +
> + ahb at 80080000 {
> + mac0: ethernet at 800f0000 {
> + phy-mode = "rmii";
> + pinctrl-names = "default";
> + pinctrl-0 = <&mac0_pins_a>;
> + phy-reset-gpios = <&gpio2 21 0>;
> + phy-reset-duration = <100>;
> + status = "okay";
> + };
> + };
> +
> + spi2 {
> + compatible = "spi-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi2_pins_cfa10056>;
> + status = "okay";
> + gpio-sck = <&gpio2 16 0>;
> + gpio-mosi = <&gpio2 17 0>;
> + gpio-miso = <&gpio2 18 0>;
> + cs-gpios = <&gpio3 5 0>;
> + num-chipselects = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hx8369: hx8369 at 0 {
> + compatible = "himax,hx8369a", "himax,hx8369";
> + reg = <0>;
> + spi-max-frequency = <100000>;
> + spi-cpol;
> + spi-cpha;
> + gpios-reset = <&gpio3 30 0>;
> + };
> + };
> +};
> --
> 1.8.1.2
>
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/f0def45b/attachment-0001.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 3/3] ARM: mxs: dt: Add Crystalfontz CFA-10058 device tree
2013-06-26 15:40 ` Alexandre Belloni
@ 2013-06-26 15:58 ` Maxime Ripard
-1 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2013-06-26 15:58 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Shawn Guo, Russell King, jimwall, brian, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2696 bytes --]
Hi Alexandre,
On Wed, Jun 26, 2013 at 05:40:32PM +0200, Alexandre Belloni wrote:
> From: Brian Lilly <brian@crystalfontz.com>
>
> The CFA-10057 is a breakout board for the CFA-10036 that has Ethernet, USB and a
> 5" LCD screen on it.
>
> Signed-off-by: Brian Lilly <brian@crystalfontz.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx28-cfa10058.dts | 158 +++++++++++++++++++++++++++++++++++
> 2 files changed, 159 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx28-cfa10058.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d494f37..ddd6f32 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -133,6 +133,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
> imx28-cfa10055.dtb \
> imx28-cfa10056.dtb \
> imx28-cfa10057.dtb \
> + imx28-cfa10058.dtb \
> imx28-evk.dtb \
> imx28-m28evk.dtb \
> imx28-sps1.dtb \
> diff --git a/arch/arm/boot/dts/imx28-cfa10058.dts b/arch/arm/boot/dts/imx28-cfa10058.dts
> new file mode 100644
> index 0000000..99a21ac
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx28-cfa10058.dts
> @@ -0,0 +1,158 @@
> +/*
> + * Copyright 2013 Crystalfontz America, Inc.
> + * Copyright 2013 Free Electrons
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/*
> + * The CFA-10058 is an expansion board for the CFA-10036 module, thus we
> + * need to include the CFA-10036 DTS.
> + */
> +/include/ "imx28-cfa10036.dts"
> +
> +/ {
> + model = "Crystalfontz CFA-10058 Board";
> + compatible = "crystalfontz,cfa10058", "crystalfontz,cfa10036", "fsl,imx28";
> +
> + apb@80000000 {
> + apbh@80000000 {
> + pinctrl@80018000 {
> + pinctrl-names = "default", "default";
> + pinctrl-1 = <&hog_pins_cfa10058
> + &hog_pins_cfa10058_pullup>;
It doesn't compile, this node doesn't exist anymore.
> + hog_pins_cfa10058: hog-10058@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
> + 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
Again, we should probably split out these two pins into two different
nodes that would be grabed by their respective drivers.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCHv2 3/3] ARM: mxs: dt: Add Crystalfontz CFA-10058 device tree
@ 2013-06-26 15:58 ` Maxime Ripard
0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2013-06-26 15:58 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alexandre,
On Wed, Jun 26, 2013 at 05:40:32PM +0200, Alexandre Belloni wrote:
> From: Brian Lilly <brian@crystalfontz.com>
>
> The CFA-10057 is a breakout board for the CFA-10036 that has Ethernet, USB and a
> 5" LCD screen on it.
>
> Signed-off-by: Brian Lilly <brian@crystalfontz.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx28-cfa10058.dts | 158 +++++++++++++++++++++++++++++++++++
> 2 files changed, 159 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx28-cfa10058.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d494f37..ddd6f32 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -133,6 +133,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
> imx28-cfa10055.dtb \
> imx28-cfa10056.dtb \
> imx28-cfa10057.dtb \
> + imx28-cfa10058.dtb \
> imx28-evk.dtb \
> imx28-m28evk.dtb \
> imx28-sps1.dtb \
> diff --git a/arch/arm/boot/dts/imx28-cfa10058.dts b/arch/arm/boot/dts/imx28-cfa10058.dts
> new file mode 100644
> index 0000000..99a21ac
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx28-cfa10058.dts
> @@ -0,0 +1,158 @@
> +/*
> + * Copyright 2013 Crystalfontz America, Inc.
> + * Copyright 2013 Free Electrons
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/*
> + * The CFA-10058 is an expansion board for the CFA-10036 module, thus we
> + * need to include the CFA-10036 DTS.
> + */
> +/include/ "imx28-cfa10036.dts"
> +
> +/ {
> + model = "Crystalfontz CFA-10058 Board";
> + compatible = "crystalfontz,cfa10058", "crystalfontz,cfa10036", "fsl,imx28";
> +
> + apb at 80000000 {
> + apbh at 80000000 {
> + pinctrl at 80018000 {
> + pinctrl-names = "default", "default";
> + pinctrl-1 = <&hog_pins_cfa10058
> + &hog_pins_cfa10058_pullup>;
It doesn't compile, this node doesn't exist anymore.
> + hog_pins_cfa10058: hog-10058 at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */
> + 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */
Again, we should probably split out these two pins into two different
nodes that would be grabed by their respective drivers.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/6defb639/attachment-0001.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-06-26 15:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-26 15:40 [PATCHv2 0/3] ARM: mxs: Various Crystalfontz DT additions Alexandre Belloni
2013-06-26 15:40 ` Alexandre Belloni
2013-06-26 15:40 ` [PATCHv2 1/3] ARM: mxs: Simplify detection of CrystalFontz boards Alexandre Belloni
2013-06-26 15:40 ` Alexandre Belloni
2013-06-26 15:40 ` [PATCHv2 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree Alexandre Belloni
2013-06-26 15:40 ` Alexandre Belloni
2013-06-26 15:57 ` Maxime Ripard
2013-06-26 15:57 ` Maxime Ripard
2013-06-26 15:40 ` [PATCHv2 3/3] ARM: mxs: dt: Add Crystalfontz CFA-10058 " Alexandre Belloni
2013-06-26 15:40 ` Alexandre Belloni
2013-06-26 15:58 ` Maxime Ripard
2013-06-26 15:58 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.