* [U-Boot] [PATCH v1 1/1] patman: README documentation nits
@ 2013-06-27 7:12 Gerhard Sittig
2013-06-27 7:16 ` Simon Glass
2013-07-14 9:27 ` [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test) Gerhard Sittig
0 siblings, 2 replies; 6+ messages in thread
From: Gerhard Sittig @ 2013-06-27 7:12 UTC (permalink / raw)
To: u-boot
the -t flag appears to have a different meaning now, refer to the
--test option for the builtin unit test, and adjust a directory
location (it's 'tools/patman' instead of 'tools/scripts/patman')
Signed-off-by: Gerhard Sittig <gsi@denx.de>
---
tools/patman/README | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/patman/README b/tools/patman/README
index 8cffcd1..b26573a 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -452,12 +452,12 @@ Most of these are indicated by a TODO in the code.
It would be nice if this could handle the In-reply-to side of things.
-The tests are incomplete, as is customary. Use the -t flag to run them,
+The tests are incomplete, as is customary. Use the --test flag to run them,
and make sure you are in the tools/scripts/patman directory first:
$ cd /path/to/u-boot
- $ cd tools/scripts/patman
- $ patman -t
+ $ cd tools/patman
+ $ patman --test
Error handling doesn't always produce friendly error messages - e.g.
putting an incorrect tag in a commit may provide a confusing message.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v1 1/1] patman: README documentation nits
2013-06-27 7:12 [U-Boot] [PATCH v1 1/1] patman: README documentation nits Gerhard Sittig
@ 2013-06-27 7:16 ` Simon Glass
2013-07-14 9:27 ` [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test) Gerhard Sittig
1 sibling, 0 replies; 6+ messages in thread
From: Simon Glass @ 2013-06-27 7:16 UTC (permalink / raw)
To: u-boot
On Thu, Jun 27, 2013 at 12:12 AM, Gerhard Sittig <gsi@denx.de> wrote:
> the -t flag appears to have a different meaning now, refer to the
> --test option for the builtin unit test, and adjust a directory
> location (it's 'tools/patman' instead of 'tools/scripts/patman')
>
> Signed-off-by: Gerhard Sittig <gsi@denx.de>
>
Acked-by: Simon Glass <sjg@chromium.org>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test)
2013-06-27 7:12 [U-Boot] [PATCH v1 1/1] patman: README documentation nits Gerhard Sittig
2013-06-27 7:16 ` Simon Glass
@ 2013-07-14 9:27 ` Gerhard Sittig
2013-07-14 17:51 ` Simon Glass
2013-07-16 14:37 ` [U-Boot] [U-Boot, v2, " Tom Rini
1 sibling, 2 replies; 6+ messages in thread
From: Gerhard Sittig @ 2013-07-14 9:27 UTC (permalink / raw)
To: u-boot
adjust instructions for the invocation of Patman's self test: the -t
flag appears to have a different meaning now, refer to the --test option
for the builtin unit test; adjust a directory location and make sure to
run the file which resides in the source directory
Signed-off-by: Gerhard Sittig <gsi@denx.de>
---
tools/patman/README | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
changes in v2:
- fix another previously missed directory location
- prefix script with './' since '.' is usually not in $PATH
couldn't determine the appropriate subsystem/tree and corresponding
custodian for this patch, who'd pick it up and thus is to Cc: to?
Simon, can you take it?
diff --git a/tools/patman/README b/tools/patman/README
index 8cffcd1..c954989 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -452,12 +452,12 @@ Most of these are indicated by a TODO in the code.
It would be nice if this could handle the In-reply-to side of things.
-The tests are incomplete, as is customary. Use the -t flag to run them,
-and make sure you are in the tools/scripts/patman directory first:
+The tests are incomplete, as is customary. Use the --test flag to run them,
+and make sure you are in the tools/patman directory first:
$ cd /path/to/u-boot
- $ cd tools/scripts/patman
- $ patman -t
+ $ cd tools/patman
+ $ ./patman --test
Error handling doesn't always produce friendly error messages - e.g.
putting an incorrect tag in a commit may provide a confusing message.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test)
2013-07-14 9:27 ` [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test) Gerhard Sittig
@ 2013-07-14 17:51 ` Simon Glass
2013-07-15 15:50 ` Tom Rini
2013-07-16 14:37 ` [U-Boot] [U-Boot, v2, " Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Simon Glass @ 2013-07-14 17:51 UTC (permalink / raw)
To: u-boot
On Sun, Jul 14, 2013 at 2:27 AM, Gerhard Sittig <gsi@denx.de> wrote:
> adjust instructions for the invocation of Patman's self test: the -t
> flag appears to have a different meaning now, refer to the --test option
> for the builtin unit test; adjust a directory location and make sure to
> run the file which resides in the source directory
>
> Signed-off-by: Gerhard Sittig <gsi@denx.de>
>
Acked-by: Simon Glass <sjg@chromium.org>
Tom, would you like to pick this fix up now, or should I do it in the next
merge window?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test)
2013-07-14 17:51 ` Simon Glass
@ 2013-07-15 15:50 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2013-07-15 15:50 UTC (permalink / raw)
To: u-boot
On Sun, Jul 14, 2013 at 10:51:08AM -0700, Simon Glass wrote:
> On Sun, Jul 14, 2013 at 2:27 AM, Gerhard Sittig <gsi@denx.de> wrote:
>
> > adjust instructions for the invocation of Patman's self test: the -t
> > flag appears to have a different meaning now, refer to the --test option
> > for the builtin unit test; adjust a directory location and make sure to
> > run the file which resides in the source directory
> >
> > Signed-off-by: Gerhard Sittig <gsi@denx.de>
> >
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Tom, would you like to pick this fix up now, or should I do it in the next
> merge window?
I shall pick this up later today, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130715/f0212a1b/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-Boot, v2, 1/1] patman: README documentation nits (unit test)
2013-07-14 9:27 ` [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test) Gerhard Sittig
2013-07-14 17:51 ` Simon Glass
@ 2013-07-16 14:37 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2013-07-16 14:37 UTC (permalink / raw)
To: u-boot
On Sun, Jul 14, 2013 at 11:27:45AM +0200, Gerhard Sittig wrote:
> adjust instructions for the invocation of Patman's self test: the -t
> flag appears to have a different meaning now, refer to the --test option
> for the builtin unit test; adjust a directory location and make sure to
> run the file which resides in the source directory
>
> Signed-off-by: Gerhard Sittig <gsi@denx.de>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130716/08232977/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-16 14:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-27 7:12 [U-Boot] [PATCH v1 1/1] patman: README documentation nits Gerhard Sittig
2013-06-27 7:16 ` Simon Glass
2013-07-14 9:27 ` [U-Boot] [PATCH v2 1/1] patman: README documentation nits (unit test) Gerhard Sittig
2013-07-14 17:51 ` Simon Glass
2013-07-15 15:50 ` Tom Rini
2013-07-16 14:37 ` [U-Boot] [U-Boot, v2, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.