All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2] introduce a cache options for PV disks
Date: Thu, 27 Jun 2013 17:41:52 +0100	[thread overview]
Message-ID: <1372351312.8976.44.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20940.27003.695837.65658@mariner.uk.xensource.com>

On Thu, 2013-06-27 at 17:34 +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH v2] introduce a cache options for PV disks"):
> > Ian Campbell writes ("Re: [PATCH v2] introduce a cache options for PV disks"):
> > > On Thu, 2013-06-27 at 17:09 +0100, Ian Jackson wrote:
> > > > + *      So use of O_DIRECT is safe, in circumstances
> > > 
> > >            ^Some ?
> > > 
> > > Otherwise I can't parse this sentence.
> > 
> > Yes.
> 
> In, fact, no.  How about:
> 
>  *      That is, if this option is enabled, use of O_DIRECT is safe,
>  *      in circumstances where we would normally have avoided it as a
>  *      workaround for that bug.  This option is not relevant for ...

I think I can parse it now. It doesn't really say what the option does
though. I'd expect it to say something about "disabling the workaround"
or "the backend may use O_DIRECT".

Ian.

  reply	other threads:[~2013-06-27 16:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 11:40 [PATCH v2] introduce a cache options for PV disks Stefano Stabellini
2013-06-27 14:21 ` Ian Jackson
2013-06-27 16:09   ` Ian Jackson
2013-06-27 16:24     ` Ian Campbell
2013-06-27 16:30       ` Ian Jackson
2013-06-27 16:34         ` Ian Jackson
2013-06-27 16:41           ` Ian Campbell [this message]
2013-06-27 16:50             ` Ian Jackson
2013-06-27 16:58               ` Ian Campbell
2013-06-27 16:41         ` Ian Campbell
2013-06-27 16:35       ` Ian Jackson
2013-06-27 16:20 ` Ian Jackson
2013-06-27 17:06   ` Stefano Stabellini
2013-06-27 17:13     ` Stefano Stabellini
2013-06-27 17:44     ` Ian Jackson
2013-06-27 17:50       ` Stefano Stabellini
2013-06-27 17:59         ` Ian Jackson
2013-06-27 18:01         ` Ian Jackson
2013-06-27 18:04           ` Ian Jackson
2013-06-28  7:39             ` Ian Campbell
2013-06-27 18:12           ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372351312.8976.44.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.