* [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
@ 2013-07-02 19:16 ` Alexander Shiyan
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Shiyan @ 2013-07-02 19:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Kukjin Kim, linux-samsung-soc, Alexander Shiyan, Ben Dooks
When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
enable FIFO but actually switch command is missing in the code.
This patch adds this switching.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
index 4afc32f..f48dc0a 100644
--- a/arch/arm/plat-samsung/include/plat/uncompress.h
+++ b/arch/arm/plat-samsung/include/plat/uncompress.h
@@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
if (!(fifocon & S3C2410_UFCON_RESETBOTH))
break;
}
+
+ uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
}
}
#else
--
1.8.1.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
@ 2013-07-02 19:16 ` Alexander Shiyan
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Shiyan @ 2013-07-02 19:16 UTC (permalink / raw)
To: linux-arm-kernel
When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
enable FIFO but actually switch command is missing in the code.
This patch adds this switching.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
index 4afc32f..f48dc0a 100644
--- a/arch/arm/plat-samsung/include/plat/uncompress.h
+++ b/arch/arm/plat-samsung/include/plat/uncompress.h
@@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
if (!(fifocon & S3C2410_UFCON_RESETBOTH))
break;
}
+
+ uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
}
}
#else
--
1.8.1.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
2013-07-02 19:16 ` Alexander Shiyan
@ 2013-07-20 18:22 ` Alexander Shiyan
-1 siblings, 0 replies; 8+ messages in thread
From: Alexander Shiyan @ 2013-07-20 18:22 UTC (permalink / raw)
To: Alexander Shiyan
Cc: linux-arm-kernel, Kukjin Kim, linux-samsung-soc, Ben Dooks
On Tue, 2 Jul 2013 23:16:33 +0400
Alexander Shiyan <shc_work@mail.ru> wrote:
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switching.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
> index 4afc32f..f48dc0a 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
> if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> break;
> }
> +
> + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> }
> }
> #else
> --
> 1.8.1.5
Ping.
--
Alexander Shiyan <shc_work@mail.ru>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
@ 2013-07-20 18:22 ` Alexander Shiyan
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Shiyan @ 2013-07-20 18:22 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2 Jul 2013 23:16:33 +0400
Alexander Shiyan <shc_work@mail.ru> wrote:
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switching.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
> index 4afc32f..f48dc0a 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
> if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> break;
> }
> +
> + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> }
> }
> #else
> --
> 1.8.1.5
Ping.
--
Alexander Shiyan <shc_work@mail.ru>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
2013-07-02 19:16 ` Alexander Shiyan
@ 2013-07-22 17:10 ` Tomasz Figa
-1 siblings, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2013-07-22 17:10 UTC (permalink / raw)
To: Alexander Shiyan
Cc: linux-arm-kernel, linux-samsung-soc, Ben Dooks, Kukjin Kim
On Tuesday 02 of July 2013 23:16:33 Alexander Shiyan wrote:
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switching.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h
> b/arch/arm/plat-samsung/include/plat/uncompress.h index 4afc32f..f48dc0a
> 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
> if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> break;
> }
> +
> + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> }
> }
> #else
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
@ 2013-07-22 17:10 ` Tomasz Figa
0 siblings, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2013-07-22 17:10 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 02 of July 2013 23:16:33 Alexander Shiyan wrote:
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switching.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h
> b/arch/arm/plat-samsung/include/plat/uncompress.h index 4afc32f..f48dc0a
> 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
> if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> break;
> }
> +
> + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> }
> }
> #else
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
2013-07-02 19:16 ` Alexander Shiyan
@ 2013-08-18 20:17 ` Kukjin Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2013-08-18 20:17 UTC (permalink / raw)
To: Alexander Shiyan
Cc: linux-arm-kernel, Kukjin Kim, linux-samsung-soc, Ben Dooks
On 07/03/13 04:16, Alexander Shiyan wrote:
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switching.
>
> Signed-off-by: Alexander Shiyan<shc_work@mail.ru>
> ---
> arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
> index 4afc32f..f48dc0a 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
> if (!(fifocon& S3C2410_UFCON_RESETBOTH))
> break;
> }
> +
> + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> }
> }
> #else
Sorry for late response, applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function
@ 2013-08-18 20:17 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2013-08-18 20:17 UTC (permalink / raw)
To: linux-arm-kernel
On 07/03/13 04:16, Alexander Shiyan wrote:
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switching.
>
> Signed-off-by: Alexander Shiyan<shc_work@mail.ru>
> ---
> arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
> index 4afc32f..f48dc0a 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
> if (!(fifocon& S3C2410_UFCON_RESETBOTH))
> break;
> }
> +
> + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> }
> }
> #else
Sorry for late response, applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-08-18 20:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-02 19:16 [PATCH RESEND] ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function Alexander Shiyan
2013-07-02 19:16 ` Alexander Shiyan
2013-07-20 18:22 ` Alexander Shiyan
2013-07-20 18:22 ` Alexander Shiyan
2013-07-22 17:10 ` Tomasz Figa
2013-07-22 17:10 ` Tomasz Figa
2013-08-18 20:17 ` Kukjin Kim
2013-08-18 20:17 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.