[Buildroot] [PATCH v1] qt-webkit-kiosk: fix icu/qt5webkit dependecy propagation

[Buildroot] [PATCH v1] qt-webkit-kiosk: fix icu/qt5webkit dependecy propagation

[Peter Seiderer]

ICU depends on BR2_HOST_GCC_AT_LEAST_4_8 and BR2_TOOLCHAIN_GCC_AT_LEAST_4_8,
this dependencies are propagated to qt5webkit but where not propagated to
qt-webkit-kiosk.

Fixes [1]:

  The WebKit build was disabled for the following reasons:
      * ICU is required.
  [...]
  cp -dpf .../host/i686-buildroot-linux-uclibc/sysroot/usr/lib/libQt5WebKit*.so.* .../target/usr/lib
  cp: cannot stat `.../host/i686-buildroot-linux-uclibc/sysroot/usr/lib/libQt5WebKit*.so.*': No such file or directory

[1] http://autobuild.buildroot.net/results/2f3/2f381967c82775ad911a246a9607034ef489c1ce

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/qt-webkit-kiosk/Config.in | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/package/qt-webkit-kiosk/Config.in b/package/qt-webkit-kiosk/Config.in
index 703f128373..c613a8e6d8 100644
--- a/package/qt-webkit-kiosk/Config.in
+++ b/package/qt-webkit-kiosk/Config.in
@@ -3,7 +3,9 @@ config BR2_PACKAGE_QT_WEBKIT_KIOSK
 	depends on BR2_PACKAGE_QT5
 	depends on !BR2_STATIC_LIBS # qt5webkit
 	depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE # qt5webkit
-	depends on !BR2_BINFMT_FLAT # qt5webkit
+	depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu/qt5webkit
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu/qt5webkit
+	depends on !BR2_BINFMT_FLAT # icu/qt5webkit
 	depends on !BR2_MIPS_SOFT_FLOAT # qt5webkit
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_QT5BASE_GUI
@@ -21,3 +23,10 @@ config BR2_PACKAGE_QT_WEBKIT_KIOSK_SOUNDS
 	  Deploy browser sound files on target
 
 endif
+
+comment "qt-webkit-kiosk needs a toolchain w/ dynamic library, gcc >= 4.8, host gcc >= 4.8"
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
+		!BR2_HOST_GCC_AT_LEAST_4_8
+	depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
+	depends on !BR2_BINFMT_FLAT
+	depends on !BR2_MIPS_SOFT_FLOAT
-- 
2.11.0

[Buildroot] [PATCH v1] qt-webkit-kiosk: fix icu/qt5webkit dependecy propagation

[Arnout Vandecappelle]

On 27-07-17 21:24, Peter Seiderer wrote:
> ICU depends on BR2_HOST_GCC_AT_LEAST_4_8 and BR2_TOOLCHAIN_GCC_AT_LEAST_4_8,
> this dependencies are propagated to qt5webkit but where not propagated to
> qt-webkit-kiosk.
> 
> Fixes [1]:
> 
>   The WebKit build was disabled for the following reasons:
>       * ICU is required.
>   [...]
>   cp -dpf .../host/i686-buildroot-linux-uclibc/sysroot/usr/lib/libQt5WebKit*.so.* .../target/usr/lib
>   cp: cannot stat `.../host/i686-buildroot-linux-uclibc/sysroot/usr/lib/libQt5WebKit*.so.*': No such file or directory
> 
> [1] http://autobuild.buildroot.net/results/2f3/2f381967c82775ad911a246a9607034ef489c1ce
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>


 Applied to master with a few changes, thanks.

[Arnout:
 - rewrap commit message
 - fix spelling mistakes in commit message
 - reformulate the dependency comments]

 Regards,
 Arnout

[snip]
-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF