* [PATCH] xen: remove unused Kconfig parameter
@ 2013-07-08 6:28 Michael Opdenacker
0 siblings, 0 replies; 6+ messages in thread
From: Michael Opdenacker @ 2013-07-08 6:28 UTC (permalink / raw)
To: konrad.wilk, jeremy, tglx, mingo, hpa
Cc: Michael Opdenacker, linux-kernel, x86, xen-devel, virtualization
This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
configuration parameter defined in arch/x86/xen/Kconfig, but used
nowhere in the makefiles and source code.
This dummy parameter was added 3 years back, and it may
make sense to remove it now, as the reasons to use it were not
very clear.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
arch/x86/xen/Kconfig | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 1a3c765..b6401dc 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -19,11 +19,6 @@ config XEN_DOM0
depends on XEN && PCI_XEN && SWIOTLB_XEN
depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
-# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
-# name in tools.
-config XEN_PRIVILEGED_GUEST
- def_bool XEN_DOM0
-
config XEN_PVHVM
def_bool y
depends on XEN && PCI && X86_LOCAL_APIC
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: remove unused Kconfig parameter
2013-07-08 19:28 ` Konrad Rzeszutek Wilk
@ 2013-07-08 20:13 ` H. Peter Anvin
-1 siblings, 0 replies; 6+ messages in thread
From: H. Peter Anvin @ 2013-07-08 20:13 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Michael Opdenacker, jeremy, tglx, mingo, x86, xen-devel,
virtualization, linux-kernel
On 07/08/2013 12:28 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Jul 08, 2013 at 08:28:24AM +0200, Michael Opdenacker wrote:
>> This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
>> configuration parameter defined in arch/x86/xen/Kconfig, but used
>> nowhere in the makefiles and source code.
>>
>> This dummy parameter was added 3 years back, and it may
>> make sense to remove it now, as the reasons to use it were not
>> very clear.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
>
> Can't remove it. It is used by grub2.
>
What the fsck does grub2 have to do with Kconfig?
-hpa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: remove unused Kconfig parameter
@ 2013-07-08 20:13 ` H. Peter Anvin
0 siblings, 0 replies; 6+ messages in thread
From: H. Peter Anvin @ 2013-07-08 20:13 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: jeremy, xen-devel, Michael Opdenacker, x86, linux-kernel,
virtualization, mingo, tglx
On 07/08/2013 12:28 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Jul 08, 2013 at 08:28:24AM +0200, Michael Opdenacker wrote:
>> This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
>> configuration parameter defined in arch/x86/xen/Kconfig, but used
>> nowhere in the makefiles and source code.
>>
>> This dummy parameter was added 3 years back, and it may
>> make sense to remove it now, as the reasons to use it were not
>> very clear.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
>
> Can't remove it. It is used by grub2.
>
What the fsck does grub2 have to do with Kconfig?
-hpa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: remove unused Kconfig parameter
2013-07-08 6:28 Michael Opdenacker
@ 2013-07-08 19:28 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-07-08 19:28 UTC (permalink / raw)
To: Michael Opdenacker
Cc: jeremy, tglx, mingo, hpa, x86, xen-devel, virtualization, linux-kernel
On Mon, Jul 08, 2013 at 08:28:24AM +0200, Michael Opdenacker wrote:
> This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
> configuration parameter defined in arch/x86/xen/Kconfig, but used
> nowhere in the makefiles and source code.
>
> This dummy parameter was added 3 years back, and it may
> make sense to remove it now, as the reasons to use it were not
> very clear.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Can't remove it. It is used by grub2.
> ---
> arch/x86/xen/Kconfig | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> index 1a3c765..b6401dc 100644
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -19,11 +19,6 @@ config XEN_DOM0
> depends on XEN && PCI_XEN && SWIOTLB_XEN
> depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
>
> -# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
> -# name in tools.
> -config XEN_PRIVILEGED_GUEST
> - def_bool XEN_DOM0
> -
> config XEN_PVHVM
> def_bool y
> depends on XEN && PCI && X86_LOCAL_APIC
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: remove unused Kconfig parameter
@ 2013-07-08 19:28 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-07-08 19:28 UTC (permalink / raw)
To: Michael Opdenacker
Cc: jeremy, xen-devel, x86, linux-kernel, virtualization, mingo, hpa, tglx
On Mon, Jul 08, 2013 at 08:28:24AM +0200, Michael Opdenacker wrote:
> This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
> configuration parameter defined in arch/x86/xen/Kconfig, but used
> nowhere in the makefiles and source code.
>
> This dummy parameter was added 3 years back, and it may
> make sense to remove it now, as the reasons to use it were not
> very clear.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Can't remove it. It is used by grub2.
> ---
> arch/x86/xen/Kconfig | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> index 1a3c765..b6401dc 100644
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -19,11 +19,6 @@ config XEN_DOM0
> depends on XEN && PCI_XEN && SWIOTLB_XEN
> depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
>
> -# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
> -# name in tools.
> -config XEN_PRIVILEGED_GUEST
> - def_bool XEN_DOM0
> -
> config XEN_PVHVM
> def_bool y
> depends on XEN && PCI && X86_LOCAL_APIC
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen: remove unused Kconfig parameter
@ 2013-07-08 6:28 Michael Opdenacker
2013-07-08 19:28 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2013-07-08 6:28 UTC (permalink / raw)
To: konrad.wilk, jeremy, tglx, mingo, hpa
Cc: x86, xen-devel, virtualization, linux-kernel, Michael Opdenacker
This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
configuration parameter defined in arch/x86/xen/Kconfig, but used
nowhere in the makefiles and source code.
This dummy parameter was added 3 years back, and it may
make sense to remove it now, as the reasons to use it were not
very clear.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
arch/x86/xen/Kconfig | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 1a3c765..b6401dc 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -19,11 +19,6 @@ config XEN_DOM0
depends on XEN && PCI_XEN && SWIOTLB_XEN
depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
-# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
-# name in tools.
-config XEN_PRIVILEGED_GUEST
- def_bool XEN_DOM0
-
config XEN_PVHVM
def_bool y
depends on XEN && PCI && X86_LOCAL_APIC
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-08 20:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-08 6:28 [PATCH] xen: remove unused Kconfig parameter Michael Opdenacker
2013-07-08 6:28 Michael Opdenacker
2013-07-08 19:28 ` Konrad Rzeszutek Wilk
2013-07-08 19:28 ` Konrad Rzeszutek Wilk
2013-07-08 20:13 ` H. Peter Anvin
2013-07-08 20:13 ` H. Peter Anvin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.