* [PATCH v2 0/2] Enable lm90 in Tegra30 and Tegra114.
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
This series is v2, previous version patches:
[RFC 1/9]: http://thread.gmane.org/gmane.linux.power-management.general/31056
[v1]: http://thread.gmane.org/gmane.linux.ports.tegra/11713/
Changes from v1:
1. add vendor strings "onnn" for nct1008 node.
Changes from RFC:
1. Enable it for Tegra114 Dalmore.
Wei Ni (2):
ARM: dt: t30 cardhu: add dt entry for nct1008
ARM: dt: t114 dalmore: add dt entry for nct1008
arch/arm/boot/dts/tegra114-dalmore.dts | 7 +++++++
arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
2 files changed, 14 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 0/2] Enable lm90 in Tegra30 and Tegra114.
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
This series is v2, previous version patches:
[RFC 1/9]: http://thread.gmane.org/gmane.linux.power-management.general/31056
[v1]: http://thread.gmane.org/gmane.linux.ports.tegra/11713/
Changes from v1:
1. add vendor strings "onnn" for nct1008 node.
Changes from RFC:
1. Enable it for Tegra114 Dalmore.
Wei Ni (2):
ARM: dt: t30 cardhu: add dt entry for nct1008
ARM: dt: t114 dalmore: add dt entry for nct1008
arch/arm/boot/dts/tegra114-dalmore.dts | 7 +++++++
arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
2 files changed, 14 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [lm-sensors] [PATCH v2 0/2] Enable lm90 in Tegra30 and Tegra114.
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
This series is v2, previous version patches:
[RFC 1/9]: http://thread.gmane.org/gmane.linux.power-management.general/31056
[v1]: http://thread.gmane.org/gmane.linux.ports.tegra/11713/
Changes from v1:
1. add vendor strings "onnn" for nct1008 node.
Changes from RFC:
1. Enable it for Tegra114 Dalmore.
Wei Ni (2):
ARM: dt: t30 cardhu: add dt entry for nct1008
ARM: dt: t114 dalmore: add dt entry for nct1008
arch/arm/boot/dts/tegra114-dalmore.dts | 7 +++++++
arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
2 files changed, 14 insertions(+)
--
1.7.9.5
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
2013-07-10 11:29 ` Wei Ni
(?)
@ 2013-07-10 11:29 ` Wei Ni
-1 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor nct1008 for t30 cardhu.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index f65b53d..3d568a1 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -286,6 +286,13 @@
};
};
};
+
+ nct1008: nct1008 {
+ compatible = "onnn,nct1008";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio>;
+ interrupts = <TEGRA_GPIO(CC, 2) IRQ_TYPE_LEVEL_LOW>;
+ };
};
spi@7000da00 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor nct1008 for t30 cardhu.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index f65b53d..3d568a1 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -286,6 +286,13 @@
};
};
};
+
+ nct1008: nct1008 {
+ compatible = "onnn,nct1008";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio>;
+ interrupts = <TEGRA_GPIO(CC, 2) IRQ_TYPE_LEVEL_LOW>;
+ };
};
spi@7000da00 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [lm-sensors] [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor nct1008 for t30 cardhu.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index f65b53d..3d568a1 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -286,6 +286,13 @@
};
};
};
+
+ nct1008: nct1008 {
+ compatible = "onnn,nct1008";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio>;
+ interrupts = <TEGRA_GPIO(CC, 2) IRQ_TYPE_LEVEL_LOW>;
+ };
};
spi@7000da00 {
--
1.7.9.5
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008
2013-07-10 11:29 ` Wei Ni
(?)
@ 2013-07-10 11:29 ` Wei Ni
-1 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w
Cc: lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Wei Ni
Enable thermal sensor nct1008 for t114 dalmore.
Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arch/arm/boot/dts/tegra114-dalmore.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index cb640eb..95c5079 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -738,6 +738,13 @@
realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
};
+
+ nct1008: nct1008 {
+ compatible = "onnn,nct1008";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio>;
+ interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+ };
};
i2c@7000d000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali, swarren, linux, thierry.reding
Cc: lm-sensors, linux-kernel, linux-tegra, Wei Ni
Enable thermal sensor nct1008 for t114 dalmore.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
arch/arm/boot/dts/tegra114-dalmore.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index cb640eb..95c5079 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -738,6 +738,13 @@
realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
};
+
+ nct1008: nct1008 {
+ compatible = "onnn,nct1008";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio>;
+ interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+ };
};
i2c@7000d000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [lm-sensors] [PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008
@ 2013-07-10 11:29 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-10 11:29 UTC (permalink / raw)
To: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w
Cc: lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Wei Ni
Enable thermal sensor nct1008 for t114 dalmore.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
arch/arm/boot/dts/tegra114-dalmore.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index cb640eb..95c5079 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -738,6 +738,13 @@
realtek,ldo1-en-gpios <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
};
+
+ nct1008: nct1008 {
+ compatible = "onnn,nct1008";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio>;
+ interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+ };
};
i2c@7000d000 {
--
1.7.9.5
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
2013-07-10 11:29 ` Wei Ni
(?)
@ 2013-07-10 17:13 ` Thierry Reding
-1 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2013-07-10 17:13 UTC (permalink / raw)
To: Wei Ni
Cc: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ, lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t30 cardhu.
Nit: "Tegra30 Cardhu"
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
[...]
> };
> };
> };
> +
> + nct1008: nct1008 {
I don't think it's very likely that this chip will need to be referenced
by a phandle, in which case the "nct1008:" label can be dropped. Even if
it was used at some point in the future, it's better to add it at that
time.
Thierry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
@ 2013-07-10 17:13 ` Thierry Reding
0 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2013-07-10 17:13 UTC (permalink / raw)
To: Wei Ni; +Cc: khali, swarren, linux, lm-sensors, linux-kernel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t30 cardhu.
Nit: "Tegra30 Cardhu"
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
[...]
> };
> };
> };
> +
> + nct1008: nct1008 {
I don't think it's very likely that this chip will need to be referenced
by a phandle, in which case the "nct1008:" label can be dropped. Even if
it was used at some point in the future, it's better to add it at that
time.
Thierry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [lm-sensors] [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
@ 2013-07-10 17:13 ` Thierry Reding
0 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2013-07-10 17:13 UTC (permalink / raw)
To: Wei Ni
Cc: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ, lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1.1: Type: text/plain, Size: 515 bytes --]
On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t30 cardhu.
Nit: "Tegra30 Cardhu"
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
[...]
> };
> };
> };
> +
> + nct1008: nct1008 {
I don't think it's very likely that this chip will need to be referenced
by a phandle, in which case the "nct1008:" label can be dropped. Even if
it was used at some point in the future, it's better to add it at that
time.
Thierry
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008
2013-07-10 11:29 ` Wei Ni
(?)
@ 2013-07-10 17:14 ` Thierry Reding
-1 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2013-07-10 17:14 UTC (permalink / raw)
To: Wei Ni
Cc: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ, lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Wed, Jul 10, 2013 at 07:29:58PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t114 dalmore.
Nit: "Tegra114 Dalmore"
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
> + nct1008: nct1008 {
> + compatible = "onnn,nct1008";
> + reg = <0x4c>;
> + interrupt-parent = <&gpio>;
> + interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
> + };
The "nct1008:" label isn't needed here either.
Thierry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008
@ 2013-07-10 17:14 ` Thierry Reding
0 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2013-07-10 17:14 UTC (permalink / raw)
To: Wei Ni; +Cc: khali, swarren, linux, lm-sensors, linux-kernel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Wed, Jul 10, 2013 at 07:29:58PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t114 dalmore.
Nit: "Tegra114 Dalmore"
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
> + nct1008: nct1008 {
> + compatible = "onnn,nct1008";
> + reg = <0x4c>;
> + interrupt-parent = <&gpio>;
> + interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
> + };
The "nct1008:" label isn't needed here either.
Thierry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [lm-sensors] [PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008
@ 2013-07-10 17:14 ` Thierry Reding
0 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2013-07-10 17:14 UTC (permalink / raw)
To: Wei Ni
Cc: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ, lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]
On Wed, Jul 10, 2013 at 07:29:58PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t114 dalmore.
Nit: "Tegra114 Dalmore"
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
> + nct1008: nct1008 {
> + compatible = "onnn,nct1008";
> + reg = <0x4c>;
> + interrupt-parent = <&gpio>;
> + interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
> + };
The "nct1008:" label isn't needed here either.
Thierry
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
2013-07-10 17:13 ` Thierry Reding
(?)
@ 2013-07-11 8:34 ` Wei Ni
-1 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-11 8:34 UTC (permalink / raw)
To: Thierry Reding
Cc: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ, lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 07/11/2013 01:13 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
>> Enable thermal sensor nct1008 for t30 cardhu.
>
> Nit: "Tegra30 Cardhu"
>
>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> [...]
>> };
>> };
>> };
>> +
>> + nct1008: nct1008 {
>
> I don't think it's very likely that this chip will need to be referenced
> by a phandle, in which case the "nct1008:" label can be dropped. Even if
> it was used at some point in the future, it's better to add it at that
> time.
Ok, I will remove it.
In the future, I may use this node in the thermal framework, something like:
thermal_zone {
sensor = <&nct1008>;
cooling = <&xxxx>;
....
}
So, at that time I will try to add it again.
Thanks.
Wei.
>
> Thierry
>
> * Unknown Key
> * 0x7F3EB3A1
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
@ 2013-07-11 8:34 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-11 8:34 UTC (permalink / raw)
To: Thierry Reding
Cc: khali, swarren, linux, lm-sensors, linux-kernel, linux-tegra
On 07/11/2013 01:13 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
>> Enable thermal sensor nct1008 for t30 cardhu.
>
> Nit: "Tegra30 Cardhu"
>
>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> [...]
>> };
>> };
>> };
>> +
>> + nct1008: nct1008 {
>
> I don't think it's very likely that this chip will need to be referenced
> by a phandle, in which case the "nct1008:" label can be dropped. Even if
> it was used at some point in the future, it's better to add it at that
> time.
Ok, I will remove it.
In the future, I may use this node in the thermal framework, something like:
thermal_zone {
sensor = <&nct1008>;
cooling = <&xxxx>;
....
}
So, at that time I will try to add it again.
Thanks.
Wei.
>
> Thierry
>
> * Unknown Key
> * 0x7F3EB3A1
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [lm-sensors] [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008
@ 2013-07-11 8:34 ` Wei Ni
0 siblings, 0 replies; 18+ messages in thread
From: Wei Ni @ 2013-07-11 8:34 UTC (permalink / raw)
To: Thierry Reding
Cc: khali-PUYAD+kWke1g9hUCZPvPmw, swarren-3lzwWm7+Weoh9ZMKESR00Q,
linux-0h96xk9xTtrk1uMJSBkQmQ, lm-sensors-GZX6beZjE8VD60Wz+7aTrA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 07/11/2013 01:13 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
>> Enable thermal sensor nct1008 for t30 cardhu.
>
> Nit: "Tegra30 Cardhu"
>
>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> [...]
>> };
>> };
>> };
>> +
>> + nct1008: nct1008 {
>
> I don't think it's very likely that this chip will need to be referenced
> by a phandle, in which case the "nct1008:" label can be dropped. Even if
> it was used at some point in the future, it's better to add it at that
> time.
Ok, I will remove it.
In the future, I may use this node in the thermal framework, something like:
thermal_zone {
sensor = <&nct1008>;
cooling = <&xxxx>;
....
}
So, at that time I will try to add it again.
Thanks.
Wei.
>
> Thierry
>
> * Unknown Key
> * 0x7F3EB3A1
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-07-11 8:36 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-10 11:29 [PATCH v2 0/2] Enable lm90 in Tegra30 and Tegra114 Wei Ni
2013-07-10 11:29 ` [lm-sensors] " Wei Ni
2013-07-10 11:29 ` Wei Ni
2013-07-10 11:29 ` [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008 Wei Ni
2013-07-10 11:29 ` [lm-sensors] " Wei Ni
2013-07-10 11:29 ` Wei Ni
[not found] ` <1373455798-2944-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-10 17:13 ` Thierry Reding
2013-07-10 17:13 ` [lm-sensors] " Thierry Reding
2013-07-10 17:13 ` Thierry Reding
[not found] ` <20130710171319.GB15665-RcKxWJ4Cfj3FNiLNb7+IINdj8bHVeoWogfoxzgwHRXE@public.gmane.org>
2013-07-11 8:34 ` Wei Ni
2013-07-11 8:34 ` [lm-sensors] " Wei Ni
2013-07-11 8:34 ` Wei Ni
[not found] ` <1373455798-2944-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-10 11:29 ` [PATCH v2 2/2] ARM: dt: t114 dalmore: " Wei Ni
2013-07-10 11:29 ` [lm-sensors] " Wei Ni
2013-07-10 11:29 ` Wei Ni
[not found] ` <1373455798-2944-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-10 17:14 ` Thierry Reding
2013-07-10 17:14 ` [lm-sensors] " Thierry Reding
2013-07-10 17:14 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.