* [Buildroot] [PATCH] nodejs: not supported on old ARM cores
@ 2013-07-12 0:58 Gustavo Zacarias
2013-07-12 11:33 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2013-07-12 0:58 UTC (permalink / raw)
To: buildroot
nodejs needs the ARM blx instruction which is only supported in v5t+
cores (v5 ISA with thumb instructions).
Disable it for lower cores. Fixes:
http://autobuild.buildroot.net/results/89e/89ee5ba047a26a8c7a612d0285b08780b70efbd4/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/nodejs/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index aa65c6f..fea3480 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -5,6 +5,8 @@ config BR2_PACKAGE_NODEJS
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_arm || BR2_i386 || BR2_x86_64
+ # ARM needs BLX, so v5t+
+ depends on !(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t || BR2_arm922t || BR2_fa526)
# uses fork()
depends on BR2_USE_MMU
help
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] nodejs: not supported on old ARM cores
2013-07-12 0:58 [Buildroot] [PATCH] nodejs: not supported on old ARM cores Gustavo Zacarias
@ 2013-07-12 11:33 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2013-07-12 11:33 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> nodejs needs the ARM blx instruction which is only supported in v5t+
Gustavo> cores (v5 ISA with thumb instructions).
Gustavo> Disable it for lower cores. Fixes:
Gustavo> http://autobuild.buildroot.net/results/89e/89ee5ba047a26a8c7a612d0285b08780b70efbd4/
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-12 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-12 0:58 [Buildroot] [PATCH] nodejs: not supported on old ARM cores Gustavo Zacarias
2013-07-12 11:33 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.