* [PATCH] ath10k: pass also QOS Null frames through mgmt tx path
@ 2013-07-12 10:25 ` Janusz Dziedzic
0 siblings, 0 replies; 6+ messages in thread
From: Janusz Dziedzic @ 2013-07-12 10:25 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Janusz Dziedzic
Fw will report wrong tx status for QOS Null frames
sent through data tx path.
This patch fixes station(s) keep alive detection
triggered from wpa_supplicant/hostapd when work
as AP/GO and WMM enabled.
Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index da5c333..81b1a4b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -1398,11 +1398,15 @@ static void ath10k_tx_htt(struct ath10k *ar, struct sk_buff *skb)
if (ieee80211_is_mgmt(hdr->frame_control))
ret = ath10k_htt_mgmt_tx(ar->htt, skb);
- else if (ieee80211_is_nullfunc(hdr->frame_control))
- /* FW does not report tx status properly for NullFunc frames
- * unless they are sent through mgmt tx path. mac80211 sends
- * those frames when it detects link/beacon loss and depends on
- * the tx status to be correct. */
+ else if (ieee80211_is_nullfunc(hdr->frame_control) ||
+ ieee80211_is_qos_nullfunc(hdr->frame_control))
+ /* FW does not report tx status properly for NullFunc and
+ * QOS NullFunc frames unless they are sent through mgmt
+ * tx path. mac80211 sends those frames when it detects
+ * link/beacon loss and depends on the tx status to be
+ * correct. mac80211 also send those frames when probe_client
+ * in case of AP/GO mode.
+ */
ret = ath10k_htt_mgmt_tx(ar->htt, skb);
else
ret = ath10k_htt_tx(ar->htt, skb);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath10k: pass also QOS Null frames through mgmt tx path
@ 2013-07-12 10:25 ` Janusz Dziedzic
0 siblings, 0 replies; 6+ messages in thread
From: Janusz Dziedzic @ 2013-07-12 10:25 UTC (permalink / raw)
To: ath10k; +Cc: Janusz Dziedzic, linux-wireless
Fw will report wrong tx status for QOS Null frames
sent through data tx path.
This patch fixes station(s) keep alive detection
triggered from wpa_supplicant/hostapd when work
as AP/GO and WMM enabled.
Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index da5c333..81b1a4b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -1398,11 +1398,15 @@ static void ath10k_tx_htt(struct ath10k *ar, struct sk_buff *skb)
if (ieee80211_is_mgmt(hdr->frame_control))
ret = ath10k_htt_mgmt_tx(ar->htt, skb);
- else if (ieee80211_is_nullfunc(hdr->frame_control))
- /* FW does not report tx status properly for NullFunc frames
- * unless they are sent through mgmt tx path. mac80211 sends
- * those frames when it detects link/beacon loss and depends on
- * the tx status to be correct. */
+ else if (ieee80211_is_nullfunc(hdr->frame_control) ||
+ ieee80211_is_qos_nullfunc(hdr->frame_control))
+ /* FW does not report tx status properly for NullFunc and
+ * QOS NullFunc frames unless they are sent through mgmt
+ * tx path. mac80211 sends those frames when it detects
+ * link/beacon loss and depends on the tx status to be
+ * correct. mac80211 also send those frames when probe_client
+ * in case of AP/GO mode.
+ */
ret = ath10k_htt_mgmt_tx(ar->htt, skb);
else
ret = ath10k_htt_tx(ar->htt, skb);
--
1.7.9.5
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: pass also QOS Null frames through mgmt tx path
2013-07-12 10:25 ` Janusz Dziedzic
@ 2013-07-15 7:37 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2013-07-15 7:37 UTC (permalink / raw)
To: Janusz Dziedzic; +Cc: ath10k, linux-wireless
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Fw will report wrong tx status for QOS Null frames
> sent through data tx path.
>
> This patch fixes station(s) keep alive detection
> triggered from wpa_supplicant/hostapd when work
> as AP/GO and WMM enabled.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
I think you mentioned privately that this patch should be dropped. Is
that still the case?
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: pass also QOS Null frames through mgmt tx path
@ 2013-07-15 7:37 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2013-07-15 7:37 UTC (permalink / raw)
To: Janusz Dziedzic; +Cc: linux-wireless, ath10k
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Fw will report wrong tx status for QOS Null frames
> sent through data tx path.
>
> This patch fixes station(s) keep alive detection
> triggered from wpa_supplicant/hostapd when work
> as AP/GO and WMM enabled.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
I think you mentioned privately that this patch should be dropped. Is
that still the case?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: pass also QOS Null frames through mgmt tx path
2013-07-15 7:37 ` Kalle Valo
@ 2013-07-15 9:06 ` Janusz Dziedzic
-1 siblings, 0 replies; 6+ messages in thread
From: Janusz Dziedzic @ 2013-07-15 9:06 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
On 15 July 2013 09:37, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Fw will report wrong tx status for QOS Null frames
>> sent through data tx path.
>>
>> This patch fixes station(s) keep alive detection
>> triggered from wpa_supplicant/hostapd when work
>> as AP/GO and WMM enabled.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> I think you mentioned privately that this patch should be dropped. Is
> that still the case?
>
Yes, please drop this patch
BR
Janusz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: pass also QOS Null frames through mgmt tx path
@ 2013-07-15 9:06 ` Janusz Dziedzic
0 siblings, 0 replies; 6+ messages in thread
From: Janusz Dziedzic @ 2013-07-15 9:06 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath10k
On 15 July 2013 09:37, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Fw will report wrong tx status for QOS Null frames
>> sent through data tx path.
>>
>> This patch fixes station(s) keep alive detection
>> triggered from wpa_supplicant/hostapd when work
>> as AP/GO and WMM enabled.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> I think you mentioned privately that this patch should be dropped. Is
> that still the case?
>
Yes, please drop this patch
BR
Janusz
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-15 9:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-12 10:25 [PATCH] ath10k: pass also QOS Null frames through mgmt tx path Janusz Dziedzic
2013-07-12 10:25 ` Janusz Dziedzic
2013-07-15 7:37 ` Kalle Valo
2013-07-15 7:37 ` Kalle Valo
2013-07-15 9:06 ` Janusz Dziedzic
2013-07-15 9:06 ` Janusz Dziedzic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.