* [PATCH] brcmsmac: Further reduce log spam from tx phy messages
@ 2013-07-12 14:55 John Greene
2013-07-12 18:00 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: John Greene @ 2013-07-12 14:55 UTC (permalink / raw)
To: linville; +Cc: arend, linux-wireless
Relegate 2 phy messages to debug status as they create excessive
log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
This is a follow on to net-next 99e94940697adec4f84758adb2db71f4a82c7ba5:
brcmsmac: Reduce log spam in heavy tx, make err print in debug
brcmsmac bcma0:0: phyerr 0x10, rate 0x14
brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
ampdu tx phy error (0x10)
Signed-off-by: John Greene <jogreene@redhat.com>
---
drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 2 +-
drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
index bd98285..42efac7 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
@@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
}
} else if (txs->phyerr) {
update_rate = false;
- brcms_err(wlc->hw->d11core,
+ brcms_dbg_ht(wlc->hw->d11core,
"%s: ampdu tx phy error (0x%x)\n",
__func__, txs->phyerr);
}
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
index 9fd6f2f..fdb4c3f 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -882,7 +882,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
mcl = le16_to_cpu(txh->MacTxControlLow);
if (txs->phyerr)
- brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
+ brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
txs->phyerr, txh->MainRates);
if (txs->frameid != le16_to_cpu(txh->TxFrameID)) {
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
2013-07-12 14:55 [PATCH] brcmsmac: Further reduce log spam from tx phy messages John Greene
@ 2013-07-12 18:00 ` Joe Perches
2013-07-15 12:15 ` John Greene
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2013-07-12 18:00 UTC (permalink / raw)
To: John Greene; +Cc: linville, arend, linux-wireless
On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
> Relegate 2 phy messages to debug status as they create excessive
> log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
Hi John,
Just trivia:
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
[]
> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
[]
> - brcms_err(wlc->hw->d11core,
> + brcms_dbg_ht(wlc->hw->d11core,
> "%s: ampdu tx phy error (0x%x)\n",
> __func__, txs->phyerr);
Please keep the indentation of the arguments of
the same statement aligned to the open parenthesis.
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
[]
> @@ -882,7 +882,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
[]
> - brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
> + brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
> txs->phyerr, txh->MainRates);
Here too.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
2013-07-12 18:00 ` Joe Perches
@ 2013-07-15 12:15 ` John Greene
2013-07-15 12:23 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: John Greene @ 2013-07-15 12:15 UTC (permalink / raw)
To: Joe Perches; +Cc: linville, arend, linux-wireless
On 07/12/2013 02:00 PM, Joe Perches wrote:
> On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
>> Relegate 2 phy messages to debug status as they create excessive
>> log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
>
> Hi John,
>
> Just trivia:
>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> []
>> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> []
>> - brcms_err(wlc->hw->d11core,
>> + brcms_dbg_ht(wlc->hw->d11core,
>> "%s: ampdu tx phy error (0x%x)\n",
>> __func__, txs->phyerr);
>
> Please keep the indentation of the arguments of
> the same statement aligned to the open parenthesis.
>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> []
>> @@ -882,7 +882,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
> []
>> - brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> + brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> txs->phyerr, txh->MainRates);
>
> Here too.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thanks Joe. My oversight. I wish the checkpatch flagged this stuff.
I'll fix this and post v2.
--
John Greene
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
2013-07-15 12:15 ` John Greene
@ 2013-07-15 12:23 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2013-07-15 12:23 UTC (permalink / raw)
To: John Greene; +Cc: linville, arend, linux-wireless
On Mon, 2013-07-15 at 08:15 -0400, John Greene wrote:
> On 07/12/2013 02:00 PM, Joe Perches wrote:
> > On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
[]
> > Just trivia:
> >> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> > []
> >> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> > []
> >> - brcms_err(wlc->hw->d11core,
> >> + brcms_dbg_ht(wlc->hw->d11core,
> >> "%s: ampdu tx phy error (0x%x)\n",
> >> __func__, txs->phyerr);
> >
> > Please keep the indentation of the arguments of
> > the same statement aligned to the open parenthesis.
[]
> Thanks Joe. My oversight. I wish the checkpatch flagged this stuff.
It does if you use the --strict option.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-15 12:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-12 14:55 [PATCH] brcmsmac: Further reduce log spam from tx phy messages John Greene
2013-07-12 18:00 ` Joe Perches
2013-07-15 12:15 ` John Greene
2013-07-15 12:23 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.