All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2013-07-12 18:01 ` Aaron Plattner
  0 siblings, 0 replies; 15+ messages in thread
From: Aaron Plattner @ 2013-07-12 18:01 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: Aaron Plattner, alsa-devel, linux-kernel

Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.

Reviewed-by: Andy Ritger <aritger@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index e12f7a0..486def7 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
+{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
@@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
 MODULE_ALIAS("snd-hda-codec-id:10de0043");
 MODULE_ALIAS("snd-hda-codec-id:10de0044");
 MODULE_ALIAS("snd-hda-codec-id:10de0051");
+MODULE_ALIAS("snd-hda-codec-id:10de0060");
 MODULE_ALIAS("snd-hda-codec-id:10de0067");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:11069f80");
-- 
1.7.12


^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2013-07-12 18:01 ` Aaron Plattner
  0 siblings, 0 replies; 15+ messages in thread
From: Aaron Plattner @ 2013-07-12 18:01 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: Aaron Plattner, alsa-devel, linux-kernel

Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.

Reviewed-by: Andy Ritger <aritger@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index e12f7a0..486def7 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
+{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
@@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
 MODULE_ALIAS("snd-hda-codec-id:10de0043");
 MODULE_ALIAS("snd-hda-codec-id:10de0044");
 MODULE_ALIAS("snd-hda-codec-id:10de0051");
+MODULE_ALIAS("snd-hda-codec-id:10de0060");
 MODULE_ALIAS("snd-hda-codec-id:10de0067");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:11069f80");
-- 
1.7.12

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
  2013-07-12 18:01 ` Aaron Plattner
  (?)
@ 2013-07-14  4:05 ` Greg KH
  2013-07-15  8:27     ` Takashi Iwai
  -1 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2013-07-14  4:05 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel

On Fri, Jul 12, 2013 at 11:01:37AM -0700, Aaron Plattner wrote:
> Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.
> 
> Reviewed-by: Andy Ritger <aritger@nvidia.com>
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> ---
>  sound/pci/hda/patch_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index e12f7a0..486def7 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
> +{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> @@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
>  MODULE_ALIAS("snd-hda-codec-id:10de0043");
>  MODULE_ALIAS("snd-hda-codec-id:10de0044");
>  MODULE_ALIAS("snd-hda-codec-id:10de0051");
> +MODULE_ALIAS("snd-hda-codec-id:10de0060");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:11069f80");

Why are these module aliases being created by hand and not automated
like all other aliases that contain device ids like this are?

odd,

greg k-h

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
  2013-07-14  4:05 ` Greg KH
@ 2013-07-15  8:27     ` Takashi Iwai
  0 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2013-07-15  8:27 UTC (permalink / raw)
  To: Greg KH; +Cc: Aaron Plattner, Jaroslav Kysela, alsa-devel, linux-kernel

At Sat, 13 Jul 2013 21:05:01 -0700,
Greg KH wrote:
> 
> On Fri, Jul 12, 2013 at 11:01:37AM -0700, Aaron Plattner wrote:
> > Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.
> > 
> > Reviewed-by: Andy Ritger <aritger@nvidia.com>
> > Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> > ---
> >  sound/pci/hda/patch_hdmi.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> > index e12f7a0..486def7 100644
> > --- a/sound/pci/hda/patch_hdmi.c
> > +++ b/sound/pci/hda/patch_hdmi.c
> > @@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
> >  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
> >  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
> >  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
> > +{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
> >  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
> >  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
> >  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> > @@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0043");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0044");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0051");
> > +MODULE_ALIAS("snd-hda-codec-id:10de0060");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0067");
> >  MODULE_ALIAS("snd-hda-codec-id:10de8001");
> >  MODULE_ALIAS("snd-hda-codec-id:11069f80");
> 
> Why are these module aliases being created by hand and not automated
> like all other aliases that contain device ids like this are?

Because of the bad design :)

The HD-audio codec isn't created as a normal device but just as an own
object of HD-audio driver.  The module alias is used when hd-audio
codec driver loads its codec-specific code, and it does
request_module() manually.

The module alias isn't automated because there won't be much additions
that require manual alias any longer.  Most of new codecs are grouped
in the vendor id, thus no need for addition.  The only still necessary
case is HDMI audio like this, and there will be only a few per year at
most.

Of course, it'd be better to be moved to a more standard model, but
it's been left as is, partly due to a historical reason, partly not to
break the current user-space setup, and partly lack of my time.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2013-07-15  8:27     ` Takashi Iwai
  0 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2013-07-15  8:27 UTC (permalink / raw)
  To: Greg KH; +Cc: alsa-devel, linux-kernel, Aaron Plattner

At Sat, 13 Jul 2013 21:05:01 -0700,
Greg KH wrote:
> 
> On Fri, Jul 12, 2013 at 11:01:37AM -0700, Aaron Plattner wrote:
> > Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.
> > 
> > Reviewed-by: Andy Ritger <aritger@nvidia.com>
> > Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> > ---
> >  sound/pci/hda/patch_hdmi.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> > index e12f7a0..486def7 100644
> > --- a/sound/pci/hda/patch_hdmi.c
> > +++ b/sound/pci/hda/patch_hdmi.c
> > @@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
> >  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
> >  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
> >  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
> > +{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
> >  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
> >  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
> >  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> > @@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0043");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0044");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0051");
> > +MODULE_ALIAS("snd-hda-codec-id:10de0060");
> >  MODULE_ALIAS("snd-hda-codec-id:10de0067");
> >  MODULE_ALIAS("snd-hda-codec-id:10de8001");
> >  MODULE_ALIAS("snd-hda-codec-id:11069f80");
> 
> Why are these module aliases being created by hand and not automated
> like all other aliases that contain device ids like this are?

Because of the bad design :)

The HD-audio codec isn't created as a normal device but just as an own
object of HD-audio driver.  The module alias is used when hd-audio
codec driver loads its codec-specific code, and it does
request_module() manually.

The module alias isn't automated because there won't be much additions
that require manual alias any longer.  Most of new codecs are grouped
in the vendor id, thus no need for addition.  The only still necessary
case is HDMI audio like this, and there will be only a few per year at
most.

Of course, it'd be better to be moved to a more standard model, but
it's been left as is, partly due to a historical reason, partly not to
break the current user-space setup, and partly lack of my time.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
  2013-07-12 18:01 ` Aaron Plattner
@ 2013-07-16  6:27   ` Takashi Iwai
  -1 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2013-07-16  6:27 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel

At Fri, 12 Jul 2013 11:01:37 -0700,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.
> 
> Reviewed-by: Andy Ritger <aritger@nvidia.com>
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>

Forgot to mention that the patch was applied.

Thanks.


Takashi

> ---
>  sound/pci/hda/patch_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index e12f7a0..486def7 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
> +{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> @@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
>  MODULE_ALIAS("snd-hda-codec-id:10de0043");
>  MODULE_ALIAS("snd-hda-codec-id:10de0044");
>  MODULE_ALIAS("snd-hda-codec-id:10de0051");
> +MODULE_ALIAS("snd-hda-codec-id:10de0060");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:11069f80");
> -- 
> 1.7.12
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2013-07-16  6:27   ` Takashi Iwai
  0 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2013-07-16  6:27 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel

At Fri, 12 Jul 2013 11:01:37 -0700,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip.
> 
> Reviewed-by: Andy Ritger <aritger@nvidia.com>
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>

Forgot to mention that the patch was applied.

Thanks.


Takashi

> ---
>  sound/pci/hda/patch_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index e12f7a0..486def7 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -2536,6 +2536,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
> +{ .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> @@ -2588,6 +2589,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0042");
>  MODULE_ALIAS("snd-hda-codec-id:10de0043");
>  MODULE_ALIAS("snd-hda-codec-id:10de0044");
>  MODULE_ALIAS("snd-hda-codec-id:10de0051");
> +MODULE_ALIAS("snd-hda-codec-id:10de0060");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:11069f80");
> -- 
> 1.7.12
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
  2014-05-13  3:05 ` Aaron Plattner
@ 2014-05-13  7:14   ` Takashi Iwai
  -1 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2014-05-13  7:14 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: Stephen Warren, alsa-devel, linux-kernel, Jaroslav Kysela

At Mon, 12 May 2014 20:05:02 -0700,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de0071 is used by a yet-to-be-named GPU chip.
> 
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
> I verified that the patch_nvhdmi code is still needed for this chip.

Thanks, applied.


Takashi

> 
>  sound/pci/hda/patch_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 0cb5b89cd0c8..347a84b58c39 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -3330,6 +3330,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
> +{ .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
>  { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> @@ -3385,6 +3386,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0044");
>  MODULE_ALIAS("snd-hda-codec-id:10de0051");
>  MODULE_ALIAS("snd-hda-codec-id:10de0060");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
> +MODULE_ALIAS("snd-hda-codec-id:10de0071");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:11069f80");
>  MODULE_ALIAS("snd-hda-codec-id:11069f81");
> -- 
> 1.9.2
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2014-05-13  7:14   ` Takashi Iwai
  0 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2014-05-13  7:14 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: Stephen Warren, alsa-devel, linux-kernel, Jaroslav Kysela

At Mon, 12 May 2014 20:05:02 -0700,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de0071 is used by a yet-to-be-named GPU chip.
> 
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
> I verified that the patch_nvhdmi code is still needed for this chip.

Thanks, applied.


Takashi

> 
>  sound/pci/hda/patch_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 0cb5b89cd0c8..347a84b58c39 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -3330,6 +3330,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
> +{ .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
>  { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> @@ -3385,6 +3386,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0044");
>  MODULE_ALIAS("snd-hda-codec-id:10de0051");
>  MODULE_ALIAS("snd-hda-codec-id:10de0060");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
> +MODULE_ALIAS("snd-hda-codec-id:10de0071");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:11069f80");
>  MODULE_ALIAS("snd-hda-codec-id:11069f81");
> -- 
> 1.9.2
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2014-05-13  3:05 ` Aaron Plattner
  0 siblings, 0 replies; 15+ messages in thread
From: Aaron Plattner @ 2014-05-13  3:05 UTC (permalink / raw)
  To: Stephen Warren, Takashi Iwai
  Cc: Aaron Plattner, alsa-devel, linux-kernel, Jaroslav Kysela

Vendor ID 0x10de0071 is used by a yet-to-be-named GPU chip.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Stephen Warren <swarren@nvidia.com>
---
I verified that the patch_nvhdmi code is still needed for this chip.

 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 0cb5b89cd0c8..347a84b58c39 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3330,6 +3330,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
+{ .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
 { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
@@ -3385,6 +3386,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0044");
 MODULE_ALIAS("snd-hda-codec-id:10de0051");
 MODULE_ALIAS("snd-hda-codec-id:10de0060");
 MODULE_ALIAS("snd-hda-codec-id:10de0067");
+MODULE_ALIAS("snd-hda-codec-id:10de0071");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:11069f80");
 MODULE_ALIAS("snd-hda-codec-id:11069f81");
-- 
1.9.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2014-05-13  3:05 ` Aaron Plattner
  0 siblings, 0 replies; 15+ messages in thread
From: Aaron Plattner @ 2014-05-13  3:05 UTC (permalink / raw)
  To: Stephen Warren, Takashi Iwai
  Cc: Aaron Plattner, alsa-devel, linux-kernel, Jaroslav Kysela

Vendor ID 0x10de0071 is used by a yet-to-be-named GPU chip.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Stephen Warren <swarren@nvidia.com>
---
I verified that the patch_nvhdmi code is still needed for this chip.

 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 0cb5b89cd0c8..347a84b58c39 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3330,6 +3330,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de0060, .name = "GPU 60 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
+{ .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
 { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
@@ -3385,6 +3386,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0044");
 MODULE_ALIAS("snd-hda-codec-id:10de0051");
 MODULE_ALIAS("snd-hda-codec-id:10de0060");
 MODULE_ALIAS("snd-hda-codec-id:10de0067");
+MODULE_ALIAS("snd-hda-codec-id:10de0071");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:11069f80");
 MODULE_ALIAS("snd-hda-codec-id:11069f81");
-- 
1.9.2

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
  2012-07-17  0:10 ` Aaron Plattner
@ 2012-07-17  5:45   ` Takashi Iwai
  -1 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2012-07-17  5:45 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel

At Mon, 16 Jul 2012 17:10:04 -0700,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip.
> 
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> Acked-by: Andy Ritger <aritger@nvidia.com>
> Reviewed-by: Daniel Dadap <ddadap@nvidia.com>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/hda/patch_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index ad319d4..4efe741 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1902,6 +1902,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0042, .name = "GPU 42 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
> +{ .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x80860054, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
> @@ -1948,6 +1949,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0041");
>  MODULE_ALIAS("snd-hda-codec-id:10de0042");
>  MODULE_ALIAS("snd-hda-codec-id:10de0043");
>  MODULE_ALIAS("snd-hda-codec-id:10de0044");
> +MODULE_ALIAS("snd-hda-codec-id:10de0051");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:17e80047");
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2012-07-17  5:45   ` Takashi Iwai
  0 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2012-07-17  5:45 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: alsa-devel, linux-kernel

At Mon, 16 Jul 2012 17:10:04 -0700,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip.
> 
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> Acked-by: Andy Ritger <aritger@nvidia.com>
> Reviewed-by: Daniel Dadap <ddadap@nvidia.com>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/hda/patch_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index ad319d4..4efe741 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1902,6 +1902,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0042, .name = "GPU 42 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
> +{ .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
>  { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x80860054, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
> @@ -1948,6 +1949,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0041");
>  MODULE_ALIAS("snd-hda-codec-id:10de0042");
>  MODULE_ALIAS("snd-hda-codec-id:10de0043");
>  MODULE_ALIAS("snd-hda-codec-id:10de0044");
> +MODULE_ALIAS("snd-hda-codec-id:10de0051");
>  MODULE_ALIAS("snd-hda-codec-id:10de0067");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:17e80047");
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2012-07-17  0:10 ` Aaron Plattner
  0 siblings, 0 replies; 15+ messages in thread
From: Aaron Plattner @ 2012-07-17  0:10 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela; +Cc: Aaron Plattner, alsa-devel, linux-kernel

Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Acked-by: Andy Ritger <aritger@nvidia.com>
Reviewed-by: Daniel Dadap <ddadap@nvidia.com>
---
 sound/pci/hda/patch_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index ad319d4..4efe741 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1902,6 +1902,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0042, .name = "GPU 42 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
+{ .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x80860054, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
@@ -1948,6 +1949,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0041");
 MODULE_ALIAS("snd-hda-codec-id:10de0042");
 MODULE_ALIAS("snd-hda-codec-id:10de0043");
 MODULE_ALIAS("snd-hda-codec-id:10de0044");
+MODULE_ALIAS("snd-hda-codec-id:10de0051");
 MODULE_ALIAS("snd-hda-codec-id:10de0067");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:17e80047");
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
@ 2012-07-17  0:10 ` Aaron Plattner
  0 siblings, 0 replies; 15+ messages in thread
From: Aaron Plattner @ 2012-07-17  0:10 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela; +Cc: Aaron Plattner, alsa-devel, linux-kernel

Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Acked-by: Andy Ritger <aritger@nvidia.com>
Reviewed-by: Daniel Dadap <ddadap@nvidia.com>
---
 sound/pci/hda/patch_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index ad319d4..4efe741 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1902,6 +1902,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0042, .name = "GPU 42 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0043, .name = "GPU 43 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0044, .name = "GPU 44 HDMI/DP",	.patch = patch_generic_hdmi },
+{ .id = 0x10de0051, .name = "GPU 51 HDMI/DP",	.patch = patch_generic_hdmi },
 { .id = 0x10de0067, .name = "MCP67 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x80860054, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
@@ -1948,6 +1949,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0041");
 MODULE_ALIAS("snd-hda-codec-id:10de0042");
 MODULE_ALIAS("snd-hda-codec-id:10de0043");
 MODULE_ALIAS("snd-hda-codec-id:10de0044");
+MODULE_ALIAS("snd-hda-codec-id:10de0051");
 MODULE_ALIAS("snd-hda-codec-id:10de0067");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:17e80047");
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2014-05-13  7:14 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-12 18:01 [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda Aaron Plattner
2013-07-12 18:01 ` Aaron Plattner
2013-07-14  4:05 ` Greg KH
2013-07-15  8:27   ` Takashi Iwai
2013-07-15  8:27     ` Takashi Iwai
2013-07-16  6:27 ` Takashi Iwai
2013-07-16  6:27   ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2014-05-13  3:05 Aaron Plattner
2014-05-13  3:05 ` Aaron Plattner
2014-05-13  7:14 ` Takashi Iwai
2014-05-13  7:14   ` Takashi Iwai
2012-07-17  0:10 Aaron Plattner
2012-07-17  0:10 ` Aaron Plattner
2012-07-17  5:45 ` Takashi Iwai
2012-07-17  5:45   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.