* [PATCH] tcp: account all retransmit failures
@ 2013-07-12 18:33 Yuchung Cheng
2013-07-12 18:38 ` Neal Cardwell
2013-07-12 18:55 ` Eric Dumazet
0 siblings, 2 replies; 4+ messages in thread
From: Yuchung Cheng @ 2013-07-12 18:33 UTC (permalink / raw)
To: davem, ncardwell, edumazet; +Cc: netdev, Yuchung Cheng
Change snmp RETRANSFAILS stat to include timeout retransmit failures
in addition to other loss recoveries.
Signed-off-by: Yuchung Cheng <ycheng@google.com>
---
net/ipv4/tcp_output.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 3d60949..92fde8d 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2407,6 +2407,8 @@ int tcp_retransmit_skb(struct sock *sk, struct sk_buff *skb)
* see tcp_input.c tcp_sacktag_write_queue().
*/
TCP_SKB_CB(skb)->ack_seq = tp->snd_nxt;
+ } else {
+ NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL);
}
return err;
}
@@ -2528,10 +2530,9 @@ begin_fwd:
if (sacked & (TCPCB_SACKED_ACKED|TCPCB_SACKED_RETRANS))
continue;
- if (tcp_retransmit_skb(sk, skb)) {
- NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL);
+ if (tcp_retransmit_skb(sk, skb))
return;
- }
+
NET_INC_STATS_BH(sock_net(sk), mib_idx);
if (tcp_in_cwnd_reduction(sk))
--
1.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tcp: account all retransmit failures
2013-07-12 18:33 [PATCH] tcp: account all retransmit failures Yuchung Cheng
@ 2013-07-12 18:38 ` Neal Cardwell
2013-07-12 18:55 ` Eric Dumazet
1 sibling, 0 replies; 4+ messages in thread
From: Neal Cardwell @ 2013-07-12 18:38 UTC (permalink / raw)
To: Yuchung Cheng; +Cc: David Miller, Eric Dumazet, Netdev
On Fri, Jul 12, 2013 at 2:33 PM, Yuchung Cheng <ycheng@google.com> wrote:
> Change snmp RETRANSFAILS stat to include timeout retransmit failures
> in addition to other loss recoveries.
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> ---
Acked-by: Neal Cardwell <ncardwell@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tcp: account all retransmit failures
2013-07-12 18:33 [PATCH] tcp: account all retransmit failures Yuchung Cheng
2013-07-12 18:38 ` Neal Cardwell
@ 2013-07-12 18:55 ` Eric Dumazet
2013-07-12 23:16 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2013-07-12 18:55 UTC (permalink / raw)
To: Yuchung Cheng; +Cc: davem, ncardwell, edumazet, netdev
On Fri, 2013-07-12 at 11:33 -0700, Yuchung Cheng wrote:
> Change snmp RETRANSFAILS stat to include timeout retransmit failures
> in addition to other loss recoveries.
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tcp: account all retransmit failures
2013-07-12 18:55 ` Eric Dumazet
@ 2013-07-12 23:16 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-07-12 23:16 UTC (permalink / raw)
To: eric.dumazet; +Cc: ycheng, ncardwell, edumazet, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 12 Jul 2013 11:55:54 -0700
> On Fri, 2013-07-12 at 11:33 -0700, Yuchung Cheng wrote:
>> Change snmp RETRANSFAILS stat to include timeout retransmit failures
>> in addition to other loss recoveries.
>>
>> Signed-off-by: Yuchung Cheng <ycheng@google.com>
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-12 23:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-12 18:33 [PATCH] tcp: account all retransmit failures Yuchung Cheng
2013-07-12 18:38 ` Neal Cardwell
2013-07-12 18:55 ` Eric Dumazet
2013-07-12 23:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.