All of lore.kernel.org
 help / color / mirror / Atom feed
* [pull] radeon drm-fixes-3.11
@ 2013-07-15 20:42 alexdeucher
  0 siblings, 0 replies; 15+ messages in thread
From: alexdeucher @ 2013-07-15 20:42 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

Bug fixes for radeon all over the place.  Big one is a fix for ttm which
causes hangs on boot for a number of systems.


The following changes since commit 774d8e34e46506222bb5e2888e3ef42b2775715f:

  Merge branch 'drm-next-3.11' of git://people.freedesktop.org/~agd5f/linux into drm-next (2013-07-09 10:49:39 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (11):
      drm/radeon/hdmi: make sure we have an afmt block assigned
      drm/radeon/dpm: disable gfx PG on PALM
      drm/radeon: Disable dma rings for bo moves on r6xx
      drm/radeon: implement bo copy callback using CP DMA (v2)
      drm/radeon: use CP DMA on r6xx for bo moves
      drm/radeon: add fault decode function for cayman/TN (v2)
      drm/radeon: add fault decode function for SI (v2)
      drm/radeon: add fault decode function for CIK
      drm/radeon: allow selection of alignment in the sub-allocator
      drm/radeon: align VM PTBs (Page Table Blocks) to 32K
      drm/radeon/dpm/sumo: handle boost states properly when forcing a perf level

Christian König (2):
      drm/radeon: fix UVD fence emit
      drm/radeon: never unpin UVD bo v3

Jerome Glisse (1):
      drm/radeon: use radeon device for request firmware

Maarten Lankhorst (1):
      drm/radeon: add missing ttm_eu_backoff_reservation to radeon_bo_list_validate

Sergey Senozhatsky (1):
      radeon kms: do not flush uninitialized hotplug work

 drivers/gpu/drm/radeon/cik.c            |   59 ++++---
 drivers/gpu/drm/radeon/cikd.h           |   16 ++
 drivers/gpu/drm/radeon/evergreen.c      |   10 +-
 drivers/gpu/drm/radeon/evergreen_hdmi.c |    6 +
 drivers/gpu/drm/radeon/ni.c             |  182 +++++++++++++++++--
 drivers/gpu/drm/radeon/nid.h            |   16 ++
 drivers/gpu/drm/radeon/r100.c           |   11 +-
 drivers/gpu/drm/radeon/r600.c           |  102 +++++++++--
 drivers/gpu/drm/radeon/r600_hdmi.c      |    6 +
 drivers/gpu/drm/radeon/r600d.h          |    1 +
 drivers/gpu/drm/radeon/radeon.h         |    9 +-
 drivers/gpu/drm/radeon/radeon_asic.c    |   12 +-
 drivers/gpu/drm/radeon/radeon_asic.h    |    3 +
 drivers/gpu/drm/radeon/radeon_fence.c   |    2 +-
 drivers/gpu/drm/radeon/radeon_gart.c    |   11 +-
 drivers/gpu/drm/radeon/radeon_irq_kms.c |   11 +-
 drivers/gpu/drm/radeon/radeon_object.c  |    1 +
 drivers/gpu/drm/radeon/radeon_object.h  |    2 +-
 drivers/gpu/drm/radeon/radeon_ring.c    |    1 +
 drivers/gpu/drm/radeon/radeon_sa.c      |    7 +-
 drivers/gpu/drm/radeon/radeon_uvd.c     |  111 +++++-------
 drivers/gpu/drm/radeon/rv770.c          |    2 +-
 drivers/gpu/drm/radeon/si.c             |  295 +++++++++++++++++++++++++++++--
 drivers/gpu/drm/radeon/sid.h            |   14 ++
 drivers/gpu/drm/radeon/sumo_dpm.c       |   14 ++-
 25 files changed, 733 insertions(+), 171 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
@ 2013-08-15 17:06 Alex Deucher
  0 siblings, 0 replies; 15+ messages in thread
From: Alex Deucher @ 2013-08-15 17:06 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

This just adds one more regression fix to my previous pull request.

Rafał Miłecki (1):
  drm/radeon: fix WREG32_OR macro setting bits in a register

 drivers/gpu/drm/radeon/radeon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.3.1

The following changes since commit 022374c02e357ac82e98dd2689fb2efe05723d69:

  drm/radeon/r7xx: fix copy paste typo in golden register setup (2013-08-14 18:03:40 -0400)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

for you to fetch changes up to d43a93c8d9bc4e0dc0293b6458c077c3c797594f:

  drm/radeon: fix WREG32_OR macro setting bits in a register (2013-08-15 12:59:45 -0400)

----------------------------------------------------------------
Rafał Miłecki (1):
      drm/radeon: fix WREG32_OR macro setting bits in a register

 drivers/gpu/drm/radeon/radeon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
@ 2013-08-14 22:11 Alex Deucher
  0 siblings, 0 replies; 15+ messages in thread
From: Alex Deucher @ 2013-08-14 22:11 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

Just two small fixes for radeon.  One fixes an array overrun
that can cause garbage to get written to registers on some r7xx boards,
the other is a small UVD fix.

The following changes since commit e42f5814212079aecd5826dba10588a896ac0862:

  Merge tag 'drm-intel-fixes-2013-08-08' of git://people.freedesktop.org/~danvet/drm-intel into drm-fixes (2013-08-09 09:09:37 +1000)

are available in the git repository at:


  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

for you to fetch changes up to 022374c02e357ac82e98dd2689fb2efe05723d69:

  drm/radeon/r7xx: fix copy paste typo in golden register setup (2013-08-14 18:03:40 -0400)

----------------------------------------------------------------
Alex Deucher (1):
      drm/radeon/r7xx: fix copy paste typo in golden register setup

Christian König (1):
      drm/radeon: fix UVD message buffer validation

 drivers/gpu/drm/radeon/radeon_uvd.c |  8 ++++++++
 drivers/gpu/drm/radeon/rv770.c      | 12 ++++++------
 2 files changed, 14 insertions(+), 6 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread
* RE: [pull] radeon drm-fixes-3.11
  2013-08-08  4:37 ` Rafał Miłecki
@ 2013-08-08 12:18   ` Deucher, Alexander
  0 siblings, 0 replies; 15+ messages in thread
From: Deucher, Alexander @ 2013-08-08 12:18 UTC (permalink / raw)
  To: Rafał Miłecki, Alex Deucher; +Cc: dri-devel

> -----Original Message-----
> From: Rafał Miłecki [mailto:zajec5@gmail.com]
> Sent: Thursday, August 08, 2013 12:37 AM
> To: Alex Deucher
> Cc: dri-devel@lists.freedesktop.org; airlied@gmail.com; Deucher, Alexander
> Subject: Re: [pull] radeon drm-fixes-3.11
> 
> 2013/8/8 Alex Deucher <alexdeucher@gmail.com>:
> > Some more radeon fixes.  Mostly dpm and uvd fixes.  Fixes hangs
> > with dpm on more rv6xx asics, and fixes suspend and resume with UVD.
> 
> That
> fix audio dto calculation on DCE3+
> looks promising, I had no idea you're working on that. Thanks for
> releasing that!
> 
> Maybe you could post your patches for review on dri-devel@? If you
> don't want Dave to take them, maybe just post them with [RFC]?

Sorry, I thought I had sent that one out, but maybe just internally.

Alex

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [pull] radeon drm-fixes-3.11
  2013-08-07 22:15 Alex Deucher
@ 2013-08-08  4:37 ` Rafał Miłecki
  2013-08-08 12:18   ` Deucher, Alexander
  0 siblings, 1 reply; 15+ messages in thread
From: Rafał Miłecki @ 2013-08-08  4:37 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Alex Deucher, dri-devel

2013/8/8 Alex Deucher <alexdeucher@gmail.com>:
> Some more radeon fixes.  Mostly dpm and uvd fixes.  Fixes hangs
> with dpm on more rv6xx asics, and fixes suspend and resume with UVD.

That
fix audio dto calculation on DCE3+
looks promising, I had no idea you're working on that. Thanks for
releasing that!

Maybe you could post your patches for review on dri-devel@? If you
don't want Dave to take them, maybe just post them with [RFC]?

-- 
Rafał
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
@ 2013-08-07 22:15 Alex Deucher
  2013-08-08  4:37 ` Rafał Miłecki
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Deucher @ 2013-08-07 22:15 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

Some more radeon fixes.  Mostly dpm and uvd fixes.  Fixes hangs
with dpm on more rv6xx asics, and fixes suspend and resume with UVD.

The following changes since commit adfb8e51332153016857194b85309150ac560286:

  drm/radeon: fix 64 bit divide in SI spm code (2013-08-04 11:03:14 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

for you to fetch changes up to 8a53fa23fd3e7c22d93f28e6aaae8358c53326ba:

  drm/radeon: make missing smc ucode non-fatal (2013-08-07 17:37:19 -0400)

----------------------------------------------------------------
Alex Deucher (11):
      drm/radeon: properly handle pm on gpu reset
      drm/radeon: select audio dto based on encoder id for DCE3
      drm/radeon/dpm: adjust thermal protection requirements
      drm/radeon/dpm: fix spread spectrum setup (v2)
      drm/radeon/dpm: adjust power state properly for UVD on SI
      drm/radeon/dpm: disable sclk ss on rv6xx
      drm/radeon: fix audio dto calculation on DCE3+ (v3)
      drm/radeon: always program the MC on startup
      drm/radeon/cik: use a mutex to properly lock srbm instanced registers
      drm/radeon/dpm: require rlc for dpm
      drm/radeon: make missing smc ucode non-fatal

Christian König (5):
      drm/radeon: fix halting UVD
      drm/radeon: only save UVD bo when we have open handles
      drm/radeon: stop sending invalid UVD destroy msg
      drm/radeon: add more UVD CS checking
      drm/radeon: remove unnecessary unpin

 drivers/gpu/drm/radeon/btc_dpm.c        | 17 +-----
 drivers/gpu/drm/radeon/cik.c            | 18 +++++--
 drivers/gpu/drm/radeon/cypress_dpm.c    | 17 +-----
 drivers/gpu/drm/radeon/evergreen.c      |  6 ++-
 drivers/gpu/drm/radeon/evergreen_hdmi.c | 26 ++++++++-
 drivers/gpu/drm/radeon/evergreend.h     |  3 ++
 drivers/gpu/drm/radeon/ni.c             | 16 ++++--
 drivers/gpu/drm/radeon/ni_dpm.c         | 17 +-----
 drivers/gpu/drm/radeon/r600.c           | 41 +++++++++++----
 drivers/gpu/drm/radeon/r600_hdmi.c      | 37 +++++++++++--
 drivers/gpu/drm/radeon/r600d.h          |  3 ++
 drivers/gpu/drm/radeon/radeon.h         |  4 +-
 drivers/gpu/drm/radeon/radeon_asic.h    |  2 +-
 drivers/gpu/drm/radeon/radeon_device.c  |  3 ++
 drivers/gpu/drm/radeon/radeon_fence.c   |  2 +-
 drivers/gpu/drm/radeon/radeon_gart.c    |  1 -
 drivers/gpu/drm/radeon/radeon_pm.c      |  9 +++-
 drivers/gpu/drm/radeon/radeon_uvd.c     | 93 +++++++++++++++++++++++++--------
 drivers/gpu/drm/radeon/rv6xx_dpm.c      | 22 ++++----
 drivers/gpu/drm/radeon/rv770.c          |  7 ++-
 drivers/gpu/drm/radeon/rv770_dpm.c      | 33 ++++++------
 drivers/gpu/drm/radeon/rv770_dpm.h      |  1 +
 drivers/gpu/drm/radeon/si.c             | 19 ++++---
 drivers/gpu/drm/radeon/si_dpm.c         | 61 +++++++++++----------
 24 files changed, 300 insertions(+), 158 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
  2013-07-29 22:39 alexdeucher
@ 2013-07-30 21:38 ` alexdeucher
  0 siblings, 0 replies; 15+ messages in thread
From: alexdeucher @ 2013-07-30 21:38 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

A few more fixes for radeon on top of the ones I sent yesterday.
- more fixes for SI dpm
- fix DP on some rv6xx boards

The following changes since commit 63f22d0e98cf74adf4ecfb25099607239b00c751:

  drm/radeon/dpm: fix and enable reclocking on SI (2013-07-29 18:14:42 -0400)

are available in the git repository at:
  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (4):
      drm/radeon/atom: initialize more atom interpretor elements to 0
      drm: fix 64 bit drm fixed point helpers
      drm/radeon/dpm: fix calculations in si_calculate_leakage_for_v_and_t_formula
      drm/radeon/dpm: re-enable cac control on SI

 drivers/gpu/drm/radeon/atom.c   |    5 +++++
 drivers/gpu/drm/radeon/si_dpm.c |   11 ++++++-----
 include/drm/drm_fixed.h         |   14 +++++++-------
 3 files changed, 18 insertions(+), 12 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
@ 2013-07-29 22:39 alexdeucher
  2013-07-30 21:38 ` alexdeucher
  0 siblings, 1 reply; 15+ messages in thread
From: alexdeucher @ 2013-07-29 22:39 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

A few more radeon bug fixes, mostly for SI dpm.  At this point dpm is
pretty solid across the majority of asics.  I think we mostly just have
corner cases and fixing up some of the trickier features at this point.

The following changes since commit bf903e4141fce4b35072d5b8fa0ddd299aaf01ea:

  Merge tag 'drm-intel-fixes-2013-07-25' of git://people.freedesktop.org/~danvet/drm-intel into drm-fixes (2013-07-26 20:38:14 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (10):
      drm/radeon: fix audio dto programming on DCE4+
      drm/radeon/dpm: fix display gap programming on SI
      drm/radeon/dpm: fix si_calculate_memory_refresh_rate()
      drm/radeon/dpm: fix powertune handling for pci id 0x6835
      drm/radeon: properly handle cg on asics without UVD
      drm/radeon/atom: fix fb when fetching engine params
      drm/radeon/dpm: fix forcing performance state to low on cayman
      drm/radeon/si: disable cgcg and pg for now
      drm/radeon/dpm: disable cac setup on SI
      drm/radeon/dpm: fix and enable reclocking on SI

 drivers/gpu/drm/radeon/evergreen_hdmi.c  |    2 +-
 drivers/gpu/drm/radeon/ni_dpm.c          |    7 +-----
 drivers/gpu/drm/radeon/radeon_atombios.c |    2 +-
 drivers/gpu/drm/radeon/si.c              |   14 ++++--------
 drivers/gpu/drm/radeon/si_dpm.c          |   34 ++++++++++++++---------------
 5 files changed, 24 insertions(+), 35 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
  2013-07-23 12:37 alexdeucher
@ 2013-07-26  2:05 ` alexdeucher
  0 siblings, 0 replies; 15+ messages in thread
From: alexdeucher @ 2013-07-26  2:05 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

  Just a few more patches to fix some issues with dpm on rv6xx.

The following changes since commit cef1d00cd56f600121ad121875655ad410a001b8:

  drm/radeon: fix combios tables on older cards (2013-07-22 15:57:14 -0400)

are available in the git repository at:
  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (4):
      drm/radeon/dpm: fix a typo in the rv6xx mclk setup
      drm/radeon/dpm: fix displaygap programming on rv6xx
      drm/radeon/dpm: implement force performance levels for rv6xx
      drm/radeon/dpm: fix r600_enable_sclk_control()

 drivers/gpu/drm/radeon/r600_dpm.c    |    4 +-
 drivers/gpu/drm/radeon/radeon_asic.c |    1 +
 drivers/gpu/drm/radeon/radeon_asic.h |    2 +
 drivers/gpu/drm/radeon/rv6xx_dpm.c   |   41 +++++++++++++++++++++++++++++++--
 4 files changed, 43 insertions(+), 5 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
@ 2013-07-23 12:37 alexdeucher
  2013-07-26  2:05 ` alexdeucher
  0 siblings, 1 reply; 15+ messages in thread
From: alexdeucher @ 2013-07-23 12:37 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

  Just a few radeon bug fixes.

The following changes since commit 058ca4a22ebf22ea1cbedd6cc0340ed1e2e94ee1:

  Merge tag 'drm-intel-fixes-2013-07-22' of git://people.freedesktop.org/~danvet/drm-intel into drm-fixes (2013-07-22 16:14:26 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (4):
      drm/radeon: wait for 3D idle before using CP DMA
      drm/radeon/vm: only align the pt base to 32k
      drm/radeon: fix endian issues with DP handling (v3)
      drm/radeon: improve dac adjust heuristics for legacy pdac

Mark Kettenis (1):
      drm/radeon: fix combios tables on older cards

Ondrej Zary (1):
      drm/radeon: Another card with wrong primary dac adj

 drivers/gpu/drm/radeon/atombios_dp.c    |   43 ++++++++-
 drivers/gpu/drm/radeon/r600.c           |    5 +-
 drivers/gpu/drm/radeon/radeon_combios.c |  159 ++++++++++---------------------
 drivers/gpu/drm/radeon/radeon_gart.c    |    8 +-
 4 files changed, 98 insertions(+), 117 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
  2013-07-17 19:54 alexdeucher
  2013-07-17 20:24 ` Andre Heider
@ 2013-07-17 21:05 ` alexdeucher
  1 sibling, 0 replies; 15+ messages in thread
From: alexdeucher @ 2013-07-17 21:05 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

Take two.  Just some DPM fixes.

The following changes since commit d1ce3d5496f2a7c90dd00a9133572f931d2acdcc:

  uvesafb: Really allow mtrr being 0, as documented and warn()ed (2013-07-16 10:24:28 +1000)

are available in the git repository at:
  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (5):
      drm/radeon: add a module parameter to disable aspm
      drm/radeon: fix an endian bug in atom table parsing
      drm/radeon/dpm: fix atom vram table parsing
      drm/radeon/dpm/atom: fix broken gcc harder
      drm/radeon/dpm: add debugfs support for RS780/RS880 (v3)

Andre Heider (1):
      drm/radeon/dpm/atom: restructure logic to work around a compiler bug

 drivers/gpu/drm/radeon/evergreen.c       |    3 ++
 drivers/gpu/drm/radeon/radeon.h          |    1 +
 drivers/gpu/drm/radeon/radeon_asic.c     |    1 +
 drivers/gpu/drm/radeon/radeon_asic.h     |    2 +
 drivers/gpu/drm/radeon/radeon_atombios.c |   40 ++++++++++++++---------------
 drivers/gpu/drm/radeon/radeon_drv.c      |    4 +++
 drivers/gpu/drm/radeon/rs780_dpm.c       |   25 ++++++++++++++++++
 drivers/gpu/drm/radeon/rs780d.h          |    3 ++
 drivers/gpu/drm/radeon/rv6xx_dpm.c       |   14 ++++++----
 drivers/gpu/drm/radeon/rv770_dpm.c       |   14 ++++++----
 drivers/gpu/drm/radeon/si.c              |    3 ++
 11 files changed, 77 insertions(+), 33 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [pull] radeon drm-fixes-3.11
  2013-07-17 20:24 ` Andre Heider
  2013-07-17 20:26   ` Alex Deucher
@ 2013-07-17 20:36   ` Alex Deucher
  1 sibling, 0 replies; 15+ messages in thread
From: Alex Deucher @ 2013-07-17 20:36 UTC (permalink / raw)
  To: Andre Heider; +Cc: Alex Deucher, dri-devel

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On Wed, Jul 17, 2013 at 4:24 PM, Andre Heider <a.heider@gmail.com> wrote:
> On Wed, Jul 17, 2013 at 9:54 PM,  <alexdeucher@gmail.com> wrote:
>> From: Alex Deucher <alexander.deucher@amd.com>
>>
>> Hi Dave,
>>
>> Just a few DPM fixes.
>>
>> The following changes since commit d1ce3d5496f2a7c90dd00a9133572f931d2acdcc:
>>
>>   uvesafb: Really allow mtrr being 0, as documented and warn()ed (2013-07-16 10:24:28 +1000)
>>
>> are available in the git repository at:
>>   git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11
>>
>> Alex Deucher (3):
>>       drm/radeon: add a module parameter to disable aspm
>>       drm/radeon: fix an endian bug in atom table parsing
>>       drm/radeon/dpm: fix atom vram table parsing
>>
>> Andre Heider (1):
>>       drm/radeon/dpm/atom: restructure logic to work around a compiler bug
>
> Discarding the debug patches from bug #66932 and then merging your
> branch makes it break again :P
> Seems like the printk()s mattered and the gcc 4.8 still hates the code.
>
> I still think its due to the asRegIndexBuf[1] definition + accessing
> the array with i>0, let me poke at it a little

Does the attached patch help?

Alex

[-- Attachment #2: 0001-drm-radeon-dpm-atom-fix-broken-gcc-harder.patch --]
[-- Type: text/x-patch, Size: 1998 bytes --]

From f90555cbe629e14c6af1dcec1933a3833ecd321f Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexander.deucher@amd.com>
Date: Wed, 17 Jul 2013 16:34:12 -0400
Subject: [PATCH] drm/radeon/dpm/atom: fix broken gcc harder

See bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=66932
https://bugs.freedesktop.org/show_bug.cgi?id=66972
https://bugs.freedesktop.org/show_bug.cgi?id=66945

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/radeon/radeon_atombios.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
index 2606ec6..e3f3e88 100644
--- a/drivers/gpu/drm/radeon/radeon_atombios.c
+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
@@ -3699,18 +3699,21 @@ int radeon_atom_init_mc_reg_table(struct radeon_device *rdev,
 						(ATOM_MEMORY_SETTING_DATA_BLOCK *)
 						((u8 *)reg_block + (2 * sizeof(u16)) +
 						 le16_to_cpu(reg_block->usRegIndexTblSize));
+					ATOM_INIT_REG_INDEX_FORMAT *format = &reg_block->asRegIndexBuf[0];
 					num_entries = (u8)((le16_to_cpu(reg_block->usRegIndexTblSize)) /
 							   sizeof(ATOM_INIT_REG_INDEX_FORMAT)) - 1;
 					if (num_entries > VBIOS_MC_REGISTER_ARRAY_SIZE)
 						return -EINVAL;
 					while (i < num_entries) {
-						if (reg_block->asRegIndexBuf[i].ucPreRegDataLength & ACCESS_PLACEHOLDER)
+						if (format->ucPreRegDataLength & ACCESS_PLACEHOLDER)
 							break;
 						reg_table->mc_reg_address[i].s1 =
-							(u16)(le16_to_cpu(reg_block->asRegIndexBuf[i].usRegIndex));
+							(u16)(le16_to_cpu(format->usRegIndex));
 						reg_table->mc_reg_address[i].pre_reg_data =
-							(u8)(reg_block->asRegIndexBuf[i].ucPreRegDataLength);
+							(u8)(format->ucPreRegDataLength);
 						i++;
+						format = (ATOM_INIT_REG_INDEX_FORMAT *)
+							((u8 *)format + sizeof(ATOM_INIT_REG_INDEX_FORMAT));
 					}
 					reg_table->last = i;
 					while ((*(u32 *)reg_data != END_OF_REG_DATA_BLOCK) &&
-- 
1.7.7.5


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [pull] radeon drm-fixes-3.11
  2013-07-17 20:24 ` Andre Heider
@ 2013-07-17 20:26   ` Alex Deucher
  2013-07-17 20:36   ` Alex Deucher
  1 sibling, 0 replies; 15+ messages in thread
From: Alex Deucher @ 2013-07-17 20:26 UTC (permalink / raw)
  To: Andre Heider; +Cc: Alex Deucher, dri-devel

Dave hold off on this for now.

Alex


On Wed, Jul 17, 2013 at 4:24 PM, Andre Heider <a.heider@gmail.com> wrote:
> On Wed, Jul 17, 2013 at 9:54 PM,  <alexdeucher@gmail.com> wrote:
>> From: Alex Deucher <alexander.deucher@amd.com>
>>
>> Hi Dave,
>>
>> Just a few DPM fixes.
>>
>> The following changes since commit d1ce3d5496f2a7c90dd00a9133572f931d2acdcc:
>>
>>   uvesafb: Really allow mtrr being 0, as documented and warn()ed (2013-07-16 10:24:28 +1000)
>>
>> are available in the git repository at:
>>   git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11
>>
>> Alex Deucher (3):
>>       drm/radeon: add a module parameter to disable aspm
>>       drm/radeon: fix an endian bug in atom table parsing
>>       drm/radeon/dpm: fix atom vram table parsing
>>
>> Andre Heider (1):
>>       drm/radeon/dpm/atom: restructure logic to work around a compiler bug
>
> Discarding the debug patches from bug #66932 and then merging your
> branch makes it break again :P
> Seems like the printk()s mattered and the gcc 4.8 still hates the code.
>
> I still think its due to the asRegIndexBuf[1] definition + accessing
> the array with i>0, let me poke at it a little

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [pull] radeon drm-fixes-3.11
  2013-07-17 19:54 alexdeucher
@ 2013-07-17 20:24 ` Andre Heider
  2013-07-17 20:26   ` Alex Deucher
  2013-07-17 20:36   ` Alex Deucher
  2013-07-17 21:05 ` alexdeucher
  1 sibling, 2 replies; 15+ messages in thread
From: Andre Heider @ 2013-07-17 20:24 UTC (permalink / raw)
  To: alexdeucher; +Cc: Alex Deucher, dri-devel

On Wed, Jul 17, 2013 at 9:54 PM,  <alexdeucher@gmail.com> wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> Hi Dave,
>
> Just a few DPM fixes.
>
> The following changes since commit d1ce3d5496f2a7c90dd00a9133572f931d2acdcc:
>
>   uvesafb: Really allow mtrr being 0, as documented and warn()ed (2013-07-16 10:24:28 +1000)
>
> are available in the git repository at:
>   git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11
>
> Alex Deucher (3):
>       drm/radeon: add a module parameter to disable aspm
>       drm/radeon: fix an endian bug in atom table parsing
>       drm/radeon/dpm: fix atom vram table parsing
>
> Andre Heider (1):
>       drm/radeon/dpm/atom: restructure logic to work around a compiler bug

Discarding the debug patches from bug #66932 and then merging your
branch makes it break again :P
Seems like the printk()s mattered and the gcc 4.8 still hates the code.

I still think its due to the asRegIndexBuf[1] definition + accessing
the array with i>0, let me poke at it a little

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [pull] radeon drm-fixes-3.11
@ 2013-07-17 19:54 alexdeucher
  2013-07-17 20:24 ` Andre Heider
  2013-07-17 21:05 ` alexdeucher
  0 siblings, 2 replies; 15+ messages in thread
From: alexdeucher @ 2013-07-17 19:54 UTC (permalink / raw)
  To: dri-devel, airlied; +Cc: Alex Deucher

From: Alex Deucher <alexander.deucher@amd.com>

Hi Dave,

Just a few DPM fixes.

The following changes since commit d1ce3d5496f2a7c90dd00a9133572f931d2acdcc:

  uvesafb: Really allow mtrr being 0, as documented and warn()ed (2013-07-16 10:24:28 +1000)

are available in the git repository at:
  git://people.freedesktop.org/~agd5f/linux drm-fixes-3.11

Alex Deucher (3):
      drm/radeon: add a module parameter to disable aspm
      drm/radeon: fix an endian bug in atom table parsing
      drm/radeon/dpm: fix atom vram table parsing

Andre Heider (1):
      drm/radeon/dpm/atom: restructure logic to work around a compiler bug

 drivers/gpu/drm/radeon/evergreen.c       |    3 ++
 drivers/gpu/drm/radeon/radeon.h          |    1 +
 drivers/gpu/drm/radeon/radeon_atombios.c |   33 ++++++++++++-----------------
 drivers/gpu/drm/radeon/radeon_drv.c      |    4 +++
 drivers/gpu/drm/radeon/rv6xx_dpm.c       |   14 +++++++-----
 drivers/gpu/drm/radeon/rv770_dpm.c       |   14 +++++++-----
 drivers/gpu/drm/radeon/si.c              |    3 ++
 7 files changed, 41 insertions(+), 31 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2013-08-15 17:06 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-15 20:42 [pull] radeon drm-fixes-3.11 alexdeucher
2013-07-17 19:54 alexdeucher
2013-07-17 20:24 ` Andre Heider
2013-07-17 20:26   ` Alex Deucher
2013-07-17 20:36   ` Alex Deucher
2013-07-17 21:05 ` alexdeucher
2013-07-23 12:37 alexdeucher
2013-07-26  2:05 ` alexdeucher
2013-07-29 22:39 alexdeucher
2013-07-30 21:38 ` alexdeucher
2013-08-07 22:15 Alex Deucher
2013-08-08  4:37 ` Rafał Miłecki
2013-08-08 12:18   ` Deucher, Alexander
2013-08-14 22:11 Alex Deucher
2013-08-15 17:06 Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.