* [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native
@ 2013-07-17 8:41 Ming Liu
2013-07-17 12:07 ` Burton, Ross
0 siblings, 1 reply; 3+ messages in thread
From: Ming Liu @ 2013-07-17 8:41 UTC (permalink / raw)
To: openembedded-core
The native/nativesdk overrides of EXTRA_OECONF should take effect before
append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
of be appended at native/nativesdk build time.
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
index 12f5021..cc11977 100644
--- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
@@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native
2013-07-17 8:41 [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native Ming Liu
@ 2013-07-17 12:07 ` Burton, Ross
2013-07-18 1:30 ` Ming Liu
0 siblings, 1 reply; 3+ messages in thread
From: Burton, Ross @ 2013-07-17 12:07 UTC (permalink / raw)
To: Ming Liu; +Cc: openembedded-core
On 17 July 2013 09:41, Ming Liu <ming.liu@windriver.com> wrote:
> +EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"
_append won't add a leading space so you're making a massive
assumption here, please add a leading space for safety.
Ross
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native
2013-07-17 12:07 ` Burton, Ross
@ 2013-07-18 1:30 ` Ming Liu
0 siblings, 0 replies; 3+ messages in thread
From: Ming Liu @ 2013-07-18 1:30 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On 07/17/2013 08:07 PM, Burton, Ross wrote:
> On 17 July 2013 09:41, Ming Liu <ming.liu@windriver.com> wrote:
>> +EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"
> _append won't add a leading space so you're making a massive
> assumption here, please add a leading space for safety.
Yes, thanks for the reminding, I will send the V3.
the best,
thank you
> Ross
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-18 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 8:41 [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native Ming Liu
2013-07-17 12:07 ` Burton, Ross
2013-07-18 1:30 ` Ming Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.