* [PATCH] slub: Remove unnecessary page NULL check
@ 2013-07-18 7:39 Libin
2013-07-18 13:46 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Libin @ 2013-07-18 7:39 UTC (permalink / raw)
To: linux-mm; +Cc: cl, penberg, akpm, mpm, rostedt, guohanjun, wujianguo
In commit 4d7868e6(slub: Do not dereference NULL pointer in node_match)
had added check for page NULL in node_match. Thus, it is not needed
to check it before node_match, remove it.
Signed-off-by: Libin <huawei.libin@huawei.com>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 3b482c8..c911ca3 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2375,7 +2375,7 @@ redo:
object = c->freelist;
page = c->page;
- if (unlikely(!object || !page || !node_match(page, node)))
+ if (unlikely(!object || !node_match(page, node)))
object = __slab_alloc(s, gfpflags, node, addr, c);
else {
--
1.8.2.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] slub: Remove unnecessary page NULL check
2013-07-18 7:39 [PATCH] slub: Remove unnecessary page NULL check Libin
@ 2013-07-18 13:46 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2013-07-18 13:46 UTC (permalink / raw)
To: Libin; +Cc: linux-mm, penberg, akpm, mpm, rostedt, guohanjun, wujianguo
On Thu, 18 Jul 2013, Libin wrote:
> In commit 4d7868e6(slub: Do not dereference NULL pointer in node_match)
> had added check for page NULL in node_match. Thus, it is not needed
> to check it before node_match, remove it.
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-18 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-18 7:39 [PATCH] slub: Remove unnecessary page NULL check Libin
2013-07-18 13:46 ` Christoph Lameter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.