* [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd service installation
@ 2021-05-14 15:28 Adrian Thomasset
2021-05-14 22:15 ` Armin Kuster
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Thomasset @ 2021-05-14 15:28 UTC (permalink / raw)
To: openembedded-devel; +Cc: Armin Kuster
[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]
From 84681a31cfd3f7aa8cc89181c2c87ffffcbc261b Mon Sep 17 00:00:00 2001
From: Mario Schuknecht <schuknecht@dresearch-fe.de>
Date: Thu, 15 Oct 2020 16:53:12 +0200
Subject: [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd
service installation
Install systemd configuration file wg-quick@.service into the proper folder.
Use 'systemd_system_unitdir' instead of 'systemd_unitdir' as the
installation
path.
Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
.../recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-networking/recipes-kernel/wireguard/
wireguard-tools_1.0.20200513.bb b/meta-networking/recipes-kernel/wireguard/
wireguard-tools_1.0.20200513.bb
index 31b33a045..3403fd943 100644
--- a/meta-networking/recipes-kernel/wireguard/
wireguard-tools_1.0.20200513.bb
+++ b/meta-networking/recipes-kernel/wireguard/
wireguard-tools_1.0.20200513.bb
@@ -9,7 +9,7 @@ DEPENDS += "libmnl"
do_install () {
oe_runmake DESTDIR="${D}" PREFIX="${prefix}"
SYSCONFDIR="${sysconfdir}" \
- SYSTEMDUNITDIR="${systemd_unitdir}" \
+ SYSTEMDUNITDIR="${systemd_system_unitdir}" \
WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES',
'systemd', 'yes', '', d)} \
WITH_BASHCOMPLETION=yes \
WITH_WGQUICK=yes \
@@ -18,7 +18,7 @@ do_install () {
FILES_${PN} = " \
${sysconfdir} \
- ${systemd_unitdir} \
+ ${systemd_system_unitdir} \
${bindir} \
"
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 2304 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd service installation
2021-05-14 15:28 [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd service installation Adrian Thomasset
@ 2021-05-14 22:15 ` Armin Kuster
2021-05-14 22:42 ` [oe] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Armin Kuster @ 2021-05-14 22:15 UTC (permalink / raw)
To: athomasset, openembedded-devel
On 5/14/21 8:28 AM, Adrian Thomasset wrote:
> From 84681a31cfd3f7aa8cc89181c2c87ffffcbc261b Mon Sep 17 00:00:00 2001
> From: Mario Schuknecht <schuknecht@dresearch-fe.de
> <mailto:schuknecht@dresearch-fe.de>>
> Date: Thu, 15 Oct 2020 16:53:12 +0200
> Subject: [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd
> service installation
>
> Install systemd configuration file wg-quick@.service into the proper
> folder.
> Use 'systemd_system_unitdir' instead of 'systemd_unitdir' as the
> installation
> path.
I take it this will affect Hardknott and Gatesgarth. I will wait for
Master to merge before propagating to those branches.
-armin
>
> Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de
> <mailto:mario.schuknecht@dresearch-fe.de>>
> Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>>
> ---
> .../recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> <http://wireguard-tools_1.0.20200513.bb> | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> <http://wireguard-tools_1.0.20200513.bb>
> b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> <http://wireguard-tools_1.0.20200513.bb>
> index 31b33a045..3403fd943 100644
> ---
> a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> <http://wireguard-tools_1.0.20200513.bb>
> +++
> b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> <http://wireguard-tools_1.0.20200513.bb>
> @@ -9,7 +9,7 @@ DEPENDS += "libmnl"
>
> do_install () {
> oe_runmake DESTDIR="${D}" PREFIX="${prefix}"
> SYSCONFDIR="${sysconfdir}" \
> - SYSTEMDUNITDIR="${systemd_unitdir}" \
> + SYSTEMDUNITDIR="${systemd_system_unitdir}" \
> WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES',
> 'systemd', 'yes', '', d)} \
> WITH_BASHCOMPLETION=yes \
> WITH_WGQUICK=yes \
> @@ -18,7 +18,7 @@ do_install () {
>
> FILES_${PN} = " \
> ${sysconfdir} \
> - ${systemd_unitdir} \
> + ${systemd_system_unitdir} \
> ${bindir} \
> "
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [oe] [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd service installation
2021-05-14 22:15 ` Armin Kuster
@ 2021-05-14 22:42 ` Khem Raj
2021-05-17 9:14 ` Adrian Thomasset
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-05-14 22:42 UTC (permalink / raw)
To: Armin Kuster; +Cc: Adrian Thomasset, openembeded-devel
On Fri, May 14, 2021 at 3:15 PM Armin Kuster <akuster808@gmail.com> wrote:
>
>
>
> On 5/14/21 8:28 AM, Adrian Thomasset wrote:
> > From 84681a31cfd3f7aa8cc89181c2c87ffffcbc261b Mon Sep 17 00:00:00 2001
> > From: Mario Schuknecht <schuknecht@dresearch-fe.de
> > <mailto:schuknecht@dresearch-fe.de>>
> > Date: Thu, 15 Oct 2020 16:53:12 +0200
> > Subject: [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd
> > service installation
> >
> > Install systemd configuration file wg-quick@.service into the proper
> > folder.
> > Use 'systemd_system_unitdir' instead of 'systemd_unitdir' as the
> > installation
> > path.
>
> I take it this will affect Hardknott and Gatesgarth. I will wait for
> Master to merge before propagating to those branches.
It's already in master for a long time. I think this patch should have
been marked with [stable] in the subject line to be clear that its a
backport request.
>
> -armin
> >
> > Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de
> > <mailto:mario.schuknecht@dresearch-fe.de>>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>>
> > ---
> > .../recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> > <http://wireguard-tools_1.0.20200513.bb> | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> > <http://wireguard-tools_1.0.20200513.bb>
> > b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> > <http://wireguard-tools_1.0.20200513.bb>
> > index 31b33a045..3403fd943 100644
> > ---
> > a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> > <http://wireguard-tools_1.0.20200513.bb>
> > +++
> > b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> > <http://wireguard-tools_1.0.20200513.bb>
> > @@ -9,7 +9,7 @@ DEPENDS += "libmnl"
> >
> > do_install () {
> > oe_runmake DESTDIR="${D}" PREFIX="${prefix}"
> > SYSCONFDIR="${sysconfdir}" \
> > - SYSTEMDUNITDIR="${systemd_unitdir}" \
> > + SYSTEMDUNITDIR="${systemd_system_unitdir}" \
> > WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES',
> > 'systemd', 'yes', '', d)} \
> > WITH_BASHCOMPLETION=yes \
> > WITH_WGQUICK=yes \
> > @@ -18,7 +18,7 @@ do_install () {
> >
> > FILES_${PN} = " \
> > ${sysconfdir} \
> > - ${systemd_unitdir} \
> > + ${systemd_system_unitdir} \
> > ${bindir} \
> > "
> >
> > --
> > 2.25.1
> >
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [oe] [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd service installation
2021-05-14 22:42 ` [oe] " Khem Raj
@ 2021-05-17 9:14 ` Adrian Thomasset
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Thomasset @ 2021-05-17 9:14 UTC (permalink / raw)
To: Khem Raj; +Cc: Armin Kuster, openembeded-devel
[-- Attachment #1: Type: text/plain, Size: 3137 bytes --]
Hi,
On Fri, May 14, 2021 at 11:43 PM Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, May 14, 2021 at 3:15 PM Armin Kuster <akuster808@gmail.com> wrote:
> >
> >
> >
> > On 5/14/21 8:28 AM, Adrian Thomasset wrote:
> > > From 84681a31cfd3f7aa8cc89181c2c87ffffcbc261b Mon Sep 17 00:00:00 2001
> > > From: Mario Schuknecht <schuknecht@dresearch-fe.de
> > > <mailto:schuknecht@dresearch-fe.de>>
> > > Date: Thu, 15 Oct 2020 16:53:12 +0200
> > > Subject: [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd
> > > service installation
> > >
> > > Install systemd configuration file wg-quick@.service into the proper
> > > folder.
> > > Use 'systemd_system_unitdir' instead of 'systemd_unitdir' as the
> > > installation
> > > path.
> >
> > I take it this will affect Hardknott and Gatesgarth. I will wait for
> > Master to merge before propagating to those branches.
>
> It's already in master for a long time. I think this patch should have
> been marked with [stable] in the subject line to be clear that its a
> backport request.
>
Apologies if this was not clear!
This is my first backport request and I was following the guidelines which
recommends adding "[some-stable-branch]".
With 3 stable branches affected, would using [stable] in the subject avoid
the need to send 3 requests?
Adrian
>
> >
> > -armin
> > >
> > > Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de
> > > <mailto:mario.schuknecht@dresearch-fe.de>>
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com
> >>
> > > ---
> > > .../recipes-kernel/wireguard/wireguard-tools_1.0.20200513.bb
> > > <http://wireguard-tools_1.0.20200513.bb> | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > > a/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200513.bb
> > > <http://wireguard-tools_1.0.20200513.bb>
> > > b/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200513.bb
> > > <http://wireguard-tools_1.0.20200513.bb>
> > > index 31b33a045..3403fd943 100644
> > > ---
> > > a/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200513.bb
> > > <http://wireguard-tools_1.0.20200513.bb>
> > > +++
> > > b/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200513.bb
> > > <http://wireguard-tools_1.0.20200513.bb>
> > > @@ -9,7 +9,7 @@ DEPENDS += "libmnl"
> > >
> > > do_install () {
> > > oe_runmake DESTDIR="${D}" PREFIX="${prefix}"
> > > SYSCONFDIR="${sysconfdir}" \
> > > - SYSTEMDUNITDIR="${systemd_unitdir}" \
> > > + SYSTEMDUNITDIR="${systemd_system_unitdir}" \
> > > WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES',
> > > 'systemd', 'yes', '', d)} \
> > > WITH_BASHCOMPLETION=yes \
> > > WITH_WGQUICK=yes \
> > > @@ -18,7 +18,7 @@ do_install () {
> > >
> > > FILES_${PN} = " \
> > > ${sysconfdir} \
> > > - ${systemd_unitdir} \
> > > + ${systemd_system_unitdir} \
> > > ${bindir} \
> > > "
> > >
> > > --
> > > 2.25.1
> > >
> >
> >
> >
> >
>
[-- Attachment #2: Type: text/html, Size: 5730 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-17 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 15:28 [meta-networking][dunfell][PATCH] wireguard-tools: Fix systemd service installation Adrian Thomasset
2021-05-14 22:15 ` Armin Kuster
2021-05-14 22:42 ` [oe] " Khem Raj
2021-05-17 9:14 ` Adrian Thomasset
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.