[PATCH 0/2] libiscsi: Updates for scsi "misc" branch

[PATCH 0/2] libiscsi: Updates for scsi "misc" branch

[adheer.chandravanshi]

From: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>

James,
 
Please apply the following patches to the scsi tree at your earliest
convenience.

Adheer Chandravanshi (2):
  libiscsi: Add a missing break statement
  libiscsi: Add missing prints for session and connection sysfs attrs

Thanks,
Adheer

[PATCH 1/2] libiscsi: Add a missing break statement

[adheer.chandravanshi]

From: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>

Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
 drivers/scsi/libiscsi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 86153e0..afc6c3f 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3350,6 +3350,7 @@ int iscsi_session_get_param(struct iscsi_cls_session *cls_session,
 		break;
 	case ISCSI_PARAM_BOOT_TARGET:
 		len = sprintf(buf, "%s\n", session->boot_target);
+		break;
 	case ISCSI_PARAM_AUTO_SND_TGT_DISABLE:
 		len = sprintf(buf, "%u\n", session->auto_snd_tgt_disable);
 		break;
-- 
1.7.1

[PATCH 2/2] libiscsi: Add missing prints for session and connection sysfs attrs

[adheer.chandravanshi]

From: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>

Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
 drivers/scsi/libiscsi.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index afc6c3f..f757617 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3312,6 +3312,9 @@ int iscsi_session_get_param(struct iscsi_cls_session *cls_session,
 	case ISCSI_PARAM_DATASEQ_INORDER_EN:
 		len = sprintf(buf, "%d\n", session->dataseq_inorder_en);
 		break;
+	case ISCSI_PARAM_DEF_TASKMGMT_TMO:
+		len = sprintf(buf, "%d\n", session->def_taskmgmt_tmo);
+		break;
 	case ISCSI_PARAM_ERL:
 		len = sprintf(buf, "%d\n", session->erl);
 		break;
@@ -3522,6 +3525,9 @@ int iscsi_conn_get_param(struct iscsi_cls_conn *cls_conn,
 	case ISCSI_PARAM_IPV6_TC:
 		len = sprintf(buf, "%u\n", conn->ipv6_traffic_class);
 		break;
+	case ISCSI_PARAM_IPV6_FLOW_LABEL:
+		len = sprintf(buf, "%u\n", conn->ipv6_flow_label);
+		break;
 	case ISCSI_PARAM_IS_FW_ASSIGNED_IPV6:
 		len = sprintf(buf, "%u\n", conn->is_fw_assigned_ipv6);
 		break;
-- 
1.7.1

Re: [PATCH 0/2] libiscsi: Updates for scsi "misc" branch

[Mike Christie]

On 07/22/2013 06:46 AM, adheer.chandravanshi@qlogic.com wrote:
> From: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
> 
> James,
>  
> Please apply the following patches to the scsi tree at your earliest
> convenience.
>

In the future could you send a link to the patches that a patchset
depends on? It helps in reviewing them.

> Adheer Chandravanshi (2):
>   libiscsi: Add a missing break statement
>   libiscsi: Add missing prints for session and connection sysfs attrs
>

Patches look ok.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>