From: Hector Palacios <hector.palacios@digi.com> To: <linux-iio@vger.kernel.org> Cc: <linux-kernel@vger.kernel.org>, <devicetree-discuss@lists.ozlabs.org>, <alexandre.belloni@free-electrons.com>, <jic23@kernel.org>, <lars@metafoo.de>, <fabio.estevam@freescale.com>, <marex@denx.de>, <hector.palacios@digi.com> Subject: [PATCH v3 0/5] iio: mxs-lradc: add support to optional divider_by_two Date: Mon, 22 Jul 2013 16:03:58 +0200 [thread overview] Message-ID: <1374501843-19651-1-git-send-email-hector.palacios@digi.com> (raw) Greetings, This is v3 of the patchset that adds support to the optional divider_by_two of LRADC channels. Changes in v3: - Fix merge conflict with previous existing patch. - Fix ampersand in function callback assignment. - Removed unused parameters of function to read single sample. - Ennumeration for two-dimensional array of scale (with divider by two disabled or enabled), for improved readability. - Created struct with integer and nano parts of the scale attribute, for improved readability. Changes in v2: - Fix the sample mask passed by the touchscreen driver to the input subsytem, to be 12 bits. - Move the reference voltages to the Device Tree. - Rebased to avoid conflict with Marek Vasut's prior patch. - Use IIO_DEVICE_ATTR() macro for adding scale_available property to all channels. - Make 'is_divided' unsigned int. Notes: - Other fixes were discussed in v1 but they were not part of this patchset changes, and should be handled in a separate patch. - The 64bit math to calculate the integer and decimal parts of the scaling attribute is a bit unreadable but used in other similar drivers like ad7791, ad7793, and ad7192. If it is to be changed it should be done in parallel with these, in a different patch. The first patch changes the realbits to 12. The second adds the channels reference voltages to the DT. The following add the scale read operation, scale_available read operation, and scale write operation. This was tested on a custom i.MX28 platform. Could someone please test on an i.MX23? Hector Palacios (5): iio: mxs-lradc: change the realbits to 12 ARM: dts: add reference voltage property for MXS LRADC iio: mxs-lradc: add scale attribute to channels iio: mxs-lradc: add scale_available file to channels iio: mxs-lradc: add write_raw function to modify scale .../bindings/staging/iio/adc/mxs-lradc.txt | 9 +- arch/arm/boot/dts/imx23.dtsi | 4 + arch/arm/boot/dts/imx28.dtsi | 4 + drivers/staging/iio/adc/mxs-lradc.c | 255 ++++++++++++++++++--- 4 files changed, 242 insertions(+), 30 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Hector Palacios <hector.palacios-i7dp0qKlBMg@public.gmane.org> To: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, hector.palacios-i7dp0qKlBMg@public.gmane.org Subject: [PATCH v3 0/5] iio: mxs-lradc: add support to optional divider_by_two Date: Mon, 22 Jul 2013 16:03:58 +0200 [thread overview] Message-ID: <1374501843-19651-1-git-send-email-hector.palacios@digi.com> (raw) Greetings, This is v3 of the patchset that adds support to the optional divider_by_two of LRADC channels. Changes in v3: - Fix merge conflict with previous existing patch. - Fix ampersand in function callback assignment. - Removed unused parameters of function to read single sample. - Ennumeration for two-dimensional array of scale (with divider by two disabled or enabled), for improved readability. - Created struct with integer and nano parts of the scale attribute, for improved readability. Changes in v2: - Fix the sample mask passed by the touchscreen driver to the input subsytem, to be 12 bits. - Move the reference voltages to the Device Tree. - Rebased to avoid conflict with Marek Vasut's prior patch. - Use IIO_DEVICE_ATTR() macro for adding scale_available property to all channels. - Make 'is_divided' unsigned int. Notes: - Other fixes were discussed in v1 but they were not part of this patchset changes, and should be handled in a separate patch. - The 64bit math to calculate the integer and decimal parts of the scaling attribute is a bit unreadable but used in other similar drivers like ad7791, ad7793, and ad7192. If it is to be changed it should be done in parallel with these, in a different patch. The first patch changes the realbits to 12. The second adds the channels reference voltages to the DT. The following add the scale read operation, scale_available read operation, and scale write operation. This was tested on a custom i.MX28 platform. Could someone please test on an i.MX23? Hector Palacios (5): iio: mxs-lradc: change the realbits to 12 ARM: dts: add reference voltage property for MXS LRADC iio: mxs-lradc: add scale attribute to channels iio: mxs-lradc: add scale_available file to channels iio: mxs-lradc: add write_raw function to modify scale .../bindings/staging/iio/adc/mxs-lradc.txt | 9 +- arch/arm/boot/dts/imx23.dtsi | 4 + arch/arm/boot/dts/imx28.dtsi | 4 + drivers/staging/iio/adc/mxs-lradc.c | 255 ++++++++++++++++++--- 4 files changed, 242 insertions(+), 30 deletions(-)
next reply other threads:[~2013-07-22 14:05 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-22 14:03 Hector Palacios [this message] 2013-07-22 14:03 ` [PATCH v3 0/5] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios 2013-07-22 14:03 ` [PATCH v3 1/5] iio: mxs-lradc: change the realbits to 12 Hector Palacios 2013-07-22 14:03 ` Hector Palacios 2013-08-13 21:24 ` Jonathan Cameron 2013-08-13 21:24 ` Jonathan Cameron 2013-07-22 14:04 ` [PATCH v3 2/5] ARM: dts: add reference voltage property for MXS LRADC Hector Palacios 2013-07-22 14:04 ` Hector Palacios 2013-07-22 18:34 ` Lars-Peter Clausen 2013-07-22 18:34 ` Lars-Peter Clausen 2013-07-22 22:06 ` Marek Vasut 2013-07-22 22:06 ` Marek Vasut 2013-07-26 9:23 ` Alexandre Belloni 2013-07-26 9:23 ` Alexandre Belloni 2013-08-13 21:23 ` Jonathan Cameron 2013-08-13 21:23 ` Jonathan Cameron 2013-08-13 21:23 ` Jonathan Cameron 2013-08-14 14:44 ` Pawel Moll 2013-08-14 14:44 ` Pawel Moll 2013-08-14 14:44 ` Pawel Moll 2013-08-21 22:13 ` Alexandre Belloni 2013-08-21 22:13 ` Alexandre Belloni 2013-08-21 22:13 ` Alexandre Belloni 2013-08-22 6:17 ` Jonathan Cameron 2013-08-22 6:17 ` Jonathan Cameron 2013-08-22 6:17 ` Jonathan Cameron 2013-08-22 16:51 ` Pawel Moll 2013-08-22 16:51 ` Pawel Moll 2013-08-23 23:00 ` Jonathan Cameron 2013-09-23 12:47 ` Alexandre Belloni 2013-09-23 12:47 ` Alexandre Belloni 2013-09-23 13:39 ` Hector Palacios 2013-09-23 13:39 ` Hector Palacios 2013-08-22 8:05 ` Hector Palacios 2013-08-22 8:05 ` Hector Palacios 2013-08-22 8:05 ` Hector Palacios 2013-08-22 16:50 ` Pawel Moll 2013-08-22 16:50 ` Pawel Moll 2013-08-22 16:50 ` Pawel Moll 2013-08-22 16:41 ` Pawel Moll 2013-08-22 16:41 ` Pawel Moll 2013-08-22 16:41 ` Pawel Moll 2013-08-22 17:00 ` Lars-Peter Clausen 2013-08-22 17:00 ` Lars-Peter Clausen 2013-08-22 17:00 ` Lars-Peter Clausen 2013-07-22 14:04 ` [PATCH v3 3/5] iio: mxs-lradc: add scale attribute to channels Hector Palacios 2013-07-22 14:04 ` Hector Palacios 2013-07-22 14:04 ` [PATCH v3 4/5] iio: mxs-lradc: add scale_available file " Hector Palacios 2013-07-22 14:04 ` Hector Palacios 2013-07-22 22:36 ` Marek Vasut 2013-07-23 7:00 ` Hector Palacios 2013-07-23 7:00 ` Hector Palacios 2013-07-23 7:00 ` Hector Palacios 2013-07-23 8:46 ` Lars-Peter Clausen 2013-07-23 8:46 ` Lars-Peter Clausen 2013-07-23 13:25 ` Hector Palacios 2013-07-23 13:25 ` Hector Palacios 2013-07-23 13:25 ` Hector Palacios 2013-07-26 13:17 ` Alexandre Belloni 2013-07-26 13:17 ` Alexandre Belloni 2013-07-26 13:17 ` Alexandre Belloni 2013-07-26 16:13 ` Jonathan Cameron 2013-07-26 16:13 ` Jonathan Cameron 2013-07-26 16:13 ` Jonathan Cameron 2013-08-07 7:50 ` Alexandre Belloni 2013-08-07 7:50 ` Alexandre Belloni 2013-08-07 7:50 ` Alexandre Belloni 2013-08-13 21:26 ` Jonathan Cameron 2013-08-13 21:26 ` Jonathan Cameron 2013-08-13 21:26 ` Jonathan Cameron 2013-07-22 14:04 ` [PATCH v3 5/5] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios 2013-07-22 14:04 ` Hector Palacios 2013-07-22 22:37 ` Marek Vasut 2013-07-22 22:37 ` Marek Vasut 2013-12-06 16:28 ` Harald Geyer 2013-12-06 16:32 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1374501843-19651-1-git-send-email-hector.palacios@digi.com \ --to=hector.palacios@digi.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=fabio.estevam@freescale.com \ --cc=jic23@kernel.org \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marex@denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.