* [PATCH v2] remotes-hg: bugfix for fetching non local remotes
@ 2013-07-24 14:21 Joern Hees
2013-07-24 23:02 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Joern Hees @ 2013-07-24 14:21 UTC (permalink / raw)
To: git; +Cc: apelisse, gitster, felipe.contreras, Joern Hees
6796d49 introduced a bug by making shared_path == ".git/hg' which
will most likely exist already, causing a new remote never to be
cloned and subsequently causing hg.share to fail with error msg:
"mercurial.error.RepoError: repository .git/hg not found"
Changing shared_path to ".git/hg/.shared" will solve this problem
and create a shared local mercurial repository for non local remotes.
The initial dot circumvents a name clash problem should a remote be
called "shared".
Signed-off-by: Joern Hees <dev@joernhees.de>
Mentored-by: Antoine Pelisse <apelisse@gmail.com>
---
contrib/remote-helpers/git-remote-hg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 0194c67..4a7d7a8 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -390,7 +390,7 @@ def get_repo(url, alias):
if not os.path.exists(dirname):
os.makedirs(dirname)
else:
- shared_path = os.path.join(gitdir, 'hg')
+ shared_path = os.path.join(gitdir, 'hg', '.share')
if not os.path.exists(shared_path):
try:
hg.clone(myui, {}, url, shared_path, update=False, pull=True)
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] remotes-hg: bugfix for fetching non local remotes
2013-07-24 14:21 [PATCH v2] remotes-hg: bugfix for fetching non local remotes Joern Hees
@ 2013-07-24 23:02 ` Junio C Hamano
2013-07-25 0:42 ` Jörn Hees
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2013-07-24 23:02 UTC (permalink / raw)
To: Joern Hees; +Cc: git, apelisse, felipe.contreras
Joern Hees <dev@joernhees.de> writes:
> 6796d49 introduced a bug by making shared_path == ".git/hg' which
> will most likely exist already, causing a new remote never to be
> cloned and subsequently causing hg.share to fail with error msg:
> "mercurial.error.RepoError: repository .git/hg not found"
>
> Changing shared_path to ".git/hg/.shared" will solve this problem
Here you say "shared" and the code says "share"; which one is
preferred (I know either would work, but we would want to be
consistent).
I'd vote for "shared", but I do not see a compelling reason to pick
one over the other so...?
> and create a shared local mercurial repository for non local remotes.
> The initial dot circumvents a name clash problem should a remote be
> called "shared".
>
> Signed-off-by: Joern Hees <dev@joernhees.de>
> Mentored-by: Antoine Pelisse <apelisse@gmail.com>
> ---
> contrib/remote-helpers/git-remote-hg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index 0194c67..4a7d7a8 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -390,7 +390,7 @@ def get_repo(url, alias):
> if not os.path.exists(dirname):
> os.makedirs(dirname)
> else:
> - shared_path = os.path.join(gitdir, 'hg')
> + shared_path = os.path.join(gitdir, 'hg', '.share')
> if not os.path.exists(shared_path):
> try:
> hg.clone(myui, {}, url, shared_path, update=False, pull=True)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] remotes-hg: bugfix for fetching non local remotes
2013-07-24 23:02 ` Junio C Hamano
@ 2013-07-25 0:42 ` Jörn Hees
0 siblings, 0 replies; 3+ messages in thread
From: Jörn Hees @ 2013-07-25 0:42 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, apelisse, felipe.contreras
On 25 Jul 2013, at 01:02, Junio C Hamano <gitster@pobox.com> wrote:
> Joern Hees <dev@joernhees.de> writes:
>>
>> Changing shared_path to ".git/hg/.shared" will solve this problem
>
> Here you say "shared" and the code says "share"; which one is
> preferred (I know either would work, but we would want to be
> consistent).
>
> I'd vote for "shared", but I do not see a compelling reason to pick
> one over the other so…?
ok, v3 coming...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-25 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-24 14:21 [PATCH v2] remotes-hg: bugfix for fetching non local remotes Joern Hees
2013-07-24 23:02 ` Junio C Hamano
2013-07-25 0:42 ` Jörn Hees
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.