* [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof
@ 2013-07-25 10:02 Shakeel, Muhammad
2013-07-25 11:08 ` Paul Eggleton
2013-07-25 16:43 ` Saul Wold
0 siblings, 2 replies; 4+ messages in thread
From: Shakeel, Muhammad @ 2013-07-25 10:02 UTC (permalink / raw)
To: openembedded-core
From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
'pidof' is alternatively coming from busybox so no need for avahi to explicitly
rdepend on sysvinit-pidof. This unnecessarily includes sysvinit in systemd only
build.
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
meta/recipes-connectivity/avahi/avahi.inc | 2 --
1 file changed, 2 deletions(-)
diff --git a/meta/recipes-connectivity/avahi/avahi.inc b/meta/recipes-connectivity/avahi/avahi.inc
index c302f87..7bb5381 100644
--- a/meta/recipes-connectivity/avahi/avahi.inc
+++ b/meta/recipes-connectivity/avahi/avahi.inc
@@ -96,8 +96,6 @@ FILES_libavahi-glib = "${libdir}/libavahi-glib.so.*"
FILES_libavahi-gobject = "${libdir}/libavahi-gobject.so.*"
FILES_avahi-utils = "${bindir}/avahi-*"
-RDEPENDS_avahi-daemon = "sysvinit-pidof"
-
# uclibc has no nss
RRECOMMENDS_avahi-daemon_append_libc-glibc = "libnss-mdns"
RRECOMMENDS_${PN}_append_libc-glibc = "libnss-mdns"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof
2013-07-25 10:02 [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof Shakeel, Muhammad
@ 2013-07-25 11:08 ` Paul Eggleton
2013-07-25 16:43 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: Paul Eggleton @ 2013-07-25 11:08 UTC (permalink / raw)
To: Shakeel, Muhammad; +Cc: openembedded-core
On Thursday 25 July 2013 15:02:04 Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> 'pidof' is alternatively coming from busybox so no need for avahi to
> explicitly rdepend on sysvinit-pidof. This unnecessarily includes sysvinit
> in systemd only build.
Surely this just results in sysvinit being built as opposed to being included
in the image?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof
2013-07-25 10:02 [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof Shakeel, Muhammad
2013-07-25 11:08 ` Paul Eggleton
@ 2013-07-25 16:43 ` Saul Wold
2013-07-30 7:58 ` Muhammad Shakeel
1 sibling, 1 reply; 4+ messages in thread
From: Saul Wold @ 2013-07-25 16:43 UTC (permalink / raw)
To: Shakeel, Muhammad; +Cc: openembedded-core
On 07/25/2013 03:02 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> 'pidof' is alternatively coming from busybox so no need for avahi to explicitly
> rdepend on sysvinit-pidof. This unnecessarily includes sysvinit in systemd only
> build.
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> ---
> meta/recipes-connectivity/avahi/avahi.inc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/avahi/avahi.inc b/meta/recipes-connectivity/avahi/avahi.inc
> index c302f87..7bb5381 100644
> --- a/meta/recipes-connectivity/avahi/avahi.inc
> +++ b/meta/recipes-connectivity/avahi/avahi.inc
> @@ -96,8 +96,6 @@ FILES_libavahi-glib = "${libdir}/libavahi-glib.so.*"
> FILES_libavahi-gobject = "${libdir}/libavahi-gobject.so.*"
> FILES_avahi-utils = "${bindir}/avahi-*"
>
> -RDEPENDS_avahi-daemon = "sysvinit-pidof"
> -
I am sure there was a reason that the sysvinit version of pidof was
required over the busybox, did you test that the busybox version works
correctly in both systemd and sysvinit usages?
It maybe that the busybox version now work correctly.
Also as Paul pointed out, this is an RDEPENDS on a single package not
all the sysvinit packages.
Sau!
> # uclibc has no nss
> RRECOMMENDS_avahi-daemon_append_libc-glibc = "libnss-mdns"
> RRECOMMENDS_${PN}_append_libc-glibc = "libnss-mdns"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof
2013-07-25 16:43 ` Saul Wold
@ 2013-07-30 7:58 ` Muhammad Shakeel
0 siblings, 0 replies; 4+ messages in thread
From: Muhammad Shakeel @ 2013-07-30 7:58 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On 07/25/2013 09:43 PM, Saul Wold wrote:
> On 07/25/2013 03:02 AM, Shakeel, Muhammad wrote:
>> -RDEPENDS_avahi-daemon = "sysvinit-pidof"
>> -
> I am sure there was a reason that the sysvinit version of pidof was
> required over the busybox, did you test that the busybox version works
> correctly in both systemd and sysvinit usages?
>
> It maybe that the busybox version now work correctly.
>
> Also as Paul pointed out, this is an RDEPENDS on a single package not
> all the sysvinit packages.
>
> Sau!
>
I have tested that pidof from busybox works fine for both systemd and
sysvinit and also avahi-daemon works fine with this.
Also sysvinit is rdepending on 'sysvinit-pidof' and for sysvinit systems
pidof will always come from inside it. It is only systemd enabled
systems which will get pidof from busybox and it seems to be working fine.
I have tried to track it that why this rdepend was added for avahi
daemon. It was added back in May 2007 but commit
(1641c2bd2c71bb08de7057b052ae74c00eedb330) message doesn't have any more
detail. I am sure that pidof from busybox is much more stable now.
This is definitely installing only 'sysvinit-pidof' but I was of the
opinion that if we can avoid all of sysvinit for systemd only build,
given that it is not impacting any of the functionality, then it will be
nice. IMHO, we should try to prevent as many unnecessary bits from
build/image as possible.
Regards,
Shakeel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-30 7:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-25 10:02 [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof Shakeel, Muhammad
2013-07-25 11:08 ` Paul Eggleton
2013-07-25 16:43 ` Saul Wold
2013-07-30 7:58 ` Muhammad Shakeel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.