All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] video: remove unused variable dev
@ 2013-07-27 10:05 ` Kefeng Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2013-07-27 10:05 UTC (permalink / raw)
  To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
	linux-kernel
  Cc: Jingoo Han, guohanjun

Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
variable dev is unused, so remove it.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/video/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */
-- 
1.8.2.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] video: remove unused variable dev
@ 2013-07-27 10:05 ` Kefeng Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2013-07-27 10:05 UTC (permalink / raw)
  To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
	linux-kernel
  Cc: Jingoo Han, guohanjun

Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
variable dev is unused, so remove it.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/video/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */
-- 
1.8.2.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] video: remove unused variable dev
  2013-07-27 10:05 ` Kefeng Wang
@ 2013-07-29  0:52   ` Jingoo Han
  -1 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-07-29  0:52 UTC (permalink / raw)
  To: 'Kefeng Wang', 'Tomi Valkeinen'
  Cc: 'Jean-Christophe Plagniol-Villard',
	linux-fbdev, linux-kernel, guohanjun, 'Luis Henriques',
	Jingoo Han

On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
> 
> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
> variable dev is unused, so remove it.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/video/vga16fb.c | 1 -
>  1 file changed, 1 deletion(-)

CC'ed Luis Henriques.


Hi Kefeng Wang,

The same patch was submitted by Luis Henriques 2 weeks ago.
Also, the patch was already applied by Tomi Valkeinen.

Best regards,
Jingoo Han

> 
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
> 
>  static void vga16fb_destroy(struct fb_info *info)
>  {
> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>  	iounmap(info->screen_base);
>  	fb_dealloc_cmap(&info->cmap);
>  	/* XXX unshare VGA regions */
> --
> 1.8.2.2



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] video: remove unused variable dev
@ 2013-07-29  0:52   ` Jingoo Han
  0 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-07-29  0:52 UTC (permalink / raw)
  To: 'Kefeng Wang', 'Tomi Valkeinen'
  Cc: 'Jean-Christophe Plagniol-Villard',
	linux-fbdev, linux-kernel, guohanjun, 'Luis Henriques',
	Jingoo Han

On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
> 
> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
> variable dev is unused, so remove it.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/video/vga16fb.c | 1 -
>  1 file changed, 1 deletion(-)

CC'ed Luis Henriques.


Hi Kefeng Wang,

The same patch was submitted by Luis Henriques 2 weeks ago.
Also, the patch was already applied by Tomi Valkeinen.

Best regards,
Jingoo Han

> 
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
> 
>  static void vga16fb_destroy(struct fb_info *info)
>  {
> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>  	iounmap(info->screen_base);
>  	fb_dealloc_cmap(&info->cmap);
>  	/* XXX unshare VGA regions */
> --
> 1.8.2.2



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] video: remove unused variable dev
  2013-07-29  0:52   ` Jingoo Han
@ 2013-07-29  1:27     ` Kefeng Wang
  -1 siblings, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2013-07-29  1:27 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Tomi Valkeinen',
	'Jean-Christophe Plagniol-Villard',
	linux-fbdev, linux-kernel, guohanjun, 'Luis Henriques'

On 07/29 8:52, Jingoo Han wrote:
> On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
>>
>> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
>> variable dev is unused, so remove it.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  drivers/video/vga16fb.c | 1 -
>>  1 file changed, 1 deletion(-)
> 
> CC'ed Luis Henriques.
> 
> 
> Hi Kefeng Wang,
> 
> The same patch was submitted by Luis Henriques 2 weeks ago.
> Also, the patch was already applied by Tomi Valkeinen.
> 
> Best regards,
> Jingoo Han
> 

Thanks for your reply, I got it, so ignore it.

>>
>> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
>> index 830ded4..2827333 100644
>> --- a/drivers/video/vga16fb.c
>> +++ b/drivers/video/vga16fb.c
>> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>>
>>  static void vga16fb_destroy(struct fb_info *info)
>>  {
>> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>>  	iounmap(info->screen_base);
>>  	fb_dealloc_cmap(&info->cmap);
>>  	/* XXX unshare VGA regions */
>> --
>> 1.8.2.2
> 
> 
> 
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] video: remove unused variable dev
@ 2013-07-29  1:27     ` Kefeng Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2013-07-29  1:27 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Tomi Valkeinen',
	'Jean-Christophe Plagniol-Villard',
	linux-fbdev, linux-kernel, guohanjun, 'Luis Henriques'

On 07/29 8:52, Jingoo Han wrote:
> On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
>>
>> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
>> variable dev is unused, so remove it.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  drivers/video/vga16fb.c | 1 -
>>  1 file changed, 1 deletion(-)
> 
> CC'ed Luis Henriques.
> 
> 
> Hi Kefeng Wang,
> 
> The same patch was submitted by Luis Henriques 2 weeks ago.
> Also, the patch was already applied by Tomi Valkeinen.
> 
> Best regards,
> Jingoo Han
> 

Thanks for your reply, I got it, so ignore it.

>>
>> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
>> index 830ded4..2827333 100644
>> --- a/drivers/video/vga16fb.c
>> +++ b/drivers/video/vga16fb.c
>> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>>
>>  static void vga16fb_destroy(struct fb_info *info)
>>  {
>> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>>  	iounmap(info->screen_base);
>>  	fb_dealloc_cmap(&info->cmap);
>>  	/* XXX unshare VGA regions */
>> --
>> 1.8.2.2
> 
> 
> 
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-29  1:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-27 10:05 [PATCH] video: remove unused variable dev Kefeng Wang
2013-07-27 10:05 ` Kefeng Wang
2013-07-29  0:52 ` Jingoo Han
2013-07-29  0:52   ` Jingoo Han
2013-07-29  1:27   ` Kefeng Wang
2013-07-29  1:27     ` Kefeng Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.