From: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>, "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [Patch net-next v2 5/8] sunrpc: use generic union inet_addr Date: Wed, 07 Aug 2013 20:27:26 +0800 [thread overview] Message-ID: <1375878446.11370.36.camel@cr0> (raw) In-Reply-To: <20130806062801.67714276-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> On Tue, 2013-08-06 at 06:28 -0400, Jeff Layton wrote: > > My question is a bit more fundamental: Why are you using this new union > in your patches instead of simply passing around "struct sockaddr" > pointers? If you did that, then you could simply replace all of the > rpc_* wrappers with your generic ones, since you wouldn't need to do > the cast to this (seemingly unnecessary) union. Because there are some places have to interpret the structure, without this union, they need to cast to either sockaddr_in or sockaddr_in6 first, which is not as pretty as using a union. For example, the code in netpoll: ipv6_addr_equal(daddr, &np->local_ip.sin6.sin6_addr) without the union, it would be: struct sockaddr_in6 *addr = (struct sockaddr_in6 *) &np->local_ip; ipv6_addr_equal(daddr, addr->sin6_addr); > > FWIW, I too am happy to see these routines moved to common code. I just > wonder whether it might make more sense to use the existing convention > instead of this new union. > Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com> To: Jeff Layton <jlayton@redhat.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Trond Myklebust <Trond.Myklebust@netapp.com>, "J. Bruce Fields" <bfields@fieldses.org>, linux-nfs@vger.kernel.org Subject: Re: [Patch net-next v2 5/8] sunrpc: use generic union inet_addr Date: Wed, 07 Aug 2013 20:27:26 +0800 [thread overview] Message-ID: <1375878446.11370.36.camel@cr0> (raw) In-Reply-To: <20130806062801.67714276@tlielax.poochiereds.net> On Tue, 2013-08-06 at 06:28 -0400, Jeff Layton wrote: > > My question is a bit more fundamental: Why are you using this new union > in your patches instead of simply passing around "struct sockaddr" > pointers? If you did that, then you could simply replace all of the > rpc_* wrappers with your generic ones, since you wouldn't need to do > the cast to this (seemingly unnecessary) union. Because there are some places have to interpret the structure, without this union, they need to cast to either sockaddr_in or sockaddr_in6 first, which is not as pretty as using a union. For example, the code in netpoll: ipv6_addr_equal(daddr, &np->local_ip.sin6.sin6_addr) without the union, it would be: struct sockaddr_in6 *addr = (struct sockaddr_in6 *) &np->local_ip; ipv6_addr_equal(daddr, addr->sin6_addr); > > FWIW, I too am happy to see these routines moved to common code. I just > wonder whether it might make more sense to use the existing convention > instead of this new union. > Thanks.
next prev parent reply other threads:[~2013-08-07 12:27 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-02 7:14 [Patch net-next v2 0/8] net: introduce generic type and helpers for IP address Cong Wang 2013-08-02 7:14 ` [Patch net-next v2 1/8] net: introduce generic union inet_addr Cong Wang 2013-08-02 21:50 ` David Miller 2013-08-05 3:09 ` Cong Wang 2013-08-02 7:14 ` [Patch net-next v2 2/8] net: introduce generic simple_inet_pton() Cong Wang 2013-08-02 7:14 ` [Patch net-next v2 3/8] inetpeer: use generic struct in_addr_gen Cong Wang 2013-08-02 7:14 ` [Patch net-next v2 4/8] bridge: " Cong Wang [not found] ` <1375427674-21735-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2013-08-02 7:14 ` [Patch net-next v2 5/8] sunrpc: use generic union inet_addr Cong Wang 2013-08-02 7:14 ` Cong Wang 2013-08-02 13:36 ` Jeff Layton [not found] ` <20130802093625.2c70a330-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> 2013-08-05 3:14 ` Cong Wang 2013-08-05 3:14 ` Cong Wang 2013-08-06 10:28 ` Jeff Layton 2013-08-06 10:28 ` Jeff Layton [not found] ` <20130806062801.67714276-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> 2013-08-07 12:27 ` Cong Wang [this message] 2013-08-07 12:27 ` Cong Wang 2013-08-07 13:21 ` Jeff Layton [not found] ` <20130807092123.451e93db-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> 2013-08-08 1:37 ` Cong Wang 2013-08-08 1:37 ` Cong Wang 2013-08-07 13:30 ` Jim Rees 2013-08-07 13:30 ` Jim Rees 2013-08-02 7:14 ` [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions Cong Wang 2013-08-02 7:14 ` [Cluster-devel] " Cong Wang 2013-08-02 10:31 ` Christoph Hellwig 2013-08-02 10:31 ` Christoph Hellwig [not found] ` <20130802103107.GA17244-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2013-08-05 3:16 ` Cong Wang 2013-08-05 3:16 ` Cong Wang 2013-08-05 3:16 ` Cong Wang 2013-08-02 7:14 ` [Patch net-next v2 7/8] sctp: use generic union inet_addr Cong Wang 2013-08-02 7:14 ` [Patch net-next v2 8/8] selinux: " Cong Wang 2013-08-02 14:34 ` Paul Moore 2013-08-02 21:51 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1375878446.11370.36.camel@cr0 \ --to=amwang-h+wxahxf7alqt0dzr+alfa@public.gmane.org \ --cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \ --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.