All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	linuxppc-dev@lists.ozlabs.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Olof Johansson <olof@lixom.net>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12
Date: Wed, 14 Aug 2013 07:03:59 +1000	[thread overview]
Message-ID: <1376427839.4255.10.camel@pasglop> (raw)
In-Reply-To: <520A536C.3030600@arm.com>

On Tue, 2013-08-13 at 16:40 +0100, Sudeep KarkadaNagesha wrote:
> There seems to be conflict in the new function "of_get_cpu_node" added.
> PowerPC also defines the same function name. Further microblaze and
> openrisc declares it(can be removed) but doesn't define it.
> To fix this:
> 1. I can rename the newly added function to something different like
>    `of_get_cpunode` or
> 2. If of_* namespace should be used by only OF/FDT and not by any
>    architecture specific code, then the arch specific version can be
>    renamed to some thing like arch_of_get_cpu_node.
>    Also most of the calls to arch specific function can be moved to
>    generic code.
> 
> Let me know your thoughts.

What is your new function about ? Does it perform the same job as the
one in powerpc ? If yes, make sure you have the same signature and
either copy the powerpc one over to a generic place or make the generic
one weak if you don't want the powerpc thread counting logic.

Cheers,
Ben.



WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Olof Johansson <olof@lixom.net>,
	linuxppc-dev@lists.ozlabs.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12
Date: Wed, 14 Aug 2013 07:03:59 +1000	[thread overview]
Message-ID: <1376427839.4255.10.camel@pasglop> (raw)
In-Reply-To: <520A536C.3030600@arm.com>

On Tue, 2013-08-13 at 16:40 +0100, Sudeep KarkadaNagesha wrote:
> There seems to be conflict in the new function "of_get_cpu_node" added.
> PowerPC also defines the same function name. Further microblaze and
> openrisc declares it(can be removed) but doesn't define it.
> To fix this:
> 1. I can rename the newly added function to something different like
>    `of_get_cpunode` or
> 2. If of_* namespace should be used by only OF/FDT and not by any
>    architecture specific code, then the arch specific version can be
>    renamed to some thing like arch_of_get_cpu_node.
>    Also most of the calls to arch specific function can be moved to
>    generic code.
> 
> Let me know your thoughts.

What is your new function about ? Does it perform the same job as the
one in powerpc ? If yes, make sure you have the same signature and
either copy the powerpc one over to a generic place or make the generic
one weak if you don't want the powerpc thread counting logic.

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] DT/core: cpu_ofnode updates for v3.12
Date: Wed, 14 Aug 2013 07:03:59 +1000	[thread overview]
Message-ID: <1376427839.4255.10.camel@pasglop> (raw)
In-Reply-To: <520A536C.3030600@arm.com>

On Tue, 2013-08-13 at 16:40 +0100, Sudeep KarkadaNagesha wrote:
> There seems to be conflict in the new function "of_get_cpu_node" added.
> PowerPC also defines the same function name. Further microblaze and
> openrisc declares it(can be removed) but doesn't define it.
> To fix this:
> 1. I can rename the newly added function to something different like
>    `of_get_cpunode` or
> 2. If of_* namespace should be used by only OF/FDT and not by any
>    architecture specific code, then the arch specific version can be
>    renamed to some thing like arch_of_get_cpu_node.
>    Also most of the calls to arch specific function can be moved to
>    generic code.
> 
> Let me know your thoughts.

What is your new function about ? Does it perform the same job as the
one in powerpc ? If yes, make sure you have the same signature and
either copy the powerpc one over to a generic place or make the generic
one weak if you don't want the powerpc thread counting logic.

Cheers,
Ben.

  parent reply	other threads:[~2013-08-13 21:04 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 13:27 [GIT PULL] DT/core: cpu_ofnode updates for v3.12 Sudeep KarkadaNagesha
2013-08-12 13:27 ` Sudeep KarkadaNagesha
2013-08-12 13:27 ` Sudeep KarkadaNagesha
2013-08-13 13:00 ` Rafael J. Wysocki
2013-08-13 13:00   ` Rafael J. Wysocki
2013-08-13 13:00   ` Rafael J. Wysocki
2013-08-13 15:40   ` Sudeep KarkadaNagesha
2013-08-13 15:40     ` Sudeep KarkadaNagesha
2013-08-13 15:40     ` Sudeep KarkadaNagesha
2013-08-13 15:40     ` Sudeep KarkadaNagesha
2013-08-13 18:29     ` Sudeep KarkadaNagesha
2013-08-13 18:29       ` Sudeep KarkadaNagesha
2013-08-13 18:29       ` Sudeep KarkadaNagesha
2013-08-13 18:29       ` Sudeep KarkadaNagesha
2013-08-13 21:07       ` Benjamin Herrenschmidt
2013-08-13 21:07         ` Benjamin Herrenschmidt
2013-08-13 21:07         ` Benjamin Herrenschmidt
2013-08-14 10:01         ` Sudeep KarkadaNagesha
2013-08-14 10:01           ` Sudeep KarkadaNagesha
2013-08-14 10:01           ` Sudeep KarkadaNagesha
2013-08-14 10:01           ` Sudeep KarkadaNagesha
2013-08-14 11:37           ` Benjamin Herrenschmidt
2013-08-14 11:37             ` Benjamin Herrenschmidt
2013-08-14 11:37             ` Benjamin Herrenschmidt
2013-08-14 13:21             ` Sudeep KarkadaNagesha
2013-08-14 13:21               ` Sudeep KarkadaNagesha
2013-08-14 13:21               ` Sudeep KarkadaNagesha
2013-08-14 13:21               ` Sudeep KarkadaNagesha
2013-08-14 22:57               ` Benjamin Herrenschmidt
2013-08-14 22:57                 ` Benjamin Herrenschmidt
2013-08-14 22:57                 ` Benjamin Herrenschmidt
2013-08-14 12:53           ` Rob Herring
2013-08-14 12:53             ` Rob Herring
2013-08-14 12:53             ` Rob Herring
2013-08-14 12:53             ` Rob Herring
2013-08-14 13:27             ` Sudeep KarkadaNagesha
2013-08-14 13:27               ` Sudeep KarkadaNagesha
2013-08-14 13:27               ` Sudeep KarkadaNagesha
2013-08-14 13:27               ` Sudeep KarkadaNagesha
2013-08-13 18:37     ` Michal Simek
2013-08-13 18:37       ` Michal Simek
2013-08-13 18:37       ` Michal Simek
2013-08-13 18:37       ` Michal Simek
2013-08-14  8:41       ` Sudeep KarkadaNagesha
2013-08-14  8:41         ` Sudeep KarkadaNagesha
2013-08-14  8:41         ` Sudeep KarkadaNagesha
2013-08-14  8:41         ` Sudeep KarkadaNagesha
2013-08-13 18:44     ` Rob Herring
2013-08-13 18:44       ` Rob Herring
2013-08-13 18:44       ` Rob Herring
2013-08-13 18:44       ` Rob Herring
2013-08-13 19:45       ` Rafael J. Wysocki
2013-08-13 19:45         ` Rafael J. Wysocki
2013-08-13 19:45         ` Rafael J. Wysocki
2013-08-13 19:45         ` Rafael J. Wysocki
2013-08-13 21:09         ` Benjamin Herrenschmidt
2013-08-13 21:09           ` Benjamin Herrenschmidt
2013-08-13 21:09           ` Benjamin Herrenschmidt
2013-08-13 21:09           ` Benjamin Herrenschmidt
2013-08-14  9:23         ` Sudeep KarkadaNagesha
2013-08-14  9:23           ` Sudeep KarkadaNagesha
2013-08-14  9:23           ` Sudeep KarkadaNagesha
2013-08-14  9:23           ` Sudeep KarkadaNagesha
2013-08-13 21:08       ` Benjamin Herrenschmidt
2013-08-13 21:08         ` Benjamin Herrenschmidt
2013-08-13 21:08         ` Benjamin Herrenschmidt
2013-08-13 21:03     ` Benjamin Herrenschmidt [this message]
2013-08-13 21:03       ` Benjamin Herrenschmidt
2013-08-13 21:03       ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2013-08-06 16:11 Sudeep KarkadaNagesha
2013-08-08 14:43 ` Sudeep KarkadaNagesha
2013-08-08 15:27   ` Rob Herring
2013-08-08 15:49     ` Sudeep KarkadaNagesha
2013-08-12  8:54       ` Sudeep KarkadaNagesha
2013-08-12  9:03         ` Viresh Kumar
2013-08-12 11:51           ` Rafael J. Wysocki
2013-08-12 12:41             ` Sudeep KarkadaNagesha
2013-08-12 13:13               ` Rafael J. Wysocki
2013-08-12 13:06                 ` Sudeep KarkadaNagesha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376427839.4255.10.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=Sudeep.KarkadaNagesha@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=olof@lixom.net \
    --cc=rjw@sisk.pl \
    --cc=rob.herring@calxeda.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.