* [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration
@ 2013-08-14 9:49 Hervé Poussineau
2013-08-18 20:05 ` Hervé Poussineau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hervé Poussineau @ 2013-08-14 9:49 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Hervé Poussineau, aliguori, av1474
This fixes the following assert when -device adlib is used:
ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/audio/adlib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
index 0421d47..db4a953 100644
--- a/hw/audio/adlib.c
+++ b/hw/audio/adlib.c
@@ -284,9 +284,9 @@ static void Adlib_fini (AdlibState *s)
}
static MemoryRegionPortio adlib_portio_list[] = {
- { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
{ 0, 4, 1, .read = adlib_read, .write = adlib_write, },
{ 0, 2, 1, .read = adlib_read, .write = adlib_write, },
+ { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
PORTIO_END_OF_LIST(),
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration
2013-08-14 9:49 [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration Hervé Poussineau
@ 2013-08-18 20:05 ` Hervé Poussineau
2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini
2013-09-01 16:01 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Hervé Poussineau @ 2013-08-18 20:05 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, aliguori, av1474, qemu-stable
Ping.
CCing stable too.
Hervé
Hervé Poussineau a écrit :
> This fixes the following assert when -device adlib is used:
> ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/audio/adlib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
> index 0421d47..db4a953 100644
> --- a/hw/audio/adlib.c
> +++ b/hw/audio/adlib.c
> @@ -284,9 +284,9 @@ static void Adlib_fini (AdlibState *s)
> }
>
> static MemoryRegionPortio adlib_portio_list[] = {
> - { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
> { 0, 4, 1, .read = adlib_read, .write = adlib_write, },
> { 0, 2, 1, .read = adlib_read, .write = adlib_write, },
> + { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
> PORTIO_END_OF_LIST(),
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] PING Re: [PATCH for-1.6] adlib: sort offsets in portio registration
2013-08-14 9:49 [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration Hervé Poussineau
2013-08-18 20:05 ` Hervé Poussineau
@ 2013-08-30 15:45 ` Paolo Bonzini
2013-09-01 16:01 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2013-08-30 15:45 UTC (permalink / raw)
To: Hervé Poussineau
Cc: qemu-trivial, aliguori, av1474, qemu-devel, qemu-stable
Il 14/08/2013 11:49, Hervé Poussineau ha scritto:
> This fixes the following assert when -device adlib is used:
> ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/audio/adlib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
> index 0421d47..db4a953 100644
> --- a/hw/audio/adlib.c
> +++ b/hw/audio/adlib.c
> @@ -284,9 +284,9 @@ static void Adlib_fini (AdlibState *s)
> }
>
> static MemoryRegionPortio adlib_portio_list[] = {
> - { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
> { 0, 4, 1, .read = adlib_read, .write = adlib_write, },
> { 0, 2, 1, .read = adlib_read, .write = adlib_write, },
> + { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
> PORTIO_END_OF_LIST(),
> };
>
>
Ping, and Cc to qemu-stable
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-1.6] adlib: sort offsets in portio registration
2013-08-14 9:49 [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration Hervé Poussineau
2013-08-18 20:05 ` Hervé Poussineau
2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini
@ 2013-09-01 16:01 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2013-09-01 16:01 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-trivial, aliguori, av1474, qemu-devel
14.08.2013 13:49, Hervé Poussineau wrote:
> This fixes the following assert when -device adlib is used:
> ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed.
Thanks, applied to the trivial-patches queue.
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-01 16:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-14 9:49 [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration Hervé Poussineau
2013-08-18 20:05 ` Hervé Poussineau
2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini
2013-09-01 16:01 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.