* [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO is detected
@ 2013-08-14 20:30 Mark Rusk
0 siblings, 0 replies; 3+ messages in thread
From: Mark Rusk @ 2013-08-14 20:30 UTC (permalink / raw)
To: arnd; +Cc: gregkh, linux-kernel, Mark Rusk, Mark Rusk
Using an uninitialized variable 'devnum' after 'goto out;' was causing
panic. Just go ahead and return, we need to ignore AUX iLO devs.
Oops: 0002 [#1] SMP
.
.
.
RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
Signed-off-by: Mark Rusk <mark.rusk@hp.com>
---
drivers/misc/hpilo.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index 621c7a3..b83e3ca 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -759,7 +759,7 @@ static int ilo_probe(struct pci_dev *pdev,
/* Ignore subsystem_device = 0x1979 (set by BIOS) */
if (pdev->subsystem_device == 0x1979)
- goto out;
+ return 0;
if (max_ccb > MAX_CCB)
max_ccb = MAX_CCB;
@@ -899,7 +899,7 @@ static void __exit ilo_exit(void)
class_destroy(ilo_class);
}
-MODULE_VERSION("1.4");
+MODULE_VERSION("1.4.1");
MODULE_ALIAS(ILO_NAME);
MODULE_DESCRIPTION(ILO_NAME);
MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO is detected
2013-08-13 14:32 Mark Rusk
@ 2013-08-14 19:17 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-08-14 19:17 UTC (permalink / raw)
To: Mark Rusk; +Cc: arnd, linux-kernel
On Tue, Aug 13, 2013 at 09:32:13AM -0500, Mark Rusk wrote:
> Using an uninitialized variable 'devnum' after 'goto out;' was causing
> panic. Just go ahead and return, we need to ignore AUX iLO devs.
>
> Oops: 0002 [#1] SMP
> .
> .
> .
> RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
> ---
> drivers/misc/hpilo.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
I think you forgot to run this patch through the checkpatch.pl tool
before you sent it out, right (hint, no signed-off-by line...)
Please fix it up and resend, so that it can be applied...
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO is detected
@ 2013-08-13 14:32 Mark Rusk
2013-08-14 19:17 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Mark Rusk @ 2013-08-13 14:32 UTC (permalink / raw)
To: arnd; +Cc: gregkh, linux-kernel, Mark Rusk
Using an uninitialized variable 'devnum' after 'goto out;' was causing
panic. Just go ahead and return, we need to ignore AUX iLO devs.
Oops: 0002 [#1] SMP
.
.
.
RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
---
drivers/misc/hpilo.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index 621c7a3..b83e3ca 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -759,7 +759,7 @@ static int ilo_probe(struct pci_dev *pdev,
/* Ignore subsystem_device = 0x1979 (set by BIOS) */
if (pdev->subsystem_device == 0x1979)
- goto out;
+ return 0;
if (max_ccb > MAX_CCB)
max_ccb = MAX_CCB;
@@ -899,7 +899,7 @@ static void __exit ilo_exit(void)
class_destroy(ilo_class);
}
-MODULE_VERSION("1.4");
+MODULE_VERSION("1.4.1");
MODULE_ALIAS(ILO_NAME);
MODULE_DESCRIPTION(ILO_NAME);
MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-14 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-14 20:30 [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO is detected Mark Rusk
-- strict thread matches above, loose matches on Subject: below --
2013-08-13 14:32 Mark Rusk
2013-08-14 19:17 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.