[PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[Sachin Kamat]

Fixes some trivial typos.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
This series is based on next branch of below tree:
git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git

This is tested on Exynos4210 and 5250 based boards.
---
 drivers/thermal/samsung/Kconfig |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
index b653f15..92492e4 100644
--- a/drivers/thermal/samsung/Kconfig
+++ b/drivers/thermal/samsung/Kconfig
@@ -3,16 +3,16 @@ config EXYNOS_THERMAL
 	depends on ARCH_HAS_BANDGAP
 	help
 	  If you say yes here you get support for the TMU (Thermal Management
-	  Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
+	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
 	  the TMU, reports temperature and handles cooling action if defined.
-	  This driver uses the exynos core thermal API's and TMU configuration
-	  data from the supported soc's.
+	  This driver uses the Exynos core thermal APIs and TMU configuration
+	  data from the supported SoCs.
 
 config EXYNOS_THERMAL_CORE
-	bool "Core thermal framework support for EXYNOS SOC's"
+	bool "Core thermal framework support for EXYNOS SOCs"
 	depends on EXYNOS_THERMAL
 	help
 	  If you say yes here you get support for EXYNOS TMU
 	  (Thermal Management Unit) common registration/unregistration
 	  functions to the core thermal layer and also to use the generic
-	  cpu cooling API's.
+	  CPU cooling APIs.
-- 
1.7.9.5

[PATCH 2/3] thermal: exynos: Fix potential NULL pointer dereference

[Sachin Kamat]

NULL pointer was being dereferenced in its own error message.
Changed it to the correct device pointer.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/thermal/samsung/exynos_thermal_common.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c
index 4d8e444..f10a6ad 100644
--- a/drivers/thermal/samsung/exynos_thermal_common.c
+++ b/drivers/thermal/samsung/exynos_thermal_common.c
@@ -53,7 +53,7 @@ static int exynos_set_mode(struct thermal_zone_device *thermal,
 {
 	struct exynos_thermal_zone *th_zone = thermal->devdata;
 	if (!th_zone) {
-		dev_err(th_zone->sensor_conf->dev,
+		dev_err(&thermal->device,
 			"thermal zone not registered\n");
 		return 0;
 	}
@@ -231,7 +231,7 @@ static int exynos_get_temp(struct thermal_zone_device *thermal,
 	void *data;
 
 	if (!th_zone->sensor_conf) {
-		dev_err(th_zone->sensor_conf->dev,
+		dev_err(&thermal->device,
 			"Temperature sensor not initialised\n");
 		return -EINVAL;
 	}
@@ -251,7 +251,7 @@ static int exynos_set_emul_temp(struct thermal_zone_device *thermal,
 	struct exynos_thermal_zone *th_zone = thermal->devdata;
 
 	if (!th_zone->sensor_conf) {
-		dev_err(th_zone->sensor_conf->dev,
+		dev_err(&thermal->device,
 			"Temperature sensor not initialised\n");
 		return -EINVAL;
 	}
-- 
1.7.9.5

[PATCH 3/3] thermal: exynos: Clean up non-DT remnants

[Sachin Kamat]

Commit 1cd1ecb6 ("thermal: exynos: Remove non DT based support")
cleaned up some non-DT code. However, there were few more things
needed for complete cleanup to make this driver DT only.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/thermal/samsung/Kconfig      |    2 +-
 drivers/thermal/samsung/exynos_tmu.c |   30 ++++++++++++------------------
 2 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
index 92492e4..f760389 100644
--- a/drivers/thermal/samsung/Kconfig
+++ b/drivers/thermal/samsung/Kconfig
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
 	tristate "Exynos thermal management unit driver"
-	depends on ARCH_HAS_BANDGAP
+	depends on ARCH_HAS_BANDGAP && OF
 	help
 	  If you say yes here you get support for the TMU (Thermal Management
 	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index a033dbb..b43afda 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -481,7 +481,6 @@ static irqreturn_t exynos_tmu_irq(int irq, void *id)
 	return IRQ_HANDLED;
 }
 
-#ifdef CONFIG_OF
 static const struct of_device_id exynos_tmu_match[] = {
 	{
 		.compatible = "samsung,exynos4210-tmu",
@@ -502,27 +501,22 @@ static const struct of_device_id exynos_tmu_match[] = {
 	{},
 };
 MODULE_DEVICE_TABLE(of, exynos_tmu_match);
-#endif
 
 static inline struct  exynos_tmu_platform_data *exynos_get_driver_data(
 			struct platform_device *pdev, int id)
 {
-#ifdef CONFIG_OF
 	struct  exynos_tmu_init_data *data_table;
 	struct exynos_tmu_platform_data *tmu_data;
-	if (pdev->dev.of_node) {
-		const struct of_device_id *match;
-		match = of_match_node(exynos_tmu_match, pdev->dev.of_node);
-		if (!match)
-			return NULL;
-		data_table = (struct exynos_tmu_init_data *) match->data;
-		if (!data_table || id >= data_table->tmu_count)
-			return NULL;
-		tmu_data = data_table->tmu_data;
-		return (struct exynos_tmu_platform_data *) (tmu_data + id);
-	}
-#endif
-	return NULL;
+	const struct of_device_id *match;
+
+	match = of_match_node(exynos_tmu_match, pdev->dev.of_node);
+	if (!match)
+		return NULL;
+	data_table = (struct exynos_tmu_init_data *) match->data;
+	if (!data_table || id >= data_table->tmu_count)
+		return NULL;
+	tmu_data = data_table->tmu_data;
+	return (struct exynos_tmu_platform_data *) (tmu_data + id);
 }
 
 static int exynos_map_dt_data(struct platform_device *pdev)
@@ -532,7 +526,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
 	struct resource res;
 	int ret;
 
-	if (!data)
+	if (!data || !pdev->dev.of_node)
 		return -ENODEV;
 
 	/*
@@ -754,7 +748,7 @@ static struct platform_driver exynos_tmu_driver = {
 		.name   = "exynos-tmu",
 		.owner  = THIS_MODULE,
 		.pm     = EXYNOS_TMU_PM,
-		.of_match_table = of_match_ptr(exynos_tmu_match),
+		.of_match_table = exynos_tmu_match,
 	},
 	.probe = exynos_tmu_probe,
 	.remove	= exynos_tmu_remove,
-- 
1.7.9.5

Re: [PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[Sachin Kamat]

Hi,

On 19 August 2013 11:58, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes some trivial typos.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> This series is based on next branch of below tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
>
> This is tested on Exynos4210 and 5250 based boards.
> ---
>  drivers/thermal/samsung/Kconfig |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index b653f15..92492e4 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -3,16 +3,16 @@ config EXYNOS_THERMAL
>         depends on ARCH_HAS_BANDGAP
>         help
>           If you say yes here you get support for the TMU (Thermal Management
> -         Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
> +         Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
>           the TMU, reports temperature and handles cooling action if defined.
> -         This driver uses the exynos core thermal API's and TMU configuration
> -         data from the supported soc's.
> +         This driver uses the Exynos core thermal APIs and TMU configuration
> +         data from the supported SoCs.
>
>  config EXYNOS_THERMAL_CORE
> -       bool "Core thermal framework support for EXYNOS SOC's"
> +       bool "Core thermal framework support for EXYNOS SOCs"
>         depends on EXYNOS_THERMAL
>         help
>           If you say yes here you get support for EXYNOS TMU
>           (Thermal Management Unit) common registration/unregistration
>           functions to the core thermal layer and also to use the generic
> -         cpu cooling API's.
> +         CPU cooling APIs.
> --
> 1.7.9.5
>

Any comments on this series?


-- 
With warm regards,
Sachin

Re: [PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[amit daniel kachhap]

On Mon, Aug 26, 2013 at 7:45 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi,
>
> On 19 August 2013 11:58, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Fixes some trivial typos.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> This series is based on next branch of below tree:
>> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
>>
>> This is tested on Exynos4210 and 5250 based boards.
>> ---
>>  drivers/thermal/samsung/Kconfig |   10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
>> index b653f15..92492e4 100644
>> --- a/drivers/thermal/samsung/Kconfig
>> +++ b/drivers/thermal/samsung/Kconfig
>> @@ -3,16 +3,16 @@ config EXYNOS_THERMAL
>>         depends on ARCH_HAS_BANDGAP
>>         help
>>           If you say yes here you get support for the TMU (Thermal Management
>> -         Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
>> +         Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
>>           the TMU, reports temperature and handles cooling action if defined.
>> -         This driver uses the exynos core thermal API's and TMU configuration
>> -         data from the supported soc's.
>> +         This driver uses the Exynos core thermal APIs and TMU configuration
>> +         data from the supported SoCs.
>>
>>  config EXYNOS_THERMAL_CORE
>> -       bool "Core thermal framework support for EXYNOS SOC's"
>> +       bool "Core thermal framework support for EXYNOS SOCs"
>>         depends on EXYNOS_THERMAL
>>         help
>>           If you say yes here you get support for EXYNOS TMU
>>           (Thermal Management Unit) common registration/unregistration
>>           functions to the core thermal layer and also to use the generic
>> -         cpu cooling API's.
>> +         CPU cooling APIs.
>> --
>> 1.7.9.5
>>
>
> Any comments on this series?
Looks OK.
Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com>

Thanks,
Amit
>
>
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Mon, Aug 26, 2013 at 7:45 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi,
>
> On 19 August 2013 11:58, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Fixes some trivial typos.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> This series is based on next branch of below tree:
>> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
>>
>> This is tested on Exynos4210 and 5250 based boards.
>> ---
>>  drivers/thermal/samsung/Kconfig |   10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
>> index b653f15..92492e4 100644
>> --- a/drivers/thermal/samsung/Kconfig
>> +++ b/drivers/thermal/samsung/Kconfig
>> @@ -3,16 +3,16 @@ config EXYNOS_THERMAL
>>         depends on ARCH_HAS_BANDGAP
>>         help
>>           If you say yes here you get support for the TMU (Thermal Management
>> -         Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
>> +         Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
>>           the TMU, reports temperature and handles cooling action if defined.
>> -         This driver uses the exynos core thermal API's and TMU configuration
>> -         data from the supported soc's.
>> +         This driver uses the Exynos core thermal APIs and TMU configuration
>> +         data from the supported SoCs.
>>
>>  config EXYNOS_THERMAL_CORE
>> -       bool "Core thermal framework support for EXYNOS SOC's"
>> +       bool "Core thermal framework support for EXYNOS SOCs"
>>         depends on EXYNOS_THERMAL
>>         help
>>           If you say yes here you get support for EXYNOS TMU
>>           (Thermal Management Unit) common registration/unregistration
>>           functions to the core thermal layer and also to use the generic
>> -         cpu cooling API's.
>> +         CPU cooling APIs.
>> --
>> 1.7.9.5
>>
>
> Any comments on this series?
>
>
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] thermal: exynos: Clean up non-DT remnants

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 3518 bytes --]

On 19-08-2013 02:28, Sachin Kamat wrote:
> Commit 1cd1ecb6 ("thermal: exynos: Remove non DT based support")
> cleaned up some non-DT code. However, there were few more things
> needed for complete cleanup to make this driver DT only.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/thermal/samsung/Kconfig      |    2 +-
>  drivers/thermal/samsung/exynos_tmu.c |   30 ++++++++++++------------------
>  2 files changed, 13 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index 92492e4..f760389 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -1,6 +1,6 @@
>  config EXYNOS_THERMAL
>  	tristate "Exynos thermal management unit driver"
> -	depends on ARCH_HAS_BANDGAP
> +	depends on ARCH_HAS_BANDGAP && OF
>  	help
>  	  If you say yes here you get support for the TMU (Thermal Management
>  	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index a033dbb..b43afda 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -481,7 +481,6 @@ static irqreturn_t exynos_tmu_irq(int irq, void *id)
>  	return IRQ_HANDLED;
>  }
>  
> -#ifdef CONFIG_OF
>  static const struct of_device_id exynos_tmu_match[] = {
>  	{
>  		.compatible = "samsung,exynos4210-tmu",
> @@ -502,27 +501,22 @@ static const struct of_device_id exynos_tmu_match[] = {
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, exynos_tmu_match);
> -#endif
>  
>  static inline struct  exynos_tmu_platform_data *exynos_get_driver_data(
>  			struct platform_device *pdev, int id)
>  {
> -#ifdef CONFIG_OF
>  	struct  exynos_tmu_init_data *data_table;
>  	struct exynos_tmu_platform_data *tmu_data;
> -	if (pdev->dev.of_node) {
> -		const struct of_device_id *match;
> -		match = of_match_node(exynos_tmu_match, pdev->dev.of_node);
> -		if (!match)
> -			return NULL;
> -		data_table = (struct exynos_tmu_init_data *) match->data;
> -		if (!data_table || id >= data_table->tmu_count)
> -			return NULL;
> -		tmu_data = data_table->tmu_data;
> -		return (struct exynos_tmu_platform_data *) (tmu_data + id);
> -	}
> -#endif
> -	return NULL;
> +	const struct of_device_id *match;
> +
> +	match = of_match_node(exynos_tmu_match, pdev->dev.of_node);
> +	if (!match)
> +		return NULL;
> +	data_table = (struct exynos_tmu_init_data *) match->data;
> +	if (!data_table || id >= data_table->tmu_count)
> +		return NULL;
> +	tmu_data = data_table->tmu_data;
> +	return (struct exynos_tmu_platform_data *) (tmu_data + id);
>  }
>  
>  static int exynos_map_dt_data(struct platform_device *pdev)
> @@ -532,7 +526,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
>  	struct resource res;
>  	int ret;
>  
> -	if (!data)
> +	if (!data || !pdev->dev.of_node)
>  		return -ENODEV;
>  
>  	/*
> @@ -754,7 +748,7 @@ static struct platform_driver exynos_tmu_driver = {
>  		.name   = "exynos-tmu",
>  		.owner  = THIS_MODULE,
>  		.pm     = EXYNOS_TMU_PM,
> -		.of_match_table = of_match_ptr(exynos_tmu_match),
> +		.of_match_table = exynos_tmu_match,
>  	},
>  	.probe = exynos_tmu_probe,
>  	.remove	= exynos_tmu_remove,
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

Re: [PATCH 2/3] thermal: exynos: Fix potential NULL pointer dereference

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

On 19-08-2013 02:28, Sachin Kamat wrote:
> NULL pointer was being dereferenced in its own error message.
> Changed it to the correct device pointer.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>


Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/thermal/samsung/exynos_thermal_common.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c
> index 4d8e444..f10a6ad 100644
> --- a/drivers/thermal/samsung/exynos_thermal_common.c
> +++ b/drivers/thermal/samsung/exynos_thermal_common.c
> @@ -53,7 +53,7 @@ static int exynos_set_mode(struct thermal_zone_device *thermal,
>  {
>  	struct exynos_thermal_zone *th_zone = thermal->devdata;
>  	if (!th_zone) {
> -		dev_err(th_zone->sensor_conf->dev,
> +		dev_err(&thermal->device,
>  			"thermal zone not registered\n");
>  		return 0;
>  	}
> @@ -231,7 +231,7 @@ static int exynos_get_temp(struct thermal_zone_device *thermal,
>  	void *data;
>  
>  	if (!th_zone->sensor_conf) {
> -		dev_err(th_zone->sensor_conf->dev,
> +		dev_err(&thermal->device,
>  			"Temperature sensor not initialised\n");
>  		return -EINVAL;
>  	}
> @@ -251,7 +251,7 @@ static int exynos_set_emul_temp(struct thermal_zone_device *thermal,
>  	struct exynos_thermal_zone *th_zone = thermal->devdata;
>  
>  	if (!th_zone->sensor_conf) {
> -		dev_err(th_zone->sensor_conf->dev,
> +		dev_err(&thermal->device,
>  			"Temperature sensor not initialised\n");
>  		return -EINVAL;
>  	}
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

Re: [PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

On 19-08-2013 02:28, Sachin Kamat wrote:
> Fixes some trivial typos.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>


Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
> This series is based on next branch of below tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
> 
> This is tested on Exynos4210 and 5250 based boards.
> ---
>  drivers/thermal/samsung/Kconfig |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index b653f15..92492e4 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -3,16 +3,16 @@ config EXYNOS_THERMAL
>  	depends on ARCH_HAS_BANDGAP
>  	help
>  	  If you say yes here you get support for the TMU (Thermal Management
> -	  Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
> +	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
>  	  the TMU, reports temperature and handles cooling action if defined.
> -	  This driver uses the exynos core thermal API's and TMU configuration
> -	  data from the supported soc's.
> +	  This driver uses the Exynos core thermal APIs and TMU configuration
> +	  data from the supported SoCs.
>  
>  config EXYNOS_THERMAL_CORE
> -	bool "Core thermal framework support for EXYNOS SOC's"
> +	bool "Core thermal framework support for EXYNOS SOCs"
>  	depends on EXYNOS_THERMAL
>  	help
>  	  If you say yes here you get support for EXYNOS TMU
>  	  (Thermal Management Unit) common registration/unregistration
>  	  functions to the core thermal layer and also to use the generic
> -	  cpu cooling API's.
> +	  CPU cooling APIs.
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

Re: [PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[Zhang Rui]

On 四, 2013-08-29 at 08:17 -0400, Eduardo Valentin wrote:
> On 19-08-2013 02:28, Sachin Kamat wrote:
> > Fixes some trivial typos.
> > 
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> 
> Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> 
so are you going to take this patch series?

thanks,
rui
> > ---
> > This series is based on next branch of below tree:
> > git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
> > 
> > This is tested on Exynos4210 and 5250 based boards.
> > ---
> >  drivers/thermal/samsung/Kconfig |   10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> > index b653f15..92492e4 100644
> > --- a/drivers/thermal/samsung/Kconfig
> > +++ b/drivers/thermal/samsung/Kconfig
> > @@ -3,16 +3,16 @@ config EXYNOS_THERMAL
> >  	depends on ARCH_HAS_BANDGAP
> >  	help
> >  	  If you say yes here you get support for the TMU (Thermal Management
> > -	  Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
> > +	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
> >  	  the TMU, reports temperature and handles cooling action if defined.
> > -	  This driver uses the exynos core thermal API's and TMU configuration
> > -	  data from the supported soc's.
> > +	  This driver uses the Exynos core thermal APIs and TMU configuration
> > +	  data from the supported SoCs.
> >  
> >  config EXYNOS_THERMAL_CORE
> > -	bool "Core thermal framework support for EXYNOS SOC's"
> > +	bool "Core thermal framework support for EXYNOS SOCs"
> >  	depends on EXYNOS_THERMAL
> >  	help
> >  	  If you say yes here you get support for EXYNOS TMU
> >  	  (Thermal Management Unit) common registration/unregistration
> >  	  functions to the core thermal layer and also to use the generic
> > -	  cpu cooling API's.
> > +	  CPU cooling APIs.
> > 
> 
> 

Re: [PATCH 1/3] thermal: exynos: Fix typos in Kconfig

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]

On 30-08-2013 04:35, Zhang Rui wrote:
> On 四, 2013-08-29 at 08:17 -0400, Eduardo Valentin wrote:
>> On 19-08-2013 02:28, Sachin Kamat wrote:
>>> Fixes some trivial typos.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>>
>> Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
>>
> so are you going to take this patch series?
> 

Yeah. already applied them in my next branch.

I will send a pull request with this one and ti-soc-thermal fixes when I
am done testing.

> thanks,
> rui
>>> ---
>>> This series is based on next branch of below tree:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
>>>
>>> This is tested on Exynos4210 and 5250 based boards.
>>> ---
>>>  drivers/thermal/samsung/Kconfig |   10 +++++-----
>>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
>>> index b653f15..92492e4 100644
>>> --- a/drivers/thermal/samsung/Kconfig
>>> +++ b/drivers/thermal/samsung/Kconfig
>>> @@ -3,16 +3,16 @@ config EXYNOS_THERMAL
>>>  	depends on ARCH_HAS_BANDGAP
>>>  	help
>>>  	  If you say yes here you get support for the TMU (Thermal Management
>>> -	  Unit) driver for SAMSUNG EXYNOS series of soc. This driver initialises
>>> +	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
>>>  	  the TMU, reports temperature and handles cooling action if defined.
>>> -	  This driver uses the exynos core thermal API's and TMU configuration
>>> -	  data from the supported soc's.
>>> +	  This driver uses the Exynos core thermal APIs and TMU configuration
>>> +	  data from the supported SoCs.
>>>  
>>>  config EXYNOS_THERMAL_CORE
>>> -	bool "Core thermal framework support for EXYNOS SOC's"
>>> +	bool "Core thermal framework support for EXYNOS SOCs"
>>>  	depends on EXYNOS_THERMAL
>>>  	help
>>>  	  If you say yes here you get support for EXYNOS TMU
>>>  	  (Thermal Management Unit) common registration/unregistration
>>>  	  functions to the core thermal layer and also to use the generic
>>> -	  cpu cooling API's.
>>> +	  CPU cooling APIs.
>>>
>>
>>
> 
> 
> 
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]