[PATCH v6 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for Exynos5250

[PATCH v6 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for Exynos5250

[Vikas Sajjan]

This patchset does the following 3 things:
 1) Fixes the RTC DT node name for Exynos5250
 2) Update the "status" property of RTC DT node for Exynos5250 SoC
 3) Adds RTC DT node to Exynos5420 SoC

changes since v5:
	- Fixed the RTC DT node name for Exynos5250 board files also,
	because otherwise it breaks RTC support in bisections.

changes since v4:
	- removed "status" property of RTC DT node from exynos5250 board dts files 

changes since v3:
	- split the 5250 related modifications into 2 separate patch as 
	suggested by Tomasz Figa <t.figa@samsung.com>

changes since v2:
	- split the 5250 related modifications into a separate patch.
	- placed the RTC node as per the alphabetical order in the DTS file as
	suggested by Kukjin Kim <kgene@kernel.org>.

changes since v1:
	- made DT node status as "okay" in the dtsi file itself.

Vikas Sajjan (3):
  ARM: dts: Fix the RTC DT node name for Exynos5250
  ARM: dts: Update the "status" property of RTC DT node for Exynos5250
    SoC
  ARM: dts: Add RTC DT node to Exynos5420 SoC

 arch/arm/boot/dts/exynos5.dtsi           |    2 +-
 arch/arm/boot/dts/exynos5250-arndale.dts |    4 ----
 arch/arm/boot/dts/exynos5250-snow.dts    |    4 ----
 arch/arm/boot/dts/exynos5250.dtsi        |    3 ++-
 arch/arm/boot/dts/exynos5420.dtsi        |    6 ++++++
 5 files changed, 9 insertions(+), 10 deletions(-)

-- 
1.7.9.5

[PATCH v6 1/3] ARM: dts: Fix the RTC DT node name for Exynos5250

[Vikas Sajjan]

Fixes the RTC DT node name for Exynos5250 as per the DT node naming
convention.

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
 arch/arm/boot/dts/exynos5.dtsi           |    2 +-
 arch/arm/boot/dts/exynos5250-arndale.dts |    2 +-
 arch/arm/boot/dts/exynos5250-snow.dts    |    2 +-
 arch/arm/boot/dts/exynos5250.dtsi        |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index 6afa57d..074739d 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -95,7 +95,7 @@
 		interrupts = <0 54 0>;
 	};
 
-	rtc {
+	rtc@101E0000 {
 		compatible = "samsung,s3c6410-rtc";
 		reg = <0x101E0000 0x100>;
 		interrupts = <0 43 0>, <0 44 0>;
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 452d0b0..264913f 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -538,7 +538,7 @@
 		};
 	};
 
-	rtc {
+	rtc@101E0000 {
 		status = "okay";
 	};
 
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index e79331d..24413a6 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -171,7 +171,7 @@
 		};
 	};
 
-	rtc {
+	rtc@101E0000 {
 		status = "okay";
 	};
 
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 1eec646..b278b00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -180,7 +180,7 @@
 		clock-names = "mfc";
 	};
 
-	rtc {
+	rtc@101E0000 {
 		clocks = <&clock 337>;
 		clock-names = "rtc";
 	};
-- 
1.7.9.5

[PATCH v6 2/3] ARM: dts: Update the "status" property of RTC DT node for Exynos5250 SoC

[Vikas Sajjan]

Moves the RTC DT node's "status" property from exynos5250 board
(arndale & snow) dts files to exynos5250.dtsi, since the bindings
in exynos5250.dtsi depicts the RTC h/w completely.

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
 arch/arm/boot/dts/exynos5250-arndale.dts |    4 ----
 arch/arm/boot/dts/exynos5250-snow.dts    |    4 ----
 arch/arm/boot/dts/exynos5250.dtsi        |    1 +
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 264913f..cee55fa 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -538,10 +538,6 @@
 		};
 	};
 
-	rtc@101E0000 {
-		status = "okay";
-	};
-
 	usb_hub_bus {
 		compatible = "simple-bus";
 		#address-cells = <1>;
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 24413a6..fd711e2 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -171,10 +171,6 @@
 		};
 	};
 
-	rtc@101E0000 {
-		status = "okay";
-	};
-
 	/*
 	 * On Snow we've got SIP WiFi and so can keep drive strengths low to
 	 * reduce EMI.
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index b278b00..b054c3c 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -183,6 +183,7 @@
 	rtc@101E0000 {
 		clocks = <&clock 337>;
 		clock-names = "rtc";
+		status = "okay";
 	};
 
 	tmu@10060000 {
-- 
1.7.9.5

[PATCH v6 3/3] ARM: dts: Add RTC DT node to Exynos5420 SoC

[Vikas Sajjan]

Adds RTC DT node to Exynos5420 SoC

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
 arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 5353e32..3f2b9c4 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -180,6 +180,12 @@
 		interrupts = <0 47 0>;
 	};
 
+	rtc@101E0000 {
+		clocks = <&clock 317>;
+		clock-names = "rtc";
+		status = "okay";
+	};
+
 	serial@12C00000 {
 		clocks = <&clock 257>, <&clock 128>;
 		clock-names = "uart", "clk_uart_baud0";
-- 
1.7.9.5

Re: [PATCH v6 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for Exynos5250

[Tomasz Figa]

Hi Vikas,

On Thursday 22 of August 2013 18:29:00 Vikas Sajjan wrote:
> This patchset does the following 3 things:
>  1) Fixes the RTC DT node name for Exynos5250
>  2) Update the "status" property of RTC DT node for Exynos5250 SoC
>  3) Adds RTC DT node to Exynos5420 SoC
> 
> changes since v5:
> 	- Fixed the RTC DT node name for Exynos5250 board files also,
> 	because otherwise it breaks RTC support in bisections.
> 
> changes since v4:
> 	- removed "status" property of RTC DT node from exynos5250 board dts
> files
> 
> changes since v3:
> 	- split the 5250 related modifications into 2 separate patch as
> 	suggested by Tomasz Figa <t.figa@samsung.com>
> 
> changes since v2:
> 	- split the 5250 related modifications into a separate patch.
> 	- placed the RTC node as per the alphabetical order in the DTS file as
> 	suggested by Kukjin Kim <kgene@kernel.org>.
> 
> changes since v1:
> 	- made DT node status as "okay" in the dtsi file itself.
> 
> Vikas Sajjan (3):
>   ARM: dts: Fix the RTC DT node name for Exynos5250
>   ARM: dts: Update the "status" property of RTC DT node for Exynos5250
>     SoC
>   ARM: dts: Add RTC DT node to Exynos5420 SoC
> 
>  arch/arm/boot/dts/exynos5.dtsi           |    2 +-
>  arch/arm/boot/dts/exynos5250-arndale.dts |    4 ----
>  arch/arm/boot/dts/exynos5250-snow.dts    |    4 ----
>  arch/arm/boot/dts/exynos5250.dtsi        |    3 ++-
>  arch/arm/boot/dts/exynos5420.dtsi        |    6 ++++++
>  5 files changed, 9 insertions(+), 10 deletions(-)

Looks good to me now.

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

Re: [PATCH v6 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for Exynos5250

[Vikas Sajjan]

Hi Kukjin,

On Thu, Aug 22, 2013 at 6:37 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Vikas,
>
> On Thursday 22 of August 2013 18:29:00 Vikas Sajjan wrote:
>> This patchset does the following 3 things:
>>  1) Fixes the RTC DT node name for Exynos5250
>>  2) Update the "status" property of RTC DT node for Exynos5250 SoC
>>  3) Adds RTC DT node to Exynos5420 SoC
>>
>> changes since v5:
>>       - Fixed the RTC DT node name for Exynos5250 board files also,
>>       because otherwise it breaks RTC support in bisections.
>>
>> changes since v4:
>>       - removed "status" property of RTC DT node from exynos5250 board dts
>> files
>>
>> changes since v3:
>>       - split the 5250 related modifications into 2 separate patch as
>>       suggested by Tomasz Figa <t.figa@samsung.com>
>>
>> changes since v2:
>>       - split the 5250 related modifications into a separate patch.
>>       - placed the RTC node as per the alphabetical order in the DTS file as
>>       suggested by Kukjin Kim <kgene@kernel.org>.
>>
>> changes since v1:
>>       - made DT node status as "okay" in the dtsi file itself.
>>
>> Vikas Sajjan (3):
>>   ARM: dts: Fix the RTC DT node name for Exynos5250
>>   ARM: dts: Update the "status" property of RTC DT node for Exynos5250
>>     SoC
>>   ARM: dts: Add RTC DT node to Exynos5420 SoC
>>
>>  arch/arm/boot/dts/exynos5.dtsi           |    2 +-
>>  arch/arm/boot/dts/exynos5250-arndale.dts |    4 ----
>>  arch/arm/boot/dts/exynos5250-snow.dts    |    4 ----
>>  arch/arm/boot/dts/exynos5250.dtsi        |    3 ++-
>>  arch/arm/boot/dts/exynos5420.dtsi        |    6 ++++++
>>  5 files changed, 9 insertions(+), 10 deletions(-)
>
> Looks good to me now.
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>


Can you apply this patchset.

>
> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for Exynos5250

[Kukjin Kim]

On 08/23/13 11:49, Vikas Sajjan wrote:
> Hi Kukjin,
>
> On Thu, Aug 22, 2013 at 6:37 PM, Tomasz Figa<t.figa@samsung.com>  wrote:
>> Hi Vikas,
>>
>> On Thursday 22 of August 2013 18:29:00 Vikas Sajjan wrote:
>>> This patchset does the following 3 things:
>>>   1) Fixes the RTC DT node name for Exynos5250
>>>   2) Update the "status" property of RTC DT node for Exynos5250 SoC
>>>   3) Adds RTC DT node to Exynos5420 SoC
>>>
>>> changes since v5:
>>>        - Fixed the RTC DT node name for Exynos5250 board files also,
>>>        because otherwise it breaks RTC support in bisections.
>>>
>>> changes since v4:
>>>        - removed "status" property of RTC DT node from exynos5250 board dts
>>> files
>>>
>>> changes since v3:
>>>        - split the 5250 related modifications into 2 separate patch as
>>>        suggested by Tomasz Figa<t.figa@samsung.com>
>>>
>>> changes since v2:
>>>        - split the 5250 related modifications into a separate patch.
>>>        - placed the RTC node as per the alphabetical order in the DTS file as
>>>        suggested by Kukjin Kim<kgene@kernel.org>.
>>>
>>> changes since v1:
>>>        - made DT node status as "okay" in the dtsi file itself.
>>>
>>> Vikas Sajjan (3):
>>>    ARM: dts: Fix the RTC DT node name for Exynos5250
>>>    ARM: dts: Update the "status" property of RTC DT node for Exynos5250
>>>      SoC
>>>    ARM: dts: Add RTC DT node to Exynos5420 SoC
>>>
>>>   arch/arm/boot/dts/exynos5.dtsi           |    2 +-
>>>   arch/arm/boot/dts/exynos5250-arndale.dts |    4 ----
>>>   arch/arm/boot/dts/exynos5250-snow.dts    |    4 ----
>>>   arch/arm/boot/dts/exynos5250.dtsi        |    3 ++-
>>>   arch/arm/boot/dts/exynos5420.dtsi        |    6 ++++++
>>>   5 files changed, 9 insertions(+), 10 deletions(-)
>>
>> Looks good to me now.
>>
>> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
>
>
> Can you apply this patchset.
>

Applied this whole series.

Thanks,
Kukjin

Re: [PATCH v6 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for Exynos5250

[Vikas Sajjan]

Hi Kukjin,

On 25 August 2013 22:53, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 08/23/13 11:49, Vikas Sajjan wrote:
>>
>> Hi Kukjin,
>>
>> On Thu, Aug 22, 2013 at 6:37 PM, Tomasz Figa<t.figa@samsung.com>  wrote:
>>>
>>> Hi Vikas,
>>>
>>> On Thursday 22 of August 2013 18:29:00 Vikas Sajjan wrote:
>>>>
>>>> This patchset does the following 3 things:
>>>>   1) Fixes the RTC DT node name for Exynos5250
>>>>   2) Update the "status" property of RTC DT node for Exynos5250 SoC
>>>>   3) Adds RTC DT node to Exynos5420 SoC
>>>>
>>>> changes since v5:
>>>>        - Fixed the RTC DT node name for Exynos5250 board files also,
>>>>        because otherwise it breaks RTC support in bisections.
>>>>
>>>> changes since v4:
>>>>        - removed "status" property of RTC DT node from exynos5250 board
>>>> dts
>>>> files
>>>>
>>>> changes since v3:
>>>>        - split the 5250 related modifications into 2 separate patch as
>>>>        suggested by Tomasz Figa<t.figa@samsung.com>
>>>>
>>>> changes since v2:
>>>>        - split the 5250 related modifications into a separate patch.
>>>>        - placed the RTC node as per the alphabetical order in the DTS
>>>> file as
>>>>        suggested by Kukjin Kim<kgene@kernel.org>.
>>>>
>>>> changes since v1:
>>>>        - made DT node status as "okay" in the dtsi file itself.
>>>>
>>>> Vikas Sajjan (3):
>>>>    ARM: dts: Fix the RTC DT node name for Exynos5250
>>>>    ARM: dts: Update the "status" property of RTC DT node for Exynos5250
>>>>      SoC
>>>>    ARM: dts: Add RTC DT node to Exynos5420 SoC
>>>>
>>>>   arch/arm/boot/dts/exynos5.dtsi           |    2 +-
>>>>   arch/arm/boot/dts/exynos5250-arndale.dts |    4 ----
>>>>   arch/arm/boot/dts/exynos5250-snow.dts    |    4 ----
>>>>   arch/arm/boot/dts/exynos5250.dtsi        |    3 ++-
>>>>   arch/arm/boot/dts/exynos5420.dtsi        |    6 ++++++
>>>>   5 files changed, 9 insertions(+), 10 deletions(-)
>>>
>>>
>>> Looks good to me now.
>>>
>>> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
>>
>>
>>
>> Can you apply this patchset.
>>
>
> Applied this whole series.

Thanks.


>
> Thanks,
> Kukjin



-- 
Thanks and Regards
 Vikas Sajjan