[PATCH v4 0/7] ARM: dts: add support for exynos hdmi subsystem

[PATCH v4 0/7] ARM: dts: add support for exynos hdmi subsystem

[Rahul Sharma]

It adds Device tree nodes and clocks information for HDMI subsystem
for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
hpd gpio and update binding documents.

This set is based on kukjin's for-next branch at
http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.

v4:
1) Remove the movement of common properties to Exynos5.dtsi for
I2C and hdmi subsystem.
2) Change the title of the patches.

v3:
1) Rebase to kgene for-next based on 3.11-rc1.
2) Changes clock numbers as per updated clocks file for
exyno5250 and exynos5420.
3) Dropped Sachin patch as already got merged.

v2:
1) Added patch for moving common i2c properties to exynos5.dtsi
2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
3) moved hpd pinctrl node to board file.
4) Added Sachin's patch to update binding document for hdmi with hpd
information.

Andrew Bresticker (1):
  ARM: dts: add i2c device nodes for Exynos5420

Rahul Sharma (5):
  ARM: dts: add clocks to hdmi dt node for exynos5250
  ARM: dts: add dt nodes for hdmi subsystem for exynos5420
  ARM: dts: add clocks for hdmi subsystem for exynos5420
  ARM: dts: add hdmi hpd gpio pinctrl node for exynos5420
  of/documentation: update with clock information for exynos hdmi
    subsystem

Sean Paul (1):
  ARM: dts: add mixer clocks to mixer node for Exynos5250

 .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++-
 .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
 arch/arm/boot/dts/exynos5250.dtsi                  |    8 ++-
 arch/arm/boot/dts/exynos5420-smdk5420.dts          |   30 ++++++++
 arch/arm/boot/dts/exynos5420.dtsi                  |   76 ++++++++++++++++++++
 5 files changed, 128 insertions(+), 4 deletions(-)

-- 
1.7.10.4

[PATCH v4 1/7] ARM: dts: add mixer clocks to mixer node for Exynos5250

[Rahul Sharma]

From: Sean Paul <seanpaul@chromium.org>

This patch adds the mixer clocks to the mixer node in the
exynos 5250 dts file.

Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 1eec646..dcb6c03 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -622,6 +622,8 @@
 		compatible = "samsung,exynos5250-mixer";
 		reg = <0x14450000 0x10000>;
 		interrupts = <0 94 0>;
+		clocks = <&clock 343>, <&clock 136>;
+		clock-names = "mixer", "sclk_hdmi";
 	};
 
 	dp_phy: video-phy@10040720 {
-- 
1.7.10.4

[PATCH v4 2/7] ARM: dts: add clocks to hdmi dt node for exynos5250

[Rahul Sharma]

Fix wrong clock numbers in hdmi dt node. Removed hdmiphy
clock which was a dummy clock earlier and not required now.
Also added mux clock to change the clock parent.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index dcb6c03..19c8174 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -612,10 +612,10 @@
 		compatible = "samsung,exynos4212-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
-		clocks = <&clock 333>, <&clock 136>, <&clock 137>,
-				<&clock 333>, <&clock 333>;
+		clocks = <&clock 344>, <&clock 136>, <&clock 137>,
+				<&clock 159>, <&clock 1024>;
 		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
-				"sclk_hdmiphy", "hdmiphy";
+				"sclk_hdmiphy", "mout_hdmi";
 	};
 
 	mixer {
-- 
1.7.10.4

[PATCH v4 3/7] ARM: dts: add i2c device nodes for Exynos5420

[Rahul Sharma]

From: Andrew Bresticker <abrestic@chromium.org>

This adds device-tree nodes for the i2c busses on Exynos
5420 platforms.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |   56 +++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 5353e32..05dee86 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -27,6 +27,10 @@
 		pinctrl2 = &pinctrl_2;
 		pinctrl3 = &pinctrl_3;
 		pinctrl4 = &pinctrl_4;
+		i2c0 = &i2c_0;
+		i2c1 = &i2c_1;
+		i2c2 = &i2c_2;
+		i2c3 = &i2c_3;
 	};
 
 	cpus {
@@ -218,4 +222,56 @@
 		clocks = <&clock 147>, <&clock 421>;
 		clock-names = "sclk_fimd", "fimd";
 	};
+
+	i2c_0: i2c@12C60000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C60000 0x100>;
+		interrupts = <0 56 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 261>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c0_bus>;
+		status = "disabled";
+	};
+
+	i2c_1: i2c@12C70000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C70000 0x100>;
+		interrupts = <0 57 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 262>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c1_bus>;
+		status = "disabled";
+	};
+
+       i2c_2: i2c@12C80000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C80000 0x100>;
+		interrupts = <0 58 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 263>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_bus>;
+		status = "disabled";
+       };
+
+	i2c_3: i2c@12C90000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C90000 0x100>;
+		interrupts = <0 59 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 264>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c3_bus>;
+		status = "disabled";
+	};
 };
-- 
1.7.10.4

[PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem

[Rahul Sharma]

Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |   19 +++++++++++++++++++
 arch/arm/boot/dts/exynos5420.dtsi         |   14 ++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index bafba25..7dbf1fa 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -61,4 +61,23 @@
 		};
 	};
 
+	hdmi@14530000 {
+		status = "okay";
+		hpd-gpio = <&gpx3 7 0>;
+	};
+
+	mixer@14450000 {
+		status = "okay";
+	};
+
+	i2c_2: i2c@12C80000 {
+		samsung,i2c-sda-delay = <100>;
+		samsung,i2c-max-bus-freq = <66000>;
+		status = "okay";
+
+		hdmiddc@50 {
+			compatible = "samsung,exynos4210-hdmiddc";
+			reg = <0x50>;
+		};
+	};
 };
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 05dee86..7c6214d 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -274,4 +274,18 @@
 		pinctrl-0 = <&i2c3_bus>;
 		status = "disabled";
 	};
+
+	hdmi@14530000 {
+		compatible = "samsung,exynos4212-hdmi";
+		reg = <0x14530000 0x70000>;
+		interrupts = <0 95 0>;
+		status = "disabled";
+	};
+
+	mixer@14450000 {
+		compatible = "samsung,exynos5420-mixer";
+		reg = <0x14450000 0x10000>;
+		interrupts = <0 94 0>;
+		status = "disabled";
+	};
 };
-- 
1.7.10.4

[PATCH v4 5/7] ARM: dts: add clocks for exynos5420 hdmi subsystem

[Rahul Sharma]

Add clocks for hdmi and mixer for exynos5420 SoC.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 7c6214d..1405074 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -279,6 +279,10 @@
 		compatible = "samsung,exynos4212-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
+		clocks = <&clock 413>, <&clock 143>, <&clock 144>,
+			<&clock 158>, <&clock 1024>;
+		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
+			"sclk_hdmiphy", "mout_hdmi";
 		status = "disabled";
 	};
 
@@ -286,6 +290,8 @@
 		compatible = "samsung,exynos5420-mixer";
 		reg = <0x14450000 0x10000>;
 		interrupts = <0 94 0>;
+		clocks = <&clock 431>, <&clock 143>;
+		clock-names = "mixer", "sclk_hdmi";
 		status = "disabled";
 	};
 };
-- 
1.7.10.4

[PATCH v4 6/7] ARM: dts: add hdmi hpd gpio pinctrl node for exynos5420

[Rahul Sharma]

Add pinctrl node for hdmi-hpd gpio pin to exynos5420
device tree files.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 7dbf1fa..681337e 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -61,9 +61,20 @@
 		};
 	};
 
+	pinctrl@13400000 {
+		hdmi_hpd_irq: hdmi-hpd-irq {
+			samsung,pins = "gpx3-7";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <1>;
+			samsung,pin-drv = <0>;
+		};
+	};
+
 	hdmi@14530000 {
 		status = "okay";
 		hpd-gpio = <&gpx3 7 0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_hpd_irq>;
 	};
 
 	mixer@14450000 {
-- 
1.7.10.4

[PATCH v4 7/7] of/documentation: update with clock information for exynos hdmi subsystem

[Rahul Sharma]

Adding information about clocks to the binding documentation
for exynos mixer and hdmi.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 Documentation/devicetree/bindings/video/exynos_hdmi.txt  |   14 +++++++++++++-
 Documentation/devicetree/bindings/video/exynos_mixer.txt |    4 ++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
index 323983b..94aaa7d 100644
--- a/Documentation/devicetree/bindings/video/exynos_hdmi.txt
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -12,7 +12,19 @@ Required properties:
 	a) phandle of the gpio controller node.
 	b) pin number within the gpio controller.
 	c) optional flags and pull up/down.
-
+- clocks: list of clock IDs from SoC clock driver.
+	a) hdmi: It is required for gate operation on aclk_200_disp1 clock
+		which clocks the display1 block.
+	b) sclk_hdmi: It is required for gate operation on sclk_hdmi clock
+		which clocks hdmi IP.
+	c) sclk_pixel: Parent for mux mout_hdmi.
+	d) sclk_hdmiphy: Parent for mux mout_hdmi.
+	e) mout_hdmi: It is required by the driver to switch between the 2
+		parents i.e. sclk_pixel and sclk_hdmiphy. If hdmiphy is stable
+		after configuration, parent is set to sclk_hdmiphy else
+		sclk_pixel.
+- clock-names: aliases as per driver requirements for above clock IDs:
+	"hdmi", "sclk_hdmi", "sclk_pixel", "sclk_hdmiphy" and "mout_hdmi".
 Example:
 
 	hdmi {
diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt
index 3334b0a..94b40b6 100644
--- a/Documentation/devicetree/bindings/video/exynos_mixer.txt
+++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt
@@ -10,6 +10,10 @@ Required properties:
 - reg: physical base address of the mixer and length of memory mapped
 	region.
 - interrupts: interrupt number to the cpu.
+- clocks: list of clock IDs from SoC clock driver.
+	a) mixer: It is required for gate operation on aclk_200_disp1 clock
+		which clocks the display1 block.
+	b) sclk_hdmi: Parent for mux mout_mixer.
 
 Example:
 
-- 
1.7.10.4

Re: [PATCH v4 5/7] ARM: dts: add clocks for exynos5420 hdmi subsystem

[Tomasz Figa]

Hi Rahul,

On Friday 23 of August 2013 15:54:19 Rahul Sharma wrote:
> Add clocks for hdmi and mixer for exynos5420 SoC.
> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 7c6214d..1405074 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -279,6 +279,10 @@
>  		compatible = "samsung,exynos4212-hdmi";
>  		reg = <0x14530000 0x70000>;
>  		interrupts = <0 95 0>;
> +		clocks = <&clock 413>, <&clock 143>, <&clock 144>,
> +			<&clock 158>, <&clock 1024>;
> +		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
> +			"sclk_hdmiphy", "mout_hdmi";
>  		status = "disabled";
>  	};
> 
> @@ -286,6 +290,8 @@
>  		compatible = "samsung,exynos5420-mixer";
>  		reg = <0x14450000 0x10000>;
>  		interrupts = <0 94 0>;
> +		clocks = <&clock 431>, <&clock 143>;
> +		clock-names = "mixer", "sclk_hdmi";
>  		status = "disabled";
>  	};
>  };

You just added all the nodes in previous patch. There is no need for a 
separate patch adding clocks. Please squash this with previous patch.

Best regards,
Tomasz

Re: [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem

[Tomasz Figa]

Hi Rahul,

Please see my comments inline.

On Friday 23 of August 2013 15:54:18 Rahul Sharma wrote:
> Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.
> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |   19 +++++++++++++++++++
>  arch/arm/boot/dts/exynos5420.dtsi         |   14 ++++++++++++++
>  2 files changed, 33 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..7dbf1fa
> 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -61,4 +61,23 @@
>  		};
>  	};
> 
> +	hdmi@14530000 {
> +		status = "okay";
> +		hpd-gpio = <&gpx3 7 0>;
> +	};
> +
> +	mixer@14450000 {
> +		status = "okay";
> +	};
> +
> +	i2c_2: i2c@12C80000 {
> +		samsung,i2c-sda-delay = <100>;
> +		samsung,i2c-max-bus-freq = <66000>;
> +		status = "okay";
> +
> +		hdmiddc@50 {
> +			compatible = "samsung,exynos4210-hdmiddc";
> +			reg = <0x50>;
> +		};
> +	};
>  };

You should separate above board-specific changes from this patch and 
squash it with patch 6/7, adjusting patch subject and description 
appropriately.

> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 05dee86..7c6214d 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -274,4 +274,18 @@
>  		pinctrl-0 = <&i2c3_bus>;
>  		status = "disabled";
>  	};
> +
> +	hdmi@14530000 {
> +		compatible = "samsung,exynos4212-hdmi";
> +		reg = <0x14530000 0x70000>;
> +		interrupts = <0 95 0>;
> +		status = "disabled";
> +	};
> +
> +	mixer@14450000 {
> +		compatible = "samsung,exynos5420-mixer";
> +		reg = <0x14450000 0x10000>;
> +		interrupts = <0 94 0>;
> +		status = "disabled";

This node looks like a candidate to be enabled here on SoC level, since it 
does not require any board specific information.

Best regards,
Tomasz

Re: [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem

[Rahul Sharma]

> Hi Rahul,
>
> Please see my comments inline.
>
> On Friday 23 of August 2013 15:54:18 Rahul Sharma wrote:
>> Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.
>>
>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts |   19 +++++++++++++++++++
>>  arch/arm/boot/dts/exynos5420.dtsi         |   14 ++++++++++++++
>>  2 files changed, 33 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..7dbf1fa
>> 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -61,4 +61,23 @@
>>               };
>>       };
>>
>> +     hdmi@14530000 {
>> +             status = "okay";
>> +             hpd-gpio = <&gpx3 7 0>;
>> +     };
>> +
>> +     mixer@14450000 {
>> +             status = "okay";
>> +     };
>> +
>> +     i2c_2: i2c@12C80000 {
>> +             samsung,i2c-sda-delay = <100>;
>> +             samsung,i2c-max-bus-freq = <66000>;
>> +             status = "okay";
>> +
>> +             hdmiddc@50 {
>> +                     compatible = "samsung,exynos4210-hdmiddc";
>> +                     reg = <0x50>;
>> +             };
>> +     };
>>  };
>
> You should separate above board-specific changes from this patch and
> squash it with patch 6/7, adjusting patch subject and description
> appropriately.
>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi index 05dee86..7c6214d 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -274,4 +274,18 @@
>>               pinctrl-0 = <&i2c3_bus>;
>>               status = "disabled";
>>       };
>> +
>> +     hdmi@14530000 {
>> +             compatible = "samsung,exynos4212-hdmi";
>> +             reg = <0x14530000 0x70000>;
>> +             interrupts = <0 95 0>;
>> +             status = "disabled";
>> +     };
>> +
>> +     mixer@14450000 {
>> +             compatible = "samsung,exynos5420-mixer";
>> +             reg = <0x14450000 0x10000>;
>> +             interrupts = <0 94 0>;
>> +             status = "disabled";
>
> This node looks like a candidate to be enabled here on SoC level, since it
> does not require any board specific information.
>

Hi Tomasz,

Both hdmi and mixer should be enabled at same time. Mixer don't
but hdmi needs hpd gpio information which is board dependent. Thats
why I kept them disabled in SoC file. What you say?

Regards,
Rahul Sharma.

> Best regards,
> Tomasz
>

Re: [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem

[Tomasz Figa]

On Saturday 24 of August 2013 12:05:36 Rahul Sharma wrote:
> > Hi Rahul,
> > 
> > Please see my comments inline.
> > 
> > On Friday 23 of August 2013 15:54:18 Rahul Sharma wrote:
> >> Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.
> >> 
> >> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> >> ---
> >> 
> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |   19 +++++++++++++++++++
> >>  arch/arm/boot/dts/exynos5420.dtsi         |   14 ++++++++++++++
> >>  2 files changed, 33 insertions(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..7dbf1fa
> >> 100644
> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> @@ -61,4 +61,23 @@
> >> 
> >>               };
> >>       
> >>       };
> >> 
> >> +     hdmi@14530000 {
> >> +             status = "okay";
> >> +             hpd-gpio = <&gpx3 7 0>;
> >> +     };
> >> +
> >> +     mixer@14450000 {
> >> +             status = "okay";
> >> +     };
> >> +
> >> +     i2c_2: i2c@12C80000 {
> >> +             samsung,i2c-sda-delay = <100>;
> >> +             samsung,i2c-max-bus-freq = <66000>;
> >> +             status = "okay";
> >> +
> >> +             hdmiddc@50 {
> >> +                     compatible = "samsung,exynos4210-hdmiddc";
> >> +                     reg = <0x50>;
> >> +             };
> >> +     };
> >> 
> >>  };
> > 
> > You should separate above board-specific changes from this patch and
> > squash it with patch 6/7, adjusting patch subject and description
> > appropriately.
> > 
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> >> b/arch/arm/boot/dts/exynos5420.dtsi index 05dee86..7c6214d 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -274,4 +274,18 @@
> >> 
> >>               pinctrl-0 = <&i2c3_bus>;
> >>               status = "disabled";
> >>       
> >>       };
> >> 
> >> +
> >> +     hdmi@14530000 {
> >> +             compatible = "samsung,exynos4212-hdmi";
> >> +             reg = <0x14530000 0x70000>;
> >> +             interrupts = <0 95 0>;
> >> +             status = "disabled";
> >> +     };
> >> +
> >> +     mixer@14450000 {
> >> +             compatible = "samsung,exynos5420-mixer";
> >> +             reg = <0x14450000 0x10000>;
> >> +             interrupts = <0 94 0>;
> >> +             status = "disabled";
> > 
> > This node looks like a candidate to be enabled here on SoC level,
> > since it does not require any board specific information.
> 
> Hi Tomasz,
> 
> Both hdmi and mixer should be enabled at same time. Mixer don't
> but hdmi needs hpd gpio information which is board dependent. Thats
> why I kept them disabled in SoC file. What you say?

Hmm, is it a hardware restriction? I mean, if HDMI is not enabled, is it 
impossible to enable mixer and use it for some purposes? I don't know much 
about the Exynos HDMI subsystem, so sorry for the noise if this is 
obvious.

What I have in mind is that device tree should describe the hardware, 
regardless of use case. This is, all the hardware that can possibly 
operate should be listed as operational.

Best regards,
Tomasz

Re: [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem

[Rahul Sharma]

On 24 August 2013 20:02, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> On Saturday 24 of August 2013 12:05:36 Rahul Sharma wrote:
>> > Hi Rahul,
>> >
>> > Please see my comments inline.
>> >
>> > On Friday 23 of August 2013 15:54:18 Rahul Sharma wrote:
>> >> Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.
>> >>
>> >> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> >> ---
>> >>
>> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |   19 +++++++++++++++++++
>> >>  arch/arm/boot/dts/exynos5420.dtsi         |   14 ++++++++++++++
>> >>  2 files changed, 33 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..7dbf1fa
>> >> 100644
>> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> @@ -61,4 +61,23 @@
>> >>
>> >>               };
>> >>
>> >>       };
>> >>
>> >> +     hdmi@14530000 {
>> >> +             status = "okay";
>> >> +             hpd-gpio = <&gpx3 7 0>;
>> >> +     };
>> >> +
>> >> +     mixer@14450000 {
>> >> +             status = "okay";
>> >> +     };
>> >> +
>> >> +     i2c_2: i2c@12C80000 {
>> >> +             samsung,i2c-sda-delay = <100>;
>> >> +             samsung,i2c-max-bus-freq = <66000>;
>> >> +             status = "okay";
>> >> +
>> >> +             hdmiddc@50 {
>> >> +                     compatible = "samsung,exynos4210-hdmiddc";
>> >> +                     reg = <0x50>;
>> >> +             };
>> >> +     };
>> >>
>> >>  };
>> >
>> > You should separate above board-specific changes from this patch and
>> > squash it with patch 6/7, adjusting patch subject and description
>> > appropriately.
>> >
>> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> >> b/arch/arm/boot/dts/exynos5420.dtsi index 05dee86..7c6214d 100644
>> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> >> @@ -274,4 +274,18 @@
>> >>
>> >>               pinctrl-0 = <&i2c3_bus>;
>> >>               status = "disabled";
>> >>
>> >>       };
>> >>
>> >> +
>> >> +     hdmi@14530000 {
>> >> +             compatible = "samsung,exynos4212-hdmi";
>> >> +             reg = <0x14530000 0x70000>;
>> >> +             interrupts = <0 95 0>;
>> >> +             status = "disabled";
>> >> +     };
>> >> +
>> >> +     mixer@14450000 {
>> >> +             compatible = "samsung,exynos5420-mixer";
>> >> +             reg = <0x14450000 0x10000>;
>> >> +             interrupts = <0 94 0>;
>> >> +             status = "disabled";
>> >
>> > This node looks like a candidate to be enabled here on SoC level,
>> > since it does not require any board specific information.
>>
>> Hi Tomasz,
>>
>> Both hdmi and mixer should be enabled at same time. Mixer don't
>> but hdmi needs hpd gpio information which is board dependent. Thats
>> why I kept them disabled in SoC file. What you say?
>
> Hmm, is it a hardware restriction? I mean, if HDMI is not enabled, is it
> impossible to enable mixer and use it for some purposes? I don't know much
> about the Exynos HDMI subsystem, so sorry for the noise if this is
> obvious.

Hi Tomasz,

No, It is not a hardware restriction. Mixer can be probed independently
but there is NO usecase where mixer can be used without hdmi
enabled. Mixer output is hardwired to hdmi block in SoC.

>
> What I have in mind is that device tree should describe the hardware,
> regardless of use case. This is, all the hardware that can possibly
> operate should be listed as operational.

I understand your point. We can keep mixer enabled in DTSI.

regards,
Rahul Sharma.

>
> Best regards,
> Tomasz
>