All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val
@ 2013-08-23 18:47 Imre Deak
  2013-08-23 19:01 ` Paulo Zanoni
  2013-08-23 20:50 ` [PATCH v2] " Imre Deak
  0 siblings, 2 replies; 6+ messages in thread
From: Imre Deak @ 2013-08-23 18:47 UTC (permalink / raw)
  To: intel-gfx

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
Author: Keith Packard <keithp@keithp.com>
Date:   Wed Nov 16 16:26:07 2011 -0800

    drm/i915: Hook up Ivybridge eDP

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
Tested-by: Jeremy Moles <cubicool@gmail.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 2b96d6b..019fd1f 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4525,7 +4525,7 @@
 #define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 <<22)
 #define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 <<22)
 #define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 <<22)
-#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x33 <<22)
+#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e <<22)
 
 /* legacy values */
 #define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 <<22)
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val
  2013-08-23 18:47 [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val Imre Deak
@ 2013-08-23 19:01 ` Paulo Zanoni
  2013-08-23 20:01   ` Daniel Vetter
  2013-08-23 20:50 ` [PATCH v2] " Imre Deak
  1 sibling, 1 reply; 6+ messages in thread
From: Paulo Zanoni @ 2013-08-23 19:01 UTC (permalink / raw)
  To: Imre Deak; +Cc: Intel Graphics Development

2013/8/23 Imre Deak <imre.deak@intel.com>:
> Fix the typo introduced in
>
> commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> Author: Keith Packard <keithp@keithp.com>
> Date:   Wed Nov 16 16:26:07 2011 -0800
>
>     drm/i915: Hook up Ivybridge eDP
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> Tested-by: Jeremy Moles <cubicool@gmail.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Nice catch!

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_reg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 2b96d6b..019fd1f 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4525,7 +4525,7 @@
>  #define EDP_LINK_TRAIN_600MV_0DB_IVB           (0x30 <<22)
>  #define EDP_LINK_TRAIN_600MV_3_5DB_IVB         (0x36 <<22)
>  #define EDP_LINK_TRAIN_800MV_0DB_IVB           (0x38 <<22)
> -#define EDP_LINK_TRAIN_800MV_3_5DB_IVB         (0x33 <<22)
> +#define EDP_LINK_TRAIN_800MV_3_5DB_IVB         (0x3e <<22)
>
>  /* legacy values */
>  #define EDP_LINK_TRAIN_500MV_0DB_IVB           (0x00 <<22)
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val
  2013-08-23 19:01 ` Paulo Zanoni
@ 2013-08-23 20:01   ` Daniel Vetter
  2013-08-23 20:10     ` Daniel Vetter
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2013-08-23 20:01 UTC (permalink / raw)
  To: Paulo Zanoni; +Cc: Intel Graphics Development

On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote:
> 2013/8/23 Imre Deak <imre.deak@intel.com>:
> > Fix the typo introduced in
> >
> > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> > Author: Keith Packard <keithp@keithp.com>
> > Date:   Wed Nov 16 16:26:07 2011 -0800
> >
> >     drm/i915: Hook up Ivybridge eDP
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> > Tested-by: Jeremy Moles <cubicool@gmail.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> Nice catch!
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val
  2013-08-23 20:01   ` Daniel Vetter
@ 2013-08-23 20:10     ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-08-23 20:10 UTC (permalink / raw)
  To: Paulo Zanoni; +Cc: Intel Graphics Development

On Fri, Aug 23, 2013 at 10:01:27PM +0200, Daniel Vetter wrote:
> On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote:
> > 2013/8/23 Imre Deak <imre.deak@intel.com>:
> > > Fix the typo introduced in
> > >
> > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> > > Author: Keith Packard <keithp@keithp.com>
> > > Date:   Wed Nov 16 16:26:07 2011 -0800
> > >
> > >     drm/i915: Hook up Ivybridge eDP
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> > > Tested-by: Jeremy Moles <cubicool@gmail.com>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > 
> > Nice catch!
> > 
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Queued for -next, thanks for the patch.

Ok, dropped again since Paulo told me on irc that we fail link training
without this and so this is a black screen fix and so should go to -fixes
with cc: stable.

Grumpy maintainer note: Stuff like this _really_ must be part of the
commit message. A headline of "fix typo in ..." plus no mention of any
further impact than the fixed type for a black screen bug in the commit
message is seriously misleading.

Also this should imo be caught in review (since Paulo obviously knew
what's going on).

Please resend.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] drm/i915: ivb: fix typo in dp voltage swing reg val
  2013-08-23 18:47 [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val Imre Deak
  2013-08-23 19:01 ` Paulo Zanoni
@ 2013-08-23 20:50 ` Imre Deak
  2013-08-23 21:02   ` [Intel-gfx] " Daniel Vetter
  1 sibling, 1 reply; 6+ messages in thread
From: Imre Deak @ 2013-08-23 20:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: stable

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
Author: Keith Packard <keithp@keithp.com>
Date:   Wed Nov 16 16:26:07 2011 -0800

    drm/i915: Hook up Ivybridge eDP

This fixes eDP link-training failures and cases where all voltage swing
/pre-emphasis levels were tried and failed during clock recovery and -
as a fallback - we go on to do channel equalization with the last voltage
swing/pre-emphasis level which will succeed. Both issues can lead to a
blank screen.

v2:
- improve commit message

CC: stable@vger.kernel.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
Tested-by: Jeremy Moles <cubicool@gmail.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 2b96d6b..019fd1f 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4525,7 +4525,7 @@
 #define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 <<22)
 #define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 <<22)
 #define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 <<22)
-#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x33 <<22)
+#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e <<22)
 
 /* legacy values */
 #define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 <<22)
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: ivb: fix typo in dp voltage swing reg val
  2013-08-23 20:50 ` [PATCH v2] " Imre Deak
@ 2013-08-23 21:02   ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-08-23 21:02 UTC (permalink / raw)
  To: Imre Deak; +Cc: intel-gfx, stable

On Fri, Aug 23, 2013 at 11:50:23PM +0300, Imre Deak wrote:
> Fix the typo introduced in
> 
> commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> Author: Keith Packard <keithp@keithp.com>
> Date:   Wed Nov 16 16:26:07 2011 -0800
> 
>     drm/i915: Hook up Ivybridge eDP
> 
> This fixes eDP link-training failures and cases where all voltage swing
> /pre-emphasis levels were tried and failed during clock recovery and -
> as a fallback - we go on to do channel equalization with the last voltage
> swing/pre-emphasis level which will succeed. Both issues can lead to a
> blank screen.
> 
> v2:
> - improve commit message
> 
> CC: stable@vger.kernel.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> Tested-by: Jeremy Moles <cubicool@gmail.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Picked up for -fixes, thanks for the patch. Although I've frobbed the
commit message a bit more and dropped the "typo" part. Since patches with
"typo" headlines really don't belong into post -rc6 pull requests ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-23 21:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 18:47 [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val Imre Deak
2013-08-23 19:01 ` Paulo Zanoni
2013-08-23 20:01   ` Daniel Vetter
2013-08-23 20:10     ` Daniel Vetter
2013-08-23 20:50 ` [PATCH v2] " Imre Deak
2013-08-23 21:02   ` [Intel-gfx] " Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.