* [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource()
@ 2013-08-27 7:05 Vishwanathrao Badarkhe, Manish
2013-08-27 12:19 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Vishwanathrao Badarkhe, Manish @ 2013-08-27 7:05 UTC (permalink / raw)
To: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ, linus.walleij-QSEj5FYQhm4dnm+yROfE0A
From: "Vishwanathrao Badarkhe, Manish" <manishv.b-l0cyMroinI0@public.gmane.org>
Convert devm_request_mem_region() and devm_ioremap() to
devm_ioremap_resource() which provides more consistent
error handling to manage resource.
Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b-l0cyMroinI0@public.gmane.org>
---
:100644 100644 7323cca... b0fef18... M drivers/pinctrl/pinctrl-single.c
drivers/pinctrl/pinctrl-single.c | 21 +++------------------
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 7323cca..b0fef18 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1556,24 +1556,9 @@ static int pcs_probe(struct platform_device *pdev)
"pinctrl-single,bit-per-mux");
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(pcs->dev, "could not get resource\n");
- return -ENODEV;
- }
-
- pcs->res = devm_request_mem_region(pcs->dev, res->start,
- resource_size(res), DRIVER_NAME);
- if (!pcs->res) {
- dev_err(pcs->dev, "could not get mem_region\n");
- return -EBUSY;
- }
-
- pcs->size = resource_size(pcs->res);
- pcs->base = devm_ioremap(pcs->dev, pcs->res->start, pcs->size);
- if (!pcs->base) {
- dev_err(pcs->dev, "could not ioremap\n");
- return -ENODEV;
- }
+ pcs->base = devm_ioremap_resource(pcs->dev, res);
+ if (IS_ERR(pcs->base))
+ return PTR_ERR(pcs->base);
INIT_RADIX_TREE(&pcs->pgtree, GFP_KERNEL);
INIT_RADIX_TREE(&pcs->ftree, GFP_KERNEL);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource()
2013-08-27 7:05 [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource() Vishwanathrao Badarkhe, Manish
@ 2013-08-27 12:19 ` Sergei Shtylyov
2013-08-27 12:59 ` ManishBadarkhe
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2013-08-27 12:19 UTC (permalink / raw)
To: Vishwanathrao Badarkhe, Manish
Cc: davinci-linux-open-source, devicetree, linux-kernel, tony, linus.walleij
Hello.
On 27-08-2013 11:05, Vishwanathrao Badarkhe, Manish wrote:
> From: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
> Convert devm_request_mem_region() and devm_ioremap() to
> devm_ioremap_resource() which provides more consistent
> error handling to manage resource.
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> :100644 100644 7323cca... b0fef18... M drivers/pinctrl/pinctrl-single.c
> drivers/pinctrl/pinctrl-single.c | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 7323cca..b0fef18 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1556,24 +1556,9 @@ static int pcs_probe(struct platform_device *pdev)
> "pinctrl-single,bit-per-mux");
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(pcs->dev, "could not get resource\n");
> - return -ENODEV;
> - }
> -
> - pcs->res = devm_request_mem_region(pcs->dev, res->start,
> - resource_size(res), DRIVER_NAME);
> - if (!pcs->res) {
Is pcs->res used anywhere else?
> - dev_err(pcs->dev, "could not get mem_region\n");
> - return -EBUSY;
> - }
> -
> - pcs->size = resource_size(pcs->res);
Is pcs->size used anywhere else?
> - pcs->base = devm_ioremap(pcs->dev, pcs->res->start, pcs->size);
> - if (!pcs->base) {
> - dev_err(pcs->dev, "could not ioremap\n");
> - return -ENODEV;
> - }
> + pcs->base = devm_ioremap_resource(pcs->dev, res);
> + if (IS_ERR(pcs->base))
> + return PTR_ERR(pcs->base);
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource()
2013-08-27 12:19 ` Sergei Shtylyov
@ 2013-08-27 12:59 ` ManishBadarkhe
0 siblings, 0 replies; 4+ messages in thread
From: ManishBadarkhe @ 2013-08-27 12:59 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: davinci-linux-open-source, devicetree, linux-kernel, tony, linus.walleij
Hi
On Tuesday 27 August 2013 05:49 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 27-08-2013 11:05, Vishwanathrao Badarkhe, Manish wrote:
>
>> From: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
>
>> Convert devm_request_mem_region() and devm_ioremap() to
>> devm_ioremap_resource() which provides more consistent
>> error handling to manage resource.
>
>> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
>> ---
>> :100644 100644 7323cca... b0fef18... M drivers/pinctrl/pinctrl-single.c
>> drivers/pinctrl/pinctrl-single.c | 21 +++------------------
>> 1 file changed, 3 insertions(+), 18 deletions(-)
>
>> diff --git a/drivers/pinctrl/pinctrl-single.c
>> b/drivers/pinctrl/pinctrl-single.c
>> index 7323cca..b0fef18 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1556,24 +1556,9 @@ static int pcs_probe(struct platform_device
>> *pdev)
>> "pinctrl-single,bit-per-mux");
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - dev_err(pcs->dev, "could not get resource\n");
>> - return -ENODEV;
>> - }
>> -
>> - pcs->res = devm_request_mem_region(pcs->dev, res->start,
>> - resource_size(res), DRIVER_NAME);
>> - if (!pcs->res) {
>
> Is pcs->res used anywhere else?
My bad, I have not seen this variable is used in another functions too.
>
>> - dev_err(pcs->dev, "could not get mem_region\n");
>> - return -EBUSY;
>> - }
>> -
>> - pcs->size = resource_size(pcs->res);
>
> Is pcs->size used anywhere else?
My bad, I have not seen this variable is used in another functions too.
>
>> - pcs->base = devm_ioremap(pcs->dev, pcs->res->start, pcs->size);
>> - if (!pcs->base) {
>> - dev_err(pcs->dev, "could not ioremap\n");
>> - return -ENODEV;
>> - }
>> + pcs->base = devm_ioremap_resource(pcs->dev, res);
>> + if (IS_ERR(pcs->base))
>> + return PTR_ERR(pcs->base);
>
I will go through code again and update it accordingly.
>
Regards
Manish Badarkhe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource()
@ 2013-08-27 12:59 ` ManishBadarkhe
0 siblings, 0 replies; 4+ messages in thread
From: ManishBadarkhe @ 2013-08-27 12:59 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: davinci-linux-open-source, devicetree, linux-kernel, tony, linus.walleij
Hi
On Tuesday 27 August 2013 05:49 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 27-08-2013 11:05, Vishwanathrao Badarkhe, Manish wrote:
>
>> From: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
>
>> Convert devm_request_mem_region() and devm_ioremap() to
>> devm_ioremap_resource() which provides more consistent
>> error handling to manage resource.
>
>> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
>> ---
>> :100644 100644 7323cca... b0fef18... M drivers/pinctrl/pinctrl-single.c
>> drivers/pinctrl/pinctrl-single.c | 21 +++------------------
>> 1 file changed, 3 insertions(+), 18 deletions(-)
>
>> diff --git a/drivers/pinctrl/pinctrl-single.c
>> b/drivers/pinctrl/pinctrl-single.c
>> index 7323cca..b0fef18 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1556,24 +1556,9 @@ static int pcs_probe(struct platform_device
>> *pdev)
>> "pinctrl-single,bit-per-mux");
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - dev_err(pcs->dev, "could not get resource\n");
>> - return -ENODEV;
>> - }
>> -
>> - pcs->res = devm_request_mem_region(pcs->dev, res->start,
>> - resource_size(res), DRIVER_NAME);
>> - if (!pcs->res) {
>
> Is pcs->res used anywhere else?
My bad, I have not seen this variable is used in another functions too.
>
>> - dev_err(pcs->dev, "could not get mem_region\n");
>> - return -EBUSY;
>> - }
>> -
>> - pcs->size = resource_size(pcs->res);
>
> Is pcs->size used anywhere else?
My bad, I have not seen this variable is used in another functions too.
>
>> - pcs->base = devm_ioremap(pcs->dev, pcs->res->start, pcs->size);
>> - if (!pcs->base) {
>> - dev_err(pcs->dev, "could not ioremap\n");
>> - return -ENODEV;
>> - }
>> + pcs->base = devm_ioremap_resource(pcs->dev, res);
>> + if (IS_ERR(pcs->base))
>> + return PTR_ERR(pcs->base);
>
I will go through code again and update it accordingly.
>
Regards
Manish Badarkhe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-27 12:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-27 7:05 [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource() Vishwanathrao Badarkhe, Manish
2013-08-27 12:19 ` Sergei Shtylyov
2013-08-27 12:59 ` ManishBadarkhe
2013-08-27 12:59 ` ManishBadarkhe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.