All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info
@ 2013-09-10  9:43 Sachin Kamat
  2013-09-10 12:08 ` Ben Hutchings
  0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-09-10  9:43 UTC (permalink / raw)
  To: netdev; +Cc: bhutchings, linux-net-drivers, sachin.kamat

'efx_ethtool_get_ts_info' is used only in this file.
Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/net/ethernet/sfc/ethtool.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
index 5b471cf..c8dc407 100644
--- a/drivers/net/ethernet/sfc/ethtool.c
+++ b/drivers/net/ethernet/sfc/ethtool.c
@@ -1035,8 +1035,8 @@ static int efx_ethtool_set_rxfh_indir(struct net_device *net_dev,
 	return 0;
 }
 
-int efx_ethtool_get_ts_info(struct net_device *net_dev,
-			    struct ethtool_ts_info *ts_info)
+static int efx_ethtool_get_ts_info(struct net_device *net_dev,
+				   struct ethtool_ts_info *ts_info)
 {
 	struct efx_nic *efx = netdev_priv(net_dev);
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info
  2013-09-10  9:43 [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info Sachin Kamat
@ 2013-09-10 12:08 ` Ben Hutchings
  2013-09-11  4:43   ` Sachin Kamat
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2013-09-10 12:08 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: netdev, linux-net-drivers

On Tue, 2013-09-10 at 15:13 +0530, Sachin Kamat wrote:
> 'efx_ethtool_get_ts_info' is used only in this file.
> Make it static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/net/ethernet/sfc/ethtool.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
> index 5b471cf..c8dc407 100644
> --- a/drivers/net/ethernet/sfc/ethtool.c
> +++ b/drivers/net/ethernet/sfc/ethtool.c
> @@ -1035,8 +1035,8 @@ static int efx_ethtool_set_rxfh_indir(struct net_device *net_dev,
>  	return 0;
>  }
>  
> -int efx_ethtool_get_ts_info(struct net_device *net_dev,
> -			    struct ethtool_ts_info *ts_info)
> +static int efx_ethtool_get_ts_info(struct net_device *net_dev,
> +				   struct ethtool_ts_info *ts_info)
>  {
>  	struct efx_nic *efx = netdev_priv(net_dev);
>  

I already have this fix, but net-next is not open for changes.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info
  2013-09-10 12:08 ` Ben Hutchings
@ 2013-09-11  4:43   ` Sachin Kamat
  0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-11  4:43 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: netdev, linux-net-drivers

On 10 September 2013 17:38, Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Tue, 2013-09-10 at 15:13 +0530, Sachin Kamat wrote:
>> 'efx_ethtool_get_ts_info' is used only in this file.
>> Make it static.

>
> I already have this fix, but net-next is not open for changes.

I wasn't aware. Sorry for the noise.

-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-11  4:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-10  9:43 [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info Sachin Kamat
2013-09-10 12:08 ` Ben Hutchings
2013-09-11  4:43   ` Sachin Kamat

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.