* [PATCH] MIPS: kernel: vpe: Make vpe_attrs an array of pointers.
@ 2013-09-11 12:17 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2013-09-11 12:17 UTC (permalink / raw)
To: linux-mips
Cc: Markos Chandras, Ralf Baechle, John Crispin, Greg Kroah-Hartman
Commit 567b21e973ccf5b0d13776e408d7c67099749eb8
"mips: convert vpe_class to use dev_groups"
broke the build on MIPS since vpe_attrs should be an array
of 'struct device_attribute' pointers.
Fixes the following build problem:
arch/mips/kernel/vpe.c:1372:2: error: missing braces around initializer
[-Werror=missing-braces]
arch/mips/kernel/vpe.c:1372:2: error: (near initialization for 'vpe_attrs[0]')
[-Werror=missing-braces]
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: John Crispin <blogic@openwrt.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
arch/mips/kernel/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
index faf84c5..59b2b3c 100644
--- a/arch/mips/kernel/vpe.c
+++ b/arch/mips/kernel/vpe.c
@@ -1368,7 +1368,7 @@ out_einval:
}
static DEVICE_ATTR_RW(ntcs);
-static struct attribute vpe_attrs[] = {
+static struct attribute *vpe_attrs[] = {
&dev_attr_kill.attr,
&dev_attr_ntcs.attr,
NULL,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] MIPS: kernel: vpe: Make vpe_attrs an array of pointers.
@ 2013-09-11 12:17 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2013-09-11 12:17 UTC (permalink / raw)
To: linux-mips
Cc: Markos Chandras, Ralf Baechle, John Crispin, Greg Kroah-Hartman
Commit 567b21e973ccf5b0d13776e408d7c67099749eb8
"mips: convert vpe_class to use dev_groups"
broke the build on MIPS since vpe_attrs should be an array
of 'struct device_attribute' pointers.
Fixes the following build problem:
arch/mips/kernel/vpe.c:1372:2: error: missing braces around initializer
[-Werror=missing-braces]
arch/mips/kernel/vpe.c:1372:2: error: (near initialization for 'vpe_attrs[0]')
[-Werror=missing-braces]
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: John Crispin <blogic@openwrt.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
arch/mips/kernel/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
index faf84c5..59b2b3c 100644
--- a/arch/mips/kernel/vpe.c
+++ b/arch/mips/kernel/vpe.c
@@ -1368,7 +1368,7 @@ out_einval:
}
static DEVICE_ATTR_RW(ntcs);
-static struct attribute vpe_attrs[] = {
+static struct attribute *vpe_attrs[] = {
&dev_attr_kill.attr,
&dev_attr_ntcs.attr,
NULL,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: kernel: vpe: Make vpe_attrs an array of pointers.
2013-09-11 12:17 ` Markos Chandras
(?)
@ 2013-09-11 15:59 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2013-09-11 15:59 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips, Ralf Baechle, John Crispin
On Wed, Sep 11, 2013 at 01:17:52PM +0100, Markos Chandras wrote:
> Commit 567b21e973ccf5b0d13776e408d7c67099749eb8
> "mips: convert vpe_class to use dev_groups"
>
> broke the build on MIPS since vpe_attrs should be an array
> of 'struct device_attribute' pointers.
>
> Fixes the following build problem:
> arch/mips/kernel/vpe.c:1372:2: error: missing braces around initializer
> [-Werror=missing-braces]
> arch/mips/kernel/vpe.c:1372:2: error: (near initialization for 'vpe_attrs[0]')
> [-Werror=missing-braces]
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: John Crispin <blogic@openwrt.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> arch/mips/kernel/vpe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ugh, sorry about that, I thought I cross-built this, testing it out, but
it looks like I didn't. I'll queue this up after 3.12-rc1 is out,
thanks for sending it.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-11 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-11 12:17 [PATCH] MIPS: kernel: vpe: Make vpe_attrs an array of pointers Markos Chandras
2013-09-11 12:17 ` Markos Chandras
2013-09-11 15:59 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.