* [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h
@ 2013-09-13 9:23 Sachin Kamat
2013-09-13 9:23 ` [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops Sachin Kamat
` (11 more replies)
0 siblings, 12 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
clk-provider.h was included twice.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
---
drivers/clk/clk-bcm2835.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
index 5fb4ff5..676077d 100644
--- a/drivers/clk/clk-bcm2835.c
+++ b/drivers/clk/clk-bcm2835.c
@@ -20,7 +20,6 @@
#include <linux/clk-provider.h>
#include <linux/clkdev.h>
#include <linux/clk/bcm2835.h>
-#include <linux/clk-provider.h>
#include <linux/of.h>
static const struct of_device_id clk_match[] __initconst = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 9:45 ` Viresh Kumar
2013-09-13 9:23 ` [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c Sachin Kamat
` (10 subsequent siblings)
11 siblings, 1 reply; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
clk_frac_ops is local to this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/clk/spear/clk-frac-synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/spear/clk-frac-synth.c b/drivers/clk/spear/clk-frac-synth.c
index 958aa3a..dffd4ce 100644
--- a/drivers/clk/spear/clk-frac-synth.c
+++ b/drivers/clk/spear/clk-frac-synth.c
@@ -116,7 +116,7 @@ static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate,
return 0;
}
-struct clk_ops clk_frac_ops = {
+static struct clk_ops clk_frac_ops = {
.recalc_rate = clk_frac_recalc_rate,
.round_rate = clk_frac_round_rate,
.set_rate = clk_frac_set_rate,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
2013-09-13 9:23 ` [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 9:23 ` [PATCH 04/10] clk: tegra: Staticize tegra_clk_periph_nodiv_ops Sachin Kamat
` (9 subsequent siblings)
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
Local variables used only in this file are made static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
---
drivers/clk/tegra/clk-pll.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 197074a..76ed452 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -1340,7 +1340,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name,
}
#ifdef CONFIG_ARCH_TEGRA_114_SOC
-const struct clk_ops tegra_clk_pllxc_ops = {
+static const struct clk_ops tegra_clk_pllxc_ops = {
.is_enabled = clk_pll_is_enabled,
.enable = clk_pll_iddq_enable,
.disable = clk_pll_iddq_disable,
@@ -1349,7 +1349,7 @@ const struct clk_ops tegra_clk_pllxc_ops = {
.set_rate = clk_pllxc_set_rate,
};
-const struct clk_ops tegra_clk_pllm_ops = {
+static const struct clk_ops tegra_clk_pllm_ops = {
.is_enabled = clk_pll_is_enabled,
.enable = clk_pll_iddq_enable,
.disable = clk_pll_iddq_disable,
@@ -1358,7 +1358,7 @@ const struct clk_ops tegra_clk_pllm_ops = {
.set_rate = clk_pllm_set_rate,
};
-const struct clk_ops tegra_clk_pllc_ops = {
+static const struct clk_ops tegra_clk_pllc_ops = {
.is_enabled = clk_pll_is_enabled,
.enable = clk_pllc_enable,
.disable = clk_pllc_disable,
@@ -1367,7 +1367,7 @@ const struct clk_ops tegra_clk_pllc_ops = {
.set_rate = clk_pllc_set_rate,
};
-const struct clk_ops tegra_clk_pllre_ops = {
+static const struct clk_ops tegra_clk_pllre_ops = {
.is_enabled = clk_pll_is_enabled,
.enable = clk_pll_iddq_enable,
.disable = clk_pll_iddq_disable,
@@ -1376,7 +1376,7 @@ const struct clk_ops tegra_clk_pllre_ops = {
.set_rate = clk_pllre_set_rate,
};
-const struct clk_ops tegra_clk_plle_tegra114_ops = {
+static const struct clk_ops tegra_clk_plle_tegra114_ops = {
.is_enabled = clk_pll_is_enabled,
.enable = clk_plle_tegra114_enable,
.disable = clk_plle_tegra114_disable,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 04/10] clk: tegra: Staticize tegra_clk_periph_nodiv_ops
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
2013-09-13 9:23 ` [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops Sachin Kamat
2013-09-13 9:23 ` [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 9:23 ` [PATCH 05/10] clk: socfpga: Use NULL instead of 0 Sachin Kamat
` (8 subsequent siblings)
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
tegra_clk_periph_nodiv_ops is used only in this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
---
drivers/clk/tegra/clk-periph.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-periph.c b/drivers/clk/tegra/clk-periph.c
index b2309d3..2c0bfa2 100644
--- a/drivers/clk/tegra/clk-periph.c
+++ b/drivers/clk/tegra/clk-periph.c
@@ -162,7 +162,7 @@ const struct clk_ops tegra_clk_periph_ops = {
.disable = clk_periph_disable,
};
-const struct clk_ops tegra_clk_periph_nodiv_ops = {
+static const struct clk_ops tegra_clk_periph_nodiv_ops = {
.get_parent = clk_periph_get_parent,
.set_parent = clk_periph_set_parent,
.is_enabled = clk_periph_is_enabled,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 05/10] clk: socfpga: Use NULL instead of 0
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (2 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 04/10] clk: tegra: Staticize tegra_clk_periph_nodiv_ops Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 22:03 ` Dinh Nguyen
2013-09-13 9:23 ` [PATCH 06/10] clk: versatile: Staticize clk_sp810_timerclken_of_get Sachin Kamat
` (7 subsequent siblings)
11 siblings, 1 reply; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
'div_reg' is a pointer. Assign NULL instead of 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Dinh Nguyen <dinguyen@altera.com>
---
drivers/clk/socfpga/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
index 5bb848c..454ddc1 100644
--- a/drivers/clk/socfpga/clk.c
+++ b/drivers/clk/socfpga/clk.c
@@ -292,7 +292,7 @@ static void __init socfpga_gate_clk_init(struct device_node *node,
socfpga_clk->shift = div_reg[1];
socfpga_clk->width = div_reg[2];
} else {
- socfpga_clk->div_reg = 0;
+ socfpga_clk->div_reg = NULL;
}
of_property_read_string(node, "clock-output-names", &clk_name);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 06/10] clk: versatile: Staticize clk_sp810_timerclken_of_get
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (3 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 05/10] clk: socfpga: Use NULL instead of 0 Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 9:23 ` [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup Sachin Kamat
` (6 subsequent siblings)
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
clk_sp810_timerclken_of_get is used only in this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/clk/versatile/clk-sp810.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c
index bf9b15a..c6e86a9 100644
--- a/drivers/clk/versatile/clk-sp810.c
+++ b/drivers/clk/versatile/clk-sp810.c
@@ -123,7 +123,7 @@ static const struct clk_ops clk_sp810_timerclken_ops = {
.set_parent = clk_sp810_timerclken_set_parent,
};
-struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec,
+static struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec,
void *data)
{
struct clk_sp810 *sp810 = data;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (4 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 06/10] clk: versatile: Staticize clk_sp810_timerclken_of_get Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 9:52 ` Gregory CLEMENT
2013-09-13 9:23 ` [PATCH 08/10] clk: vt8500: Staticize vtwm_pll_ops Sachin Kamat
` (5 subsequent siblings)
11 siblings, 1 reply; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
'of_cpu_clk_setup' is used only in this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
drivers/clk/mvebu/clk-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
index 1466865..8ebf757 100644
--- a/drivers/clk/mvebu/clk-cpu.c
+++ b/drivers/clk/mvebu/clk-cpu.c
@@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = {
.set_rate = clk_cpu_set_rate,
};
-void __init of_cpu_clk_setup(struct device_node *node)
+static void __init of_cpu_clk_setup(struct device_node *node)
{
struct cpu_clk *cpuclk;
void __iomem *clock_complex_base = of_iomap(node, 0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 08/10] clk: vt8500: Staticize vtwm_pll_ops
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (5 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-13 9:23 ` [PATCH 09/10] clk: ux500: Remove extra semicolon Sachin Kamat
` (4 subsequent siblings)
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
'vtwm_pll_ops' is local to this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Tony Prisk <linux@prisktech.co.nz>
---
drivers/clk/clk-vt8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index 82306f5..a45e7a6 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
@@ -620,7 +620,7 @@ static unsigned long vtwm_pll_recalc_rate(struct clk_hw *hw,
return pll_freq;
}
-const struct clk_ops vtwm_pll_ops = {
+static const struct clk_ops vtwm_pll_ops = {
.round_rate = vtwm_pll_round_rate,
.set_rate = vtwm_pll_set_rate,
.recalc_rate = vtwm_pll_recalc_rate,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 09/10] clk: ux500: Remove extra semicolon
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (6 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 08/10] clk: vt8500: Staticize vtwm_pll_ops Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-17 8:02 ` Ulf Hansson
2013-09-13 9:23 ` [PATCH 10/10] clk: max77686: Remove redundant break Sachin Kamat
` (3 subsequent siblings)
11 siblings, 1 reply; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
Extra semicolon is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/clk/ux500/clk-prcmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index 293a288..e2d63bc 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c
@@ -36,7 +36,7 @@ static int clk_prcmu_prepare(struct clk_hw *hw)
if (!ret)
clk->is_prepared = 1;
- return ret;;
+ return ret;
}
static void clk_prcmu_unprepare(struct clk_hw *hw)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 10/10] clk: max77686: Remove redundant break
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (7 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 09/10] clk: ux500: Remove extra semicolon Sachin Kamat
@ 2013-09-13 9:23 ` Sachin Kamat
2013-09-24 12:04 ` [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (2 subsequent siblings)
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-13 9:23 UTC (permalink / raw)
To: linux-arm-kernel
'break' after 'goto' is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
---
drivers/clk/clk-max77686.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
index 9f57bc3..b4a1a97 100644
--- a/drivers/clk/clk-max77686.c
+++ b/drivers/clk/clk-max77686.c
@@ -157,11 +157,9 @@ static int max77686_clk_probe(struct platform_device *pdev)
case MAX77686_CLK_AP:
dev_err(&pdev->dev, "Fail to register CLK_AP\n");
goto err_clk_ap;
- break;
case MAX77686_CLK_CP:
dev_err(&pdev->dev, "Fail to register CLK_CP\n");
goto err_clk_cp;
- break;
case MAX77686_CLK_PMIC:
dev_err(&pdev->dev, "Fail to register CLK_PMIC\n");
goto err_clk_pmic;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops
2013-09-13 9:23 ` [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops Sachin Kamat
@ 2013-09-13 9:45 ` Viresh Kumar
0 siblings, 0 replies; 18+ messages in thread
From: Viresh Kumar @ 2013-09-13 9:45 UTC (permalink / raw)
To: linux-arm-kernel
On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk_frac_ops is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/clk/spear/clk-frac-synth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/clk-frac-synth.c b/drivers/clk/spear/clk-frac-synth.c
> index 958aa3a..dffd4ce 100644
> --- a/drivers/clk/spear/clk-frac-synth.c
> +++ b/drivers/clk/spear/clk-frac-synth.c
> @@ -116,7 +116,7 @@ static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate,
> return 0;
> }
>
> -struct clk_ops clk_frac_ops = {
> +static struct clk_ops clk_frac_ops = {
> .recalc_rate = clk_frac_recalc_rate,
> .round_rate = clk_frac_round_rate,
> .set_rate = clk_frac_set_rate,
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup
2013-09-13 9:23 ` [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup Sachin Kamat
@ 2013-09-13 9:52 ` Gregory CLEMENT
0 siblings, 0 replies; 18+ messages in thread
From: Gregory CLEMENT @ 2013-09-13 9:52 UTC (permalink / raw)
To: linux-arm-kernel
On 13/09/2013 11:23, Sachin Kamat wrote:
> 'of_cpu_clk_setup' is used only in this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Good catch, it should have been part of the "f640c0f clk: mvebu: Use
common of_clk_init() function" commit.
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> drivers/clk/mvebu/clk-cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
> index 1466865..8ebf757 100644
> --- a/drivers/clk/mvebu/clk-cpu.c
> +++ b/drivers/clk/mvebu/clk-cpu.c
> @@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = {
> .set_rate = clk_cpu_set_rate,
> };
>
> -void __init of_cpu_clk_setup(struct device_node *node)
> +static void __init of_cpu_clk_setup(struct device_node *node)
> {
> struct cpu_clk *cpuclk;
> void __iomem *clock_complex_base = of_iomap(node, 0);
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 05/10] clk: socfpga: Use NULL instead of 0
2013-09-13 9:23 ` [PATCH 05/10] clk: socfpga: Use NULL instead of 0 Sachin Kamat
@ 2013-09-13 22:03 ` Dinh Nguyen
0 siblings, 0 replies; 18+ messages in thread
From: Dinh Nguyen @ 2013-09-13 22:03 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2013-09-13 at 14:53 +0530, Sachin Kamat wrote:
> 'div_reg' is a pointer. Assign NULL instead of 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> ---
> drivers/clk/socfpga/clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
> index 5bb848c..454ddc1 100644
> --- a/drivers/clk/socfpga/clk.c
> +++ b/drivers/clk/socfpga/clk.c
> @@ -292,7 +292,7 @@ static void __init socfpga_gate_clk_init(struct device_node *node,
> socfpga_clk->shift = div_reg[1];
> socfpga_clk->width = div_reg[2];
> } else {
> - socfpga_clk->div_reg = 0;
> + socfpga_clk->div_reg = NULL;
> }
>
> of_property_read_string(node, "clock-output-names", &clk_name);
Acked-by: Dinh Nguyen <dinguyen@altera.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 09/10] clk: ux500: Remove extra semicolon
2013-09-13 9:23 ` [PATCH 09/10] clk: ux500: Remove extra semicolon Sachin Kamat
@ 2013-09-17 8:02 ` Ulf Hansson
0 siblings, 0 replies; 18+ messages in thread
From: Ulf Hansson @ 2013-09-17 8:02 UTC (permalink / raw)
To: linux-arm-kernel
On 13 September 2013 11:23, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Extra semicolon is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/clk/ux500/clk-prcmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
> index 293a288..e2d63bc 100644
> --- a/drivers/clk/ux500/clk-prcmu.c
> +++ b/drivers/clk/ux500/clk-prcmu.c
> @@ -36,7 +36,7 @@ static int clk_prcmu_prepare(struct clk_hw *hw)
> if (!ret)
> clk->is_prepared = 1;
>
> - return ret;;
> + return ret;
> }
>
> static void clk_prcmu_unprepare(struct clk_hw *hw)
> --
> 1.7.9.5
>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (8 preceding siblings ...)
2013-09-13 9:23 ` [PATCH 10/10] clk: max77686: Remove redundant break Sachin Kamat
@ 2013-09-24 12:04 ` Sachin Kamat
2013-10-02 6:49 ` Sachin Kamat
2013-10-29 11:58 ` Sachin Kamat
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-09-24 12:04 UTC (permalink / raw)
To: linux-arm-kernel
Mike,
On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk-provider.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
> drivers/clk/clk-bcm2835.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 5fb4ff5..676077d 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -20,7 +20,6 @@
> #include <linux/clk-provider.h>
> #include <linux/clkdev.h>
> #include <linux/clk/bcm2835.h>
> -#include <linux/clk-provider.h>
> #include <linux/of.h>
>
> static const struct of_device_id clk_match[] __initconst = {
> --
> 1.7.9.5
>
Gentle ping on this series.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (9 preceding siblings ...)
2013-09-24 12:04 ` [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
@ 2013-10-02 6:49 ` Sachin Kamat
2013-10-29 11:58 ` Sachin Kamat
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-10-02 6:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mike,
On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk-provider.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
> drivers/clk/clk-bcm2835.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 5fb4ff5..676077d 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -20,7 +20,6 @@
> #include <linux/clk-provider.h>
> #include <linux/clkdev.h>
> #include <linux/clk/bcm2835.h>
> -#include <linux/clk-provider.h>
> #include <linux/of.h>
>
> static const struct of_device_id clk_match[] __initconst = {
> --
> 1.7.9.5
>
Gentle ping.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
` (10 preceding siblings ...)
2013-10-02 6:49 ` Sachin Kamat
@ 2013-10-29 11:58 ` Sachin Kamat
11 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-10-29 11:58 UTC (permalink / raw)
To: linux-arm-kernel
Mike,
On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk-provider.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
> drivers/clk/clk-bcm2835.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 5fb4ff5..676077d 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -20,7 +20,6 @@
> #include <linux/clk-provider.h>
> #include <linux/clkdev.h>
> #include <linux/clk/bcm2835.h>
> -#include <linux/clk-provider.h>
> #include <linux/of.h>
>
> static const struct of_device_id clk_match[] __initconst = {
> --
> 1.7.9.5
>
This series is pending since a long time. Can you please look into it?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup
2013-10-08 11:17 [PATCH Resend " Sachin Kamat
@ 2013-10-08 11:17 ` Sachin Kamat
0 siblings, 0 replies; 18+ messages in thread
From: Sachin Kamat @ 2013-10-08 11:17 UTC (permalink / raw)
To: linux-arm-kernel
'of_cpu_clk_setup' is used only in this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
drivers/clk/mvebu/clk-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
index 1466865..8ebf757 100644
--- a/drivers/clk/mvebu/clk-cpu.c
+++ b/drivers/clk/mvebu/clk-cpu.c
@@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = {
.set_rate = clk_cpu_set_rate,
};
-void __init of_cpu_clk_setup(struct device_node *node)
+static void __init of_cpu_clk_setup(struct device_node *node)
{
struct cpu_clk *cpuclk;
void __iomem *clock_complex_base = of_iomap(node, 0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-10-29 11:58 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-13 9:23 [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
2013-09-13 9:23 ` [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops Sachin Kamat
2013-09-13 9:45 ` Viresh Kumar
2013-09-13 9:23 ` [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c Sachin Kamat
2013-09-13 9:23 ` [PATCH 04/10] clk: tegra: Staticize tegra_clk_periph_nodiv_ops Sachin Kamat
2013-09-13 9:23 ` [PATCH 05/10] clk: socfpga: Use NULL instead of 0 Sachin Kamat
2013-09-13 22:03 ` Dinh Nguyen
2013-09-13 9:23 ` [PATCH 06/10] clk: versatile: Staticize clk_sp810_timerclken_of_get Sachin Kamat
2013-09-13 9:23 ` [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup Sachin Kamat
2013-09-13 9:52 ` Gregory CLEMENT
2013-09-13 9:23 ` [PATCH 08/10] clk: vt8500: Staticize vtwm_pll_ops Sachin Kamat
2013-09-13 9:23 ` [PATCH 09/10] clk: ux500: Remove extra semicolon Sachin Kamat
2013-09-17 8:02 ` Ulf Hansson
2013-09-13 9:23 ` [PATCH 10/10] clk: max77686: Remove redundant break Sachin Kamat
2013-09-24 12:04 ` [PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
2013-10-02 6:49 ` Sachin Kamat
2013-10-29 11:58 ` Sachin Kamat
2013-10-08 11:17 [PATCH Resend " Sachin Kamat
2013-10-08 11:17 ` [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.