* [PATCH] command: Treat empty messages as failures, not CommandCompleted
@ 2013-09-13 16:33 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2013-09-13 16:33 UTC (permalink / raw)
To: bitbake-devel
Empty messages should trigger CommandFailed, not CommandCompleted as
otherwise the exit code will be incorrect.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py
index 6c7b891..f1abaf7 100644
--- a/bitbake/lib/bb/command.py
+++ b/bitbake/lib/bb/command.py
@@ -117,7 +117,7 @@ class Command:
return False
def finishAsyncCommand(self, msg=None, code=None):
- if msg:
+ if msg or msg == "":
bb.event.fire(CommandFailed(msg), self.cooker.event_data)
elif code:
bb.event.fire(CommandExit(code), self.cooker.event_data)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-09-13 16:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-13 16:33 [PATCH] command: Treat empty messages as failures, not CommandCompleted Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.